From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.2322.1655860689982598727 for ; Tue, 21 Jun 2022 18:18:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=iSKPPwP7; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655860689; x=1687396689; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XrmMiAhItjfZs/9Ey/hUp1Seg48GFaCKdbe7xnm7H+8=; b=iSKPPwP704tM1Y7EjcRzFssjCRfeFJK70vCYt1R62hva1UCRixOK2/E5 UgGIWvWg0Fxs+9ydi59hl7c4ebn7fZKmgHpQwGNriKF205U5PO/VWn2sb U6jXfyDJo8McHVdgaVCvC0UH6tTBmQrEI5PtO7iXB6IEQjMLmvu/HpzdD 6jchGUlOGztTrXWrwXAx+R2C470W7a74HAgh6O6+yyYmrCkalRyY5CcIq pRM+n0AJ1sN/BsVF3Lq2pe8NTXA+lNzPSF6t6IRwzCHk5qBqXUof/KqkM e1OaGLk0Oi654fP6jWXh5QvJ3sLM7OI5LcvwmtrXkypac9pyl/xmiWJva w==; X-IronPort-AV: E=McAfee;i="6400,9594,10385"; a="260101836" X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="260101836" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 18:18:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,211,1650956400"; d="scan'208";a="764678557" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 21 Jun 2022 18:18:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 18:18:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 18:18:08 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 18:18:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4zu5OxErKLpfhmbuPPJ63LQGQwa3EZXr5mbXttiCdp+VTZMgumb/pPK14AINGAyKgfCuY06XobNOfYFaHBjOW4lSjoR4ZQU62RhBam5Tw5V+eWniqonah1q9VeJj2WJKNhcQE6R1LL1EFlPtAicEE0Ojdnkqrys0fuoh3OwieT2qX949dftJRnswm7+lTtRu3onxz3CGXuP7VBXE9CzLLmPU1BmVYYclcN68zEZI5Ly7/0gOFKAVxNLk3agUeZtv4Sun4wi0V39W5w8D+G1ZRKRwxsE5gCoTTGNtoEJphCe7GX1JBimMTM1ux+TW5/MPwIlif4uu+FfWXRDRAnsrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2h9QCdLinoc9v4rjgeBeEAbtaDI129izVlMcjUCv8uo=; b=CaQwcHYrtg0gYboTE9n/P6ZUXAGqdZkD+SNBUIBdKUIwknXn2+8UTUTFI+aamsUk3kb4RRthIUuJMxK17ORTZdZfz25yLB3tGVv4Xzwjb2s1/zCJOVe3RrUbcR7dlMXm0xrPi7aO0ZUNVCGpSReh+5H/sAgYaMXhbTweSr+fyTfA0jl3GzNZf+DL8cUVI3nMJ/FixDH6JenA68UG+i5+fTj2H3Kw/yjSSZkYQleEr69AUKnocs5ceJAqT4psacN93aEBQxUEE9iszIOVI6a1jHXqpbFxr42S4awKKRDUYUm0UKONUGDtPfQqNeZ3vTcyK4F6xJLHKCZz2TU6k9R4pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DS7PR11MB6199.namprd11.prod.outlook.com (2603:10b6:8:99::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Wed, 22 Jun 2022 01:18:06 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::c473:f30f:6b1f:c5ec]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::c473:f30f:6b1f:c5ec%5]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 01:18:06 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Luo, Heng" CC: "Ni, Ray" , "Chan, Amy" Subject: Re: [edk2-devel] [Patch V2] XhcCreateUsbHc: Check return value of XHC_PAGESIZE_OFFSET Thread-Topic: [edk2-devel] [Patch V2] XhcCreateUsbHc: Check return value of XHC_PAGESIZE_OFFSET Thread-Index: AQHYhHSPPfQQ40T1H0SmWvnVV2DkIq1X6HqwgAK6CfA= Date: Wed, 22 Jun 2022 01:18:06 +0000 Message-ID: References: <20220620070816.648-1-heng.luo@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d739793b-3f14-498a-fa2f-08da53ed1010 x-ms-traffictypediagnostic: DS7PR11MB6199:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZwhwVminAmGI1TvQu26zC9rjmtiqSuKaSkhmGlG8/trXTE5x15moPdAM2zmRY0RbeYou5Mn3n2Ys5dO8+LsiL+h4vBmYATKZzCE2qxKkyQmSgTeh+QKLPqVHRxTKvo8tAv2d6BLUic70aHEQNfFTMF1YnWOPYOKRH0mJQ4BC4ss66kfEnF1US60ttV4WjKaqjPxccKQju9xht9Rw6CccNtgI8/riPidmW0zTvdiJU/D7Fy/sJ8QVGJiZrapjLrvaQvOMRWVcRPeKxw3lJiqQ2VrDIylZh1OnhtFolI1UoKXnDqkKBxaTmHULVaz3pb0bFEzXvcbNdSWmMDLeD6tSNgv/ToMe0p4i13Ytq0WvvD+ijfgc64P0hw73ihqyRensB01xgS9E+/7q3VLqNdfE+kuyu0XJe6zQ/YduX4RLu6piUuHaf0vo3xgu8PZq/U+HgKFgYsegddcJzeVna5OiygIyv5Xe2M1TsDyzkDL7E9nFZMvwEQGCgd18/wWlI/t+k7GlffozwRQYiuW7Rzdx1tfmtXPdNiJQinCutufjNYlxUh3GPEG9oCGSd4NDdNQRjrNhCkkZtm96X+EYn0Uul7l96i2jWnC83TyIP1BrHkAIaFH72SEmkRBJd/Iy58tJlrlTpONJtzGmbjWmYWHf6jpfD88Do7lA4449RKqCWwGyjXwAchnIqeZQB0fQCdbTqDRqzmna2kjwftbd+KKiAs2TKR0veFQqnwrM/I/qqD5IMwmYqwazgd9XWViSBz6+O5tjjr+BZaF8p5mtVk/sQA8J6QrvZsbLFGddgsarDcBvZHyu9pe6j7p8+WVbn3WT+/IeDJAdfWnIvDBFHzqQzA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(376002)(396003)(366004)(39860400002)(53546011)(33656002)(107886003)(64756008)(7696005)(41300700001)(122000001)(966005)(83380400001)(55016003)(5660300002)(8936002)(186003)(86362001)(9686003)(8676002)(54906003)(38100700002)(66476007)(6506007)(66946007)(76116006)(66556008)(71200400001)(2906002)(26005)(316002)(110136005)(38070700005)(82960400001)(6636002)(478600001)(4326008)(66446008)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nbEtsr+BXllCQj//rdxvLArmSgl34fx6a0nYLZFnPJx7EOFNh5QZBcR47Hb2?= =?us-ascii?Q?qFQfKirvoeajhpA+dGCvpcIL61k91rkxI09Fj1AQwgzqYWD7ZGs0M709SSn4?= =?us-ascii?Q?QeuPOdpOw4cQ7vnkyOwMrnsQc9Ef97X5DwXMgIZ2RokyAu/vZo/gfMGJHoaK?= =?us-ascii?Q?jGonLZXezNpiZfKPTu5RW8yRhJduRZH3waUPltjkfNH+pCUyZcgDL7FumcH9?= =?us-ascii?Q?WdkXJ6wRZOnYa7PWr1a0vJhwWU0uZ7LKOdhb9CqbbAHOYz2frFMrCv3fMPAf?= =?us-ascii?Q?3RUrJbjnDpMm3YI1PJJaFkriqFZuQIXF8n+9ShB+9SYUL2uAafQqdLpvJ9Nq?= =?us-ascii?Q?yENngCutv5NKaYtE2c3waDCJZKFtNS82oKtU+pxWLmpUgfE/M73Ip24Rh0hr?= =?us-ascii?Q?uX1RhFqqt23EtEC600oN88m0Ak62QDaIGtaV3Et/eCtQqNLLaYGVd/uoWWgf?= =?us-ascii?Q?Dfp5hbvGQnhAP5egZbHuAXnVa4w0GeuVO6hgb7KNwMnL+PyNb+fi6etrXVJ4?= =?us-ascii?Q?VYuHtteDtslMK19g0uiW0EM05Cf/2BsMOCIc7/xdW7/nZa1PJ5/egZytmiHe?= =?us-ascii?Q?nLoVpiOUHuv5KVDekXqTJvagRHc4l8ZzCxMrjzWBI9H6nDlSZxtwMadzembI?= =?us-ascii?Q?DPMT/dsFcQ7DDsgaaga0Bw+YUk9AtlfGXgdw/fX3Rbzs1/cKpJkhfk5MAL+w?= =?us-ascii?Q?lVV7AurvqXntn9x55NLbt46FckEMDkWTrdl3twsHXqane2uWHw8ggkheUJpD?= =?us-ascii?Q?6w2d8O+Hg3cyyiqF6lGnNdcxLifqu9jDpQ3snicOxjmsRse0OdCInbtdgLQ6?= =?us-ascii?Q?JbjH0DZpNAv/8Pfm3C0pG9H3gOWOEKKvBu+HN507aSd5K0uF2lV24HMtfggK?= =?us-ascii?Q?00y4yeE4xDd8NqPbGi5XisWdvRc7m9lMQTRmAMDeu31a9AOuh9q83HaIY0Xe?= =?us-ascii?Q?T7GW3vk5BF0mk48FDHmjAj4RXRxpiJzl7/DV5Py/PyuaTdf+wBrPiy52WAms?= =?us-ascii?Q?s/krEbMo0zl7tJc5qGSg+n1Pw67dbsRN1aygg5x+dnSl5Op1VBXQ59T6lVU0?= =?us-ascii?Q?2/DFirBKn2fprKrFvkIcMcri/lUZH8WwHYQTTXxQcPoOtsKg9TBWLvzeUrs0?= =?us-ascii?Q?Mynzvg4Rhlf2axU8Mtld+/Zz0ES76xwIXavrQQzuqBf191J/oyIRO+yVnzhX?= =?us-ascii?Q?htFUxzYQFHcIBseDJeOJZMeZb1jRL/7ACKzYcdOHowT+GXaVIQsXtVZ7wN3l?= =?us-ascii?Q?58WvAKaYHTiYN1Hc8TgaU4FdcPvY++WvqPSOucH4KJaSMVaFIIn+wUGGh30S?= =?us-ascii?Q?KQvcrhGAGnDPsF6HHzyHXXLMHUi3o+6dmYgKPzzpg47HxZzLluAuud3Okh9H?= =?us-ascii?Q?/f2oVBgfRSQRqxOnY3TKZP3xNvAVS4D3RHtzSUnURJe64dnDdgSkrrygJh6e?= =?us-ascii?Q?p39PJZ9AVN7Mb6oOgU5r0iF6T0MNbvobsiePR4zqlHiUQyNZ4dA7LQd/yw4x?= =?us-ascii?Q?Aws+0WDzmVMq1TpBR82dTCh8EQ6yLxuebt+qXlsONVKs1BPr8AGwbqcg1mS9?= =?us-ascii?Q?x4Xs54s+vfLR67rbaCwYgCLd+stzvvHO62hpDXv07v+VVi1u8gFnN6UZAqND?= =?us-ascii?Q?7UmsGOF5VNUuX7nEmFjzoRK7AN5R1b/ppmKL2WP+DB3xiBHmX3Y01h6+oA97?= =?us-ascii?Q?geMFIfnTGZLEh/dwiPrMJKInDFN2Q1ig8kEva3FNFz8PO3OS4Osli361ONbd?= =?us-ascii?Q?eTEJP7/mzQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d739793b-3f14-498a-fa2f-08da53ed1010 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2022 01:18:06.8092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oSpPMt8nZLaX+CXoDwEcAHKFMHXoW+pPm1wP51nO8U8UIyc3R9hZJthVSCWexvlwNqmaY3HHx2098WRQE4lHNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6199 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch merged via: PR - https://github.com/tianocore/edk2/pull/2997 Commit - https://github.com/tianocore/edk2/commit/b97243dea3c95ad923fa4ca19= 0940158209e8384 Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Monday, June 20, 2022 3:40 PM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Ni, Ray ; Chan, Amy > Subject: Re: [edk2-devel] [Patch V2] XhcCreateUsbHc: Check return value o= f > XHC_PAGESIZE_OFFSET >=20 > Reviewed-by: Hao A Wu >=20 > Will wait some time to see if comments from other reviewers. >=20 > Also, Will change the title a little bit to: > MdeModulePkg/XhciDxe: Check return value of XHC_PAGESIZE_OFFSET >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Luo, Heng > > Sent: Monday, June 20, 2022 3:08 PM > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Wu, Hao A > > Subject: [Patch V2] XhcCreateUsbHc: Check return value of > > XHC_PAGESIZE_OFFSET > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3954 > > > > Report error if reserved bits are not 0 for PageSize > > > > Cc: Ray Ni > > Cc: Hao Wu > > Signed-off-by: Heng Luo > > --- > > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > index b79499e225..381d7a9536 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > > @@ -1,7 +1,7 @@ > > /** @file > > > > The XHCI controller driver. > > > > > > > > -Copyright (c) 2011 - 2018, Intel Corporation. All rights > > reserved.
> > > > +Copyright (c) 2011 - 2022, Intel Corporation. All rights > > +reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > **/ > > > > @@ -1813,7 +1813,13 @@ XhcCreateUsbHc ( > > // This xHC supports a page size of 2^(n+12) if bit n is Set. For > > example, > > > > // if bit 0 is Set, the xHC supports 4k byte page sizes. > > > > // > > > > - PageSize =3D XhcReadOpReg (Xhc, XHC_PAGESIZE_OFFSET) & > > XHC_PAGESIZE_MASK; > > > > + PageSize =3D XhcReadOpReg (Xhc, XHC_PAGESIZE_OFFSET); > > > > + if ((PageSize & (~XHC_PAGESIZE_MASK)) !=3D 0) { > > > > + DEBUG ((DEBUG_ERROR, "XhcCreateUsb3Hc: Reserved bits are not 0 > > + for > > PageSize\n")); > > > > + goto ON_ERROR; > > > > + } > > > > + > > > > + PageSize &=3D XHC_PAGESIZE_MASK; > > > > Xhc->PageSize =3D 1 << (HighBitSet32 (PageSize) + 12); > > > > > > > > ExtCapReg =3D (UINT16)(Xhc->HcCParams.Data.ExtCapReg); > > > > -- > > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20