From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BDD28AC0C4F for ; Thu, 21 Sep 2023 06:24:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=y23wy5hcFexbRqmK/8M9qsF6sYtV5brvWwuiNfx/Do4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695277450; v=1; b=IyTuOBK147UUna6J1tVeRQbvmDL+RZuL+VkfFkqKwiKtavegpHO0BDfqceilmkyt7AOtTAhm ra1MnkZ28IU8Lh3w0KNy9+gWH7WaLaYOZWPHMGBypsMe95HAt33ZsMXhDk90IjLjE1+PChB6o1T VAK6FqqYe4pINw/sbYxACtDU= X-Received: by 127.0.0.2 with SMTP id K2r8YY7687511x6CCPCM4a9v; Wed, 20 Sep 2023 23:24:10 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.9892.1695277449226988626 for ; Wed, 20 Sep 2023 23:24:09 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="444536170" X-IronPort-AV: E=Sophos;i="6.03,164,1694761200"; d="scan'208";a="444536170" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 23:17:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="993951406" X-IronPort-AV: E=Sophos;i="6.03,164,1694761200"; d="scan'208";a="993951406" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2023 23:17:04 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 23:17:04 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 23:17:03 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 20 Sep 2023 23:17:03 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 20 Sep 2023 23:17:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZxrZO4Wqiq8Vq7N69nMJBD/bhPcmXMaMHyhiEQOM0npphZTDTVG+cCefDi9bwTSGL8EWHHOx3/jCK9ekMVn+Af3edxrIokO72GYO4O9jDOg7a09RY/tmc/jxXCd+/ehreRfQRinH1SiLlDKjozaVqkH0jBmLL+h2fK3eaFMfoco+WvfjgxT9MlKsPWqoRXwLZ8xfwopLxjzfmbqxaCCReet5UXHWBj+d8MojsW8VIZ4vzD3bDBD1d2vMhLNcH6oClPZ5AST2UBPOPEpl8Px3190jR6tf/8PMFAiu1+s3+aLEOS3odKFVEt7mpqnQc6KNn3lk2SG1VD5yoX77ssWPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yjUEQ22xlUjx+QxIe7A23rJu4HIacPHb63p3Z+mAvo=; b=ZvWZyjvivwMxt6A2i2wEz1Ez3xnthapO8kgHf5JoADyBHqRbX1NHYce8pp1zmRr8QEHbsYiydMgcNzDjV+NXn/bAB1S9f8R//w1Bk3roDMsKOb3bv47kB6JtGsjZE/mzpVcq0GEPdJdry+ELcyyj3eNgk1PIPS7REdr/TDYIfqb07GmwDPDmMGAxYi+RgD70CywUpQQbBswO4bjNvQmt2U1HgM/780mfeK3pFcCT3N2aAHXIjeu70E8WN1Bi1NiCEjiexdU/MfsIhN2uaIXuAzrCS4xJIgttsaDIi3SamlK0B23D7nkyG/mQ/+YXYdqWO+v9XQGIl1fKAisaiQLsxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Thu, 21 Sep 2023 06:16:55 +0000 X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::38c3:ed7c:3562:2e18]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::38c3:ed7c:3562:2e18%4]) with mapi id 15.20.6792.026; Thu, 21 Sep 2023 06:16:55 +0000 From: "Wu, Hao A" To: "Cai, Xianglei" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , "Shih, More" , "Huang, Jenny" Subject: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device cmd when time out Thread-Topic: [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device cmd when time out Thread-Index: AQHZ7D/SazI69dQ+jkqpajW72xbbmLAkzd2g Date: Thu, 21 Sep 2023 06:16:55 +0000 Message-ID: References: <5a1ea986c40109ea9860f0b6bd2be0fa249c9b3a.1695268645.git.xianglei.cai@intel.com> In-Reply-To: <5a1ea986c40109ea9860f0b6bd2be0fa249c9b3a.1695268645.git.xianglei.cai@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH0PR11MB5112:EE_ x-ms-office365-filtering-correlation-id: 4c97f151-940c-4b8f-cdd6-08dbba6a5acc x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wnPczCxqPGiSs1uHy+SEybQ3G5lavhEtUprPx1v3qk4++3uCWIBqmp20M3URkgakeniFSD8SzR8TMC1zP2cXqg16RbjClBpp/hWE5t65/gTRey4nWP4acQff77QR6pSjV8EyiaYE1iLT3WPe9JAmFUAUTs4JFWOU83j0IiJF6M02gDOUKmcuHnV2JFTpsm1k2rjlbTjD0ufupiYh2W98yxa0pob4YMgUhVP6jbTk6WECsI+wIpE20m7hSmdMiK58SZo6R37U5sH8nG1HYrIgqnbovrpVhyRbxze8E34h76F9LxLJRQiWW8gKJ0r1l+/vnaAGwxIgCtY1DKmeNmi+J/IKM8cCNLOjPI8phjHHs6lifZ2VqyPS4TChX6PIVfYgZplMACZjfZu+6hkNsekA7znDB3vOvIJOGzukipC16vsZCESHFszZVRpYVejlz07BT/0qOuNKiBPyHeZCt7QFyxfYVQbPhQWJi5LIyzKJXT3Hn3tGHOVIZ38m/1jfRwPUGiZtzGam4VAbfoT6yk6qRg1mPOCU7a2xdDOs33nu8cLjC7U71G4Jc3WVFtLAneQJcwbommk4m5pkrhgsSATfeyYkIwlE0rCfMf13fFth570= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JD7qvVbsLlZtKpd9/fv4WHRTj4TnNDfGPG8YVmhB/DdYK1BJIFQMYRZrSwu0?= =?us-ascii?Q?i/hfVybYTRqBuPDuCAFB0uLBJgR75E9HRwIxFX7S0jZvMmle7/mGU+6nP8CL?= =?us-ascii?Q?jDG0iwVZ6ma6TrOcGqD7fiyYkG4OQxtje2ME9TPYSnTM5ryuZq3SzArzQaXF?= =?us-ascii?Q?YxYBuEykn/wicu/W/SaQQRAB0Fqadi1WZIcsyLSDFyI/Qjbn+cO6/TIG+xQi?= =?us-ascii?Q?VOz+usTGmOTKuHiwwu43aM5pTBqM+lAGsRDkpwwWbS+Ck8M2yrplII2Ofin4?= =?us-ascii?Q?GRSzG1MK4jL4QovO93e36fqqhuhIG595IxBwHESil3Le1SDvLJOKTIXtTv0f?= =?us-ascii?Q?CSrIKsEtZVJRbYEPoDIqiBsgnmJG0GResIww1qhjUylxnUAojU4YnlOgqXUf?= =?us-ascii?Q?IvrilnFokoHconUdUVfGP4IXZzWDisIeI4I17WyDhgtK0+rusEh4wqDDi0ZM?= =?us-ascii?Q?fFl/p3dHJJnQTcYsutrpaW/8NMuIqCzIye+zPEvqxroDPIhPHeTxYQDI2Jk/?= =?us-ascii?Q?ay7dy0/CkUEUVDP6JZ0aqe9VYAA9lgZXcgtjMgYJMrdGYiulJFwdLT/N4aDo?= =?us-ascii?Q?jgkAxM5kRPQ82B8/alxl298q8L5lQv6IHTEOSXhWfoK8quFuNZki7uE2n1dx?= =?us-ascii?Q?+KJqYE2zmennP/ys6Z4ThnreZaWzVHhM0K6dcmoy3NkvFEWOzRnTnly/GtMo?= =?us-ascii?Q?zXlUosfS3rwoptGVUhb2EN9KBh1HqcJnc1hZRBohTequ4mv0KSq1UJcG1/OU?= =?us-ascii?Q?1drlZXP/sba8Dvmv72Gz3b3r0pvnqu4wSHxZWyIfgZmVYEw5iCVgv77SQmK6?= =?us-ascii?Q?VpJjElx+jBdZLwtqKEqqAVq/nAQ4T1ruCPCe80/iWk5O1wKwdSLQECytvzM8?= =?us-ascii?Q?/izg1LW8/VBlidLflD+OltWE5Xk5tdmmLJ3nXhdgEdqDsVeco2Cg3bYsSBs1?= =?us-ascii?Q?mdvH2WicAqM+NJHRaYskjqiiP2wXboNBT2XyEwaMayObYijcVikg6HmUq9nK?= =?us-ascii?Q?7NDuWHXtUp6skpVgCIhYk7du5IYEH9f/jxJ7DuNAHxFYeXhfeUkx4kDxqHeh?= =?us-ascii?Q?TwzdqUNP+yD0UCahI9T/72Xw9knkHdd0wp7zhShw6m2tQxaa0OF2VdJU6Dii?= =?us-ascii?Q?VYHB/puE/j/1hRBHkDLUthM0aIdzBV+XRcy/yA9uBPft1/rTU4Z5j9bkc0Lx?= =?us-ascii?Q?djz4W8fzsUQNbo3Y2h6wVAl2aUWkK7SEDUOszX3zkt8/PxMQ14dpl5oFvMcx?= =?us-ascii?Q?NrU4v280Sp+Wed1RzwV+UcAXYhyJK/edixbMQ9s4jF3oKnnMl//PLQGuhKjD?= =?us-ascii?Q?UmNgtKJw3aS5Lli9yqwD+AodH9G+9i/YwKuY8NOzZEGGCS7DFwsl8Oba5DZW?= =?us-ascii?Q?AXm8OvZl8RgS+aYHSBQDlF2Mu/3NaxrOZk9rjMBnu0WwSuVlJ4g1HEJwmIQf?= =?us-ascii?Q?LXCwFH3HEG/8aiNM7uWMBMC/3hOTsDiwlalc9x2iu3hrTGQ0bMm2v5Dv1W3V?= =?us-ascii?Q?v5yap0v/b2momTWAMxteGEOaO+Gn26s3ixYM9VFgJp2k/TVHdB3dMU+Ufr6W?= =?us-ascii?Q?PnYBPGSEsCpYwXTEuIJ3iobr/4PzKWIXRBAEURuR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c97f151-940c-4b8f-cdd6-08dbba6a5acc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2023 06:16:55.5548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: degbxX5A/H1H1d8bl+i7SKMIJuaMznj41Sei8H0e8CBNh5bo0AsmeBc+wIlGeVf/JYhP1zCXO13jE8IjIzFhcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oUwQ3FOVulekEtUa9gJVCsa2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IyTuOBK1; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: Cai, Xianglei > Sent: Thursday, September 21, 2023 11:58 AM > To: devel@edk2.groups.io > Cc: Cai, Xianglei ; Wu, Hao A ; > Ni, Ray ; Wang, Jian J ; Gao, > Liming ; Shih, More ; > Huang, Jenny > Subject: [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device > cmd when time out >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4552 >=20 > Following XHCI spec 4.6.1.2, software may abort the > execution of Address Device Command when command failed > due to timeout. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Cc: More Shih > Cc: Jenny Huang > Signed-off-by: Xianglei Cai > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 36 > ++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > index 53421e64a850..f6efcf80f376 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > @@ -2121,6 +2121,26 @@ RingIntTransferDoorBell ( > return EFI_SUCCESS; > } >=20 > +/** > + Set Command abort > + > + @param Xhc The XHCI Instance. > + @param SlotId The slot id to be disabled. > + > +**/ > +VOID > +XhcCmdRingCmdAbort ( > + IN USB_XHCI_INSTANCE *Xhc, > + IN UINT8 SlotId > + ) > +{ > + // > + // Set XHC_CRCR_CA bit in XHC_CRCR_OFFSET to abort command. > + // > + DEBUG ((DEBUG_INFO, "Command Ring Control set Command Abort, > SlotId: %d\n", SlotId)); > + XhcSetOpRegBit (Xhc, XHC_CRCR_OFFSET, XHC_CRCR_CA); > +} > + > /** > Assign and initialize the device slot for a new device. >=20 > @@ -2331,6 +2351,14 @@ XhcInitializeDeviceSlot ( > Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; > } else { > DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully. > Status =3D %r\n", SlotId, Status)); > + // > + // Software may abort the execution of Address Device Command when > command failed > + // due to timeout by following XHCI spec. 4.6.1.2. > + // > + if (Status =3D=3D EFI_TIMEOUT) { > + XhcCmdRingCmdAbort (Xhc, SlotId); > + } > + > XhcDisableSlotCmd (Xhc, SlotId); > } >=20 > @@ -2547,6 +2575,14 @@ XhcInitializeDeviceSlot64 ( > Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; > } else { > DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully. > Status =3D %r\n", SlotId, Status)); > + // > + // Software may abort the execution of Address Device Command when > command failed > + // due to timeout by following XHCI spec. 4.6.1.2. > + // > + if (Status =3D=3D EFI_TIMEOUT) { > + XhcCmdRingCmdAbort (Xhc, SlotId); > + } > + > XhcDisableSlotCmd64 (Xhc, SlotId); > } >=20 > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108935): https://edk2.groups.io/g/devel/message/108935 Mute This Topic: https://groups.io/mt/101493909/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-