From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.33957.1670813330523304153 for ; Sun, 11 Dec 2022 18:48:51 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QO8HnQDe; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670813330; x=1702349330; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=JiIsYbMlH85MOh3xS+1ECt2f9m+7CJUlHWSq9vQTPPs=; b=QO8HnQDem7uIOT0eLYvUrWy2/2J8zkh9Ht0uJ/Eiux69dZj1GDjPkv7y b4QM6UYPZbfGl0mFFvffYO40UhpJjq//ddFRUHsqFUky//q0POK9Pbk26 ZR6CzFeHjnzj411QMcUkdMhKdOc3wuwMDzZeMUq5J9EXdfZYyGl8Rjg54 c0uvW+wFasJGZ/blJ1Xh54am3MTnBGLwLQE60eJTFiyabzO+TJs4ZyWpx NwqGfMVM3FqXJkFjnfpFyBR/uwSkEVg4E2AM34BKAZV+v5YoT6/w/274p 01C5Z5PXypMtK6+DaIf5hbINwXsyTyuAhkWbVe//X3eYu1KrXcypLWy+N Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="379962322" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="379962322" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 18:48:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="648008337" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="648008337" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 11 Dec 2022 18:48:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 11 Dec 2022 18:48:49 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 11 Dec 2022 18:48:48 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 11 Dec 2022 18:48:48 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 11 Dec 2022 18:48:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NluqHsVfImQwtJX//kWikzPNFultdAYaXMQ9IBKuVzEHUkjDfv6tX298c91MXX1k1qNlxZkp2o6IlbbCGJxNEpYzupvyuyJdFtgB2t55jK/Aw5igBTYXeALvT8/WuTwcy3i01PltLej1GPkfh2s2rnY1EuJoL8mihs7kTY+RdUo8cc8xjQcntUVmvl+/9nZW17g7BD0755gqWPOsTXRXXA3VMM/rQAt87w8pMXtwP1yivhIuuxxP+n/s07KovDZWUzW5F40fqlRahmCQLMf58xMUtp2DlZjtmI2fotgNXHjgvVUNPWKWK2bY9ww71jMxAgtNGL3SsJJfYHJ1JUcgxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uixQc1L//qSkNDElhcdNxvAOnhKhznu7dYAi0b3K9CY=; b=HSGZQlHiCOAlRJBrNmj5wCVc7L6Pv58I8l7UFe/nUVDv46fTcQ/6l7AgXSfABBW0+7GswHo9vn446vcwZJ7zG5sOBnXaRKGKmA/Z5xmTiiMUK8mrCsuww+H/o6ce5q2RLmjI/zp8B+CtKDD43Q2JbBphzpEU7h2Qhkg68bHW7ToPW5QguNN8mQ/LeSST5JkkVoLxWPLLQ2HnYtQ06qPYyggtEfiB+e7lP8H8LhNG9lKF02KPEgaTsP6WyBuWX81FJMEgD0TOaNKHe9sE2uqoS/huD4NrpMTn3idNQ/21TB23z6i0E4JROmIBRPrkuSQgdkc6Hfiw8vmwHfmLI7isYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DS7PR11MB7859.namprd11.prod.outlook.com (2603:10b6:8:da::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 02:48:45 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c%3]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 02:48:45 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , Chevron Li CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , "shirley.her@bayhubtech.com" , "shaper.liu@bayhubtech.com" , "xiaoguang.yu@bayhubtech.com" Subject: Re: [edk2-devel] [edk2-platform][PATCH V3 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized Thread-Topic: [edk2-devel] [edk2-platform][PATCH V3 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized Thread-Index: AQHZCixXj8yhAoOp2EKirlNWOv0qaq5jUZFggAZCXVA= Date: Mon, 12 Dec 2022 02:48:45 +0000 Message-ID: References: <20221207110839.1185-1-chevron.li@bayhubtech.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|DS7PR11MB7859:EE_ x-ms-office365-filtering-correlation-id: ecd28769-9e8c-49df-d9a6-08dadbeb6342 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2bZhYURzW8Tyn3dEoIyKYDVY2VDV8OpZhQr61tjoVeUjgITVhsMwC+j90E3toJjnCRhD3oKssPMltuskzjOX6yiq+Bl4ICnFJihAxI3TQxyMD9qF/X3SjYdD4GyYDlab+BbmRxEbHjP/UUXu9S61wvYvttMGnFp1Yy3Cp2n+zfIuDdV8dYy9lUfr0TlRb7PBRqMEV0/bgV+NLvreEQE/PQHTj2UOzMvBzHQKqM5b2MsDhHjxiqUsv4M9itGfQGWjLVV8nhRmFamp51c/i9VlLlW0aTPuy0MTlWvF88rEWyFwPlbKWMbIsL/LThlhUwwgTDkTEPnlWiSl5GmK+djog9oJI3aiTmbHbV1Eq361t9Vb9VzNpZvZHbClgNlpYDA4r4uZVHZ+36jLMXJfQ65xcCIOu00L5ZP/6zzdeazFMzlCk9Cv3waj2XV1B95ByLTh90mdZV9y/JB6M3TpEhoPjC3iPQ2Lf4ve8atxkBxSlDACe9Dh1DVeXF01CZVzKO71kbAwFZh3nxDBAM6LMRhB+Q56QNFe17vfVSJBCRVfMaJPiOY+h1DI0bLOxOWHv8H4aPkfN5l16RikbZ8b7Nyp+vrYDhCa8SVifownvAnHhwhzoAxPInI52dTGAfpob0yjtvMxL+jpjOOgZNk8KZcor2pKGKf1EZVM+x8PVGi8cy0yOKJLnlrOcxQrv3Kfus7ppMpWiIcQrYplf5OhRumCL8yphjcUmjYWIxTCOwFG3x6BvURbbTjen1e7Rw+3GeY6g4rIVsPusCOnjf9jOj0ttA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(39860400002)(376002)(346002)(136003)(396003)(366004)(451199015)(38100700002)(122000001)(82960400001)(5660300002)(86362001)(2906002)(38070700005)(55016003)(966005)(71200400001)(478600001)(41300700001)(66556008)(66946007)(66446008)(8676002)(76116006)(4326008)(66476007)(52536014)(316002)(110136005)(64756008)(54906003)(83380400001)(186003)(26005)(6506007)(8936002)(9686003)(7696005)(66899015)(53546011)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ql5A1FfDLRZ4yVbhzVdsy/Zr3QWeLuQnD51q3MAeShr4VCUHgEOqDTUBlKyB?= =?us-ascii?Q?kvyOwHPGBDTAGOb43dveA/pCb4+/k/PGlW4oZRDrVRA8fXuTSDjGTooZPW8G?= =?us-ascii?Q?5fmdYglzpToI2prN86VsJt4ARsvM9LGWX3nLcd3THAbALWRR5TGVMMDQtIfw?= =?us-ascii?Q?MXajotk/XixHUtUje0+snz6oCRYe9gWuFcT4FtUK7MG2JjtpPwetXqj77kca?= =?us-ascii?Q?UAjsmXkhoYrSDtR4pIkkSLo4ZTVRsqANQD1T06nbHjmLNi7FytsnwxeD5uUC?= =?us-ascii?Q?sT2PvWFPm9tzdtAi04liir3NMfJEcxep4Joqfiv+uh2Eyb20OmtI9omFmsGz?= =?us-ascii?Q?XPDUaD/2/muLs6YBFf16vjMfLobhcP7E9Yh7RW+RE9bTvu9rS+5Jdyzt6xYY?= =?us-ascii?Q?RaGFH9ViS6bicw7oXXlXicFmvn5gogW9Zn78oG1z6PKs8Rphm9HdmIlWwXSl?= =?us-ascii?Q?anREicRCIRdHjg7kyP1S7I9JUKbBFxdK5Lodqp9Na0jCLsfMQhTN6Uhsuj29?= =?us-ascii?Q?/xxLvzJibFLC4lanDqhpKT83bBEs9/qH4NaEAQJuyxiXnItAXfXs90WdUmSZ?= =?us-ascii?Q?9nnDzbsBD+3lbBd6RITRH9QMQuI0FWOHpbM1FaZnlI8t4UZb/H1laHBQStUd?= =?us-ascii?Q?ZHR+/+xv0qk0t2rMMkUmfAjntZRKOS2JEyIcpv6PpZ2am21z246ey+tTh55X?= =?us-ascii?Q?yqPZPg3Ofs2WqHnXWIO0SUk/gJRwT90y/8+zz5Ro+zXDmfOYBmQZEGQHsmT0?= =?us-ascii?Q?51PLDyt09+toBl0FlssWIt43gKuX0jgvpqeBqmWhbvHriywhB2zcvA0TIK7m?= =?us-ascii?Q?67GjWdGRCPsPRvuFKGE33i0Rmx0cIoMoMi0lCpy0FsCpvqVCVmSieASZgpr3?= =?us-ascii?Q?9lk0KRpKW29KRhXUipAHsslkqV78YAsmbnT9QvWIvBHw3vjrBQItHgFD/5J/?= =?us-ascii?Q?3kau/IHejrp1qBl+3SDg7ic66sSJ14bi7fKQ7FHN6eW/ZALTfEjtJ91c7ce2?= =?us-ascii?Q?ceafGSHGwXciPQweagaMZDfMqQCLKIeudy0/9tcyFB2JpsoZwA8FewccQysH?= =?us-ascii?Q?H28/ndQdGuF5EoJeXPBvbAY4U03w/taySjPAT02e4BhI+6+gJv5I0c42Oo/M?= =?us-ascii?Q?a9Wu/jVgp5AJtNgkNyEW3ZOSgtoQwfgRIokzAX0Ik/msQsvnyDZTfl2PaJQH?= =?us-ascii?Q?8B+h9m8xp0dwchn7Ql5Mcnb/ymA44ni2MP6/Z4B8evBgojiDGX1OS2vW80Hu?= =?us-ascii?Q?IbNdwrL9PrZ5WfR7DSWPRkL/JUPZchKAF1wqp4SqhApNuQBlfE02g6IkZ09z?= =?us-ascii?Q?FtXA2dvtoFiHuwy8M3fESm3DUPY6CZd4qnVLRBWBjS9zU4mbg3HETXtAX9Qf?= =?us-ascii?Q?DpL/7wJcab4SMJ2EQYXGZRraN5TZ6mQLfAowrhYhfRW//DMqB/29EGRMdfFt?= =?us-ascii?Q?KAQ0IVYk/Q9tNn9R8nqkSIvQFtvvrdVexWceQsIfuBDdflMClgjZxOx7oCss?= =?us-ascii?Q?LUEIkRllgErfFD1VXAlajeaot7V8jKtyviHxbG14Bbk7LK4GWG8A/cROLsap?= =?us-ascii?Q?jHXP+P46SmldSFnqe6R8670OuwwVdplnZYbbrX1V?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecd28769-9e8c-49df-d9a6-08dadbeb6342 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2022 02:48:45.5313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wLUGAJh77O2J89+hnip/aVQaRLZ2GxBrsl7n90csujMFmR2rzB56zZp0j3sIYkY+TGQ7pHC2jfmxkaUV/ks9wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7859 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed via: PR - https://github.com/tianocore/edk2/pull/3748 Commit - https://github.com/tianocore/edk2/commit/5890a18409a0e67a491c600b9= 30e6c904ad3b3fd Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Thursday, December 8, 2022 11:14 AM > To: Chevron Li ; devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Gao= , > Liming ; shirley.her@bayhubtech.com; > shaper.liu@bayhubtech.com; xiaoguang.yu@bayhubtech.com > Subject: Re: [edk2-devel] [edk2-platform][PATCH V3 1/1] MdeModulePkg: > SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized >=20 > Reviewed-by: Hao A Wu > Will wait a couple of days before merging to see if comments from other > reviewers. >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Chevron Li > > Sent: Wednesday, December 7, 2022 7:09 PM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Ni, Ray ; Wang, > > Jian J ; Gao, Liming ; > > shirley.her@bayhubtech.com; shaper.liu@bayhubtech.com; > > xiaoguang.yu@bayhubtech.com; Chevron Li (WH) > > > > Subject: [edk2-platform][PATCH V3 1/1] MdeModulePkg: SdMmcPciHcDxe: > > Fix issue that SD1.0 cards can't be recognized > > > > From: "Chevron Li (WH)" > > > > SD1.0 cards don't support CMD8 and CMD6 > > CMD8 result can be used to distinguish the card is SD1.0 or not. > > CMD8 result can be used to decide following CMD6 is sent or skip. > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Signed-off-by: Chevron Li > > --- > > Changes in V2: > > 1.Update description comment for input parameter 'SdVersion1'. > > 2.Add variables initialize operation to avoid unexpected value. > > 3.Use TRUE replace with 1 to assign value for BOOLEAN variable. > > > > Changes in V3: > > 1.Update code format for CL test fail. > > 2.Fix memory out of bounds when initialize SwitchResp. > > --- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 34 > +++++++++++++-- > > ---- > > 1 file changed, 24 insertions(+), 10 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > index f5a3607e47..8bf452e9d0 100644 > > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > @@ -1074,6 +1074,7 @@ SdGetTargetBusMode ( > > @param[in] Slot The slot number of the SD card to send the > > command to. > > > > @param[in] Rca The relative device address to be assigned= . > > > > @param[in] S18A The boolean to show if it's a UHS-I SD car= d. > > > > + @param[in] SdVersion1 The boolean to show if it's a Version 1 SD= card. > > > > > > > > @retval EFI_SUCCESS The operation is done correctly. > > > > @retval Others The operation fails. > > > > @@ -1085,7 +1086,8 @@ SdCardSetBusMode ( > > IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, > > > > IN UINT8 Slot, > > > > IN UINT16 Rca, > > > > - IN BOOLEAN S18A > > > > + IN BOOLEAN S18A, > > > > + IN BOOLEAN SdVersion1 > > > > ) > > > > { > > > > EFI_STATUS Status; > > > > @@ -1095,6 +1097,8 @@ SdCardSetBusMode ( > > SD_MMC_HC_PRIVATE_DATA *Private; > > > > SD_MMC_BUS_SETTINGS BusMode; > > > > > > > > + ZeroMem (SwitchResp, 64 * sizeof (UINT8)); > > > > + > > > > Private =3D SD_MMC_HC_PRIVATE_FROM_THIS (PassThru); > > > > > > > > Capability =3D &Private->Capability[Slot]; > > > > @@ -1117,10 +1121,13 @@ SdCardSetBusMode ( > > > > > > // > > > > // Get the supported bus speed from SWITCH cmd return data group #1. > > > > + // SdVersion1 don't support the SWITCH cmd > > > > // > > > > - Status =3D SdCardSwitch (PassThru, Slot, 0xFF, 0xF, SdDriverStrength= Ignore, > > 0xF, FALSE, SwitchResp); > > > > - if (EFI_ERROR (Status)) { > > > > - return Status; > > > > + if (!SdVersion1) { > > > > + Status =3D SdCardSwitch (PassThru, Slot, 0xFF, 0xF, > SdDriverStrengthIgnore, > > 0xF, FALSE, SwitchResp); > > > > + if (EFI_ERROR (Status)) { > > > > + return Status; > > > > + } > > > > } > > > > > > > > SdGetTargetBusMode (Private, Slot, SwitchResp, S18A, &BusMode); > > > > @@ -1141,9 +1148,14 @@ SdCardSetBusMode ( > > } > > > > } > > > > > > > > - Status =3D SdCardSwitch (PassThru, Slot, BusMode.BusTiming, 0xF, > > BusMode.DriverStrength.Sd, 0xF, TRUE, SwitchResp); > > > > - if (EFI_ERROR (Status)) { > > > > - return Status; > > > > + // > > > > + // SdVersion1 don't support the SWITCH cmd > > > > + // > > > > + if (!SdVersion1) { > > > > + Status =3D SdCardSwitch (PassThru, Slot, BusMode.BusTiming, 0xF, > > BusMode.DriverStrength.Sd, 0xF, TRUE, SwitchResp); > > > > + if (EFI_ERROR (Status)) { > > > > + return Status; > > > > + } > > > > } > > > > > > > > Status =3D SdMmcSetDriverStrength (Private->PciIo, Slot, > > BusMode.DriverStrength.Sd); > > > > @@ -1214,8 +1226,10 @@ SdCardIdentification ( > > UINT8 HostCtrl2; > > > > UINTN Retry; > > > > BOOLEAN ForceVoltage33; > > > > + BOOLEAN SdVersion1; > > > > > > > > ForceVoltage33 =3D FALSE; > > > > + SdVersion1 =3D FALSE; > > > > > > > > PciIo =3D Private->PciIo; > > > > PassThru =3D &Private->PassThru; > > > > @@ -1231,12 +1245,12 @@ Voltage33Retry: > > } > > > > > > > > // > > > > - // 2. Send Cmd8 to the device > > > > + // 2. Send Cmd8 to the device, the command will fail for SdVersion1 > > > > // > > > > Status =3D SdCardVoltageCheck (PassThru, Slot, 0x1, 0xFF); > > > > if (EFI_ERROR (Status)) { > > > > + SdVersion1 =3D TRUE; > > > > DEBUG ((DEBUG_INFO, "SdCardIdentification: Executing Cmd8 fails > > with %r\n", Status)); > > > > - return Status; > > > > } > > > > > > > > // > > > > @@ -1426,7 +1440,7 @@ Voltage33Retry: > > DEBUG ((DEBUG_INFO, "SdCardIdentification: Found a SD device at slot > > [%d]\n", Slot)); > > > > Private->Slot[Slot].CardType =3D SdCardType; > > > > > > > > - Status =3D SdCardSetBusMode (PciIo, PassThru, Slot, Rca, ((Ocr & BIT= 24) !=3D > > 0)); > > > > + Status =3D SdCardSetBusMode (PciIo, PassThru, Slot, Rca, ((Ocr & BIT= 24) !=3D > 0), > > SdVersion1); > > > > > > > > return Status; > > > > > > > > > > base-commit: 7bee2498910a9034faaf90802c49188afb7582dc > > -- > > 2.18.0.windows.1 >=20 >=20 >=20 >=20 >=20