From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.6072.1645150593041459715 for ; Thu, 17 Feb 2022 18:16:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=LRUIoxd+; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645150593; x=1676686593; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KI2A9mgyhwhlbmK88OR6c5X2K813C+UkDMgnA/JFveU=; b=LRUIoxd+/HJ8QNKHxZwFCU0HDln1s2/cHlviycJGSFZlMjifH5eTLcgX 8FB2djG10FCM/IpY19vnSzNQly0fkZeKjH0UHS1/gWQ0Y9SDra1WZ3Ze0 JEEt3MtW3417e1wQGl9RIhtJEyXf8F5BP8DmBcYtspyXGh73y8oD4E0om qdfVNLOngMygENE4mI+UNIe3NBBihkHjj4ETAWxwUJiLLoNcmcWDUz8BN tOm7u2glHL9MYzJhw3BZT5GJTep4VXVP31CsKf4Fq8p/ritsIOq5kz0NM Xu1GrNdPPCA9ofKGgQudlZ31deX1lwXU53S0bRRF/GwJzzCSqvxLOhO4H A==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="311773671" X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; d="scan'208";a="311773671" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 18:16:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,377,1635231600"; d="scan'208";a="626433560" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 17 Feb 2022 18:16:31 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 18:16:31 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 18:16:31 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 17 Feb 2022 18:16:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ha7SyyZjnDZoLXjBTScVvU9M8Zlvvi9m5RNavgyurcoSP+qZHdZxA+uz+eTeMofAELIHrZrCr9Y0UjUS82r+cHDfTkswHxg/Jsk4tGIkbM+SHDRv12h3CjyXW3GBuynsGmJqI4BH2b9uBSNQPq5zxlDlMQYgxSFlYRRQoTgCXzY2JEHDdT8ZNFkGKVJKrN9UpdeuTWJmGjOt/U7rC0dVg4nyhavUnlYgXPc588q/VTX8L1xPXXdtQi/XcxxeYTuDUQAo2WmmwKX0S6boARAoX1c2GmH1096JHfPhrqw0UxAji9zTwFw3MXhop/7X2F4uYXP1eL/CLY4Abs+rpbDpaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dqpefiwRFkevs5jC4L1lmOUHorOZNmkW3qKk0O5+Jxw=; b=TsgqkvlCpTtnLa0psF4Da6evOe5JHn5yYrfxa9QmhDgDNtGTrnVvB398bu+ZXXvUq2OiANmF1HQSZLr8jhgBvWu+i6KqsBCaVy9PnfDy4VPKWyp7gCGhaZEta3jTWN5C32Ae0cYA7YclJwM5xyzpAUvWPn8V0hgoWlyfIzJJe3/JBhP2RaZd7yBm+XvfWGMKLCp5wusqA9Cl1QmXVhnfGejI2KhnmsXMqeSpcYDzDrULEFKvATB/5gwrJqdDya6YXwmzPkWmv36E/J1sz8nTNBHwyWqVIxfvqNay2/B3zdktfqKbnxTQGnAokb2uo2PGF09fxVRcBW44PXwMdGcGfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SJ0PR11MB5088.namprd11.prod.outlook.com (2603:10b6:a03:2df::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 02:16:29 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::707a:603c:30eb:bcdd]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::707a:603c:30eb:bcdd%3]) with mapi id 15.20.4975.019; Fri, 18 Feb 2022 02:16:29 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Rhodes, Sean" CC: "Dong, Guo" , Matt DeVillier , "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/2] SdMmcPciDxe: Make timeout for SD card configurable Thread-Topic: [edk2-devel] [PATCH 1/2] SdMmcPciDxe: Make timeout for SD card configurable Thread-Index: AQHYHyNzxtrpUdvS/EGHO50V6xEESqySsKkw Date: Fri, 18 Feb 2022 02:16:29 +0000 Message-ID: References: <019ffb146f19e495e98c709cf7ccdb439cb60ea4.1644568992.git.sean@starlabs.systems> In-Reply-To: <019ffb146f19e495e98c709cf7ccdb439cb60ea4.1644568992.git.sean@starlabs.systems> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 45c19549-bc77-4c74-5046-08d9f284acc9 x-ms-traffictypediagnostic: SJ0PR11MB5088:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gxQ9PaXT+gF8qJHE7A8bVzJ6NlgdqqIAJvM8PuFLXhXg18MMYVW4eZD8JE7Kfs1DUtT/5gvsdyCzFjcCTIavbwwzBtzyJtmE/FYIQ9LOjjqR+MF6vhM43tvtaK1rNQWfpYOTkU+WVW2bHbt5QlxDxON7PPwJrgDuRTOROhzDg09tblymlWEcTwgn9hKrv9t3+2lPqpVkGfm4yh+wERrNOun7+ksqtFmt11EzPQMRfcOqzG8DPX0Jidajd5BtfyibvUPApO42RPBTQwkT4zKySLEXyYcLM0u+bCcA91SsnlPLdmLdPEHndcoYl89RpiXGtang77NP7qSw5jZNmtedy6rHNk8zim/mNRRapcEVk77A2qH3UYEHLPJC20tQugufi0QPEE2x13QkS3QAk0fDuSC1WyzSL57Jee/N0a5P0M7FRb5DOn282YkkcHM3swMO/a09v8YtbTvsUv8HVt6fHByrUo/Kt9wsdRuAH0olJn1U5ngP8AuEz6NElhQw9ppOA6MgmlXU9k5fnOSeHEI6lvBYg6KrryWHc/1+khiHadxVemWc4jYZL2WBnornYKg9NNdA+i1w1/WfhDecQcIGCVzSOxsS3DYDMQ7fnuT2iiFyG3voKf9Gt75f4oKaODk7lOsmBIJdkB37Ze2WhaSgqdtfZ0UmqArV6fmf6jBBBVl97FLBP45LDWopB8ubwhfAr0qzqeSd334tqic/SBXg+BeWjyMM8IZJobWVHCEPCYAQJ6WOIegSlkst4Yn7DSM2dr1KPXgsASwOyVc/2/HXjA9NJ38U68/VV4l+u4S8kmvpVAI/apNDjooNXSPQwDfgz/BWs0EwH0PEMj6iWhbDug== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(122000001)(83380400001)(26005)(38100700002)(38070700005)(82960400001)(33656002)(186003)(4326008)(52536014)(8936002)(66446008)(8676002)(64756008)(5660300002)(66476007)(66556008)(71200400001)(55016003)(66946007)(76116006)(2906002)(53546011)(6506007)(7696005)(508600001)(9686003)(54906003)(316002)(110136005)(86362001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?25Q+qTH5WqBe08Is1KcSierhlETDgOn1sWFVHX/cADjVNn+YoHA6Of686dP4?= =?us-ascii?Q?kc1W2VZ2ovQviY+bmBSri9fC4NwBgRc3gN1Sshl2OwK7qXmkJSSAJk0YxZxx?= =?us-ascii?Q?WjN0MxIlipLnENV7b89BEUsPjJgf7uclJ9E46YLBfE5ap+tKYR+kxmj+qQRz?= =?us-ascii?Q?6u8+GxMczlpHdg6pOuzQL+0I2oveN0KQiqQvwSHldlutFU+pTxesnmTJDr34?= =?us-ascii?Q?SL81cWV2NwtRdSBbMJzgUy7tI//xxazD3HzxwpXOYHqTQfK4LCA2IdGlMSXP?= =?us-ascii?Q?jsRLT3gHuh1YP/ZWYPdNIsxUXc4P0Uq6gFbCV7bkcU5rYbM0goXh46sPwC8A?= =?us-ascii?Q?qBGAJPmkKy9TwNlHmKnlghckAWOE18uwvFEjEaLaLtwfqjqDjpRnlfvS6OWv?= =?us-ascii?Q?lmyIPh806hzaA3fpHvwJnn4RIfCoYqRwRUibfAjVy1tqspiOCq8sanR/xbOT?= =?us-ascii?Q?Y8MO4WxTMifzEW603QYdZ55aq7RSwR+UJ6g9kFX9yJSBv7/m3i9a5voRHvDT?= =?us-ascii?Q?UI26OgakhEA9/Qp5Gt6RsCrBkX3AzZnMiwdaourr6/jP1JehVlf8W1miul6P?= =?us-ascii?Q?SiizFlMWZ6IADUW0OJVeM9mXWo6x4WEaWVBdD9v3mqmGjtsrfKRYrCvvS7E5?= =?us-ascii?Q?tsICGH6lnLQd1+zpx3osrPMyppuaNovl09k8RqAmWzyqo06lifUlI6opkgI4?= =?us-ascii?Q?aSJQlM3lyS/CrQjRgq4HuayyJmvGiXPlBQTKbL6ARjuq5GXWTCBwO8DWnUyy?= =?us-ascii?Q?aEjm6/L6UdtlIHSKgyS54Wp9SJXIjI3DdlhQzqWTd6OpFwLEBM0poPuXm86y?= =?us-ascii?Q?yB4SxMeo0ugIOmVZPrDJrxawFqo3YXYWBLXp7lLBzqnbDqGWiKWhaehddLfK?= =?us-ascii?Q?ik1YALKdZP0ZLvdNrXcMID+xKhz1/RXuZj3wxx/Uo4KuPuiK9K5uRtRkkAlB?= =?us-ascii?Q?sK8PKRlE2ZSAaOH/yV98t0Oe0lyhqLXaLI4HQzEO/TC2JiLNyk6fdkRKzqWi?= =?us-ascii?Q?SIH86yAp3ED1EG/cbdHqcA2/z3yv46+fm4c4ClhY8rX78W9P6z95CUrQgtwJ?= =?us-ascii?Q?zKg+b1oc3jwzYE6J+Lx0FwuIavvV2ButfpsNJ7Firuh/iXUNsZo9U3aUrPuW?= =?us-ascii?Q?sVEOAbv70BfFtsq/pOHfmE6DDMBbSMIDeo3h+jfotBnQCCaAWnUM1HS11xA3?= =?us-ascii?Q?sOi/JJxGEe/L/NB3L0+afwy/FTh1VAbZ1WBlU1LxvShs7AotE50JEdE1LVLP?= =?us-ascii?Q?youOhMoffeg1CKkLfLCzMruiWYldPUYycZmhvJAnmUEhJQT8LF48BfvOwKwc?= =?us-ascii?Q?ncDXhoAMCzaorAXk+0vHfJltYBDTVOepyW6jzB+51TBcAQgPo+t8UAD+IPxl?= =?us-ascii?Q?pRD5FnubbjlvjKTR0mFE54deLqEwBKDIkg9YSDeN6WaRb1P2RsFR4dl8e1RK?= =?us-ascii?Q?M78cttRZ3fGVgPb5o63xE/lcrpUeIRpMJ8wNiotxcqRqqz7ZUZA4gG4s4e5n?= =?us-ascii?Q?tWgluOPMEQNsjVyk88AyudR2JiAz6uk7s4xM6f9pBb6GYp/8kJrASAA72I9V?= =?us-ascii?Q?jnwH1OZYNsO7V5E/sx4oBqJpGc91TVz7TUcEqSoYckRNdlPfC8KXnBcT3w8r?= =?us-ascii?Q?ZqEzXnXJE9uno/P5XKdkPWY=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45c19549-bc77-4c74-5046-08d9f284acc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 02:16:29.6865 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nmjCJiehMXG8n6Ukbsd5h+fQWRZs00XAhOSzFSysQ7BZM75KBRKF4lQal3ZKwEbg3/28rfh/gSc/WieWgaSeeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5088 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Inline comments below: > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > Sent: Friday, February 11, 2022 4:43 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Matt DeVillier > ; Wu, Hao A ; Ni, Ray > ; Wang, Jian J ; Gao, Liming > ; Rhodes, Sean > Subject: [edk2-devel] [PATCH 1/2] SdMmcPciDxe: Make timeout for SD card > configurable 1. Please help to update the commit subject to "MdeModulePkg/SdMmcPciHcDxe:= Make timeout for SD card configurable"? >=20 > From: Matt DeVillier >=20 > The default 1s timeout can delay boot splash on some hardware with no > benefit. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Signed-off-by: Matt DeVillier > Signed-off-by: Sean Rhodes > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 2 +- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > index 85e09cf114..c9a21e01bd 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > @@ -49,7 +49,7 @@ extern EDKII_SD_MMC_OVERRIDE *mOverride; > // >=20 > // Generic time out value, 1 microsecond as unit. >=20 > // >=20 > -#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 1000 >=20 > +#define SD_MMC_HC_GENERIC_TIMEOUT ((PcdGet32 > (PcdSdMmcGenericTimeoutValue) 2. The parentheses in the macro definition are not matched. How about "... (PcdGet32 (PcdSdMmcGenericTimeoutValue))"? Could you help to verify the patch before sending it out? Thanks in advance= . >=20 >=20 >=20 > // >=20 > // SD/MMC async transfer timer interval, set by experience. >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 463e889e9a..092660f7f0 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1559,6 +1559,9 @@ > # @Prompt Maximum permitted FwVol section nesting depth (exclusive). >=20 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdFwVolDxeMaxEncapsulationDepth| > 0x10|UINT32|0x00000030 >=20 >=20 >=20 > + ## SD Card timeout 3. Could you help to update the PCD description to: ## Indicates the default timeout value for SD/MMC Host Controller operati= ons in microseconds. # @Prompt SD/MMC Host Controller Operations Timeout (us). >=20 > + > gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000 > 000|UINT32|0x00000031 >=20 > + 4. I think the patch is missing the PcdLib reference in files SdMmcPciHcDxe= .h and SdMmcPciHcDxe.inf. 5. The patch is also missing the PcdSdMmcGenericTimeoutValue PCD reference = in SdMmcPciHcDxe.inf. Please follow other INF files in edk2 to add the PCD reference. Also please help to verify the patch before sending it out. Thanks in advan= ce. 6. When adding a new PCD in DEC file, please also help to update the UNI fi= le as well. Could you help to add below lines in file MdeModulePkg.uni: #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue_PROM= PT #language en-US "SD/MMC Host Controller Operations Timeout (us)." #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue_HELP= #language en-US "Indicates the default timeout value for SD/MMC Host Con= troller operations in microseconds." Best Regards, Hao Wu >=20 > [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >=20 > ## This PCD defines the Console output row. The default value is 25 > according to UEFI spec. >=20 > # This PCD could be set to 0 then console output would be at max colu= mn > and max row. >=20 > -- > 2.32.0 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#86612): https://edk2.groups.io/g/devel/message/86612 > Mute This Topic: https://groups.io/mt/89066986/1768737 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20