From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.3047.1655952844125529316 for ; Wed, 22 Jun 2022 19:54:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=NEts8UQ7; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655952844; x=1687488844; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=w20pKE3rg3aepIle4mK/jj5kkonvooK35FEwLPgb+nc=; b=NEts8UQ7DrxCx0D98pPNAMe67BoNQQRgFhNT+1RQRfihimnATwUcsrIP tL5GWebb18bBnGkES51SIJrN00HCGMMG85XANxUjPa+I/vUj1UymV/BBZ ppT3zK5cbtJJgTIHAOePKOKn/em+y7NJYWIgNzZe23+u5TVAXwF0zRswj kr0xdi0JaEflQvX+P6Cmwd+IS58OgRUxY7hRrEgQMaE+AFNU+d3NHXvP8 7fMmcLexKiBCpeX+eJF17/bJ12OYFf+auM0xXQCcxp94xB9zoGsW1X1qh 1NVLUaPmcW7CU5oh2CnQyb9uLQQ94kVVqabavbTHW65BNm8f4//IceoL+ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="281334967" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="281334967" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 19:54:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="715657287" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 22 Jun 2022 19:54:03 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 19:54:03 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 19:54:02 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 22 Jun 2022 19:54:02 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 22 Jun 2022 19:54:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Giy3fvEmDWNIcHat7jkUS1VMJC7HFFx3+ZMgE3HbQF/RRqEi4P3GYcqJhu20vPIcS2CTWiuzww6+rq5eU18yBDUAC7Imexcu9WEVFi9SaxQtWw1lkC3eokv5TuhaoElraSPDY4JL7N6q4KMeF2KyCbpvFj4cO3BzmimLf83NlMWpd6ix6+hY2crzK0ttJaRznwbIMgs76PV2XWlHZYHyE5jvwyubPcKjSZcuv4uWUEFP7N5Qaw5bhb9m1qfFs5sXk2OTXOH/wOoD6uQ9KEGVs/VpvaRnjmqUWAQORFiKhCapFZmppdWVg+AfJWCtSwOUqX0P3O+lhGJh2IJcDlpl2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+SRk/Yi8kLIvvUYP/ZIFC6HEi5WYZguTMK4/giTHHKc=; b=l/D8yRQ8z3bHrTHqK6sUzwTH5KjukT1IRpxVFIvIE5jjZ6xC/b2EAzl4yGZNHrkPtx55qhST4NGvZZf7cBtzYWqn4E0g0RgRueqOllhCzj6XsHYhAATLh6ySVt+TffA7iMy6GkYHWWrX470tTHSou0HGr8SVWOlj0Jhw8VivIdgyt9KNq+5EUvJSUwjNcbcz3owsq4vhy6EMvmsBNfRcZy1VANjnnGYqkSgdcoRZ3BNEzgsgLzL8V7HiBRO3TKpa0/ypKGfOP921zgi9YGxJvH7RxYQv1L0jQIGPv5Fza0utRrnsyDvYJubAFITtByiJsfXjdGH8ZS49p2aJmB6+8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SA0PR11MB4622.namprd11.prod.outlook.com (2603:10b6:806:9c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Thu, 23 Jun 2022 02:54:00 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::c473:f30f:6b1f:c5ec]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::c473:f30f:6b1f:c5ec%5]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 02:53:59 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "jbrasen@nvidia.com" CC: "Ni, Ray" , "Kinney, Michael D" , "Gao, Liming" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Thread-Index: AQHX8RRhP+NC435QqEyMgowdUQbl8Kwy2ghggAAhxYCBIeJPAIAIjGCAgAAMDvA= Date: Thu, 23 Jun 2022 02:53:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f5f0c35-12e9-4390-8353-08da54c39f8d x-ms-traffictypediagnostic: SA0PR11MB4622:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ycxakhN8JZQR1qS5KsRQDNBkNQU2p/Yht6cqAO4ePsYCOOYrHPPiKdGn+gHn5YNIAxYV0PrAgbPMi54vnR93jolIjLBNOkiVlnPizBF43A1x4Es0rkYC8qZ4ohkfy1pkOT3IBn3baKMeDJTuZcUHGpI0uaFAHS1pD4UOYNb6iugnWWypGQiOarTBhL49OZTqNLFMXLAFcf75zZ4N87Vh727+jwNjwVSucVv88J58bug4hX9ad84ZQqa2f6ZHwzneL3mEf+6fpFqJ8fZTLxkGqUqbjw0pFpHcsCfLAyPWl5wHLxkZ2cMI6V7F0ZTEMr3ZKVXHWGFqQGy3U9fStz42a7bdC8vJVCTP2Dxm0doWuiE0FPlxxvjNKKkhMtSMXvsoF8lDUeEBq4z/w4pcD3GaM+FgMNkwoIodm3tYYlcG4q/gJme6KuJnnm6g/8qYE5yJ+6ZUFoB0lsg9M8RZaH/Q1wXq9ImOnQPUaDBzN+vsFXSk0LweCI/o6CEe40YARm24kg5a6AICir0GR9gdJQ4e4xmtnoMHtKnmnMj0Hk7+GPTN7DMVc6dCj3q++qaviPlASddw2LqIltHO5BzVG2A4IqdTade1HCrYjOvhEY0RKoJN8b2IqLeAfAIFtDGn/Vivl2UjBJjZFkDw5XziTzfUqI+1SHooytgxNQoJNzZICa+zn5Y2D0xqA6YzktClVZhe4QvYtQr31iZUnVzyb9beJZU7DNbx2sY7bGMgtSHbOK1KI31XXC98weXTgLHemtbCcuXq4FFKISNT3RadxnFP6QIDsE6+1su8Uf2Ku5oDRdjXGHSsWP/e0yJI0cTN8NlyNsjWruwytTCIRJG/n04syQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(376002)(39860400002)(366004)(110136005)(54906003)(41300700001)(83380400001)(186003)(38070700005)(316002)(26005)(30864003)(122000001)(66446008)(82960400001)(53546011)(2906002)(7696005)(64756008)(9686003)(6506007)(66946007)(66476007)(66556008)(2940100002)(478600001)(33656002)(966005)(52536014)(4326008)(76116006)(8936002)(5660300002)(38100700002)(8676002)(86362001)(55016003)(71200400001)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rHL2a/Cp/OsaWszak90fNjhG9gvE5dllvIINNJjTDt2CW1zigBw8Y32mzvu2?= =?us-ascii?Q?iqPS820r7S02fUw1JFkrgHgyoDMgnNC/t+TPuT2BTUrOs0GNWVRUSCVYFxdv?= =?us-ascii?Q?N/cDQn2FKd7/dtxKxBxp9W8+alPfiH0xcRAhkZRt03kxLRHx3ewQacXoP+Yk?= =?us-ascii?Q?Z1QMZDF+Fy5wHpLdpw+7HAdHYPe9bDo9U9FRyujAbfwjjlFikbDNYpJ/AlG1?= =?us-ascii?Q?oxjsHPEJ9ltyl+gMHH7Ug6OOsr20mi1WLP5hJTtfGXMFP4mMnC2UtuTeT149?= =?us-ascii?Q?/3/L0QCNkC3VgWMJUjs6k5rg98LG7fAkmpK6z0rUtze9Tl7ryBcnaV4m0GkE?= =?us-ascii?Q?YAy624VMTzbeCz6SlJzYogwZDoCKeL00c+6yc3VOkVufxXx6VSbz1kvo1J3A?= =?us-ascii?Q?US7FxXV+QsthuZxPps21rcsY1pAD/00EYnaUh1xmCMs5ussMo3lAES4Qk1lz?= =?us-ascii?Q?g7Bqq01s91x3NWu81A1+bBoytN4gjn+GaB1VJEtcTvsQF/lZ/gquAlmBg5i1?= =?us-ascii?Q?kxG2J/b0sQthJWG3dQ1qk7WCcLzQ31St9GVVsZ4Jv9owKCxePKzLsTpGcSW4?= =?us-ascii?Q?Srj+H95lONoclnVe+5OTa8jFvbCfjBx4TQp1YfM9KPH4NHbCGQo9GHB6667a?= =?us-ascii?Q?6StFYZpxpr+P+fevKa3kBnZwUoiWYs/TIzB3N5yKScCuGYPLd+YvovICJab2?= =?us-ascii?Q?LAvT1lkwfJUyAmeehLOXIPTwqh0TwS/Q0z533mO6SPIAkYFdeAtIGNmZtKjy?= =?us-ascii?Q?uz6hGxH381Q+O3ctvxt7uJJtIu7WQf6EVfXOglURfaXAQWvrCHShS4ifhJjL?= =?us-ascii?Q?shp91yN/sZhZ61NUJ0NVjS+R6l0lIdYAuG4IGXYm4uO9K8ZVBmo1vmybIz1N?= =?us-ascii?Q?1xaVBY4qNSMpJtYhRiKu8ZQmfKUhut8iiir/1kp1PxdmWvr1+7KD8Bphs7mS?= =?us-ascii?Q?BZs9ZAuU7KfdqpNipTyXMXCZmssAnL2Urwvv3HRDyY2aIVEuUQMEeZeAYmZt?= =?us-ascii?Q?d50g7sCDo8hcMxGfPRJ9NYeyjAaHWPbmiJLQ6P0bCQRHM65nPMcdi/F/n0dv?= =?us-ascii?Q?EW+6qAQ6kpgEgsUPmSWKg7UOUb0VHKc15L5PO8NWPZyerPdDtoXKnlDBa8HA?= =?us-ascii?Q?bkoSt84qtHDYPk7gD1UmsOysgkendlGdz8YZP92bsMZ1pOlCgqiCsBpz/YzC?= =?us-ascii?Q?OcHxpRr8Xnt5Xfv3obMb3rJqZrF2F+CCvgqZk7vcDXw2uOzZVocrvm7BSApc?= =?us-ascii?Q?TDbO53rzPp44/fpIA7fH5hnKmWfaGe8LEwsQwQHnjgq/W+eDJ2X1+dO6CKM1?= =?us-ascii?Q?iZVHgimhU7iNSHYb+qbPXesK/JHucOxuV++8NzXalERoACF4SQrRcVXtJzAC?= =?us-ascii?Q?ViXUsvSb9zI20EhnkOP5DWrXxdJHQ/ZORDHtFL5oFP9k2TSPP1MY/XN8vsl1?= =?us-ascii?Q?TxM6A5mjSuX0lnjRXbnZjFGtzCVoxNIHIajGo2GCG6ROJE3ElF4yAeaim1hS?= =?us-ascii?Q?RBFtDM4MHk/cZP1Bo0JlaeDwCOQaDRuDKIQK3R96pMgpywhnhmHZpFbR7FFC?= =?us-ascii?Q?hJewJP6pflXzNK0h48DpkABxAGCSuunNDQk7JVHb?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f5f0c35-12e9-4390-8353-08da54c39f8d X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2022 02:53:59.8397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QUgU/d/wZ3wbnu/gatUa8/SoooLkDxUdu489Mf2R2700a+meCxI10FoHc6f/6i4clwiz2bOkhJvpGb1/n+JjFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4622 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Fix a typo below: blocking I/O request will wait for all the (synchronous -> asynchronous) I/= O requests to complete first before sending down the synchronous request Best Regards, Hao Wu > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, June 23, 2022 10:47 AM > To: devel@edk2.groups.io; jbrasen@nvidia.com > Cc: Ni, Ray ; Kinney, Michael D > ; Gao, Liming ; > Zeng, Star > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to > NOTIFY >=20 > Hello, >=20 > Several concerns: > 1. Raising the TPL to NOTIFY level for blocking/synchronous BlockIO servi= ce > will break the using case when the co-existence of synchronous and non- > blocking/asynchronous IO tasks > As far as I know, in DiskIoDxe, blocking I/O request will wait for all th= e > synchronous I/O requests to complete first before sending down the > synchronous request. > Please consider the scenario where a previous asynchronous IO task, it wi= ll > take a long time to complete due to big data transfer size. > When a subsequent synchronous IO task is submitted before the > asynchronous task completes, it will wait for the previous asynchronous t= ask > to complete. > However, if the TPL level for this synchronous task is NOTIFY, it will ge= t stuck > since the completion callback for the asynchronous task is also at NOTIFY= TPL > level, which will never be called. > More details can be referred to commit: > SHA-1: a717086c5f973821b9b49646a4ec725f6b898bdb > * MdeModulePkg ScsiDiskDxe: Raise the Tpl of async IO callback to > TPL_NOTIFY >=20 > 2. My personal take is that BlockIO is not a proper base service for vari= able > service > To my knowledge, the variable service will still exist during runtime, bu= t the > BlockIO services (as far as I know) do not. > My understanding is that the main purpose of the BlockIO services are to > provide BIOS boot codes with the ability to locate partitions and file sy= stems > on media storage devices and search boot options on them. > I would recommend to implement a dedicated platform driver to produce > the FVB services for variable driver consumption. >=20 > If you think using the BlockIO service as the base for variable service i= s the > right direction, I have added people in the CC list that might help. > Could you please reach out to them for feedbacks on the TPL restriction o= n > BlockIO services and Variable service? >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Jeff > > Brasen via groups.io > > Sent: Friday, June 17, 2022 11:37 PM > > To: Wu, Hao A ; devel@edk2.groups.io > > Cc: Ni, Ray > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/ScsiDisk: Change TPL to > > NOTIFY > > > > Resending this as I replying via edk2.groups.io doesn't seem to copy > > maintainers. > > > > Resuming this patch to see if there are any additional thoughts on this= . > > > > In response to the query about DXE/BDS services we have some internal > > connection logic that runs in DXE to connect the devices that are neede= d > for > > arch services that have to be connected prior the end of dxe. > > > > Thanks, > > Jeff > > > > > -----Original Message----- > > > From: Jeff Brasen > > > Sent: Tuesday, December 14, 2021 9:48 PM > > > To: Wu, Hao A ; devel@edk2.groups.io > > > Cc: Ni, Ray > > > Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > > > > > > > > > > > > -----Original Message----- > > > > From: Wu, Hao A > > > > Sent: Tuesday, December 14, 2021 8:00 PM > > > > To: Jeff Brasen ; devel@edk2.groups.io > > > > Cc: Ni, Ray > > > > Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > > > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > -----Original Message----- > > > > > From: Jeff Brasen > > > > > Sent: Wednesday, December 15, 2021 1:59 AM > > > > > To: devel@edk2.groups.io > > > > > Cc: Wu, Hao A ; Ni, Ray ; > > > > > Jeff Brasen > > > > > Subject: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > > > > > > > > > Increase TPL to TPL_NOTIFY to allow for use if caller is > > TPL_CALLBACK. > > > > > This allows services like variable services that run at TPL_NOTIF= Y > > > > > to be hosted on ScsiDisks (i.e. UFS) > > > > > > > > > > Aligns with the eMMC driver that also uses a higher TPL. > > > > > This change was made in > > 3b1d8241d0dac25c5e678c364fa2754ac1731060 > > > > > > > > > > > > Sorry, my take is that this change is not equivalent to the one mad= e > > > > in the SD/MMC stack. > > > > > > > > For the SD/MMC change you mentioned (commit > > > > 3b1d8241d0dac25c5e678c364fa2754ac1731060), the TPL is raised to > > > > TPL_NOTIFY only when: > > > > a) Operation to the linked lists that manage the asynchronous IO = tasks > > > > b) Callback functions that process the asynchronous IO tasks The > > > > TPL remains TPL_CALLBACK during the BlockIO services and the > > > > majority of the > > > > BlockIO2 services (operations to asynchronous tasks linked list are > > > > the exceptions). > > > > > > > > But the proposed change in ScsiDisk modifies the TPL level of the > > > > entire > > > > BlockIO/BlockIO2 (and other protocols) services to TPL_NOTIFY. > > > > For me, this is not aligned with the "TPL Restrictions" documented > > > > in the UEFI specification. > > > > > > > > Best Regards, > > > > Hao Wu > > > > > > > > > > > > > > I had sent out a query on this before and didn't see any response. Th= e > > > core of the issue I am trying to solve it support variable services o= n a UFS > > device. > > > When the UFS blockIO is invoked from variable services it is not > > > allowed (which does align from the UEFI spec perspective but does not > > > allow me to implement variables services on UFS) > > > > > > The other way that worked was lowering the lock TPL level in the PCD > > > driver and Variable down to callback. The PCD one seems like it shoul= d > > > be done as variable services is supposed to only be called from <=3D > > TPL_CALLBACK. > > > However, I was worried about that having a larger system impact on > > > that change. > > > > > > > > > > > > > Signed-off-by: Jeff Brasen > > > > > --- > > > > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 22 > > > > > ++++++++++---------- > > > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > > > > > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > > > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > > > index 98e84b4ea8..b6e5848e77 100644 > > > > > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > > > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > > > @@ -514,7 +514,7 @@ ScsiDiskReset ( > > > > > SCSI_DISK_DEV *ScsiDiskDevice; > > > > > EFI_STATUS Status; > > > > > > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > > > > > > > > > > @@ -581,7 +581,7 @@ ScsiDiskReadBlocks ( > > > > > EFI_TPL OldTpl; > > > > > > > > > > MediaChange =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -733,7 +733,7 @@ ScsiDiskWriteBlocks ( > > > > > EFI_TPL OldTpl; > > > > > > > > > > MediaChange =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -898,7 +898,7 @@ ScsiDiskResetEx ( > > > > > SCSI_DISK_DEV *ScsiDiskDevice; > > > > > EFI_STATUS Status; > > > > > > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > > > > > > > > @@ -975,7 +975,7 @@ ScsiDiskReadBlocksEx ( > > > > > EFI_TPL OldTpl; > > > > > > > > > > MediaChange =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -1154,7 +1154,7 @@ ScsiDiskWriteBlocksEx ( > > > > > EFI_TPL OldTpl; > > > > > > > > > > MediaChange =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -1323,7 +1323,7 @@ ScsiDiskFlushBlocksEx ( > > > > > EFI_TPL OldTpl; > > > > > > > > > > MediaChange =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -1717,7 +1717,7 @@ ScsiDiskEraseBlocks ( > > > > > EFI_TPL OldTpl; > > > > > > > > > > MediaChange =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_ERASEBLK (This); > > > > > > > > > > if (!IS_DEVICE_FIXED (ScsiDiskDevice)) { @@ -1907,7 +1907,7 @@ > > > > > ScsiDiskReceiveData ( > > > > > AlignedBuffer =3D NULL; > > > > > MediaChange =3D FALSE; > > > > > AlignedBufferAllocated =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -2122,7 +2122,7 @@ ScsiDiskSendData ( > > > > > AlignedBuffer =3D NULL; > > > > > MediaChange =3D FALSE; > > > > > AlignedBufferAllocated =3D FALSE; > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); > > > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > > > > > @@ -2294,7 +2294,7 @@ ScsiDiskDetectMedia ( > > > > > > > > > > Status =3D gBS->CreateEvent ( > > > > > EVT_TIMER, > > > > > - TPL_CALLBACK, > > > > > + TPL_NOTIFY, > > > > > NULL, > > > > > NULL, > > > > > &TimeoutEvt > > > > > -- > > > > > 2.17.1 > > > > > > > >=20 > >