From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.28836.1641799091627329352 for ; Sun, 09 Jan 2022 23:18:12 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MOIcL1Cf; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641799091; x=1673335091; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=p5YHverrPeos2VeJc/Uhpj6G3MyhAXp8GXVuBQyNhu8=; b=MOIcL1Cfca7jFxQBNgffvXLxMH9mM4euY+20q/et1eEJkEj4R3c+pmCJ dmVtz7ITXvO02qS4OQCtHvNTHt5v1FhdC33qaHRDakLLbf7QK43QakrYM wfhThWKI4nivOVVRuqXspUfYZckn1ciGbIuaGpkquA1nhpZswAvYkxrmZ 6m0kUY7SVx0msp8564lyvv8KD5PjV2pn9aWKnoCANCuT4r4B4AmNtohxh IAgtrABnNO7zaOfQmoCc2U8e9bbQDwUcKChDC6j7X0weASjiSxDStED+u b0AfWLuN15ST4/AT1HghrGyMct2CHOCf6HGmCt1YWMRVSM4wX+abVaVO6 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10222"; a="267494829" X-IronPort-AV: E=Sophos;i="5.88,276,1635231600"; d="scan'208,217";a="267494829" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2022 23:18:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,276,1635231600"; d="scan'208,217";a="474035819" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 09 Jan 2022 23:18:10 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 9 Jan 2022 23:18:09 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 9 Jan 2022 23:18:09 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 9 Jan 2022 23:18:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C7SHdkXzmgdsSbihgSVpedWKpdALJw1ooPGQmGqVGUp4kqeHQ42jZEtsgUDC3TjcBvVntoHyiw2PdJ8GSSuLvnUcLCUvqtf1je0qRGi/I5xmI/DV3IaG9Kb1NmVmuj01/VrucjIkWUaELwOddUT2/I5KxmN6JPKRilhLsXhk0sSaOo3J9MbLenKKmJn9TUK73PXjJ2wuATyserN70BDDbeQ5lvUZsc7y8tDhAxeMERMgk2yDDAPOk/0Re5oSv7doDbTxpKM5YPfFN3KOhVSf3+Rqhdnr5NCx/ztPUbQCS61eGtOFnYpQdS2IH/wMxM2bvHGcUVwF8HWffJHQDj+CdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2chICch5ZGfCQNUf4psePzWnQwkhWLOWXKxQqYbQ7aE=; b=iIgszb/XuPz9udJumB3oA8bx2eJKasya9p8EK+c/8gwX8Qlki237zYKDh7r0PgZAJeQhX4RXeeJaeeglwCzqVOrvUIn82laX+E8FcHNz/T5N5DahyAdSy0Z+raPnhkBSaDZfHvTAnHJK3qixDl7kW/M0UswsgkSsSNNOyeWcvaqyoiQp7s+L5Lw+q7Q2Df3ytLIbTdwo0PMnaV53mhmSLVkpfAkD4cgOXWJGG0SbVzAcc0Yxra4rwcr5ikK4plEKGVNcHFgODSO2ahTqVCPd/yF5y5zvXldHS7+xPrTL8B+0G1w9Fn958qcIAHpAcSpw61X5lOB2jGl7PA4+zWryHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB4610.namprd11.prod.outlook.com (2603:10b6:5:2ab::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.7; Mon, 10 Jan 2022 07:18:07 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%6]) with mapi id 15.20.4867.011; Mon, 10 Jan 2022 07:18:07 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Edwards, Craig" , "Gao, Liming" , "Wang, Jian J" , "Ni, Ray" , "Gao, Zhichao" , "Shutt, Mark" Subject: Re: [edk2-devel] [Patch MBR endless loop hang with invalid LBA0 1/1] MdeModulePkg/PartitionDxe: Add break to handle invalid LBA0 in MBR Thread-Topic: [edk2-devel] [Patch MBR endless loop hang with invalid LBA0 1/1] MdeModulePkg/PartitionDxe: Add break to handle invalid LBA0 in MBR Thread-Index: AdgCZVzj5whplCenSWm261VEn+0/fwARri+AANGDCNA= Date: Mon, 10 Jan 2022 07:18:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Enabled=true; MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_SetDate=2022-01-05T18:53:11Z; MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Method=Standard; MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_Name=No Protection (Label Only) - Internal Use; MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_ActionId=628769ec-5e69-4788-82ed-a28e932d329d; MSIP_Label_73dd1fcc-24d7-4f55-9dc2-c1518f171327_ContentBits=2 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9644983-e173-40ad-49bf-08d9d40959d4 x-ms-traffictypediagnostic: DM6PR11MB4610:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:346; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W6HW/0mbpKuYOIR1cmWyw/lFZvtJOwSCgoNYEj8H9DjTVGKKLSsTI7VZAravRIGFcuM4/1nVxTdCSF/Z3Ah66eEE/IO/ouJMHMuDnq9HqoNbUCL1LuSR7Pil8DI569IU/h0IkC/mFD3NMU4lFCrOag9f2VAmukVrdUwpgYLIkNJ607OWEXClMqvY1RSC1tPEhDGmgK3cOjjDZW1bh7fc6Og4rjqCVOg0s2nxaZPPJMwGWjvCqE0aYfwppOW8FlrnNuDHgg340FgdESMY+BvS8aYaRwVVhAq3b4cMpqSvJ2aH4a3VrZcASbDnQ7vARb8q+g0eyP2r57dbJYnN47DK9Jiz0JLlcQ9+sauUzl/AAufxowc0RfruXjuXenbw6XtRYXIzefHmGjblLVn69/5/NpKHuIz+SGV5N/zVjOv/9hfgbx1A2/pbGrLudTZaWh0burCAzheTB6NfoBv3uH9LLm1Q0RlpQXguFrsqiy3FtPyoECzs7+BiXSLXCeE6ZvzrTMl/caxx1nCwmp2cSXQ/hYRclyQ2aeypS1vLj1zV+WH5S50T236FLRWBu7c0C5DD0Ml6zxna3yABZVgH2JTfg5gvAQkCSdpBg/rnIz/yjYsf0Q7aM1whAvOCRy/nl2WgCCt8xbvthUvu3iQ4ymtH7MEb88/7Clg4Z1a5PGVjVySwG/GD+ITwSo5VKxrHDvmF77k+S7p8pGvVCdzxL5iTPfr1uvDDu1CccrvrFS57u9nEjEMWCyBJ3p55mfpLrePkwq/Ab6/kPowRsYutckqgZ8R3ZFisMQUGG3SCaW0J+LGrVUW9ckbPF2pz4VNVnx5KCDotW/5kpaYn1Hw4Li79e1o4SlRiD1r6fpCgxiLHNxE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(83380400001)(7696005)(508600001)(55016003)(186003)(76236003)(6506007)(82960400001)(45080400002)(38070700005)(53546011)(76116006)(66946007)(110136005)(8676002)(8936002)(122000001)(316002)(38100700002)(2906002)(9686003)(921005)(166002)(66556008)(66476007)(64756008)(52536014)(86362001)(66446008)(5660300002)(33656002)(71200400001)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?l2dV4BIsYXI9cR7RDVI3NKDKzA504KvmNE9TXfDBmUaLNRuihD2ttVuruO4Q?= =?us-ascii?Q?udQqatkFiQ+a51BgLa/3dQqunz05+kxfUbL1gvLaagiwe14uAlVGpNGrndWy?= =?us-ascii?Q?Z0ToTy8ImL+vB92U/f7dRJrbCFTE0Jvp1chxiWJAjHY1x2t0Oi1uyApsS9zc?= =?us-ascii?Q?U4p1DemTpR5vKY2AWVBlzsP/DiSr9tBH8ul1T+d6875Tk4yx7EmYjTLSja9l?= =?us-ascii?Q?xG4/RW+/oOsFHUX1qbxxUoXQ/BLLD8DQC+jrDD0xgJxBwOPDns11bL7iWw2J?= =?us-ascii?Q?swYQFLbRkY5hb2YEIGvTd5wzLcMCmHwWwAX75VH3rkoI+SyjINjvQm4B9UUA?= =?us-ascii?Q?kjYsjXIjmbr3kjxqLabGjXfCiQeLgkXkMdGEgbw7D8FNp/9xsHt9hni+3eQf?= =?us-ascii?Q?M6NVyENkhCd0sMTWkwMuRn+OQQ398tO+zHRrq5gfgUUO6y9z/qMLs6pz3tSj?= =?us-ascii?Q?r2ZjzGwxrwTV3yCepMiICX9InqLUUKHvSHrUuJeUfX1SgoSXjM7ghpya3IBl?= =?us-ascii?Q?sIZYXkzhkCw4UH0X36gDNvqT/Ph4YQj/ZNw/q/aD1bbqL/mgRTgrsZ0KVo9Q?= =?us-ascii?Q?WiqtJ+J1p/YZQwBcgnCGZ0UjOKT21pxx4KGYy4sUNg9/D9DIXa1hGHanLWUZ?= =?us-ascii?Q?//MaBXX5J0BH5LE0DpjnV1TuSYGVnPOmkQvSmKssr4ZDbTdPfPwj9kxOvdHj?= =?us-ascii?Q?VbeNzEWLqr3dgU4x5xKLFjnZjB6f/gTHEZU2YUQFv8HaGUaWU64rVO83GT5l?= =?us-ascii?Q?P03F6cbwmw2DcB22uTtpYFvwuogj4md2y1QedwOVjjZJVE9WN1ywaA4NRM7o?= =?us-ascii?Q?QsSLkZ4T6FbAQn0KapsppedwZWsxnBNMA6OOl+991LwGpJVZ5MmmtSLD2yX4?= =?us-ascii?Q?U5jeT965gL99aA7l94+YgtqN7Tn/iezjqVr5LL90/gXDdWgUsGmm3JdZ4NJB?= =?us-ascii?Q?H0Bv22QAP703z31mhzxJxNd8sMpiKOl2lRLvl5mhc3sK9et5iV/FR5m8dhie?= =?us-ascii?Q?n1n9XQfVZeYo3oMyphOaI6pXZC1Jm35qcEq1DwwqXe4HPU0n9BhrPG2olzdW?= =?us-ascii?Q?cFZhT7ntwA3qxY9/GmvMrUGq6gwicrZaYs2olGZL/tvL3uuYK2hE9ViofCLl?= =?us-ascii?Q?vnYswTHIGgVU9AuwTNRWrh5nJn1uIPF4Wb16kSiNkFEXWtRNrKJ0dWvYh0Ho?= =?us-ascii?Q?2miGYsKwSWu4VMqyPE2rjc+hidhFVMDtaDMl78LycQE0eLelLjYtF2hbCx+7?= =?us-ascii?Q?Qj+5j3QVmc95sl0zN/ps8RhehEiNuadOJPENMIWYQ16ECN6cXAWiUCHVH7+g?= =?us-ascii?Q?ihuzr9n/dPXna2aeG2RP/WYNJ5RsKOZ0oCg1iTtMc7V5lYL4d/kCrJxWxRTV?= =?us-ascii?Q?rjg7gG73lcVql0pyU4IM1Z2lG0r0TzeNgk50ZgpBZDTdpBLIUyzVEM79r02s?= =?us-ascii?Q?Vo2Dn/MxzisbIy9Q5H0DMiJoyk6ni9E7E5cnNVLn5Kr3KWfxqsv803KHzVDu?= =?us-ascii?Q?ojwvPVyMTRXYd5qVrp16Z3Ktctj9m0B26VvfAjkpVLPjy3pCWGFyTkIb8VGS?= =?us-ascii?Q?ycdNvRb1tB9Tbbdhj6bMtiZAEjADSJxLAbtPzufdvcQ7JTkwztaqTu9pk0GQ?= =?us-ascii?Q?t1Kd3Kf52wyu77B4Kmlh7es=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9644983-e173-40ad-49bf-08d9d40959d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2022 07:18:07.5889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wsH7rZUJKt8FU/Wl+XUmdrPztvKqXdyhtQJgj2yjz0k3EFudVKZNAsFSE25G8/XLmToHHJya3Zy9ZhX8JL2Y1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4610 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB4025605CE0C14FBFE5D15AB3CA509DM6PR11MB4025namp_" --_000_DM6PR11MB4025605CE0C14FBFE5D15AB3CA509DM6PR11MB4025namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed via: PR - https://github.com/tianocore/edk2/pull/2399 Commit - https://github.com/tianocore/edk2/commit/6062002bd5a394fef46243dd8= 66860c3480d918e Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Wu, Hao A Sent: Thursday, January 6, 2022 11:21 AM To: Edwards, Craig ; Gao, Liming ; Wang, Jian J ; Ni, Ray ;= Gao, Zhichao ; devel@edk2.groups.io; Shutt, Mark Subject: Re: [edk2-devel] [Patch MBR endless loop hang with invalid LBA0 1/= 1] MdeModulePkg/PartitionDxe: Add break to handle invalid LBA0 in MBR Inline comment below: From: Edwards, Craig = > Sent: Thursday, January 6, 2022 2:53 AM To: Gao, Liming >= ; Wang, Jian J >; Wu, H= ao A >; Ni, Ray >; Gao, Zhichao >; devel@edk2.groups.io;= Shutt, Mark > Subject: [Patch MBR endless loop hang with invalid LBA0 1/1] MdeModulePkg/P= artitionDxe: Add break to handle invalid LBA0 in MBR Read Disk does a modification of ExtMbrStartingLba with the code MultU64x32 (ExtMbrStartingLba, BlockSize) Error detection to see if ExtMbrStartingLBA has a value of 0. This is invalid as LBA 0 =3D MBR. After modification, the next time ExtMbrStartingLba is in this function if ExtMbrStartingLba is set to 0 in the MBR it never passes the while/do evaluation It is multiplied by= 0 by read disk , set to 0 by an invalid MBR and goes back to evaluation This condition will also cause Ws19 and WS22 to hang, however Microsoft has developed a hotfix patch that will be released in 2022 Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Craig Edwards > Date: Wed Jan 5 12:27:46 2022 -0600 On branch graceful_handle_mbr_hang_edit1 Changes to be committed: modified: MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c --- MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c b/MdeModulePkg/= Universal/Disk/PartitionDxe/Mbr.c index 0f8dc5486521..ad18840e5efd 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c @@ -293,6 +293,12 @@ PartitionInstallMbrChildHandles ( (Mbr->Partition[0].OSIndicator =3D=3D EXTENDED_WINDOWS_PARTITION= )) { ExtMbrStartingLba =3D UNPACK_UINT32 (Mbr->Partition[0].StartingLBA= ); + // + // A value of 0 is invalid for StartingLBA + // + if (ExtMbrStartingLba =3D=3D 0) { + break; + } Seems the indent includes 2 unneeded spaces. I will help to remove them whe= n merging the patch. Reviewed-by: Hao A Wu > Will wait a couple of days before merging to see if comments from other rev= iewers. Best Regards, Hao Wu continue; } -- 2.32.0.windows.1 Craig Edwards Software Engineer Dell | GDP | PSE | COMMS | BIOS Craig_Edwards@Dell.com Internal Use - Confidential --_000_DM6PR11MB4025605CE0C14FBFE5D15AB3CA509DM6PR11MB4025namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Pushed via:

PR - https://github.com/tianocore/edk2/pull/2399

Commit - https://github.com/tianocore/edk2/commit/6062002bd5a394fef46243dd866860c348= 0d918e

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Wu, Hao A
Sent: Thursday, January 6, 2022 11:21 AM
To: Edwards, Craig <Craig.Edwards@dell.com>; Gao, Liming <g= aoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>; Ni= , Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;= devel@edk2.groups.io; Shutt, Mark <mark.shutt@dell.com>
Subject: Re: [edk2-devel] [Patch MBR endless loop hang with invalid = LBA0 1/1] MdeModulePkg/PartitionDxe: Add break to handle invalid LBA0 in MB= R

 

Inline comment below:

 

 

From: Edwards, Craig <Craig.Edwards@dell.com>
Sent: Thursday, January 6, 2022 2:53 AM
To: Gao, Liming <gaol= iming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhi= chao <zhichao.gao@intel.com= >; devel@edk2.groups.io; Shutt, Ma= rk <mark.shutt@dell.com> Subject: [Patch MBR endless loop hang with invalid LBA0 1/1] MdeModu= lePkg/PartitionDxe: Add break to handle invalid LBA0 in MBR

 

Read Disk does a modification of ExtMbrStartingLba with = the code MultU64x32

(ExtMbrStartingLba, BlockSize) Error detection to see if= ExtMbrStartingLBA

has a value of 0. This is invalid as LBA 0 =3D MBR. Afte= r modification, the

next time ExtMbrStartingLba is in this function if ExtMb= rStartingLba is set

to 0 in the MBR it never passes the while/do evaluation = It is multiplied by 0

by read disk , set to 0 by an invalid MBR and goes back = to evaluation This

condition will also cause Ws19 and WS22 to hang, however= Microsoft has

developed a hotfix patch that will be released in 2022

 

Cc: Liming Gao <gaoliming@byosoft.com.cn>

Cc: Jian J Wang <j= ian.j.wang@intel.com>

Cc: Hao A Wu <hao.a.wu@intel.com>

Cc: Ray Ni <ray.ni@inte= l.com>

Cc: Zhichao Gao <z= hichao.gao@intel.com>

 

Signed-off-by: Craig Edwards <craig.edwards@dell.com= >

 

Date:      Wed Jan 5 12:27:46 2= 022 -0600

 

On branch graceful_handle_mbr_hang_edit1

Changes to be committed:

        modified:&nbs= p;  MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c

---

MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 6 +++++= +

1 file changed, 6 insertions(+)

 

diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mb= r.c b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c

index 0f8dc5486521..ad18840e5efd 100644

--- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c

+++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c

@@ -293,6 +293,12 @@ PartitionInstallMbrChildHandles (

         &n= bsp; (Mbr->Partition[0].OSIndicator =3D=3D EXTENDED_WINDOWS_PARTITION))<= o:p>

       {=

         ExtMbrS= tartingLba =3D UNPACK_UINT32 (Mbr->Partition[0].StartingLBA);=

+          = //

+          = // A value of 0 is invalid for StartingLBA

+          = //

+          = if (ExtMbrStartingLba =3D=3D 0) {

+         &= nbsp;  break;

+          = }

 

 

Seems the indent includes 2 unneeded spaces. I will = help to remove them when merging the patch.

Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

 

Will wait a couple of days before merging to see if = comments from other reviewers.

 

Best Regards,

Hao Wu

 

 

         continu= e;

       }=

 

--

2.32.0.windows.1

 

 

 

 

 

Craig Edwards

Software Engineer

Dell | GDP | P= SE | COMMS | BIOS

 

 

 


Internal Use - Confidential

 

--_000_DM6PR11MB4025605CE0C14FBFE5D15AB3CA509DM6PR11MB4025namp_--