From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.178.1642553163520521310 for ; Tue, 18 Jan 2022 16:46:04 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=JnOlA634; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642553163; x=1674089163; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=F0E2M13/MPlhpz1ZtxwszzqE5jbZtmgZiDc1c+NvPhI=; b=JnOlA634Fx9Eh+shFRVBZHm/WJfsB2UcgGKjHtuFuVwtC17pNv9HINrF WooCvaiiAgr91lbVPkkD/T1yTivVAcMLkr6qXahAlPhVOegIlDtKn/Z0M t2WIOKx7XrG4ZhwC5aa9M352ZhbJqmjvMTso8/r89Qy2cla1HM51SjK54 eWplwtOywSJbTcL0wCllGEL5BGF7mbvURX2nnT1GYxd4VUbdrhXtVT9vd 8chSzydIo0s19ySVe1jXDF0zqxUudH2bzysC7uZm4fy9/QtaE69t4JpLG 1QUIVRsQPgTvq7Xwa9CP7ooMVpdYK3VmLfTOdmjrFkXyIpN3JZoVjal8D A==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="242512789" X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="242512789" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 16:46:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="767080707" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 18 Jan 2022 16:46:02 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 16:46:02 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 16:46:02 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 16:46:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HgP9wrZF/edpaLAGRTiR7scSd2OY5VB7eQDJQ3CC6VX0UBs1Q06RyWl7X5pTN7UFZaDYGD71qL1XlRTBWO11EQ7rzEFgqPnRyogawqwWG58YvwHCQoQ5/fLfM+j3mvTYzrZnSghIjggvanfX3KucnsmG7N+D69H2/0/oTjIdx4DNZYHsF+mIIH+4sii8xIc5KT2Byz7f41Ws9b0ARTVezQqvgGXSyMZNgFDAKhoe4krFPXW2TbXjjMVFUWDbMJaXamfQIGQmQMTgSjFjQv3kP/4j/lzdjsMNzVlrHUKyCnnqPXfjWpVCR4RLiwKmcs8HcmPY1kLoxj5376ZyU38YOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bv5dngdVyEw2PscbPdkM5B4z0HXeEQXDM07UHzLt9Oo=; b=fJVp0OS+aHWzDqAELhMdOfl1UyXgx//7BNlSkJZ1dD/H5E24t+BhVqdzDbIZLTVJ6xnrqSVIYt/lyDRZwJxHnGaY5/RwWOr7slI8chXMRFE05+zrFf4jhxtbcSMUC0pCjTbZLe/pElsdVnfhme6algdTpoS12SdhIcFEcYy+GklHaeCTPg+UMHShUcc57l0buLyR6VnPnI/dAapdGQhWzGBDZaJ7NqczVeMDhByF6BtxbrUhlGfMW8hQE8JmVJIppV1PAdMsU2JeCOaaVXDUObAyWZlcKNN7yK7DgBTQg7UtNM3k55PFO5h8BvRoAWW37xdKa3IMVJ8nkrFWsb0MrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by BL0PR11MB3092.namprd11.prod.outlook.com (2603:10b6:208:7d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Wed, 19 Jan 2022 00:46:00 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%6]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 00:45:59 +0000 From: "Wu, Hao A" To: "Rosli, Muhammad Aiman" , "devel@edk2.groups.io" , "Gao, Zhichao" , "Ni, Ray" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from SD card through UEFI payload Thread-Topic: [edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from SD card through UEFI payload Thread-Index: AQHYC6Gfwyfu0rCEMk+KApzOKRH66qxo9+pwgACMIyA= Date: Wed, 19 Jan 2022 00:45:59 +0000 Message-ID: References: <16CB1013993012B3.30851@groups.io> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42fe8989-674e-473b-1ece-08d9dae50ff6 x-ms-traffictypediagnostic: BL0PR11MB3092:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y/aW+c1mL1gvsPxDR6sKuAuIX5VFqw1zEZs4ssU5/LkJFr3et/MFZhTYUBwywVFyyf/RlARfCfGHsml/yPYioXit+qwD7tzWCEh7U/hADCK/N3KV6hCFQ6czrXfNd3FOmlIHSI0W1aGsrXOnlfCshrGzc16Qy1P6mkJ0Ja0cp3QH/wxjD7mktXqObyumL6jF6ggiJqdgpPZSbjwIrOgQWI4XR8kNhi+v/VIvXQmXmuMDm1Ea5Hl8D4LzFP5xhApocp6srBuefQ2xvcw5Q8OThpQle7fB/5coCH7IAwQYlhJCsgokTno5SG2xq2mgtCGNIV51H8D2V5HkjXFGG12ZbMQ4FD/d0n7blAxwh0H+oDKdoj+4S5OQGHU3vBsZrnpYNDF5P4aMkKf7v/iGaq/58P0JJHqKc+jYH/1bhdDve2+3BkEh2Wi+X4SJjJkWePcK+OcZlbzGXLq65i+MNSoicpxOvPZV+Gbb9cFYFhvAC4f8hFkyc5aK/XPjbjzgm44jpIw6kkDrMKB1yBfD3HNWBoYgXR0x0/QlcL4cF3olXukiqBiN4BeYsVVz8AiOso4vPq5wvyFwJ9xQ+ukVIpp1ygGJA4b2TIivo6xQhT+dHW5oyuxyaeLBoQwIu1GCVmovLBVz4CC9z82c6y28FG4erO9CW7TcWeWzm4XMUM/Im7JeAz/wvCJK5EGBhmcjAjbutd3ViEHlb4U86Q0PXc2mLa48jvxN7tp4y6dwoEJwiK+Gm24ONsDYzsNu8zchIsm4E8xUM3dON2zqBAqmF1nrFws8ZLdauLg6TFExCADSsZSXPLgZPn+nCjgK/iNPlht6zRxFtzE1eXah31mDxVFKkA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(66446008)(2906002)(9686003)(66556008)(66946007)(33656002)(186003)(6636002)(110136005)(64756008)(52536014)(316002)(71200400001)(8936002)(8676002)(5660300002)(508600001)(122000001)(26005)(38100700002)(7696005)(76116006)(6506007)(966005)(86362001)(82960400001)(38070700005)(83380400001)(53546011)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h+Y1HU3yl/YK2rmqQMwL2p7jNmo6lwNQyZcOlST/0dpozZWqnA6zZwDpTtSF?= =?us-ascii?Q?zcE+luzn39+pEiXeueS6shGR3vU713s1VK2cwoZmm1ag5OSU2ZCmAXX2wWOa?= =?us-ascii?Q?9IFMFesZ7JTEUYTzNDIoaFh5hSpLd86/iP0kZw1EL/iJGomVJlYUnXi2hyAj?= =?us-ascii?Q?KkOIL3mOXVKHUZJdbX/xFlTeJt4qSFF7OccxgeIvLE0N2YCybSu9gGtFvnxp?= =?us-ascii?Q?CEZf1HokFRnLhFroRAgBApEwxWMhTS1+GtMg5Jvaf8twNNwkduav0VCYdU4d?= =?us-ascii?Q?nmscPr98ElMBF5lq53FWyoNnkyAa/eQB8b97xn40vXnu7Jhq+KxThC7Bc0x4?= =?us-ascii?Q?iBUilRHE8E3TLRkj3+R4BaZFkrbjjf3n+4m6SYpWWTHYfP8ZD98xH4amtjIV?= =?us-ascii?Q?5IF4rRogB3w99J/7T1PQKutUI9wnqYZsxxfdzjNVMZJ6wi29sfBYrG56XPbF?= =?us-ascii?Q?+gIjfMuarq0ruS0HvDiQl7c3BYDiq3jIATFwGnYuEDDpTr0FYTGKv3wx5sX4?= =?us-ascii?Q?WzCfkutBBnKYUgXFlpRBoaIzhS61HRhqj2/za6M8Y4GzPOIvxFa2ThA2MuBc?= =?us-ascii?Q?UEQyYIltJ1xcZ3fAkIXiN+IkqsQnksQtaPfA6cBt7U2QIt0XdZrPPY98O3+c?= =?us-ascii?Q?pJDii7BZ1ftAlAJ2CJTXjnTppf+lB6CauppJ+K0xR0CurorOCcGLHU0gAKva?= =?us-ascii?Q?lEwyvoVLNj8sUy+uWwMK1yFmNC+ztyhrE3btW+88epw/a6h2gG9oBaglck8v?= =?us-ascii?Q?wV8zPe2hgJgJTRAq8JSF+3hxXlfB/4GHDikk0rMUmSoDupieZpwWxY/31gKF?= =?us-ascii?Q?fRfbu3BH+WJw9YtKl1nFP4p6quB3AsoF0L10ovqGFixSIwTS+Z0ZIjC1+lK8?= =?us-ascii?Q?WTpUMl6KtqEtWAqCo6b8oCQcPnYtRRhl9W1Fa3cHgVPCXyr0ra2aRyK+g3re?= =?us-ascii?Q?r1x9/YwYGMsqX7cDaPWa5QMW8iLKoumborav9k7b6v9VShuF823Uj21jVVfg?= =?us-ascii?Q?23z28ncayDhIunpPZoLIFLP6JgF8rGxUfXyRM7ZEIJTlpsI6hzh0iUhIwxx4?= =?us-ascii?Q?naA+5HMTaY///UBN5Kuqe8PW0wuyXiJbjNG+Pz4IzA93FNCKiajohkiijurl?= =?us-ascii?Q?kmLoeSCBpJhEAS5F7HTRPA57vDmadqp1Z2sUxO7JOENWZGiRi9ACnkOezWme?= =?us-ascii?Q?S0cB7YKO+7/EhIMNe9jxiLrQ4DKExeSS/lbNMzgFDBT4Md8SCR6sqyCVeXyz?= =?us-ascii?Q?y1WM0yEsIgaM7njVFTqQ1wW0X4TCvFgkQacrPFCrO+vcyZN15cmai4kpRxYB?= =?us-ascii?Q?cAnGwNjauszzFCxkwEIUyUn33cgUSKVTEOSnKm0L/9AW34CogxQNPbERE7gJ?= =?us-ascii?Q?/uWDhQCfFYNCOBst4Ncl1LQJy+ZVuRVwLa1DEAlSCBvmUnMa186p55vbcX4k?= =?us-ascii?Q?cD8giyMPmd3ig0nsE5mbGr30xl2biOP871g98A5AslsISL7jHx74AnulZ3oQ?= =?us-ascii?Q?l9imshU8Qw8K3XwdiTN4vIc4q68LlAUGnWmQzNzm/aqgQj8TfbS9iG+KsnRH?= =?us-ascii?Q?5oq8nk/lZo3d4EUmZmqETSILMAqbMNiFeKfeyri69WX/r2pmACTLipFxO+B6?= =?us-ascii?Q?o0zsVt8wpMF2pfBcGDm8N3Q=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42fe8989-674e-473b-1ece-08d9dae50ff6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2022 00:45:59.8695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MhnpWG6OLmSWigffmTol2lbzh4+tzU0GmNvlTXq7dcpY/WbR0PwBDtwTwKeM5iM71cDvPpOWAQigZj+uD8TJ5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3092 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Aiman Rosli, I have provided my feedbacks by replying your patch mail. Please help to check if you received the mail. Or you can check the feedbacks at: https://edk2.groups.io/g/devel/message/8= 5764 Best Regards, Hao Wu > -----Original Message----- > From: Rosli, Muhammad Aiman > Sent: Wednesday, January 19, 2022 12:26 AM > To: devel@edk2.groups.io; Wu, Hao A ; Gao, Zhichao > ; Ni, Ray ; Wang, Jian J > > Subject: RE: [edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from > SD card through UEFI payload >=20 > Hi all, >=20 > Please review my patch, if there is no issue, can help to add push label. >=20 > Thank you. >=20 > Regards, > Aiman Rosli >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Aiman > Rosli > Sent: Monday, 17 January, 2022 8:56 PM > To: devel@edk2.groups.io > Cc: Rosli, Muhammad Aiman > Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from SD > card through UEFI payload >=20 > This changes is by adding 50ms delay during voltage switching from 3.3V t= o > 1.8V, plus adding a goto Voltage33Retry for 3.3V checking and retrying. >=20 > Signed-off-by: Aiman Rosli > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 23 > ++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > index 662f9f483c..527fe7dc20 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > @@ -1213,9 +1213,14 @@ SdCardIdentification ( > UINT32 PresentState; > UINT8 HostCtrl2; > UINTN Retry; > + BOOLEAN ForceVoltage33; > + > + ForceVoltage33 =3D FALSE; >=20 > PciIo =3D Private->PciIo; > PassThru =3D &Private->PassThru; > + > +Voltage33Retry: > // > // 1. Send Cmd0 to the device > // > @@ -1294,6 +1299,14 @@ SdCardIdentification ( > return EFI_UNSUPPORTED; > } >=20 > + // > + // 1.8V had failed in the previous run, forcing a retry with 3.3V > + instead // if (ForceVoltage33 =3D=3D TRUE) { > + S18r =3D FALSE; > + ForceVoltage33 =3D FALSE; > + } > + > // > // 5. Repeatly send Acmd41 with supply voltage window to the device. > // Note here we only support the cards complied with SD physical > @@ -1362,13 +1375,17 @@ SdCardIdentification ( > goto Error; > } >=20 > - gBS->Stall (1000); > + // Workaround to add a delay of 50 ms in order for clock to stabil= ize > before turning on the SD card again. > + gBS->Stall (50000); >=20 > SdMmcHcRwMmio (PciIo, Slot, SD_MMC_HC_PRESENT_STATE, TRUE, > sizeof (PresentState), &PresentState); > if (((PresentState >> 20) & 0xF) !=3D 0xF) { > DEBUG ((DEBUG_ERROR, "SdCardIdentification: SwitchVoltage fails = with > PresentState =3D 0x%x, It should be 0xF\n", PresentState)); > - Status =3D EFI_DEVICE_ERROR; > - goto Error; > + Status =3D SdMmcHcReset (Private, Slot); > + Status =3D SdMmcHcInitHost (Private, Slot); > + ForceVoltage33 =3D TRUE; > + DEBUG ((DEBUG_ERROR, "SdCardIdentification: Switching to 1.8V ha= d > failed in the previous run, forcing a retry with 3.3V instead\n")); > + goto Voltage33Retry; > } > } >=20 > -- > 2.34.1.windows.1 >=20 >=20 >=20 >=20 >=20