From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.43225.1685336008132968665 for ; Sun, 28 May 2023 21:53:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mfGcujad; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685336008; x=1716872008; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=naNIoW2pDs4NjEGr6EsrPgIMssvT/UhVkHj+AJZbz+I=; b=mfGcujadOT1xSuM6BZ1iyk4qjQ3TobYV0DxUUMQ6VpSc92p+w7AxWtGV 2P9BJzgshLWQ1IXRL/29cRdkrcYfYmkYdr+KunujGOmv78TrHuvjKz17y CqxkScHFuubTBIkqhELJfmqbP5+tRWtdNbJJOpzoOKpvORxuDL4sClsEK 99wyGxrhFX9MvmQqCj7wVQgqSs9Wm5pv/UokAmXuBpmpw5jQCf9VqUJfm ZX6zomrmZoEPKVllyZazgn8NbPM0hoXtr6+CE0hXl7xtEmlI6FKDT6VyJ QO9H0B3WlCgNXU981nlN05r3shmd3dWccmZLE7uF1SKnEbeRYCsEdYur6 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="382870694" X-IronPort-AV: E=Sophos;i="6.00,200,1681196400"; d="scan'208";a="382870694" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2023 21:53:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10724"; a="775790498" X-IronPort-AV: E=Sophos;i="6.00,200,1681196400"; d="scan'208";a="775790498" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 28 May 2023 21:53:24 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 28 May 2023 21:53:21 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 28 May 2023 21:53:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 28 May 2023 21:53:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 28 May 2023 21:53:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0i3mtGQ25x7XwcF00T2QauXZjYh2ZihAbJpncJyQBleHHms6TjbQ1e1A2lObvtzw1X/8WHQiQoJ8lvgoV/ubC+SuDbxvnSSdsDslElI9c5+ueyUem6IhXdgvXEvxj87wvIbxpqb9RYFXo6bxpzijokUyA0rpbiuEozh+S6X7bVRctmJo0z7/dtam1+3r2KnsmT2JTeoivhgX5glcuxdLkfvK68Mf2IpC35B4g9WgA7bXzx4HYYXMpZczDkbGibxPGlVzvhoPVo7rWRqB2GVGDq6SM9xQbjgujiGaIpi5Femm5Tl2qZiw3S2+2UkPBQL957gQGeJTc5iPTgOck/xVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UCDltFaFFusbOAHqeJ72xq0qbHBT/O9CC1c1WCUJZhc=; b=QTRJIsiWtxNBfsMnCK3e638ONsoPbXVBwxgLxNqyrt0dPe+Tk+KLVl0r8ZYbvQZQkre2/JN+fFrS/+pUpdnqk/mtAcq941xOe3nhkJenBGFVJGXNp0GCd9V0Ru+Okv0t1yUP1bKPHyEPaDzn34eL/ir9Mycr/0QyGW9++oM8OFS3bhBDSHzMvmxYfBV+X1oPMbw+iEjdWYPUB3Lb7c42HqGA+4M1psD7Fwe6JGlcjGu680rEc1AHBu6j38elAqFAv79SIngrNTw7n8neWSTHuIq2wTnvdZWavX6F9nsbBD4dqQ3UA8RKSp5iU48x4SluYORB71zuseNHn7GA0K6R6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SA2PR11MB5068.namprd11.prod.outlook.com (2603:10b6:806:116::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.21; Mon, 29 May 2023 04:53:18 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebdd:c7e9:13b2:437b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebdd:c7e9:13b2:437b%7]) with mapi id 15.20.6433.022; Mon, 29 May 2023 04:53:18 +0000 From: "Wu, Hao A" To: Giri Mudusuru CC: "devel@edk2.groups.io" , "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , Andrew Fish Subject: Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Thread-Topic: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Thread-Index: AQHZhLfuIP/BGWMyN0mYxc7eOskLV69d41mQgADmKwCAEf/eIA== Date: Mon, 29 May 2023 04:53:18 +0000 Message-ID: References: <7ba00d73bd53c401b9fcd6fd4a3a79f9e43d9662.1683885276.git.girim@apple.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|SA2PR11MB5068:EE_ x-ms-office365-filtering-correlation-id: 63bf823c-c742-4666-5d86-08db60009ede x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kAIaaCh3g/L6K9WAUH69v45apJrmrlWLJ+0PzzwPBZgBcz1OLpl9EaBBJYUkus7FDpMKm89zhaXQWwJtQHJqQB06MKZm47+yp4laOurMnvF8bB5UH+iM6NsiSt/X8ph8V+CvEUvMKdNPJZEjydClDs5WBRKnXgOZD9EPuT3zTnHETa0qNRlcB7LxxJsdFzNhK/9+qLX9WExyHeXZn/dePcHjXBuDCAMa9O1kcsMFII8rdgHuyKxscXWhKjsInBoIE4DqCnX8o+KCD1vqiabsdaVR3RUquuaMgTdnNsGazQ+dY9j69pYnGNyHjz0VMIzzmcBv1nK87zBJ/itkrJipOfi+6tLy+9PxASGJ/vZyaFe9eF/1BNlw88wobVfY/MIzOd0ro1gZhImndSQJSlF0XJAFnrTWaiePYWioLaPd8bRUK8Hu8dxGKVEZp0dt+Ih5JAozPt0UOWkD+47ECJH2MsIow9oGnRbjD+IQt/zBW5KZXKwU7iGaaFXbQH4gpXdFVMAAmVmlnc1XAEElIEeCuw5m0LaPI8bxm1s/Z9QVEN5weJOsgKzA9MSt+aXbPL3c165GqGYVY57U+NgobQ5q6gbp9AY0dWdlhG/lkL39YrRy7BuA7g758JGD9xI/FiVJXuljvXNA58xJF64psd8S+A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(39860400002)(396003)(346002)(366004)(376002)(136003)(451199021)(4326008)(33656002)(86362001)(55016003)(186003)(53546011)(8936002)(9686003)(8676002)(26005)(83380400001)(6506007)(41300700001)(52536014)(5660300002)(54906003)(76116006)(478600001)(6916009)(66946007)(66476007)(66556008)(64756008)(966005)(66446008)(316002)(71200400001)(82960400001)(122000001)(38100700002)(38070700005)(7696005)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mBTwNePMtHFV2hIYrmcl5TcOZSxGrePsw1bPx+wMe0SIQwO2ZlixzEI/4/UF?= =?us-ascii?Q?YLRON3B9awZePUEZ+APUY1dZlhD9RZF1FeqspXREf3Jo0ta0cQYGN8eH8t6j?= =?us-ascii?Q?nuypfGucnQ9gxNyThS6PqNFB3NUVuS82+Xuu+fM5cIH46lYYRsFa0V98fSOq?= =?us-ascii?Q?Re9EuxbIjJPlXapMnH1eKYJnt/Czp04NkfiBBRzI9RCS1W55gA36GCi+/17K?= =?us-ascii?Q?H4Kr5l2wr4+jEcg7/MIradBONTeAFOLmQaMnNcwnZM3x1PjKSH5jKtICIHxD?= =?us-ascii?Q?qIKmTKjqRydkpZniZyK78yZbwNLNZrgO97mWJK043dNhSyQJ3qe6DqvCwLUe?= =?us-ascii?Q?+kV8/jfKHpwUM1wa63LuCCBfDSJGipYa1/Nu73tt9C9Ac8mT/guGUT5sSmWm?= =?us-ascii?Q?2JbfywPB1wW/KGLwllRx7Kxb3XvzvvJof4Z2QISxWFk8X9soPnJEu6wXldqE?= =?us-ascii?Q?0LuRxOpKjP3y6qz6jvaZzJrQoWnjZIwC3a4Pl3KD2sKeg1HuMoA3pWdz2+/k?= =?us-ascii?Q?c5BK6fHjDdfH9tokIby4+6z+dXS62AfhLRmEo1cwLvl7Q1UP1toV/UgDkTuu?= =?us-ascii?Q?AWPRFkGzEWjN4TOcbO6k8n/L3jInV6pnr4R5bC13D8+iTo9LvvpX58kquWkr?= =?us-ascii?Q?zzZSdOjKfphNcLTmbtayvmS3OzNgJmge8ExXrQtIGSaE7DtjLgcFrhOsrkcP?= =?us-ascii?Q?+u5r0tD3jTE3nc10S2LLKd8Ay5mSNpI6v7UbFFR6oAWSzCfGTbM/LfZ584pF?= =?us-ascii?Q?qQdDnptIS6Olo/IJgnwCXWZHE7CrXwJWl+CBC0kqTDK5Pyyzo3/sQUm96AOC?= =?us-ascii?Q?vth19QikI6R6NDKnCZ8dm/mPqIjuh+8gzzJGhTolm1olTdXj69UP6AFxFi8a?= =?us-ascii?Q?8sZgIGQJ12PeYQi4VydMVWhGHDM+4pocU1Ro/2ms/M5xOwZaphZ8bqptmUuV?= =?us-ascii?Q?x/d2CGxlcxElkJ6bNhlWdSEvS0C/JfePODMm09F9borf47byFeYTwh32krl7?= =?us-ascii?Q?QEHWdGPx4dLzcOEA0A+Nwp6E/NKPdmpDIkKU2xL3Mv9tITXuJoTssB3+bbAF?= =?us-ascii?Q?XUGN98CtSLEG80UOXQGVagBTAd91MnH6Xlza/6Hn6d9ssOXaCKPN79jMFj+W?= =?us-ascii?Q?g6iSeop6pD+5DIMfIheZtGO2lefPW9z1/D1k5vGS3beNXywN8sWzT/1FCT75?= =?us-ascii?Q?fQ8UkzB02wz2XT9m/CK3jUZcBT+kGoNGD8dhYM4PRqEF9iAZgq+tKyxUwR/H?= =?us-ascii?Q?sTOFGVRGxP5hG96Cu3mSFg1hr5na99Qq2bP+/enjFpZWn6Mbtxklg5NiA7Tx?= =?us-ascii?Q?TmN3DI4p8AnX7bjij4HkkR031mPOCLXVMV8iKbXUzulxg0tXhci3QWd0QdDC?= =?us-ascii?Q?8hd2kdXNq4O9Bnpzvpqm8qs0rC/OUDHL/pq/n4OEA25CZd2nUeKn+Ot3AmET?= =?us-ascii?Q?yN/ta2fR1olDQfD3mSIvp4evLaCPepOvoExLKMepyj3sJTk/LAtxldEWqI8z?= =?us-ascii?Q?u3t2XIxWN/IMktgzsy2Z6BPoZkR8cok6SeRast+/HNYY72solazoERwhuND/?= =?us-ascii?Q?H9uNekcIv21Rv8Nd0P/8uYcKRvJGYH81/Ls0aB9+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63bf823c-c742-4666-5d86-08db60009ede X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2023 04:53:18.4648 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q7DaS3ZhgNHtIl1SwqmL4i5e0XU7i6fnBkQkqV8iofHVZy8cT20A1ppEBBDEVfNyWo+jWse7Sfy5miNJD9EY5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5068 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Merged via: PR - https://github.com/tianocore/edk2/pull/4439 Commit - https://github.com/tianocore/edk2/commit/e1f5c6249af08c1df2c6257e4= bb6abbf6134318c Best Regards, Hao Wu > -----Original Message----- > From: Giri Mudusuru > Sent: Thursday, May 18, 2023 2:01 AM > To: Wu, Hao A > Cc: devel@edk2.groups.io; Ni, Ray ; Wang, Jian J > ; Gao, Liming ; > Andrew Fish ; Giri Mudusuru > Subject: Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability > debug print is incorrect >=20 > > Please help to use %p for printing pointers. > Thanks for approvals. To clarify the value is 64-bit capability register = value. >=20 > Thanks, > -Giri >=20 > > On May 17, 2023, at 9:49 AM, Wu, Hao A wrote: > > > > Thanks for the patch, inline comment below: > > > > > >> -----Original Message----- > >> From: Giri Mudusuru > >> Sent: Friday, May 12, 2023 5:55 PM > >> To: devel@edk2.groups.io > >> Cc: Giri Mudusuru ; Wu, Hao A > ; > >> Ni, Ray ; Wang, Jian J ; > >> Gao, Liming ; Andrew Fish > > >> Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability > debug > >> print is incorrect > >> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4394 > >> > >> Fix DumpCapabilityReg() debug log to print 64 bit capability instead > >> of 32 bit pointer > >> > >> Cc: Hao A Wu > >> Cc: Ray Ni > >> Cc: Jian J Wang > >> Cc: Liming Gao > >> Cc: Andrew Fish > >> Signed-off-by: Giri Mudusuru > >> --- > >> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> index aab6815328..2e7497a89d 100644 > >> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > >> @@ -30,7 +30,7 @@ DumpCapabilityReg ( > >> // > >> > >> // Dump Capability Data > >> > >> // > >> > >> - DEBUG ((DEBUG_INFO, " =3D=3D Slot [%d] Capability is 0x%x =3D=3D\n"= , Slot, > >> Capability)); > >> > >> + DEBUG ((DEBUG_INFO, " =3D=3D Slot [%d] Capability is 0x%llx =3D=3D\= n", > >> + Slot, > >> *(UINT64 *)Capability)); > > > > > > Please help to use %p for printing pointers. > > > > Best Regards, > > Hao Wu > > > > > >> > >> DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- > >>> TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); > >> > >> DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- > >>> BaseClkFreq)); > >> > >> DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << > >> Capability->MaxBlkLen))); > >> > >> -- > >> 2.39.2 (Apple Git-144) > >