From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D098374003E for ; Wed, 2 Aug 2023 03:17:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NzPfzmaR/P1V8ehgb+VwZreSBpYA2PG5jpNUypvewuk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690946223; v=1; b=KDtSp5biksJAy+9EiBdor9j7rCs/vRamm1PWS1zXcJXZvJQvpaUH9NtiKHE0oyeogzHibV69 hJJvKYHmtUnEjwFai2h9ehRRzTwDWDLW/mAN4xCKjLVO6Re7bkliEEdE4Ef75XEEUCGj7bcDk/H 6fDp6jSj2yXZlgWZqj9rXLio= X-Received: by 127.0.0.2 with SMTP id 1AszYY7687511xdRAyDB7sO4; Tue, 01 Aug 2023 20:17:03 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.6687.1690946222835977251 for ; Tue, 01 Aug 2023 20:17:03 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="455835395" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="455835395" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 20:17:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="1059654461" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="1059654461" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 01 Aug 2023 20:17:01 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 20:17:01 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 20:16:58 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 20:16:58 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 20:16:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTQZo8DZZWwFTBplQ6eLnubosGq3C7/h8Vkkst50HYUio8RQfhHTYa7RqrJpsV/LbeGaCOspdPen9pqFIylgTV1zo7XqqKnpPjCaauaouOE8cZqVThNYlRe2GrnHlNK/yBU/lKOIr6dlCfmSulwsYYdsFmygDAZDGuO26Oy2wz1C+WFQur88DKYwzePVfnHxWa5m50DQlruOqOjUtj1Vehas2Id3JlXV+kr5Ha+DfyDoY/ZocJyeq54Q3NjeQNX5Sp9AlNX5pFaNoNYo4OVuFOX4bkSFiBm7MoLB82iNgbY/Kfxr34CNIMxZ0rIO6p7L7UNX0+2xYMzD8jSmwEOCYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ETMrqF2n9yupzcLP64hlw3HUDqCpPP+eoS1QucW+DCE=; b=J1N02lEWq0EGzPcnEZtTkT87HOMi3dF9Vq5QDtCAgrGwH2WOJKuLIhgYHa/WxrOjP5h8QNaq2F8MSU+fuRJ+7SfBYnazaNb+u1lWswZIDO4QHQ4RfLCq1m3YzIvdcTeWqSyj5AaRJr2Psb6e+2RvEyirgx6qIjBfQTZSTwdDyvea/PTepNkekDI6l6YbVbCqAKvvmF7qYijd64gQCQXT8iwIiR3J63eu+PDM+xF8RT1Dah8++L2feTzoLl9St8/JLUlcjbkEUqCdAyA/acJl6rosHHLZSV/fxaSAYVJBOTMBHnx4H6L9XcbfKlB1qjhjXXPysm9fxcikUWIOlbpv0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH7PR11MB7595.namprd11.prod.outlook.com (2603:10b6:510:27a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.45; Wed, 2 Aug 2023 03:16:55 +0000 X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebe2:341b:4ed7:d19b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebe2:341b:4ed7:d19b%6]) with mapi id 15.20.6631.045; Wed, 2 Aug 2023 03:16:55 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "rsingh@ventanamicro.com" Subject: Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix Thread-Topic: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix Thread-Index: AQHZuVaMRpT8nn50QUO3q22Sm5Vny6/WbKMA Date: Wed, 2 Aug 2023 03:16:55 +0000 Message-ID: References: <20230717042444.2242552-1-rsingh@ventanamicro.com> In-Reply-To: <20230717042444.2242552-1-rsingh@ventanamicro.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH7PR11MB7595:EE_ x-ms-office365-filtering-correlation-id: aed4320d-2e96-4957-5939-08db9306ecbc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: m0UhmzWsKc7kdu0g0/H+AbKX8HRnyo/xHE4bSynaCNAoDRKF/nJRSa2r4GBhKL4R4GLmcvFVJ1DQekt1fwClLJqiC1VflVAUHQGky3pagI4HHYAuuqmjngrRwpM7rla52fjjSarpjNQSdLeWrCy0Ckk5y0tOJBf/htHRA2r9DVjPV9KyE+xzGxnhIkR+wFRjO54/GEL6EhMvPe1Zp57HQaWzXnIKs68PcwsOqcwxc7a6dXCM/cAMi8aI0osnxLIzPIwIYOs8KgBgfTSK4Q9oceMV88mGaLcNUPhk2YsnqRuupsHf4J92HyWgjP/Jfmew7G9aAI4Tlxmxz0kPAAJxcZyeKggg2YKa4mtxqXoAif0DgcqsWSrJd+erDqkz4IrdxqQ9LHypOM+W1zpDFJBgqZ30N4Ego7rSC5PflOYzZ3sTm0Ry1nOHD2/DkXiDXLQfnebWR/gOKp9ho2+3u0y3II/J7WoeXiiOUr4eLkfR/s8vack9fkjr6MUFDOkHCxUEvodeb70hUg2KOz8hWOqf4EI/ZmtTqLLyMd01ZV2lIczk0gzLWWbaTGxFYU/gfVvxsx1iMCs1pZBqgTtqKpCw0j5FzfX8cZr3XT+7b3LJIczZeOJ8ww9HnCj2vdRCuiQtFYDRPvLSH419Tm5NqP81pA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GjySS0wzYer8JhEAliFACtI13VPWYuPejWAXpoxIZKinXYOQzTalkPtnIHMe?= =?us-ascii?Q?c0c/vur+PE7UlDUxGW+Z24KlpW8YpAQmLtU51TbX8DZTfetMxo3dqEedtB9s?= =?us-ascii?Q?EUhJMDI5mJzLNNLjI0+PpOU0Z5shD/UQrc9758hKruYRZcNXqaedsmHtZ2TZ?= =?us-ascii?Q?6PdNkbMT9DzLkyYfDDtTcVlL9zDlXiMmuPg/rmjSpOItMjfPqCR0bAxSkSD+?= =?us-ascii?Q?d2G1EOTIWF+YmPMxS3W6OdjnfpdHa0BnybUpmWxLLbWJilKah1IVY3HPPgik?= =?us-ascii?Q?i1AwkgGsFi9vn5hlWrs+zAjfeAueB9wcfk2+ira4mSuYqHVz9rFN80JVQmNl?= =?us-ascii?Q?Kmo61FONIAfwgC861qGfvDsqLZeP791e6iaYMqsovIK7uU4NGPZr4uNXZr30?= =?us-ascii?Q?pl7HR0yUFWSMcejfpyZgZmNO1TfnMfW2BytxBDh4i7NN5pWDfvLnpFjLRytn?= =?us-ascii?Q?6aPE9d9Z4PC2+TjexIpVhBQ3S+IZOlAErAQFhkSxnsUiFZamP2Q0nkp6wKzi?= =?us-ascii?Q?DU4CeCh3Ejr607K7soDV/avS4AAP+f5bjKVLNR83QSx64IiSgnz648AiJ8zH?= =?us-ascii?Q?9gPnmFwiJ4GIMtN6MKB44n/I42wYsdQvD/zGK+/w90LXxjNPDuW7KX2/kQ7b?= =?us-ascii?Q?Yma1FZ7K5N6g3mDYtjCXmL5MhWNbY/aeGL5U9sEq+N6ri+//J4vL7/uISWRy?= =?us-ascii?Q?apSOnp7ntxYISD60ac4jKfT5EcOpJFXxZowzzfOm8T9keaPNr2howGxYjWsv?= =?us-ascii?Q?y/Yww62i6L0Vg4h82k3dMRUD+SSdx8XlwV7D5rB9q1xmvYkZ/MBV3bmyZUWV?= =?us-ascii?Q?1ai3auEMP+l8DfeQ4bIUmJ6PxBAP3FF1WXbAqMaWqjz0B06iZOfUjP8nJ7Oj?= =?us-ascii?Q?1VrWxuqSAEGGqcJgGEbqhbA39tPjMbzigg6fzINj6AlutymGxtl22R2+SQnk?= =?us-ascii?Q?hRlOAhgJqCO91Jts7au5JtWE7hXZoMr8kSc0beZDmMMHhkx0KbAyLj+PUcQL?= =?us-ascii?Q?7e6RxgFlB9NPzglxZc06r/BPyQcDQrxNbMjVt83JTuFonG7t+YC2eoyedHz2?= =?us-ascii?Q?rd0/oJUAI10AeX4bHvQuxjo0iIkb85eFnJxbFML1eNB1mu9ijm7isLEDEFQt?= =?us-ascii?Q?bAyWG8VbLkqsRfuF0gtNFhNnXLfytj2FXXIjYvjGZniulZHkxPEOtilaRguV?= =?us-ascii?Q?ER49OU5nwbFgsFEZDYiXYHH98LICvRdnrgJDT8RolyC/JrGTP3UUx7ZPhDkK?= =?us-ascii?Q?LtZxPsKvP58ddsO0Bc0YrGDAF3YBbItnBmA2BR945NYTgGxI9Iw/WkAvyAFq?= =?us-ascii?Q?FW/XrStRz2OEPevxJ+D6ufVz8Tbq4NS5V/GvyWTD2NtKKn7SbVXyXnJWVmrE?= =?us-ascii?Q?eM83NPNqdOLebEeWVYrza1rJCz0VT2vF7/+DbGL9XZMgdgf2ULKzml0ZM7xc?= =?us-ascii?Q?F9Lz0Bkqi4cW3zH72HzlGZwuGju20Zp4V5m8LY+xmsr80sGYSUv7g8Y9vgrH?= =?us-ascii?Q?FZ4iA1usEUfmjqoW6hUZ3SEeZuOl/5nJVgQHjzrXsx1XN+ttfkOsSAvJ7cWr?= =?us-ascii?Q?roUxZmVBh1xUguK5DLXUO5Wo360aoOxotNZF4O+F?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aed4320d-2e96-4957-5939-08db9306ecbc X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2023 03:16:55.3624 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VUfz2qMDYOw2BNaxi8Vp/nWF2uaUEHCwapCin4y6kzi0t/bJVXUEMOxbXuNPIJ7K7yVhThS/+78KitlxlQfpSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7595 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Dy8pPw7f81T35Ywwbibz3dW2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KDtSp5bi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Series pushed via: PR - https://github.com/tianocore/edk2/pull/4707 Commits: https://github.com/tianocore/edk2/commit/c7c1170a4568ecc0f63e14ca6a844d40f4= 7519a9 https://github.com/tianocore/edk2/commit/d11968fcc56cbbffef7d906048b00faea9= 415447 Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ranbir > Singh > Sent: Monday, July 17, 2023 12:25 PM > To: devel@edk2.groups.io; rsingh@ventanamicro.com > Subject: [edk2-devel] [PATCH v4 0/2] > MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix >=20 > v3 -> v4: > - [Patch 2] Further update as per review comments > - Status storage removal at call point > - Error checks moved inside SetDriveParameters function >=20 > v2 -> v3: > - [Patch 2] Update as per review comments >=20 > v1 -> v2: > - Retain outer cast > - Add error check instead of Status storage removal >=20 > Ranbir Singh (2): > MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix SIGN_EXTENSION Coverity > issue > MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity > issue >=20 > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.c | 2 +- > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 12 > ++++++++++-- > 2 files changed, 11 insertions(+), 3 deletions(-) >=20 > -- > 2.34.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107442): https://edk2.groups.io/g/devel/message/107442 Mute This Topic: https://groups.io/mt/100212103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-