From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.583.1686021252729617963 for ; Mon, 05 Jun 2023 20:14:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=lm0zlZi2; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686021252; x=1717557252; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=aZ7NTMZaN4A9tdQ3c993nMflQOV6ZBOCMMy/WvPJvLM=; b=lm0zlZi2Y/SfadoWZC9ApyRrJ5m5z+rStasTgIwioSjxThjbZMOtu1gV hagYktPZlBfEc0P1esEjipBiMzX+rliB61AhUQGZ2WVk4/MxmfJ7oB12t rrshECUzL7yE4xJDlUElC61az4hPbfeFcu+wn/oDjOPv1YfFa6OtH2bBV 9QqYZBWo14DRn4S/pHHv2r1lu7ihaVREBRN9bxzqfB/+iDQSg0bspN8M8 Zd914C9qOaFMgLIwmYlX/SgF6ZAyhnahsanrDudJkCpPLbcgtnTNA2qUJ XAf8BpiZWLm9MBxPOPotj59XrfLApprE0Mq73J0n048fP6MwuUzOos5Cb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="420097059" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="420097059" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 20:14:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="883163334" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="883163334" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 05 Jun 2023 20:14:12 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 5 Jun 2023 20:14:11 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 20:14:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 5 Jun 2023 20:14:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0CJ8UWlYzAH7osWAWkU4a9cH0cFP1QJQOsVgRk+MMJORQ3asSF0cgl8oS5/5tJBV6SnubIFZGCkWX8JQe3MQ9do7Xao2o4acgKbYLwgaQaE3MbiK4ZCWDgd/9Lg/7K/CP2aJUa3pjN13anhk6/pjHga5tY9cwP3577jv6IA+DCtk9rg2mJPnfNzqbjY/W1ICAEsqrPAgZFkk1zU+nr8eWIDoWMTfhhZ0w5UgYw1xaA4WpjUan17kYTFgse5/rfGMGiq6ZwcpzYt+xmWRPMtvwUUgM4Oj+r4UvOphAEoPqr55/jwya+NlIpNI8zgdU8eSLv8AfLW7i0bq7Dema8Xrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CFtFXcPhUae0ij0ChXKM/O/NTj0ca9k+PpOdwCNnzcw=; b=mPMHrRDeDLOGLIrW1m1e4tlnc/EGz3jfMer0oJfPc1wIlSKzR9fMZXNvo57TYZogtWpHynEYFnGKvYtx1h33C67Y5fp8uSITvDMMxdkdV2dja/53o5Jb0ta610/gEDDHB3Lb7fxNbxNQhKywtt0LKf2N18LOSE9YkC56pHmaXMIrJ5p8n+mBK90nWfBs7IehsfDtHd34FmVsXfw2vHXbjvJT0HuWkT6QJ+PZEpL3SpSsBD4zzIeVrJe1QicpQa+3BxDXABngLSJFCW9Ttu7qUK0j9Lm44uoSRBfGTR4Oa4Sb+t8OiboClIcMiCm3UXWEn8SLBf7+dVq++BzV5Zr/nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH8PR11MB8287.namprd11.prod.outlook.com (2603:10b6:510:1c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 6 Jun 2023 03:14:07 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 03:14:07 +0000 From: "Wu, Hao A" To: "brit.chesley@amd.com" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" Subject: Re: [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build Descriptor table after resetting port Thread-Topic: [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build Descriptor table after resetting port Thread-Index: AQHZiEQjxTWWxls5lk6nrEZFvhHFc699NbWg Date: Tue, 6 Jun 2023 03:14:07 +0000 Message-ID: References: <20230516221557.471-1-brit.chesley@amd.com> In-Reply-To: <20230516221557.471-1-brit.chesley@amd.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH8PR11MB8287:EE_ x-ms-office365-filtering-correlation-id: 197b0e07-a35a-4ab0-e98a-08db663c16ee x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K4ALLYCoDIk5gxxcJ8/Q3zvmB7sV5zdcwRBoGk7Oqo9Vs5cIdZtm2eRHDdEZ4XcZl0vrkdb/uoe2XQ1Y95YOK6GOE/4qQnCQ9mHxdLpzvp5j5GdAHoHpTv0EkuWz6YCTRugtj3c9HSEJ7T+PU+pLyY22AIF0SIclmOwuk/wCZwtU0X4d2T3bJlWOVkkScZNommBFoL8NVBcV5B19rr1f6WDxjkW24OCGFM/qSuQNeLFgMtKfd2w86cfJqtjlHpFj0HFo2Miz4+Avy+SDCt0ltbSHO3oxfZ5usYuO4WjxRldWJ0fYI1l7xNZGIN6p0yfSTb7/dJekLQwaOfTJ3xgWy2DraKpt+7svNCY3BbJ2mJX+Uq97bWvfYX97BKJ41zGEmavWD0b/+XL3l8HWe3N7N4O5KjKYpmCil7G3DYVPn2F6Fju7JANkVOt5GMjMlIm2FAbV/OQNebEPeFne4/pTnvvZToBsossDnV6NVmwdr0qlrJQG/OMWpZHXxfJnvigftBBJfwUMICcxGj7/q95I4Pp0qaVYAuTMfkfYh4W9wk5Dbeu/1Mz1ysjxvbuoCS4W07qKalPIyp41H1u0oKuynv4YQl9CacDoljKa5F6Nmy3X5eIMrjxioaCtVt6uNh6E x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(366004)(346002)(396003)(39860400002)(451199021)(8936002)(8676002)(107886003)(7696005)(478600001)(54906003)(110136005)(55016003)(41300700001)(52536014)(5660300002)(6506007)(316002)(26005)(4326008)(64756008)(66556008)(66446008)(76116006)(66476007)(71200400001)(66946007)(9686003)(53546011)(186003)(83380400001)(2906002)(122000001)(38100700002)(82960400001)(86362001)(38070700005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x6AryEmrjDwQEGlehnCLKncgMC54l8+n8wHdNyel9Wf8jvXENryPApi02/Wg?= =?us-ascii?Q?c1s2oiSZx8dbkxQ7/08DDT3L8lMAtubVIEuxisJdmRlu4u5I0nSY1eVKYdHa?= =?us-ascii?Q?T9eV2Y0bjzo7vYcO0XpwW8AjTf0v/35tYoyS0SYWeiTgbywuUZD2nVlo4hrV?= =?us-ascii?Q?GieGMPLbWXqAgJgRGf+EG0YfQRsrHL4Ez2RBUUbcpHja4nxh8PaeFTR9++CF?= =?us-ascii?Q?hZLbvGR/ObjNb7LMGrxl/xptHfrUhyKzjXqaPCHluF7C8HsshoV/sf+jz7C/?= =?us-ascii?Q?kO4Y8/7ciH4x8ACwyzICh+WP5UFCl2lNJpw3NkFaMgDesMr6vHB07Q+NXVlO?= =?us-ascii?Q?enprEP0KQioaKtjnNEqIFUNiuC9TfEewwbPi6ctYaK9rg6ETXNvbNXfYxQN4?= =?us-ascii?Q?rwSIMS0DY76Cx9nsjDqTiVURDpEF6IE4yFeqAXyeYOaqG2Ew6uZ+5Ymx+O9i?= =?us-ascii?Q?60tZGYrIFUmNYeF6Pvo/DmBxAhUuwc3NfdRN6alnIcfSBLimawk8hq6vedbm?= =?us-ascii?Q?ABK0FJX6klRX5+VsR4nHVwn8as4dBTlHMxqoG9Dyamro2bulMY0GXTJPbS+4?= =?us-ascii?Q?Y8cpkwaGxjf+qRfVYVuWuXfdbm2i2Yha/WkYe8kCVfUkyvFO+OzvU9IItj3j?= =?us-ascii?Q?Z7Mdt9J4Gent2DX8y7Hq7Mf4EMKrh4lVwLcvxHUdnenHswL5WoYA7zz6lhP4?= =?us-ascii?Q?S0UQOJZDoa27Haan3eJMqdlrFAe22xNpZIb/Z9l5bL0lMusCG5H6dT9Qy0Qa?= =?us-ascii?Q?lZp5T/7gMW1ZzTJF1WewNOLbN31qLsWpczg/tYmadOZyxTc44byiTa8KZnTL?= =?us-ascii?Q?+bqlCDrf2VvbKpoNpbuWWnyC0Cq8U9n1avRZ2LhYsEuZvdqe/HoTY/F4zDLK?= =?us-ascii?Q?jWF9asy1hrxhft0VH11xPC9Vo3qOXfihgmg56G2kUQ+Pa9XFybJPVl8Yv1rR?= =?us-ascii?Q?3zGYPvf6AebDloKfDxMoUeIB5QZvPb+I37hGAJwJ99dVXjy4ONDuHMk9i7vU?= =?us-ascii?Q?XKUsVYfNC8hi0LuQG3DkIT69cr4CallXklGVPXKSgzPK5ESKmCWS1C504At/?= =?us-ascii?Q?1pFRKptX4RANVthxjXhzG43RcBIUK8v+2FmhwGd2Aa+r/BCy8KSNnjasD3Y9?= =?us-ascii?Q?eWHNF3pa/SNsGL3ed5ZU+pZZwKn9T8mUX/rR03EyJ2mDGeI4gCcHwfbDd3Ja?= =?us-ascii?Q?PrCFV3ldXwjsXkP/i7OgL3/BZOD1qdjhDlEJ/mCh+dZ7zyPnZ9h0Yfl8LZLm?= =?us-ascii?Q?KuTyrxpBRNdjonb1UzOpl6BhkhX3g/J1uui78BWykKErN2JcO9YHSD22sJbT?= =?us-ascii?Q?+42hWpINddaM+A3zkAnCsbRHOypFVjJZAlU+8sXVNt+4TI088p7rgLXMmume?= =?us-ascii?Q?OCZoRL1l+7HZavLXw7Up6FU4w9xIDbmFv7GL+clRGMMHYlwPfFJAHVpNI40Z?= =?us-ascii?Q?UxBSjLABq086ZyRs8eFDzjUWNEhDIzmQFQe7T4CN/UI96ioLseOOwM9RsBsT?= =?us-ascii?Q?dsHxs+MrE+Rw46MTgAVkGUfCWiNiPHFpjMDOTPgA6vD8Id2InTZhf2aqXwOS?= =?us-ascii?Q?N/7yxQFQFEPZ2FJkKRqknSCc8dLqwAhuebC7bbqj?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 197b0e07-a35a-4ab0-e98a-08db663c16ee X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2023 03:14:07.1466 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iBjx3exmRzVM/D06kxYVDkb5ddSdPgXS7y36x45XlpYUq8wkyqhJs0jPLaeTxVurVJTNkx6+gDx1Nar70q/+6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8287 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry for the late response, inline comments below: > -----Original Message----- > From: brit.chesley@amd.com > Sent: Wednesday, May 17, 2023 6:16 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Wu, Hao A ; Ni, Ray > > Subject: [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build Descriptor table > after resetting port >=20 > From: Britton Chesley >=20 > Fixed a bug which led to an ASSERT due to the USB device context being > maintained after a port reset, but the underlying XHCI context was > uninitialized. Added build descriptor table call in UsbIoPortReset Could you help to elaborate on what data in XHCI is not initialized that le= ads to the assert? Thanks. >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Britton Chesley > --- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > index c25f3cc2f279..55e0e1f16cdb 100644 > --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c > @@ -882,6 +882,12 @@ UsbIoPortReset ( > // is in CONFIGURED state. > // > if (Dev->ActiveConfig !=3D NULL) { > + Status =3D UsbBuildDescTable (Dev); The UsbBuildDescTable function will allocate new buffer resources for and u= nder Dev->DevDesc (device, configuration and interface descriptors). Could you help to double check if the old buffers are properly freed for th= e proposed change? Best Regards, Hao Wu > + > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "UsbIoPortReset: failed to build descriptor > table - %r\n", Status)); > + } > + > Status =3D UsbSetConfig (Dev, Dev->ActiveConfig- > >Desc.ConfigurationValue); >=20 > if (EFI_ERROR (Status)) { > -- > 2.36.1