From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Pawel Polawski" <ppolawsk@redhat.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Gao, Liming" <gaoliming@byosoft.com.cn>
Subject: Re: [PATCH 1/1] UsbBusDxe: fix NOOPT build error
Date: Tue, 21 Dec 2021 08:23:59 +0000 [thread overview]
Message-ID: <DM6PR11MB40256A421CE91B0577CA066ACA7C9@DM6PR11MB4025.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211220143238.718544-1-kraxel@redhat.com>
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Monday, December 20, 2021 10:33 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Philippe Mathieu-Daudé
> <philmd@redhat.com>; Wang, Jian J <jian.j.wang@intel.com>; Pawel
> Polawski <ppolawsk@redhat.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH 1/1] UsbBusDxe: fix NOOPT build error
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Will tweak the subject to "MdeModulePkg/UsbBusDxe: fix NOOPT build error" before merging. If concerns, please help to raise.
Best Regards,
Hao Wu
>
> gcc-11 (fedora 35):
>
> /home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus
> .c: In function ‘UsbIoBulkTransfer’:
> /home/kraxel/projects/edk2/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus
> .c:277:12: error: ‘UsbHcBulkTransfer’ accessing 80 bytes in a region of size 8 [-
> Werror=stringop-overflow=]
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h | 2 +-
> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> index 04cf36d3c860..d93370a6c21e 100644
> --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.h
> @@ -148,7 +148,7 @@ UsbHcBulkTransfer (
> IN UINT8 DevSpeed,
> IN UINTN MaxPacket,
> IN UINT8 BufferNum,
> - IN OUT VOID *Data[EFI_USB_MAX_BULK_BUFFER_NUM],
> + IN OUT VOID *Data[],
> IN OUT UINTN *DataLength,
> IN OUT UINT8 *DataToggle,
> IN UINTN TimeOut,
> diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> index 12d08c0b740f..740e7babb0ca 100644
> --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbUtility.c
> @@ -267,7 +267,7 @@ UsbHcBulkTransfer (
> IN UINT8 DevSpeed,
> IN UINTN MaxPacket,
> IN UINT8 BufferNum,
> - IN OUT VOID *Data[EFI_USB_MAX_BULK_BUFFER_NUM],
> + IN OUT VOID *Data[],
> IN OUT UINTN *DataLength,
> IN OUT UINT8 *DataToggle,
> IN UINTN TimeOut,
> --
> 2.33.1
next prev parent reply other threads:[~2021-12-21 8:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 14:32 [PATCH 1/1] UsbBusDxe: fix NOOPT build error Gerd Hoffmann
2021-12-21 8:23 ` Wu, Hao A [this message]
2021-12-23 1:34 ` [edk2-devel] " Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB40256A421CE91B0577CA066ACA7C9@DM6PR11MB4025.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox