Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect

["Wu, Hao A" <hao.a.wu@intel.com>]

Thanks for the patch, inline comment below:


> -----Original Message-----
> From: Giri Mudusuru <girim@apple.com>
> Sent: Friday, May 12, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Andrew Fish <afish@apple.com>
> Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug
> print is incorrect
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394
> 
> Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 32 bit
> pointer
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Andrew Fish <afish@apple.com>
> Signed-off-by: Giri Mudusuru <girim@apple.com>
> ---
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index aab6815328..2e7497a89d 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -30,7 +30,7 @@ DumpCapabilityReg (
>    //
> 
>    // Dump Capability Data
> 
>    //
> 
> -  DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n", Slot,
> Capability));
> 
> +  DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n", Slot,
> *(UINT64 *)Capability));


Please help to use %p for printing pointers.

Best Regards,
Hao Wu


> 
>    DEBUG ((DEBUG_INFO, "   Timeout Clk Freq  %d%a\n", Capability-
> >TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz"));
> 
>    DEBUG ((DEBUG_INFO, "   Base Clk Freq     %dMHz\n", Capability-
> >BaseClkFreq));
> 
>    DEBUG ((DEBUG_INFO, "   Max Blk Len       %dbytes\n", 512 * (1 <<
> Capability->MaxBlkLen)));
> 
> --
> 2.39.2 (Apple Git-144)