From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.42214.1684297145427441145 for ; Tue, 16 May 2023 21:19:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RlaPQnDg; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684297145; x=1715833145; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bGZ4vc0R56GcLoURwuvr9XwZo7WgM0/WDWBD1AgBs8o=; b=RlaPQnDgFdRVBWSfQO7y2nuBJTiyLO0z8KnLP/GifYPKMCsEtTXqCuu9 YZohHtrKi9zb2dCrHvPJnZ/Yew+Xx3sqKQ6bF861TOX66Cbk9D1wZ15SW LUygVL/I98fIVLkCyxVuKzrKg1HXujQq7x3frThz7RuyG8FRjDamHKX4O jC7r91jh+X/Qy1RsQfC52cmiCFk+XGcnWAUPU0Vp0jEi/nZYhEC0asmn4 yepIwllHtgj8SdWZ3J9yEeZThNwxUHAk5PzRskM4G3zHBImIvg+LzQFgS uezfLVnoI1P76uLr6kWmLlduC884p9L0xLyLc7sehR9gERrtWIXVyHdwM g==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="350496190" X-IronPort-AV: E=Sophos;i="5.99,280,1677571200"; d="scan'208";a="350496190" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 21:19:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="845937774" X-IronPort-AV: E=Sophos;i="5.99,280,1677571200"; d="scan'208";a="845937774" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 16 May 2023 21:19:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 21:19:04 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 21:19:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 21:19:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RcfcvhGO1mHa1P6gvbyucxIvrLFNN3M+SOqszzBBRoi+XDAJ9d5K839qYySbPA+UgtebvWDMTzMRQYfXIjCtazPMAEfa5E2BD7pLH7oW3QiAioTBq9nlqacsoFRW43g0Ad6mXKK+zWj973/5GM19IqAy/pj5jUyUf3LA21gCA9rqdh9HEjp7Gr+r2Q2KV3JCKlXO3rOAQ4UeLqpfjIJQx5ZDzjqIgcYBVU/vIc8Cn0z6SI/Y46YqzcEvbZ+qCHul6KXLb4zpwijQjWsH2Fwrq/utBHFtJRQJPZjCgSCBhtuKDcgDgpNtQjhxyzolNhF/QDc59uRfDmRBMHQLAhOejw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yevtFibUoIJEg0G3HN1z2DoyEAqmTXgFw18ISzxvzRw=; b=TFCkwl6mGC0ySJXGLWz9jGsNIxu/3PyYp3JqEAvHW+EQUxOfJTAf3/vSLdLyZCvNeCH7HvoJvH4J7vOyRkGYaYd7o2yMDjBPkvjFQdElz/UP5XXonWycxUFRybM+Kk4rAWRNFDNqBG3dHc3S5XxdWFTJhFe9TSoAbAI+nWpKPvwQQEYdcLyWJjZmdNsAWTg0Zeqqm0w2eIFFoWKhUplXwF21939HmzNmcl2V2zsjBgiKU5x305BArNWhbg7pX07FKzVedOy58OMU+D818P79iT2BB3H8oCnuLazCW1ZZXvuUW2lcoFY8P5GMtEHv/tN+SICvONFALZvDlUbD/DrUIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CY8PR11MB6937.namprd11.prod.outlook.com (2603:10b6:930:5b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 04:19:00 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebdd:c7e9:13b2:437b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebdd:c7e9:13b2:437b%7]) with mapi id 15.20.6411.017; Wed, 17 May 2023 04:19:00 +0000 From: "Wu, Hao A" To: Giri Mudusuru , "devel@edk2.groups.io" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , Andrew Fish Subject: Re: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Thread-Topic: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect Thread-Index: AQHZhLfuIP/BGWMyN0mYxc7eOskLV69d41mQ Date: Wed, 17 May 2023 04:19:00 +0000 Message-ID: References: <7ba00d73bd53c401b9fcd6fd4a3a79f9e43d9662.1683885276.git.girim@apple.com> In-Reply-To: <7ba00d73bd53c401b9fcd6fd4a3a79f9e43d9662.1683885276.git.girim@apple.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|CY8PR11MB6937:EE_ x-ms-office365-filtering-correlation-id: 6de98532-27f7-43a6-509d-08db568dd72b x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +0OvE4GZFsaOdfuDAnj2I7y1vw06gIMvPumaoHb4witpsuIK4sVb3rN75CdymgPwyGDwn7U3dWzSkbNZQFGR+HCg2WCOIlYmlRpXZOCevd3OnO815G7cSPjqzx8n3rGAr5QQn8gZuExH7V+lrQZGunrf7/vbCCWHiXJg8GScgrsLmFzQ9KYFUoig9VNGskOBabMpZj/YmYU9TiK9RxG7XwWPEXx06wiJvxAw49umlWJ3GfrQ9DheWTPad6NUNVP4z877oVkFECHCRb9b9Cm4QahaK7txaqm7Uzu3g6ZdcoOK7y9gI61RhDVQN/syPSGLEnhw0Ovq2XK/4QCa9CRK0DnX8yKuBEhVjp5xHayZpdqpBtL7EWnuVoeiziBbcxbP8rA3E5y3++yictvwCrFyX5cxUVZKRKu1UX32UxVtTztCaD3bFe1ZK6KyXXw53rGTlooSOH9zWIGiChjiGT9U9MtUwOaQSudhQM8ACwWkX2o48rbv1XZCEDB0HgN9QKLQ76oB8jKdBWrbg0W6TAwu5sKExg3pK41WpH4XisOYPH6Y+CboBUBD8DBURvePAaesZ3PruKK53gCpSAWNjSkAlC1HhUOaOUEMbFhkgRKRkKs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199021)(86362001)(33656002)(38070700005)(966005)(110136005)(54906003)(316002)(66556008)(64756008)(66446008)(76116006)(66946007)(4326008)(66476007)(7696005)(478600001)(71200400001)(55016003)(41300700001)(52536014)(8676002)(8936002)(5660300002)(2906002)(38100700002)(122000001)(82960400001)(6506007)(53546011)(9686003)(83380400001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W+BJaiyUvkjy93B2fFEdtVr0DaUkgtAomA1+opMOID9Vy73ws6a8JP88+Bwb?= =?us-ascii?Q?s2TfG8YEPf56xKIwB8otITcqnb1rr/HTLkjj70Xf+z1JJvQEML0256EyhGVX?= =?us-ascii?Q?S8MvhufJefxnLTGZLaaj0yrl0jfpS/+VO3XTpysbdwAkA9w/F4KqKtqniaFU?= =?us-ascii?Q?2LUZDb0QXB6WyvJARHq7k+gYKmJNzEurRzZxaTiCqVmoIkgmNdvalgFoPmCd?= =?us-ascii?Q?y+kfUDbxkEZfrCU6+sMN2AJ2qfuvX3H2IDwly7LUlsrt3QR5Gc2hw8d2hU4a?= =?us-ascii?Q?UM79/wKHE8UzmmpEfj7bfwpoEiksdlwIcX2C2COPgKm4P14tV/rt1Z/v3slQ?= =?us-ascii?Q?zluUQ6liEW0qflC53cynKm7HBBK2FHrXxERkrJWzU9IX8MUC35rgFVr80Dz6?= =?us-ascii?Q?RCRF5Jk/75HU/esCHUI/6oYFhq3BVGKsylG1h0oUvyyxW7CCdcvm6V3p7UDK?= =?us-ascii?Q?o7n9eR6xPY0BESm/AWAPuF+l57kBDlLIFnhmUcC/hn6ItepgF5LemKVW0pbW?= =?us-ascii?Q?uZllSoQxgWkglFzGnBVSDMtrdHDQypghPGsjPr5PvkOMqU9q1widdoYFUjLu?= =?us-ascii?Q?3/hFhRjd+LntJGFudP1DMEoqXDd0VpEI5vTxh6mJFKtCeAlKBltOCIRl4Ghb?= =?us-ascii?Q?0Y4RzuqrxyTDqkAHOhlf5JUOaee4VCB063cqLv4mMMDGHpjuFuIQ4cbiokY/?= =?us-ascii?Q?fBDUYjlAHPT0zIEALfVF1TtWOeOG9c4OhuLQp+qIL0ehOE3tfh6/O4d8Wl9Z?= =?us-ascii?Q?/GiBfQSS6Onw1FT+5ZbGKPhAO1e4uMtx1efwrmwaQdD2Rkr6cv18hF0k06Wb?= =?us-ascii?Q?wsGLuIkRlquskKvZU7a1RQ/VrwBYJMoRER7dOaSSDZvcv2PROOLUPUP5HCQQ?= =?us-ascii?Q?AEAGHGMwlYuVFQZzspXo5mDFaa9O6uWpB+Hbr3aaBv0lV+mVZ5et4zMMdvtj?= =?us-ascii?Q?7ap7UH4qH5k5Q0RWSe5VX7MUwYx71g/J5vgMNBU5rYbYDLbWaMhs0VmvPQUq?= =?us-ascii?Q?jkTIBSyYwh8BVB0qmdELutlskw+YsjdP9vI4Zd+2sOIrPhMLBYgltKaSWrKf?= =?us-ascii?Q?S9AqRTd+CorQbF4M0QxtiC8uwqF6p+mDt89hHgbD0tCAqzPWrMvcwNFEXyZi?= =?us-ascii?Q?mapn3kDifPOcMcq8WFV2lh56blY3aux9iqu/2i/S4dfuBIyAKjH1T5j86RIZ?= =?us-ascii?Q?SlT15eC0pFpKCxXVxXSWi0Zrx4k/Dmpyt+wnVGruSdSHArh1wGSY+/vbGInf?= =?us-ascii?Q?Z9nt3EAkeJcP+oZraVGsrhqob2TgULRbg45hcEapvrodjzU7REa2ySpSQMsG?= =?us-ascii?Q?c8Mi+MWEXi5IL7xjTWPC3AM7hxdWRLDYFGymJ80T8zksw9pDJOkwez4KQVFf?= =?us-ascii?Q?jpusZ1Ws6t8d+lczFvHgaP+17I2fl+OXeklEUZrf/6QEFtUHuqmZvxAbsEqa?= =?us-ascii?Q?ydf2ihxUI7PsUK013JUtQ848Mlb8XQKdGQGBg+1hKF1P1/RUhsDMedqra0Dh?= =?us-ascii?Q?KaY3GInkjpRzsIYvLS29JbwKf85sQk7LakUKGQ6EdGk+GLPeFQq8163zRQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6de98532-27f7-43a6-509d-08db568dd72b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 04:19:00.3128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ABA3+szHffesjrpkw6A6WZNbBca1McOhYodH2/AeOLIRyDNwz8DCn06/vVvfZNjEe6MTYZvaO78imXop4T5ulg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6937 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the patch, inline comment below: > -----Original Message----- > From: Giri Mudusuru > Sent: Friday, May 12, 2023 5:55 PM > To: devel@edk2.groups.io > Cc: Giri Mudusuru ; Wu, Hao A ; Ni, > Ray ; Wang, Jian J ; Gao, Liming > ; Andrew Fish > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug > print is incorrect >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4394 >=20 > Fix DumpCapabilityReg() debug log to print 64 bit capability instead of 3= 2 bit > pointer >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Cc: Andrew Fish > Signed-off-by: Giri Mudusuru > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > index aab6815328..2e7497a89d 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > @@ -30,7 +30,7 @@ DumpCapabilityReg ( > // >=20 > // Dump Capability Data >=20 > // >=20 > - DEBUG ((DEBUG_INFO, " =3D=3D Slot [%d] Capability is 0x%x =3D=3D\n", S= lot, > Capability)); >=20 > + DEBUG ((DEBUG_INFO, " =3D=3D Slot [%d] Capability is 0x%llx =3D=3D\n",= Slot, > *(UINT64 *)Capability)); Please help to use %p for printing pointers. Best Regards, Hao Wu >=20 > DEBUG ((DEBUG_INFO, " Timeout Clk Freq %d%a\n", Capability- > >TimeoutFreq, (Capability->TimeoutUnit) ? "MHz" : "KHz")); >=20 > DEBUG ((DEBUG_INFO, " Base Clk Freq %dMHz\n", Capability- > >BaseClkFreq)); >=20 > DEBUG ((DEBUG_INFO, " Max Blk Len %dbytes\n", 512 * (1 << > Capability->MaxBlkLen))); >=20 > -- > 2.39.2 (Apple Git-144)