From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.27469.1655710782286527532 for ; Mon, 20 Jun 2022 00:39:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=P9+AiWb7; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655710782; x=1687246782; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=K+DLT5TuvNOU/UjRX32J0FiTEjQXlaRucMrm7g6VZ0I=; b=P9+AiWb7HQTFVd4O0vkmrIX0ZPVCJGuMapd6BsN1AToNfFjSlNOd6ElA ND/OvguuxBdEsKSOcVh6sdV/yPUd5Ox27DWRXNFeKztcwj6OF6/wVYMIT /XWaYjDFJMMp0Mef4Niq9s0R120/mPiIXEqR9N0xWxJfn+EP8IfwHfGOo lo74SiIjh0dA6LwSm1PqSr16nLM7uAcPB0CFvCgXeWvM1dQJtkV+a6rQt xmpoKr+jtS2JtL00XG2zOPjP+l4gQQ0+DzPghmbUdNZ6zaiCzINlEU25s JGaoHIvVUkHaC+iKNHGJ+GQQTxAvhE9vQ455y6m8ySuasYtbJdOP7N0Cq Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="260259647" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="260259647" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2022 00:39:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="764000860" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 20 Jun 2022 00:39:41 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 20 Jun 2022 00:39:40 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 20 Jun 2022 00:39:40 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 20 Jun 2022 00:39:40 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 20 Jun 2022 00:39:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZKcBHoZC1C7ToKDAPQnceK2diZiDIgrL5bCx2jtoSyt7Cco12TYG8s5ANC/XAhZHdoFerAwpWVWIrGNY2iOBiUWDtAQoYN+BMkFFqIyTnF9wJ+ecyoRY8cm0gQbRQGg8U51CZNYYGtNzXvt1VPFBvBNUho4O+D0+wIb5fjIE8PLW1owodnxRWpp+Beog5Ru7KPIpX49QS2ggDXqs+OS/G/IS/1U+eJBUCTUb6mtv49802f8OlJwOtjGhH25DMbY5AbxflNj6NYzHQgEmvq6BnwSpnsLqSVYGhst0TehDHg6ccjG4Twpwq9mYBrm8/a0YwrGS1wCxhgn+rAzmNXsbAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5QObdtl9CxyOX4e6TJ2VA6cVDaZeKvmLifHH5/O4s4=; b=Ms66bya3hGI3MZ9bHq4u5zSVfAXyv6bNlUmoL4ufuHIBtlPDtfYFHVqVNxx64vGigvF8k1WtiD8HJ3YmwWXayJb2DtCaR2lz1OOWNOmJfj57YrbYscpJay0O0lDZj6hBkPSd+dXM1MX4zcVDOUVqv8H/8U0xWZ9h15YfvXeuZPAFoX0xPEy5J6GaPs2I2ZMGjpKQBDNJR9dFlacfgjJLGo9fWlVL04+3hwa1KY6PaLO90uLNmDgYMOL+T995HKssOillt8vuB6rL4uml4efOfqJEos4svnjwK+24z/NeUR2/FKRvdngZtgCgugthlyu5s1sng2K8PhVVvtl2QL8NHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by MWHPR11MB1294.namprd11.prod.outlook.com (2603:10b6:300:2a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.21; Mon, 20 Jun 2022 07:39:38 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::c473:f30f:6b1f:c5ec]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::c473:f30f:6b1f:c5ec%5]) with mapi id 15.20.5353.022; Mon, 20 Jun 2022 07:39:38 +0000 From: "Wu, Hao A" To: "Luo, Heng" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chan, Amy" Subject: Re: [Patch V2] XhcCreateUsbHc: Check return value of XHC_PAGESIZE_OFFSET Thread-Topic: [Patch V2] XhcCreateUsbHc: Check return value of XHC_PAGESIZE_OFFSET Thread-Index: AQHYhHSPPfQQ40T1H0SmWvnVV2DkIq1X6Hqw Date: Mon, 20 Jun 2022 07:39:38 +0000 Message-ID: References: <20220620070816.648-1-heng.luo@intel.com> In-Reply-To: <20220620070816.648-1-heng.luo@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37b86b82-738f-4704-0da7-08da529007d3 x-ms-traffictypediagnostic: MWHPR11MB1294:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cH9IEo/3IrNwbNf+WUx6oEFemclCxBnzaQR7TyC83JIp9SGRQdgmzEJUhLE7x3m9XqXINsFlYZJM1ILogSHc6R37a5AbsuNzfsAP2nGEmccSMN0BrNQ/5k6wxdUOEM13WDrZQnmUPCt88Ok+4sBy/8CRkI+u9dyL8EhQvRP4QzSQmHTZ/CDFSugK6X/Qp3wBD5I0bsVMokIJtkrzM5WaD4/qCtx9ME3AxkQpDQpe1g33GNtUHYP1W3BrOYQMjUC++iOUtLPTni3KE421ixMIsUcXAPpgW2oUn1j+3X/LPIaonKNsnGNeFIolZu+JqnUB+g/MQot8HHbXQCTye9eUgKk659Vgbvrlpqvh8/ucTllfQQk3cFaNEgR0ufKbcyqQORoF3t37sfkEdIfhxwsdpnSRsIVJ0PYtlMnCZ6r12UWkNekVh51xLWsLG6/JRzNtvG+nDGu6a4gU9gzYGp1LwFr/AfePdbE4Mb9NZ+uyUv2WtZTwXXX6wBRSPUMa7cdbPL+UNWy+ryFVaWip/zX5t6OkmK1Ep+iaseUSa77mwyto2h79G5fEhXoyPvgC2QWUrs4A+PTp4Kd2gvawEMbtDvsBkugStE00V1pe7t0+NlPMHmdgWK2WJjIYKvk+5WLPnCf8szIwBo/XagZZPr8si4fPaJQw2NmF24daAT2KIkZ3hBwYhu48xD+FEx0/9hNzrRMSUa87jQ9TP+NHh/e4OeZ8+1/neIeQ4ALSdEUsFE+FZQDassPhTV5a1eZEnqXvfOxT9U6tXtaBRzGwpbbNwnJp/p2E+xTWkmL1ZQ66TTI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(346002)(376002)(136003)(396003)(2906002)(122000001)(66446008)(66476007)(66556008)(64756008)(38070700005)(66946007)(82960400001)(38100700002)(76116006)(4326008)(83380400001)(33656002)(6506007)(71200400001)(478600001)(966005)(53546011)(316002)(7696005)(110136005)(55016003)(41300700001)(54906003)(86362001)(186003)(8676002)(26005)(107886003)(9686003)(8936002)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2sLCiH5bOUsXtSemU210Ttzq/ULA9mWiVNcAWSSn2/+82czarLUby63Qt7oE?= =?us-ascii?Q?R/lqkYr39Tgxfgf6sLyyR/mtoeI8Pewo+Tf5gE80M2wyle/1ChZRI4w4YZwt?= =?us-ascii?Q?r92PLxretK3Sd0KtYnMhlbVsKcJ/soB+BNwrLWHzFMF+3QCoIv1c+l5VT2pK?= =?us-ascii?Q?7S8/J+L4TeEt9b7N2HHYlnFNjgN3Fg7xPXlYlgWBzylNMmxH+WCrVU1P+p0g?= =?us-ascii?Q?rhYEEHtn2aiZEJwszCHM+LH4Vz9c2BBx7zEAqNLJ+sKanMjHa+izlJkzhOoq?= =?us-ascii?Q?eMFRaQlP5oVQ/w6Cn29vA4VUG+FKHI4FM9qn/9D5E5SWBPO2Z5HOOX+BZ+IA?= =?us-ascii?Q?bvC/QQoxdIpgwisH9xV/QonpTmubK/+cvhdDGnVlKXuC1zRstfQYPihlV8r3?= =?us-ascii?Q?g6yyQNzIHWYUOLV+InuzAE6C2gRRD6x6kS+6l0ufQBZKVw60fnLPQZipCBl+?= =?us-ascii?Q?oGN7jymGRLoH6I02l26i1YanfMAc2qvOKCjSPG0gNHWpHnslegMueohegajc?= =?us-ascii?Q?GzExeH4syP1PkH/+hwHnKPWDHVvTUOIn89OXi9nnn4QVYEvHNlquL+XbcQt7?= =?us-ascii?Q?Rlxue/j9dbJur/Aelg+ppex/x13xhECDH1gEAPJo0hNcuKO1glXAIE0F2mAn?= =?us-ascii?Q?F6oLQUrEpjdjpanSQbX5D7Yq847/IV94EH2iF2N0QjHb50p8VzEgNhIEIiTg?= =?us-ascii?Q?f3umeZm5MJ0JL/YIYoMMs9uYCxFKJSobO4JHtFP7VPsJBEk23oQLLSUX9oMb?= =?us-ascii?Q?I8PR7lRfkf9/GKnCK50lhQ/o5RzlT36evf5wemDa8ORvkqHt/mOZq1aCxAF0?= =?us-ascii?Q?ejLycgmyFKFfLbms894Jd/nTCzNveXwL3KkD3QbzcK/Ow/2GaXLgR2Z8wSNG?= =?us-ascii?Q?UxRrnnL1AEPLUCjYx13KmE9T8MSHirUDbR5GjDAwCjV/YsOSO4WTjnTl/h8j?= =?us-ascii?Q?Qm1ZnQg3jizGNq24w4/l4zBdvLh5E5+sRNFRMAx/3S2MMPxaMBJsLS51IMZI?= =?us-ascii?Q?B1iaKB54DLuOVQzcRcPFA/W7ZUEzgTrcAJ29yEOZcmle8DKodK11wBOtNJi0?= =?us-ascii?Q?SJ3tFtwkun/pXVuf4NriEE1ePfwTpteYAmVc1Y0C0Te4c5AL66OJD4bi4Gv8?= =?us-ascii?Q?uDV3WpkejI2vA6AqepMCf49xMw4XOg/ilhghzPq4XGu6mC5t+cjEzfHxxHYx?= =?us-ascii?Q?ygXKUynrbedtbpVJ1lbHlNnkIwHieENke0G05Ib1A8wPJ3o7wOfPtJ6BhHmI?= =?us-ascii?Q?h3/GbfbL+RpoBgSr2YtEpL8S4yPgtRMtZ6LFdFlRU2RqiXmwzDjI8jESgKW8?= =?us-ascii?Q?J6Rc8z2kukKlmxlY0ZzH61QSiiCwVGeK5/TQjO5+v+g91j1yl6MAwrLBRvKQ?= =?us-ascii?Q?Fwwhn8SUkpQ7g6so7jYHJpG/Aq18dgaYwn+FghxsFpwPmkoDHbLFQNrbJt1k?= =?us-ascii?Q?gkcQTCM6gFF6N9Tx9h9NL3yVzd7K48nrSyHpZ7elD11DS6qAtfN1mHbeQaQT?= =?us-ascii?Q?E+TQCLszFi3c5fqG/MtD8Jaaosy/6UrxbgPNhEfanmIVtY4fqYcDek4YRJZ/?= =?us-ascii?Q?pasQQ4hzJWZYuR+cMAPQ0ToNp7p+Ym9WTZ0sYpuBc1C0LV6GZgO04dTHHS2C?= =?us-ascii?Q?QMIoTv/HXj8CrLSTqVjUaQiuUE5+S3YRSFeu0wFDpbTlGYc6j81AUK9wy5p9?= =?us-ascii?Q?V8y4YTuT3IODFxbyDIKayz4hUtkkxPlqwfnXsqI+l4tov4oTr37fTGtHoqIP?= =?us-ascii?Q?ChGsJw7fbw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37b86b82-738f-4704-0da7-08da529007d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2022 07:39:38.5918 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hC6l3l6VXp/0N+P4AkO0fdQ+0MbRVWetYOF+SpYDfEIHS1ovLUTaYC+QfRB7lKEke4TaYxKVVDB8L6Ud7pxCgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1294 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Will wait some time to see if comments from other reviewers. Also, Will change the title a little bit to: MdeModulePkg/XhciDxe: Check return value of XHC_PAGESIZE_OFFSET Best Regards, Hao Wu > -----Original Message----- > From: Luo, Heng > Sent: Monday, June 20, 2022 3:08 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wu, Hao A > Subject: [Patch V2] XhcCreateUsbHc: Check return value of > XHC_PAGESIZE_OFFSET >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3954 >=20 > Report error if reserved bits are not 0 for PageSize >=20 > Cc: Ray Ni > Cc: Hao Wu > Signed-off-by: Heng Luo > --- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > index b79499e225..381d7a9536 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > @@ -1,7 +1,7 @@ > /** @file >=20 > The XHCI controller driver. >=20 >=20 >=20 > -Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2011 - 2022, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -1813,7 +1813,13 @@ XhcCreateUsbHc ( > // This xHC supports a page size of 2^(n+12) if bit n is Set. For exam= ple, >=20 > // if bit 0 is Set, the xHC supports 4k byte page sizes. >=20 > // >=20 > - PageSize =3D XhcReadOpReg (Xhc, XHC_PAGESIZE_OFFSET) & > XHC_PAGESIZE_MASK; >=20 > + PageSize =3D XhcReadOpReg (Xhc, XHC_PAGESIZE_OFFSET); >=20 > + if ((PageSize & (~XHC_PAGESIZE_MASK)) !=3D 0) { >=20 > + DEBUG ((DEBUG_ERROR, "XhcCreateUsb3Hc: Reserved bits are not 0 for > PageSize\n")); >=20 > + goto ON_ERROR; >=20 > + } >=20 > + >=20 > + PageSize &=3D XHC_PAGESIZE_MASK; >=20 > Xhc->PageSize =3D 1 << (HighBitSet32 (PageSize) + 12); >=20 >=20 >=20 > ExtCapReg =3D (UINT16)(Xhc->HcCParams.Data.ExtCapReg); >=20 > -- > 2.31.1.windows.1