From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3FCF4941005 for ; Thu, 10 Aug 2023 02:39:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7cSyiOSSPBe3E0i36mLx7+QqlWZhWXn+c0wQhfaj4Xg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691635142; v=1; b=PzET+d0eRboCDwE7g6hRV/tr1SKuwnrSFRYbGYtdw7FaFAxurWaPHKczKx+IQmozv1F066Bh vU8+fjHL2LuntHI8Pa9nh8j/S1RwHF4Mf6S+uLeuqiP4RjIOh2LvgZqTIXbfyqFh/vU0ZsxWBCH YEbwQZ1EKRbhwxWeS1HoVoF4= X-Received: by 127.0.0.2 with SMTP id HxNBYY7687511xSTDKWz20uG; Wed, 09 Aug 2023 19:39:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.9129.1691635141715840831 for ; Wed, 09 Aug 2023 19:39:02 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="437638040" X-IronPort-AV: E=Sophos;i="6.01,160,1684825200"; d="scan'208";a="437638040" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2023 19:38:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="846194410" X-IronPort-AV: E=Sophos;i="6.01,160,1684825200"; d="scan'208";a="846194410" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 09 Aug 2023 19:38:54 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 9 Aug 2023 19:38:54 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 9 Aug 2023 19:38:54 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 9 Aug 2023 19:38:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JB/Z2GlCQIaSmGU5DuYMne/Og5q9NxYNqkMDclVebYTb7Vne2l3BBoecFBUnxl7XleSoAH2BS81vOLxg0PqE74TVP2SK8jMlN9x90f4bTSBBxcNaw0EnBp0TaXdoAyXf9BezkN2hXsssH4IG1V42qpD/KSfrRCqTByGrc+Kys1Sm02OoSFgXtZLdeDK/8TMQoWGr3AKUw3xvrTgpjyOh5k7NuadkhDQ0UjfvObphIh3IFb6q+k7osNhlAE49ZuAqpZGA0yglIu2r9NPKyEkxazu8OwbzIVhN/6n7DHga52xiSOvZQMnxvum72yHJ38Pbm7b5aPISJMDNtz9j7NiMew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lG++47xwy2bSfkq/f4MUhhn9IIN/SzMAjSOLfVYmDhI=; b=QkRF0or85R3EFJ7tB/mFKACp87UBA3nC+Qrq2nGiU7EUPQN3bmr5q4dx5kyyQqIbeIGR3POkcZ/FZr8PI3ET2YeytgvsrOHrlEa8/44bthHreSoPYvXO/QwiubYie9lSY4LVM4yYSwTqNdtgn8EoGMzqmBrJHPcVOp567kq1nS9xdJBFnUPQEy06MrNrMmFS2p4i8PaX9vWNEPx8z9CPhnKzrcmjSz10ghl1Ic1miiBswtCsQf4mad0UxAbJ5vsqk3X5Bt+fl7m7irtHa99X85TsQqtNO3xJG9eMZfPmsVU5PMcQNk+xmbJHZ007FNtiwd/O9SVxRnfJStdyr76+lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by LV8PR11MB8584.namprd11.prod.outlook.com (2603:10b6:408:1f0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 02:38:48 +0000 X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebe2:341b:4ed7:d19b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ebe2:341b:4ed7:d19b%6]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 02:38:48 +0000 From: "Wu, Hao A" To: Ranbir Singh , "devel@edk2.groups.io" CC: "Ni, Ray" , Veeresh Sangolli Subject: Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue Thread-Topic: [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT Coverity issue Thread-Index: AQHZuKM9hh3q270WaEKu+HcaFrI14K/i50DQ Date: Thu, 10 Aug 2023 02:38:48 +0000 Message-ID: References: <20230717113831.2290882-1-rsingh@ventanamicro.com> <20230717113831.2290882-2-rsingh@ventanamicro.com> In-Reply-To: <20230717113831.2290882-2-rsingh@ventanamicro.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|LV8PR11MB8584:EE_ x-ms-office365-filtering-correlation-id: 31e8d91b-cd8b-4f1e-a2ca-08db994aecd2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7sCaVCc4i7yOtHNbmLaHn+wnRpJ7Sr6m4N0boAlvwJAi1X16zQ5cm+CCOcwkwPLwpYuSyR1HX5yz0J3tSHj9K1XqYt5ANRjz20ltR3bbz8c8CoyTagFq9P9mWxGy449Y6naZL5Gsuz82f/p/nIh5pYIfyh4i+hRGsYye6ZCJPoEPvEDl80+LylLeu0/5VgRk3/bJRleLDRqNDJA270NXO3cHCSkznJxWMUl45JUJw4NM4XYExmygQMnV1eB7/UKoPqJgQGH9rZWl50DXtKz4UEWIf2s9KdBlEEa2NjskVUjHM6VAdjRxCYc2gBgIV8HGi7LQJco/Hp3JRJYnCmfS3BK1XFsLXl68gx98R8NT8IjJvBBQ9OSPU7bgr3z93Mfh8eARMOCxRFqP5M6zqQomOTKE+2cbKtwEDqRfj45Nrr+yTHm5g/wWkRRkOc6yRc1i696A7rvPLgWRR+evlyHVVZLGUBislCdazdtUWeSGR5J3xOGRMQRA4MQFG5Hr+zhklrEj0hLfvxyFuPVmdzhrcSYGsFtbVICVa6g4OPrWovrKeR2OkCVLeWBxAfzX8OCx3phTpBvguq0skM+bkkRk8kQSA2PUMxpw4kw1a1fYF00= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MkOv6ZuMcbrLpO3vuz6/RoM/G+k3ym3lU+O6Ngx6/69Hh1qEC2cDcVrFarqD?= =?us-ascii?Q?2I9KWiUwjWbSb1Sp7FWC+90/nyPmwrARjn7wTKF+u6+kVma2Gj55eg4mHe4s?= =?us-ascii?Q?f3VdJI/ImHwaWIWacDT5Wn3r4hLO0v/enelVx+lDccPugk3zGSKKxFxah1pe?= =?us-ascii?Q?gTJ96H7DV+7InuAq2sA800nnQeYQt8GRdHVX8x/zTlK9OSK42S/A1WgTLyo2?= =?us-ascii?Q?XjjSJnerPilZ9vT1GulXDncNsU0auLUOEGohVbk/9VLEPU3P9y0OV1EHzv0X?= =?us-ascii?Q?FMMffLf8SnE9u3yr0YknFIgbyOD+Xk8Pi3LtSQQeQr1kHRJ6q7nwfdKH2Brb?= =?us-ascii?Q?/rBV71N7epRg1MfCTNc6BGREapGSvsdjfCCM5jLCu2ZbA+NNoYv+nSvSJfj4?= =?us-ascii?Q?m1cGAFCZDZiuChLHVTvgFJg0K32J7L0zXSp4/mGWzJGpPAv9ywDVIx9yUjyh?= =?us-ascii?Q?1JF2Vn8KmuxuN3SEI/1RVox5tJHi9b4HgPfApR1vdie6kf2PymOUe6tS2pzk?= =?us-ascii?Q?LDNCerrKDocIf8w/1P9dK0Xr6LupG0N3u1p9zEnjeEkcsqGI6M7eTkF3P9Ym?= =?us-ascii?Q?y3kMBGDV3dYQtoGq0/edECTz5hbhhP2s/GIVebPMQeuUXpD3jKKXvcsPzTq/?= =?us-ascii?Q?gqibknEqx2M0Pko4eyOrftME22baXyLShwrIlibNrDmHrjPsCqig1qlfohFC?= =?us-ascii?Q?y6vYxz4LJd6Niutv1g560D3T7B3QNbVWbydhiNsR6kAUsce8BQIQeGcmiGaX?= =?us-ascii?Q?FDYvFEOEApa+blwabxaCXx3vpUQEqASbfNMo+y58sJXK8kqK35Kgv4qEipUD?= =?us-ascii?Q?62YWkZk+1dLwACdRJK0HWe3g5Rs9UOGTCIUMRGGawHhizwuUBi0+CtwBMHLU?= =?us-ascii?Q?jwWa9OKLe5Om04EajZMPH/KPTsfcDooSZ2874WsUoVvwv5sYyoi36vJkIYwb?= =?us-ascii?Q?OWwGg3Wr7nKY64H8XCeXr9weh7tUOC0dvN9ifvHz6ZifAssPnYofML3yc68C?= =?us-ascii?Q?HokI8ndgS0D2Pi0/LIaP/oamy1oobRHi1rTUZ8knRzWlvDMYN4/1w7K+i2yA?= =?us-ascii?Q?6EWIhEcRw06d1TT9gxg2HRcjUKeYg8gvwVhPlc5QFvADjYTOOX719cvBhIg1?= =?us-ascii?Q?XEN9K/ds0eq4eE/IjS2FuAqKGYMO6Z0TsL1kIKSGcrgreLk0X+c0oMqP+vsG?= =?us-ascii?Q?2rrSoJLorppKUM5Cc56nmavGsaRvpuq61ryiagNrMgO4qAG9GeY7T75q38iQ?= =?us-ascii?Q?s7V8T/K9zlaTCBADeioFTn/wHV/i3NQ5rkLhOh9+Gzpja36ehqs1qT9PBa7k?= =?us-ascii?Q?rBYAU2PExo1D5Aj20gJ3vlj9eJH647SH8rd/Sh/jj3mLAdds0ZFYSnRTxU3l?= =?us-ascii?Q?LzSDVh/S+tJIhCQH6cJaXvzA4n+D16Jga/q+qrK9etgQQJPMOKcGg9WQeQ29?= =?us-ascii?Q?6JeF4PjwRDZH+1Jt5QzgYWoimecQuev8sryY3lDW8mu/v/SLvJ2TljfQDyy1?= =?us-ascii?Q?WQKH35we8gr1Si5znJLrpYAWGqfKxSabWgfvRog/OP7fcV6PnbEjPbdkFcL3?= =?us-ascii?Q?VwmJP8IjE85X5x5ZcY+nI0fDKDHRV2XYUMWGHdzP?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31e8d91b-cd8b-4f1e-a2ca-08db994aecd2 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2023 02:38:48.2355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PFXjvCF7hL8vAJyDuhemVwbZ2zmBgbOVzJHL0y6nVlUaT9Vmo05hFbQQZrax+KPW1DDjyf9apeVuNcZjm2P8lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8584 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4KEXeQ5gfIoGwK0oV8j86FVpx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=PzET+d0e; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io > -----Original Message----- > From: Ranbir Singh > Sent: Monday, July 17, 2023 7:39 PM > To: devel@edk2.groups.io; rsingh@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray ; Veeresh > Sangolli > Subject: [PATCH v1 1/2] MdeModulePkg/Bus/Pci/UhciDxe: Fix BAD_SHIFT > Coverity issue >=20 > From: Ranbir Singh >=20 > The function UhciConvertPollRate has a check >=20 > ASSERT (Interval !=3D 0); >=20 > but this comes into play only in DEBUG mode. In Release mode, there is > no handling if the Interval parameter value is ZERO. To avoid shifting > by a negative amount later in the code flow in this undesirable case, > it is better to handle it as well by simply returning ZERO. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4211 >=20 > Cc: Hao A Wu > Cc: Ray Ni > Co-authored-by: Veeresh Sangolli > Signed-off-by: Ranbir Singh > Signed-off-by: Ranbir Singh > --- > MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c > b/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c > index c08f9496969b..8ddef4b68ccf 100644 > --- a/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c > +++ b/MdeModulePkg/Bus/Pci/UhciDxe/UhciSched.c > @@ -214,6 +214,10 @@ UhciConvertPollRate ( >=20 >=20 > ASSERT (Interval !=3D 0); >=20 >=20 >=20 > + if (Interval =3D=3D 0) { >=20 > + return 0; Return 0 will cause further issues within UhciLinkQhToFrameList() & UhciUnlinkQhFromFrameList() where the returned value is being used in the b= elow 'for' statement: for (Index =3D 0; Index < UHCI_FRAME_NUM; Index +=3D Qh->Interval) { My thought is to return 1 (i.e. 1 << 0) as if the minimum allowed value for 'Interval' (which is 1) is being passed into this UhciConvertPollRate funct= ion. Best Regards, Hao Wu >=20 > + } >=20 > + >=20 > // >=20 > // Find the index (1 based) of the highest non-zero bit >=20 > // >=20 > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107678): https://edk2.groups.io/g/devel/message/107678 Mute This Topic: https://groups.io/mt/100212109/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-