* [edk2-devel] [PATCH v1 0/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix issues pointed by Coverity @ 2023-07-17 11:40 Ranbir Singh 2023-07-17 11:40 ` [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue Ranbir Singh 0 siblings, 1 reply; 4+ messages in thread From: Ranbir Singh @ 2023-07-17 11:40 UTC (permalink / raw) To: devel, rsingh Ranbir Singh (1): MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106999): https://edk2.groups.io/g/devel/message/106999 Mute This Topic: https://groups.io/mt/100212114/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue 2023-07-17 11:40 [edk2-devel] [PATCH v1 0/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix issues pointed by Coverity Ranbir Singh @ 2023-07-17 11:40 ` Ranbir Singh 2023-08-10 2:38 ` Wu, Hao A 0 siblings, 1 reply; 4+ messages in thread From: Ranbir Singh @ 2023-07-17 11:40 UTC (permalink / raw) To: devel, rsingh; +Cc: Hao A Wu, Ray Ni, Veeresh Sangolli From: Ranbir Singh <Ranbir.Singh3@Dell.com> The code can reach line 65 only through the else path above at line 53. The else path already has the same NULL check at line 55 and hence the duplicate code lines are totally redundant which can be deleted. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220 Cc: Hao A Wu <hao.a.wu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Co-authored-by: Veeresh Sangolli <veeresh.sangolli@dellteam.com> Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com> --- MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c index d704c62eaab3..1d03d4964025 100644 --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( } } - if (S3InitDevices == NULL) { - return Skip; - } - // // Only need to initialize the controllers that exist in the device list. // -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107000): https://edk2.groups.io/g/devel/message/107000 Mute This Topic: https://groups.io/mt/100212115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue 2023-07-17 11:40 ` [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue Ranbir Singh @ 2023-08-10 2:38 ` Wu, Hao A 2023-09-20 7:14 ` Wu, Hao A 0 siblings, 1 reply; 4+ messages in thread From: Wu, Hao A @ 2023-08-10 2:38 UTC (permalink / raw) To: Ranbir Singh, devel@edk2.groups.io; +Cc: Ni, Ray, Veeresh Sangolli Reviewed-by: Hao A Wu <hao.a.wu@intel.com> Best Regards, Hao Wu > -----Original Message----- > From: Ranbir Singh <rsingh@ventanamicro.com> > Sent: Monday, July 17, 2023 7:40 PM > To: devel@edk2.groups.io; rsingh@ventanamicro.com > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Veeresh > Sangolli <veeresh.sangolli@dellteam.com> > Subject: [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix > DEADCODE Coverity issue > > From: Ranbir Singh <Ranbir.Singh3@Dell.com> > > The code can reach line 65 only through the else path above at line 53. > The else path already has the same NULL check at line 55 and hence the > duplicate code lines are totally redundant which can be deleted. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220 > > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Co-authored-by: Veeresh Sangolli <veeresh.sangolli@dellteam.com> > Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> > Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com> > --- > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > index d704c62eaab3..1d03d4964025 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( > } } - if (S3InitDevices == NULL) {- return Skip;- }- // // Only need to > initialize the controllers that exist in the device list. //-- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107679): https://edk2.groups.io/g/devel/message/107679 Mute This Topic: https://groups.io/mt/100212115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue 2023-08-10 2:38 ` Wu, Hao A @ 2023-09-20 7:14 ` Wu, Hao A 0 siblings, 0 replies; 4+ messages in thread From: Wu, Hao A @ 2023-09-20 7:14 UTC (permalink / raw) To: devel@edk2.groups.io, Wu, Hao A, Ranbir Singh; +Cc: Ni, Ray, Veeresh Sangolli Pushed via: PR - https://github.com/tianocore/edk2/pull/4843 Commit - https://github.com/tianocore/edk2/commit/4317b4824bc881fe6079d04b7ee5b0f6bddf62ca Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wu, Hao > A > Sent: Thursday, August 10, 2023 10:39 AM > To: Ranbir Singh <rsingh@ventanamicro.com>; devel@edk2.groups.io > Cc: Ni, Ray <ray.ni@intel.com>; Veeresh Sangolli > <veeresh.sangolli@dellteam.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] > MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue > > Reviewed-by: Hao A Wu <hao.a.wu@intel.com> > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: Ranbir Singh <rsingh@ventanamicro.com> > > Sent: Monday, July 17, 2023 7:40 PM > > To: devel@edk2.groups.io; rsingh@ventanamicro.com > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; > > Veeresh Sangolli <veeresh.sangolli@dellteam.com> > > Subject: [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix > > DEADCODE Coverity issue > > > > From: Ranbir Singh <Ranbir.Singh3@Dell.com> > > > > The code can reach line 65 only through the else path above at line 53. > > The else path already has the same NULL check at line 55 and hence the > > duplicate code lines are totally redundant which can be deleted. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220 > > > > Cc: Hao A Wu <hao.a.wu@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Co-authored-by: Veeresh Sangolli <veeresh.sangolli@dellteam.com> > > Signed-off-by: Ranbir Singh <Ranbir.Singh3@Dell.com> > > Signed-off-by: Ranbir Singh <rsingh@ventanamicro.com> > > --- > > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > index d704c62eaab3..1d03d4964025 100644 > > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( > > } } - if (S3InitDevices == NULL) {- return Skip;- }- // // Only need to > > initialize the controllers that exist in the device list. //-- > > 2.34.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108898): https://edk2.groups.io/g/devel/message/108898 Mute This Topic: https://groups.io/mt/100212115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-20 7:14 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-17 11:40 [edk2-devel] [PATCH v1 0/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix issues pointed by Coverity Ranbir Singh 2023-07-17 11:40 ` [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue Ranbir Singh 2023-08-10 2:38 ` Wu, Hao A 2023-09-20 7:14 ` Wu, Hao A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox