From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.98813.1683513221161610994 for ; Sun, 07 May 2023 19:33:41 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IErY0Jq9; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683513221; x=1715049221; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yxrnzvJXb6Dkj0PLTp7WjZw8wSGTPr21OGPnq+OCz9k=; b=IErY0Jq9mLqL7hZd7QSWfsM6afNj3LF8hzlKpWCwauk6fou8GyeYje2p ByY/bG3n2FmZk4jLnJfsZx62CJWH4U05OHjue3DeLingByY7H5jeeN4Ut BO1ys6Py6BUQtIp0pekDfGG0VFxt2QxGMJoHh36TkGvoRxaGuQcvBeTX7 ObfdJjbzZ0cOgsvcigho/mAc9vRMbSEg8k0CNacutnZyiIPjRLEmF0/A6 Nt55rRxtuIa/SUFmnUlttH0ONl48WPXgp6YhePSKj/IoCAIirKGzFkCnj fF7gs5qy6HQT6nE74tWRsGp1LW+EnS/JCvZ1dKacjNNd3IGJBIBTO1naA A==; X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="349572004" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="349572004" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2023 19:33:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10703"; a="731122071" X-IronPort-AV: E=Sophos;i="5.99,258,1677571200"; d="scan'208";a="731122071" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 07 May 2023 19:33:39 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 7 May 2023 19:33:38 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 7 May 2023 19:33:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 7 May 2023 19:33:38 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 7 May 2023 19:33:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K6q8wwhr+KvzDah+Wme7cqBDLNYCzJbeJw029AF1ZVcSGnLldu7Shy2WXcXfSU+DmUqkW4U75qqcFH2LTK7a0Fmr9kvOhak3dfFKhIzxuM74GUSp7fEArBqqFXVKHlh4zwZ3aIYakf/MU0PKu7bHVMivvBX33FKYIX+5K9L/fPiavgXlHrBu9B1YARVeDMbM5r/7nv9HGu/nuBGVBWeKlcQNIikYoR3r0nLG9ItqR4/79eNzAiskdclL63T8pJ46ZxF1NU8aMqddZNr7Ztf+SPYgI6OxxY6+zMujdo6Utul2g/79YbS2n+bmQJUsMbWa+iWX6kjqBM8qfJ/f/apYVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lTxO9i0BTyfLAyv0vBuQmmtLvO2k8vus+gyVZP5iEwM=; b=CQCoRXok7Lxaxe6OGNV32Sr5hnUosr89x6e/wQDLcDXqPzbEeRx7wlTi1p5FG8IBsM59IcarSDB9PPLoyupWmEvCwotEpbJ+wsUsLKO2sHA0hBCoelIfmI1p5+v9EW1PUbAziacn4o+CPDNLeC7R4lekSKgd53fhgZ13hLh6Yd6s1IqnZaeWA2XHV0/lu1UfQNAxxO8jzyZUAM/HnqiA/EkLys14mwXjdcHmCTVlOQDHPevHc4qRGjXAxCdMjt/0NIvbxDetLJLhc8CupSVJlp2ympEZZrdLmyUe5EJivJJFqSLoLmVk8dMFrwXnNbrtfw1UZd6mrsAnrvBSYHYaWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SJ1PR11MB6226.namprd11.prod.outlook.com (2603:10b6:a03:45b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.31; Mon, 8 May 2023 02:33:36 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::2210:76b:72c8:e83e]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::2210:76b:72c8:e83e%6]) with mapi id 15.20.6363.032; Mon, 8 May 2023 02:33:36 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "osde@linux.microsoft.com" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , Michael Kubacki , Sean Brogan Subject: Re: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpress Passthru CQs Thread-Topic: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpress Passthru CQs Thread-Index: AQHZeS7dP5FEY4wwDUOTI4Soljfcvq9JavtQgAZNaJA= Date: Mon, 8 May 2023 02:33:35 +0000 Message-ID: References: <20230427173622.10614-1-osde@linux.microsoft.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|SJ1PR11MB6226:EE_ x-ms-office365-filtering-correlation-id: 75e5d2f1-7679-4339-4f55-08db4f6c9fcc x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LWIHwaHG+RJptW78NXZYkC6itJZJRRIQF6B+aRI35P4QJId8hh/JLvpl2z3BJbsxVPFb9zC7xFn4vSZV5gspUu9FiemmgmEFvIt34WwycHSnjMY9NOdk7PH2WR4PLohIzC+r33nFK6as6NHlUFu2miZbShqLW4iV2f1hAGrv+3wD2BDh/4ZH+t5yId8b5Uar8GXO5rTgFkbpXHWdev5WQwEY/27B4lLv5FAd09lTackhoniuyq86CZNMsGTxUl+LMuII3WDRGrhS2vW3hVIF4SV9EPBh4ca86dblMDFuTwcuD6O4BOqXGonnN5DVd1WQrLakdNWVzy6RmwleIgj5QtkRX/UQXBH3pipCNboJhnTeTSOLGM06q9RbD9m6JpY5HYL1FBUc87NMmnz5DDImJFOLKhlt3r53/bPvaqZR8OmCfTBwg/o5uBsoBv1yqpssXw4o69pTVdkSYNfBQMiZKDa8JPVKVWmscUTc+8D4NYecq7q9aiiAwC273KfU5sp4IRsl3yRP4us91tAqct3BLwMx1mT8pOJqldWNPi1Kc19qdk42Z26KP5lGeGm/0zUu5zjw8MnqyEKrye8Trz2iYnPPtQdzWmOuALnaypvgO2uwneRLETAMR4wnDm+aQxkTzewi6qzysCQyi87JxTk6Ig== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199021)(83380400001)(186003)(2906002)(38100700002)(33656002)(86362001)(38070700005)(82960400001)(122000001)(55016003)(52536014)(5660300002)(8936002)(8676002)(966005)(66476007)(66556008)(66446008)(66946007)(64756008)(4326008)(76116006)(41300700001)(7696005)(71200400001)(478600001)(316002)(66899021)(54906003)(6506007)(26005)(53546011)(110136005)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5CoGBSHSdy9zYvn2joWx8VCrb9P1qKTKFf25YTf5FyR8LVAfK5tNp916vlGV?= =?us-ascii?Q?0jjSlo4l7cUI7L43FiGqzrvUvOLFrmYHtXhyeIqZvs6IA9XMzgPgb2vIfSFB?= =?us-ascii?Q?u5fI0mBMZh5Ru4ZLAUKWFmHqzn8y3CAMGt6n4/cJ4TMp3cgm075sRhaM64OA?= =?us-ascii?Q?OHJ2/xvKh3DQiDVMiTCNg8bfLn9FFvWtIvYKLFDhzuEr34s4+TiXS4EDUkq1?= =?us-ascii?Q?u7vKdGnuz63x7FdHwmyTOJlOydUJic5fBjuW9QhMqBpLrVA9yYuf9pqeBhlg?= =?us-ascii?Q?5sGFShFfSEAJZoIF4cuFYNS0QuPSG4w2VrO19YpnehgOWTuxWk0ikdXDxZWc?= =?us-ascii?Q?w+Ei2DkFUnvlA+0f5jDQg3OsDU54/zYdi1m0rAmgQlUxYhXOcjiXqFKAkryB?= =?us-ascii?Q?IISh0wzwpcbCfC1kLp7f4/n0egfDbrOOXjaVXZtLfiYQf3Jgx+rnhbvlh0RB?= =?us-ascii?Q?S6qzMahNeah+B+EPCAHzDUKj6AaTuJcO0tm+/EpIyFtCI2YpRgrMWrfh0mId?= =?us-ascii?Q?97+BMGUuNw8nmB992Lr1GhEFCCdXGV7P5cAug1GkgCTC/b0ciXqh0YgZjzTv?= =?us-ascii?Q?4e4yrjHEYBn7UqM2yjTnSjHrP9bzFIsw+7Pt/RmBWbeIadMUorOrpSx91Wil?= =?us-ascii?Q?5NK377QD44R70SH4Re72oj6GDWadLJsBlZIo6jgrQmEBCbj4Ja5Xmnw+lq64?= =?us-ascii?Q?8QExJzTfCEstOpc6u/TudoT04gcWnUXSjfiIONKwgIXgoQKGlaeKSFFdlz3q?= =?us-ascii?Q?Y0qNJbZKKxNIeSPjji537bIccCIxCS4HKXmSFWGaAIqN5qJbuUOUytjhVnig?= =?us-ascii?Q?sC+WqWXfBdepH+ivUJIm0IxEV/wcseDXQ2NSeaq31R8w1IOkJ+RRM8NjxtYc?= =?us-ascii?Q?Gnyk5pIQMEiAyGRVMFoOuV9c6SnFZgDuDgdPT7a6WZydNa/o9lyVxKxaeKAc?= =?us-ascii?Q?xhxGYO/q+FgwxmPAwgcrNw42xhsWnHMJYbrqMq10ayOZEOg6sk+EeVRW2Cbm?= =?us-ascii?Q?K+86A+g6EXxORRj2eDMWxyc4vjbPgwdK/jOd0+e7vrCBlWxLP5TvGoZlyBlA?= =?us-ascii?Q?nFJZpzkC55uC7JdL6n6i+By/hGFndFQx+IxLyPJg2XxvYyWMjuqtaksa6gUR?= =?us-ascii?Q?vHX/eC1X8foHMHxcPTS4mNvOi0EpK4vbRo4aKx58CvneCKEdb2oPhFkzRkpu?= =?us-ascii?Q?0y+2+XU8hnoEhgENCqFitRFRb0buEn4tVoQrQb8VRMqX2mLu2gnMlJqijFiq?= =?us-ascii?Q?5NbtJ/Ieca0f7GFTD0o1pHlL6JuioCdKop9jYvdx+X/A273duUBd/RnYrEsn?= =?us-ascii?Q?xO+d5rq5K87hsmlUkLunuR6XFk8J5bb7uJR9CO7tMhDqLClW4RTtrsWBvwDa?= =?us-ascii?Q?3kbekMYmL5sDREx/ASirD1q0zw+xgBAy4yWwh/r8gn+6lTQdp3L8pMs6wIPf?= =?us-ascii?Q?tYgJQ1BjC7PHixA8fcyHzQa02J1vcc62hNjSiVc+FAeUzgiHNZOy+5X2ck34?= =?us-ascii?Q?B7wMA/hOFCHP2WXm2oZixPTRUQ8PepdHfimTMCcUZIJ5ig4Norc1e+bAjxDW?= =?us-ascii?Q?GBEPLqcWECr94UgnTpQk8masOBMo1xdhNOJgHGbl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75e5d2f1-7679-4339-4f55-08db4f6c9fcc X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2023 02:33:35.8657 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tRSt3RrdJUTVebWgHpO4HuZ3DtoelVocawOfGx1+aQZia7mNK8RTQT4JpUu5W1lBREXgkK7/B86mEtwl5Fjgtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6226 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed via: PR - https://github.com/tianocore/edk2/pull/4353 Commits: https://github.com/tianocore/edk2/commit/293b97d0c4624c13a4e934294d2c4b161a= 09a91b https://github.com/tianocore/edk2/commit/8dbf868e02c71b407e31f9b41b5266169c= 702812 Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao A > Sent: Thursday, May 4, 2023 10:20 AM > To: devel@edk2.groups.io; osde@linux.microsoft.com > Cc: Ni, Ray ; Wang, Jian J ; Gao= , > Liming ; Michael Kubacki > ; Sean Brogan > Subject: Re: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpres= s > Passthru CQs >=20 > For the series: > Reviewed-by: Hao A Wu >=20 > Will wait a couple of days before merging to see if comments from other > reviewers. >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Oliver > > Smith-Denny > > Sent: Friday, April 28, 2023 1:36 AM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Ni, Ray ; Wang, > > Jian J ; Gao, Liming > > ; Michael Kubacki > > ; Sean Brogan > > > > Subject: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpress > > Passthru CQs > > > > NVMe CQs are hardware queues mapped to EFI memory. > > In the NVMExpress Passthru implementations in PEI and DXE, it has been > > observed that NVMe CQs are not marked volatile, meaning the compiler > > has significant leeway to optimize accesses to these structures. > > > > This led to an issue where the passthru driver waited for a timeout > > period for an NVMe CQ to mark that it was finished with a transaction, > > but the compiler had optimized away the read to the actual HW mapped > > memory, so the transaction had completed but the timeout continued. > > > > Marking the CQs as volatile fixes this issue as the reads happen to > > the actual HW. > > > > Personal GitHub PR: https://github.com/tianocore/edk2/pull/4320 > > Github branch: https://github.com/os-d/edk2/tree/osde/volatile_cq_v2 > > > > Changes v1 =3D> v2: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > - Remove volatile keyword from SQ > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: Michael Kubacki > > Cc: Sean Brogan > > > > > > Oliver Smith-Denny (2): > > Add the volatile keyword to NvmExpressDxe's Passthru CQ > > Add volatile keyword to NvmExpressPei's Passthru CQ > > > > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c | 6 +++--- > > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c | 6 +++--- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > > > -- > > 2.40.0 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#103725): > > https://edk2.groups.io/g/devel/message/103725 > > Mute This Topic: https://groups.io/mt/98541927/1768737 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > >=20 >=20 >=20 >=20 >=20