From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.363.1689136698594206515 for ; Tue, 11 Jul 2023 21:38:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mwaxhmtH; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689136698; x=1720672698; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XmYVpHzI++p5hJ2k9ZzaQ7ATMVxxToiVCllqurpv9hQ=; b=mwaxhmtHDwEZkUfGSYyUhgRizA9ppPihtS65YtswROj0xafd4QmWRzzm Ekfp7hSZ76+JlMUw1Bktd6Qkt7nE5Eon0gkpDnYl8FnTJKJrssmL8Y15k ZTUMJid0qiAP3AVzEidNGVdG/ia/5yrQP9sspUBq9fwfFZJcHEEMzaknC wojy1xq3yY4cjRqXBANFcUC7SOaDr/7Lb/pRXdPWe8LYpPmYWQ2VnLhiR /YxTYQIcTrvEf6DWbvsdW5sl0nLh+9yHga4a2WqSp9WE5gIvnfxvc2kEB yMIi9WzoP3mGyn4SW+WUkTMFm+fOJthKC43j+um+PQHwcJy3Qxakkmcgm w==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="367417276" X-IronPort-AV: E=Sophos;i="6.01,198,1684825200"; d="scan'208";a="367417276" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 21:38:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="895454920" X-IronPort-AV: E=Sophos;i="6.01,198,1684825200"; d="scan'208";a="895454920" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2023 21:38:17 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 11 Jul 2023 21:38:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 11 Jul 2023 21:38:16 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 11 Jul 2023 21:38:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mA/5Pfe4JPbWdGkUT38J2GY9TgUEEpXCh6y0biBnoGaRmfiJ9PwG6SAYk/pZylc+xK9uLXuBTAp8UXz9eicoqQnhicTq1AkVnKJaGpddaPzjJrgHCg6B0jfwatE8DPHHWCvDShyDJHOC3qpIrQhl+wYBPy5cyOQRn7llSi0hAU/7nnucN19NlHnjQVC0uXZP6bhQ5W4KccQKytvQ9vGCLk/yPb6OU4+Cc1EZP5R+4N4nepEncNSbWBWnIh33mUxfjMO7yJWwl963Rb/tC45XeXMKjuxfmLg2RsQImPAJlDX+gOHW780/TbqkV8+RHH80y6NLjWx96MPxACtR0nUYqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CE/jZeSRQSL7gAaXD1W8/EyMZDC7FKfCja0GFa/qOQI=; b=BsJXVWyqklLx5khVP2nEbFasN3GLQLNQi0XdGv0rRXAIUcoe75vRyYlUYWVD7/klOkafmhc9P1NDeMUw4r/1vrzN0Apzqdh4iTYIoDFzQaqoMk49wQ6sDb3ggo5jk5VyFkXQXQrLGH3QOY/K5qaOAvXmQPrwlFmlz/68QopySzaghWoUIqzPmVMMPuWO1aY9cboWIMuh001T33KZoPaQs+udfI+0JLMsz6KPJzSddgU9pgj3CYHspXt2tToMeNGQ1FNBd7g1NZPmJe8UJMA2JqoGTdWiCPUKCRf1R92TG94hGoF4fBXRUxl51fN8J3dORgfdFuNR8Z/ORuYPKmqueg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DS0PR11MB7558.namprd11.prod.outlook.com (2603:10b6:8:148::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.31; Wed, 12 Jul 2023 04:38:14 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30%4]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 04:38:14 +0000 From: "Wu, Hao A" To: Ranbir Singh , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH v2 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue Thread-Topic: [PATCH v2 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue Thread-Index: AQHZms6jFQxQqJyiBEe/Z4y7jA1+fq+1uRfA Date: Wed, 12 Jul 2023 04:38:13 +0000 Message-ID: References: <20230609123322.191390-1-rsingh@ventanamicro.com> <20230609123322.191390-3-rsingh@ventanamicro.com> In-Reply-To: <20230609123322.191390-3-rsingh@ventanamicro.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|DS0PR11MB7558:EE_ x-ms-office365-filtering-correlation-id: 92c6c7dc-9ac4-4d17-ae26-08db8291cdbe x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f0JmEYvX7jA36QJi4NMh5E5OttwRW8L9QBgV7S4HEcPbKBMbHNdRquHDV+c0WM5oBdCrE3HGtKztoaTQsDi4H6H0mlHgRB1zdtgOW1K4VzG/ulkN6RcLyqhCHBSioCczjlJzxgUngbUG/PUZtewJEeO3/AAEvmxR8ZSC+cBUEiVnfIuM5nTTaNYc5Fh+O8TvrcymGCqCO2zo7lIcf0ZmV4XpbdBmz8xhscVkt6CPzfyzc9cSo31NIrRmxLqv5+ztAxqCHpEBQHL+ZcA2WZgfeUQNNuSQx2ByB98foElpcma7uubqtgJHC7ltinm1FyEgl/DCryB3ybSXU51/AjSmFU3tCpLsJrvq+SQ/p9VF/MhYazpnnOuaSyKKwLiRmo4WH0vHaTwXZ6DLmtCE9ssNzrhdJ7MNyp1JIPIiB4pvw9aItgsg+wTaSR4evfzON6vUCPv0GNq27udwa7JtnMDqulM2JmLbInEtohKF0Udv9zN1UnqR3QrnPbk87hJu9dgqj/StGdYD8ViDiMULhEceAE8kp84s1QSq6iR57PTugUxtkWPo2/FxiKIO3q22vXzI+E65fy1ZnWZv3iW8ea9QJddq6+ETrYsysiKmRKmeshw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(376002)(136003)(396003)(39860400002)(366004)(451199021)(33656002)(5660300002)(2906002)(110136005)(71200400001)(7696005)(478600001)(76116006)(41300700001)(66556008)(66946007)(8936002)(316002)(66446008)(64756008)(4326008)(66476007)(9686003)(83380400001)(55016003)(82960400001)(966005)(38100700002)(122000001)(52536014)(86362001)(6506007)(8676002)(107886003)(38070700005)(186003)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GvtQWW52QIKUHA7f/peLcBZlp/ybzAkf5Qe6m7U0MyQA1Yhjh2/9SWlObmHB?= =?us-ascii?Q?nT+RpGo+7CRGqfBRYH6v0zpceDP0Zw1cmqlQG7cdwJUA7H+MOYgAFYvfAQR1?= =?us-ascii?Q?paiDExF0YzX+qlmBbi6wKOWQitT9SkVPIE8E6xHh5lQ/z1hX5ztLLc5Ieri/?= =?us-ascii?Q?kSfVSOIeyPKAIcbeSWBvcTxw8UiyBeZUoh2XSswDyyrx5p09woQshIthC4Ze?= =?us-ascii?Q?fCxX7xmnzt79fMnjAjb/JhIwsz8Vb8qsj0f6pYokTQq65BchlYbWmp8BVqQd?= =?us-ascii?Q?uwiw5js1jBXV6BTc3YLNEo0bkRMk8kN3esBfRn3wwXg+RTlWE5CG3AHVNcYS?= =?us-ascii?Q?FjmZkIKwU+5eXVm1rouuqSrPwFyYfNVsQdzok5TpdqDYUJVIunhKewzsPWtt?= =?us-ascii?Q?LBsWpAm+alJHgIl9oju8mrWXiIdjS5N9aggdaCoLf8ERXW3ZNvqcPnQL8sjy?= =?us-ascii?Q?BR46hLDC34UjH1NEKwHpydixw4bk5XcBuvqizPrKDqVsO6EXeBRcA3+KIWQA?= =?us-ascii?Q?O4fACvy+eIuYIlKNwOAoqT+jDgz9/8DsT8h0lzHzjIuVjZR5jFumI+ZyDxfN?= =?us-ascii?Q?/a5oip7Q7+HZaqCme+qXBxt/0u/k4H0XZ35F280mq2ungR1v2bq4yLVwaTLq?= =?us-ascii?Q?aZQpLpae0nvHH6pt2+MM8F4U2R7+dbBj5YIwDCioZyn92TWBVzIINOBShH6R?= =?us-ascii?Q?aA6bwID/WLfHu2tzbOwNLHiCW18yxbz9tG7SXf1epXC7YlVHeo/QXLnq6b8Q?= =?us-ascii?Q?x3NGRlD0HuDmwwQ0rSKoEte+o1J52059ilAbNJ8tnbod3bIqgiM0KEVDO7Wc?= =?us-ascii?Q?n2ufRDI45UBlwdVvc6WdTyBtkkOcxBCsiDpn5yOJJQf4g5m20koLyzZXppxc?= =?us-ascii?Q?dvSvUtTpzySaWHJm4UO+f5N/Roh6FB+z1E9FNFE8+57h7YT78kNMD4bybN0i?= =?us-ascii?Q?KcXtNuQirkngM46PkRA22dwlUPzRDtOSoRFf0GNBj6PwpRmfFZm25qrD2Tmc?= =?us-ascii?Q?LH0tl0E46Az5QJm6i5wrUWky9oF4JY6o6SqcGeJygD4Z1HdCQnHjel9YTvCd?= =?us-ascii?Q?KMCQTJrwJr0Zlwpnyl9G9TtDid8thImyQqdD77AA53kc3KWLgewYZnuiUvTt?= =?us-ascii?Q?G1ug9N2G5aXTW3OmPSRrcEL5gUWxmbQIbPxgWC5Gx9BI89IC3FtTYAm3XhtA?= =?us-ascii?Q?i71jdes3UhA1uS64iZlRQX0ABPxIMJoNIGAQJ6aXbo/RAS0oLh5tM+8bmUf9?= =?us-ascii?Q?cSOgCdkUo+IBfi7jKKyiDFZ1lSdWGF6M0T6/1c5hYBWAmWY6t8qYaNydm65M?= =?us-ascii?Q?JEUrfkErpUiVu+1ddTEJgLXFdsGO9Foo1XDscastan0jcbmXoUIzUguvDp30?= =?us-ascii?Q?0F0Ru3wOhNIEKH3oea5diC1gRFHMrUXge/vKeKvXWsTbxLGeuXsaXWItOJB4?= =?us-ascii?Q?/zBdl4YSCuGPV0sarZAgyCsIWWRZoIyBwWWs4y4yIpBwSdvyXEvIqIdwoVrs?= =?us-ascii?Q?/eKwXtmEGIaZ9L6JQ3b+DYNMjaRuLmu4rF66hmP4kP1hPjstlF9DmiwxMQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92c6c7dc-9ac4-4d17-ae26-08db8291cdbe X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2023 04:38:13.6747 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3YzUwvle5f+ULz4cRynfrvuzTfHivj3MDRT4+iHWwGPxaJqcIkRz0TN7EAcgF8P5j/es25eUF69Gh/H4Je6CgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7558 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Really sorry, After referring to the Information Technology - AT Attachment with Packet I= nterface (ATA/ATAPI) Specification, It seems to me that the commands being executed in function SetDriveParamet= ers() are not mandatory during device initialization. 1. INITIALIZE DEVICE PARAMETERS command (ID 0x91h): This command got obsoleted since ATA/ATAPI-6 spec version. Also, the return status of SetDriveParameters() is irrelevant with the exec= ution result of this command. 2. SET MULTIPLE MODE command (ID 0xC6h): My take is that this command is necessary if there is subsequent usage of c= ommand READ MULTIPLE, READ MULTIPLE EXT, WRITE MULTIPLE, or WRITE MULTIPLE = EXT. I do not find usage of the above 4 commands within edk2, so I think the suc= cessful execution of SET MULTIPLE MODE command is not mandatory for detecti= ng hard disk device. Based on the above findings, could you help to update the patch to: Status =3D SetDriveParameters (Instance, IdeChannel, IdeDevice, &Driv= eParameters, NULL); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_WARN, "Set Drive Parameters Fail, Status =3D %r\n", S= tatus)); } Will doing so still please Coverity? Best Regards, Hao Wu > -----Original Message----- > From: Ranbir Singh > Sent: Friday, June 9, 2023 8:33 PM > To: devel@edk2.groups.io; rsingh@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH v2 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix > UNUSED_VALUE Coverity issue >=20 > From: Ranbir Singh >=20 > The return value stored in Status after call to SetDriveParameters > is not made of any use thereafter and hence it remains as UNUSED. >=20 > Add error check as is done after calls to SetDeviceTransferMode. >=20 > Cc: Hao A Wu > Cc: Ray Ni > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4204 > Signed-off-by: Ranbir Singh > Signed-off-by: Ranbir Singh > --- >=20 > Notes: > Add error check instead of Status storage removal >=20 > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > index 75403886e44a..d04b1d95a7f5 100644 > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > @@ -2549,13 +2549,18 @@ DetectAndConfigIdeDevice ( > // >=20 > if (DeviceType =3D=3D EfiIdeHarddisk) { >=20 > // >=20 > - // Init driver parameters >=20 > + // Init drive parameters >=20 > // >=20 > DriveParameters.Sector =3D (UINT8)((ATA5_IDENTIFY_DATA > *)(&Buffer.AtaData))->sectors_per_track; >=20 > DriveParameters.Heads =3D (UINT8)(((ATA5_IDENTIFY_DATA > *)(&Buffer.AtaData))->heads - 1); >=20 > DriveParameters.MultipleSector =3D (UINT8)((ATA5_IDENTIFY_DATA > *)(&Buffer.AtaData))->multi_sector_cmd_max_sct_cnt; >=20 >=20 >=20 > Status =3D SetDriveParameters (Instance, IdeChannel, IdeDevice, > &DriveParameters, NULL); >=20 > + >=20 > + if (EFI_ERROR (Status)) { >=20 > + DEBUG ((DEBUG_ERROR, "Set Drive Parameters Fail, Status =3D %r\n= ", > Status)); >=20 > + continue; >=20 > + } >=20 > } >=20 >=20 >=20 > // >=20 > -- > 2.34.1