From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.471.1689137327380148185 for ; Tue, 11 Jul 2023 21:48:47 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nN7GJrhx; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689137327; x=1720673327; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=SD2KiPTEA6Ys78GP7SMIOwRoXuhBvMC2A/YOujV8bIw=; b=nN7GJrhxwUi+3EnFhF/VSHrN1vLv/z+uJE2a28ZGZyxuB1HLWk+H3BwX uusgGeAS/I4IZan6+Swd7JCF99EWrPr/obF3uigTkd0aLUiY1iY1L1uS2 /zSnTJqQW6c0s1nTBC4ArE0oZhIt0s9fbutdNNXoDTpPQUpOuomfoa6CJ IWBiJ4qtTwZVYRoaST/+qzyB7/aeuZpy5PFgkUcdRhfPbExzCoZs/XEa2 6dvElkHOF/qJq2g4vfjat1Dk8Nrk459TkUSNFbfElHabrkLQr0AySf/ET mWHMaj2bIn17KHZ5nWj4pxSezgOIMaAX4HTIZEIplNJbeTOOx2OI00JiC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="367418410" X-IronPort-AV: E=Sophos;i="6.01,198,1684825200"; d="scan'208";a="367418410" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 21:48:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10768"; a="865972235" X-IronPort-AV: E=Sophos;i="6.01,198,1684825200"; d="scan'208";a="865972235" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 11 Jul 2023 21:48:46 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 11 Jul 2023 21:48:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 11 Jul 2023 21:48:46 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 11 Jul 2023 21:48:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+aqta7I0dtqNVc5MXjf8YkGkCzfrnrofpgYPZnc3rtQdB/nPhpqVHRk7xcOmaJ5E7rubFYlSftPSQT25WwVOkuJAuxXXyfgudGwrlZRDi8d6mgYKvzrM1X55DaOm2RdHtzpNZDabneDubBPcKpN6s/E3dqq7dSzEZSpH8RqNinHtq8ac4P+RuFAvV8a+smc3G/C6BhnSy6KSN89NuybuHW+vzu3iGTnFjKKVDFP4lntTgXqGkmjg6YFnEte2oh0CJ/TXJH392bnWPIWirsEiVeh48ix5FLvmXC9qdsqdPuFYkM2kRLj7Gfc8kqGmQnG9sLiX06cXjS+PfdHTsSD1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gxLD3+u7mXFPp/L0JAc63vMbxp6LG8f7WPouVoThiC8=; b=XhUzKuE71QzT9BCs63ZVLb36CeD/U5u4hdDSGsRU7AtYBoywYtxffpK8FfoeKgAg38s77XsMnKd0Lp4q7JC/VMP9OcuQ2/X0vMjIfk2dwwaME/5MtOUOkYglqqDpOmNP8oIcIceG+ma6M/GgEKgrKCgQiQS/ivSR020AQ20vgRsPpEW56l3a7HyijQPLi6dCX1UsKv5gnUlzXt0dgPQD3HCbxAk9ThmuVNjbWaYCljbLuKp7W5UUPWSV7lTDwS36t3D47n8KJ04q4G4dxuaBcgSOMjjZFuM1GH8c/Nj4KGSiZlDLZqMvHP/rkP5tEIljfOWyfc6RGCU54Tt9xEygcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM3PR11MB8736.namprd11.prod.outlook.com (2603:10b6:0:47::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 04:48:38 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30%4]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 04:48:38 +0000 From: "Wu, Hao A" To: Ranbir Singh , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWARD_NULL Coverity issues Thread-Topic: [PATCH 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWARD_NULL Coverity issues Thread-Index: AQHZraPEsIKQNTz6+UOPA4FxaM0KpK+1nO6g Date: Wed, 12 Jul 2023 04:48:38 +0000 Message-ID: References: <20230703114424.227779-1-rsingh@ventanamicro.com> In-Reply-To: <20230703114424.227779-1-rsingh@ventanamicro.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|DM3PR11MB8736:EE_ x-ms-office365-filtering-correlation-id: 6ba0bfba-483e-42db-48cf-08db82934257 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /s2Z/ppy5NsWNmy1R8zkwnqsl4SgRCHW0xaPmFyAHSK+QWc9RDdzAO48rVADpj5PABog/1g5VMRZoRJLiKzEczs7TQMzc3OeUX3BZW4+ITRE5uJe3H1Xu5Hwu+2RfnmqiV8zBS8Rm2IipaO6KPenqZ0Rpt7+mO7O6Zrsgj4WV3pOo29yvI1UgxjT4ba9l6XtvVnm289O1+haU8sSDURvuLKBsy0xzmMCbSa/HI3tL56HFpbGUQXbdFYDuEInf7bxkibAw0RaFoZOhUwCTWqoBKCvZAGm9tJuVefJlZSVpkm3oiZdGLz/f7uwsF+cEO7BPfgmLTVJa33nwnzCFcUlUKha2a2ujTefI7NQJFQW1LrHpVHv2KjIwOjKQSPWCjNASM+QeJObW6K40Zyt1RvJ47HNx1THzT29dN26YfXec1ObFLN/U/orS4VfjlPWYYhC1VnN6qu2L3/CsZacJmczBjraVRuGJCCXPXIgbkzRbVtZwcCAi50YLqTMGGAT266uStrl4+cYpQqD81moRXGJVr3CBOigqxzaBOLNo9TF9P73bL4Pa5lI7r114vxIEzVV3R0vuv/3k74CbH8UEWWWVbIb449+1WxmzaAgHZo6E50= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(346002)(39860400002)(376002)(136003)(366004)(451199021)(7696005)(186003)(122000001)(55016003)(82960400001)(86362001)(71200400001)(478600001)(110136005)(53546011)(52536014)(6506007)(9686003)(38070700005)(316002)(107886003)(8936002)(8676002)(41300700001)(5660300002)(83380400001)(966005)(33656002)(66446008)(66476007)(66556008)(64756008)(66946007)(4326008)(38100700002)(2906002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vCQ7pa0slqaTVlnsY1iP0bJU3oPWc6q0A1zZzy2OYbA5f/+g0eraBBkfAJL9?= =?us-ascii?Q?4pi8Kr1rSCoMdokL2Sn197GEV+hK5OpMsRJFwZbVsKkUjU4eJnr2a+nqZ4pt?= =?us-ascii?Q?+McjLPBnpi9Y1PfbBc0WVGliGiZucLhooP0As30YT56T+r4p9nhZSGQ9UDHH?= =?us-ascii?Q?rsbeQuGBHBmj6GYzLCKUc6t6qhn18U+TWBLww+NYvJRM6gCvRFOWR/TzNbfP?= =?us-ascii?Q?FXa1z1/9havJswbnIZCNXJv3occNl6RNB7v5APYucpNfrpRyMSeTQJ+85fte?= =?us-ascii?Q?KjwyFog9dgI+cKRcKaS0Uq6nQCFsRDpWNJ0lbJbuFi39LNmhvUzwoEDWja1P?= =?us-ascii?Q?1Flf9tyQreYRoxahN6VS3ZpCo+OKghBslxNyaNq1SINOEwR5jT4l+9cf5Gzp?= =?us-ascii?Q?1tgEnS1c/ekJOFFDyM/HdoY9KFl7X71cHkeaH8IHtM46lrqoSe2AqI+lzhPE?= =?us-ascii?Q?O4SAtrjuOLY+UmsjMeojBrk5X5BOIZhtnHnvssosii1RntHIJJCjSdsXTZ5H?= =?us-ascii?Q?cpgiiut9RPoH450V+WqWGFLbvZR9flhfBk3nL1OOEN1RDpQiyUj81Z+qG0Br?= =?us-ascii?Q?d4M5kTyqDwFw4mwBSe95Sxo1apmsn1KzC90LFU1EIUCbs4eEiZox6qXapRA6?= =?us-ascii?Q?Z+Gjf7uIfjgfLidVYYnfrilBcVkKtNSNLGNARtNemvvSt1Kex6PFEZGRowqV?= =?us-ascii?Q?MK9O02gp8K70Fl0Fj+5C6pYCvVcPRK3QN/JkorXO96NqyzrXXZ8keLBjxNta?= =?us-ascii?Q?JzliX209h1RUj9bO8nUsoAK6WukJb9tZjDGARWuE7lfFNuAMEN9C1xqnc19Y?= =?us-ascii?Q?/8RpAxOFte/DNiADNSdM5rCTwTphfpg4xwGxUL/1apBl3J5m1Sz8f45k4t28?= =?us-ascii?Q?QD83fpSJM91Uu00IPjhgv/cB/B+86C2cnAa5McN2pHkzcgK7ZB7AG7aqonLe?= =?us-ascii?Q?wdje4bNlMzn3Z0s6hcuvGzi378ZniWOiD25u/224c+ypBtYxQCTnxbW+TMZX?= =?us-ascii?Q?57geL8WFDYCjVqkKC0A8hiuzK7vh9bXV383xXfd5Hy2LtdWUoBkZ8DN+rbG4?= =?us-ascii?Q?piEaXjbyN6EF/d9Df7fcHKhhHKB01a6INqkXxQAS/qXaaHtnfpOF2wfi8yrg?= =?us-ascii?Q?3y07V/vTpzYd+xyOvMbZE0PQqrpjs2IFIM42qCdU2W1uu/5YZHVHi6uUReuU?= =?us-ascii?Q?BWQG12m1gDXPc3iWCw5FM7QGxWHMDvP8cq0lRK6xQsVYsMByx9uPGJ4CKj3x?= =?us-ascii?Q?bzYYEi/5g7YzxA4vhb1PGtBNCasu6+8x7pIS1eZZ/ORoceVAe2hxXWHTDgKT?= =?us-ascii?Q?Oc2F6DwsIObTBkE034qxS/aePQM5VrIoGHzTvRo1E4UUGaQUrA5gDAjx0TWM?= =?us-ascii?Q?GRiMaWL4rHW2iQ3aPDtMrAJWQkhCNENTUP6lHNxyDAgOUvcjcSqJxNwDM+bU?= =?us-ascii?Q?GunjdcRevcV05HQqgxfFE0lU9dkiTsjxKICUINTnD3zq58VVNX0zus3x37LY?= =?us-ascii?Q?/SksU6I/FrVQHPQKrq2xXfwJX2eDwpoWkwyLIHyv6j7oxoHWjq9YXwGxrg?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ba0bfba-483e-42db-48cf-08db82934257 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2023 04:48:38.7583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qzbxPPRfr/XkXGxC30Q3ewEXeYj7atMcoKpJ28HHwUVy52Pus/IKNKp4vfbgnat2IDRPIovSDC+41OYHTeLhhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR11MB8736 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: Ranbir Singh > Sent: Monday, July 3, 2023 7:44 PM > To: devel@edk2.groups.io; rsingh@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH 1/1] MdeModulePkg/Bus/Pci/EhciDxe: Fix FORWARD_NULL > Coverity issues >=20 > From: Ranbir Singh >=20 > The function UsbHcGetPciAddressForHostMem has >=20 > ASSERT ((Block !=3D NULL)); >=20 > and the UsbHcFreeMem has >=20 > ASSERT (Block !=3D NULL); >=20 > statement after for loop, but these are applicable only in DEBUG mode. > In RELEASE mode, if for whatever reasons there is no match inside the > for loop and the loop exits because of Block !=3D NULL; condition, then > there is no "Block" NULL pointer check afterwards and the code proceeds > to do dereferencing "Block" which will lead to CRASH. >=20 > Hence, for safety add NULL pointer checks always. >=20 > Cc: Hao A Wu > Cc: Ray Ni > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4210 > Signed-off-by: Ranbir Singh > Signed-off-by: Ranbir Singh > --- > MdeModulePkg/Bus/Pci/EhciDxe/UsbHcMem.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/UsbHcMem.c > b/MdeModulePkg/Bus/Pci/EhciDxe/UsbHcMem.c > index 0a3ceb9f711a..79575b6f6304 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/UsbHcMem.c > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/UsbHcMem.c > @@ -250,6 +250,11 @@ UsbHcGetPciAddressForHostMem ( > } >=20 >=20 >=20 > ASSERT ((Block !=3D NULL)); >=20 > + >=20 > + if (Block =3D=3D NULL) { >=20 > + return 0; >=20 > + } >=20 > + >=20 > // >=20 > // calculate the pci memory address for host memory address. >=20 > // >=20 > @@ -536,6 +541,10 @@ UsbHcFreeMem ( > // >=20 > ASSERT (Block !=3D NULL); >=20 >=20 >=20 > + if (Block =3D=3D NULL) { >=20 > + return; >=20 > + } >=20 > + >=20 > // >=20 > // Release the current memory block if it is empty and not the head >=20 > // >=20 > -- > 2.34.1