From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.12530.1689314033640661425 for ; Thu, 13 Jul 2023 22:53:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=YDtxi9GB; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689314033; x=1720850033; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uL2wLvuwrNDm28bvaX9ynyXOy64p6LrvzGDLRrLuJ1c=; b=YDtxi9GBybFMlBXNjvkpsZw/vgG6plFOn4RfB2DZ2KEnT7rzNiia9W8S jCXe6Q83YmfEkdC7M5YGFRqd7nF4FEMLdLQpjQrZAPy+0EY4cPZKV4FAR DNg69aCz3gyxje82bxYQJQ1Ke9TEOH8Nr8h771fJ90rY75XsSrfwChvZB h0IB8Y/ja6arKF9igMuxU9tRXxOTBxlBC3mDo+no6CCESMILyX3htFkh+ jpfaoC6xDI4vzjyRsYTLOCp4l4ohnNGfKQI1R8fv+2thMJwbqqrgRcynm XiF0sBEFlpzo6czQQFJo5yR01C/H7CrWMV66ZEkGQqFQxMjDX56DcClgM g==; X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="350269448" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="350269448" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 22:53:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10770"; a="757452203" X-IronPort-AV: E=Sophos;i="6.01,204,1684825200"; d="scan'208";a="757452203" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 13 Jul 2023 22:53:36 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 13 Jul 2023 22:53:36 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 13 Jul 2023 22:53:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 13 Jul 2023 22:53:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 13 Jul 2023 22:53:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUyCkSWF3Gm414HcXE86T9oKJVVkqqGwvuXpKyKctlMmwWJH3TEDPAN8wG1SlzanxB4JtMUTHX9wiiqD9Ykp7VYH4fJ0RvO7UGqFwVfGQMa2gsmBSENT5Rb+EATzEgJkgJHf4VZliZH7nwefD0o/1H2RT6bq4bsnzGrYD/gYGJqRvvTNdZ3t9ZwndS78kppxuMGN0GIn9keTnOlRZDbCJFW+W0DLlckBmKS0qT5sIQ6EHxk2cJXkV8r24eJNErfG3xPYNXXoAPoTnn80CfZy/V7wOMSoEt/8o8o6mHcs92zKEOBBIwVhQXd5UT1ff6OV64a5KIjuBaBNQ9ZfJsTcKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q7qtYgkfjMb6rTrIvzO2SVNmLyhxTTIMjEaMKm3SZiw=; b=fkYiG8dA7g7MQKTafcXA4kDVpSGeJOIlPfhXTq+NshS3ODlnGc6qkgNrEnZBhhK6wdAS3GbHgKnnuNZfRIac0vlhnvwkqvdqe/6cZjlCMPNxdwlajUU5aZ0hkAjn4mEGdAsx7p4nq+VIK2sYtYBKNC8kU+UQAbu6yA/QwAJDRNv93dfWnizZzuvckNrKjB56sRcfzKFSFOKtaScP9R1xgSUaOdz5ouPE554/iIwAYW/yXU1CMB6SOaTdPJV6GF3cmhDXuXrziAk/VUVOiopNsitV8KtX86DdtIkj2AzRCZwFJGDmArrx+LjBc8f0ZppVEXDdeL3KmsFZoXlfqSd/Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by MN2PR11MB4598.namprd11.prod.outlook.com (2603:10b6:208:26f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27; Fri, 14 Jul 2023 05:53:33 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::9c7e:53ba:995f:bc30%4]) with mapi id 15.20.6588.027; Fri, 14 Jul 2023 05:53:33 +0000 From: "Wu, Hao A" To: Ranbir Singh , Ard Biesheuvel , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue Thread-Topic: [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix UNUSED_VALUE Coverity issue Thread-Index: AQHZtam8/vxD1E4xcUaAapXXDMRiya+4vtzg Date: Fri, 14 Jul 2023 05:53:32 +0000 Message-ID: References: <20230713164715.1734745-1-rsingh@ventanamicro.com> <20230713164715.1734745-3-rsingh@ventanamicro.com> In-Reply-To: <20230713164715.1734745-3-rsingh@ventanamicro.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|MN2PR11MB4598:EE_ x-ms-office365-filtering-correlation-id: 0a99e08f-d720-4add-b8db-08db842ea81f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ReoQk/jH9upqPG25izYJvYz1Lydbjcw7Vpc8oBkQbGoSnFcAbocgs2rR0m3cI+kVWj3BiZ3aeWwBFEpugk1bYBxooalBPlLmADuNEb/DSR4sFz9nBEvjsHGWs+6ww0OCbTU36fsjbgn6uPqU0p8YNVPsCJ+M7wU+DaV5ozfFr0mZFXPes97xChlzT5AiueqtaRv17LIioYWiiTo8fM39QV6lWTRKAilz7iku0H/VCyY/TWPMIfBQ3mqAtj2qte8xmfbDuS0bCAXsFun/1CHnaJXf4grEWvikZNrM47nPpkYHYrx7+1YyizRAndHCVqlwrvHb3ekec37ieUaTG6zk7QBMUwrqBEGTooTYcxmv6ZmcIx8pxjUvXgVD2oLw7q6bTk28Q8DuJjRuCCwSt2EuNkj06TnkWYY+KcXeugVW/9upgd0k0MqDVn3cgqlQjYPL02wNvgaSF7i/H6kZlwQUkdhVwL2idFNMaTnD6sZ882Qrp4xfuqk7TkefJ5ZgYxdV7VFo4p3SO6ktAnWrtJtrTLBdwOS5BGE0sujvINf9DSzEYljYwc2UGQ9z6NUsODL60/iAJmgi30PmNfMj4clfMKVYyHdd9b/nAs2EFjgV6U1Qw8daLQkrdg4lBbQymYJokG7rimNxlE7WcYV+00N01g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(136003)(376002)(396003)(39860400002)(346002)(451199021)(316002)(8676002)(76116006)(66946007)(8936002)(41300700001)(107886003)(55016003)(110136005)(52536014)(4326008)(66476007)(66446008)(64756008)(66556008)(5660300002)(2906002)(478600001)(71200400001)(966005)(7696005)(82960400001)(86362001)(26005)(6506007)(53546011)(9686003)(186003)(33656002)(83380400001)(38070700005)(38100700002)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WlcURgtpb/+8LRGUzjfY4vkTBA2NZAZPD/sJqlKRSDqtAtbY5WB0/BMqZe1z?= =?us-ascii?Q?o3KCsR2qTvDq8ToByFNeJ4cnWdF0/zNlT0VDLy3wMfsaSRaTKz51IcFOIVC/?= =?us-ascii?Q?D5ntV1ZzLuEExtUBuDreUEfW1C1u4i9KiEhjBz/El4/uBER8lpOC/UbiD7AA?= =?us-ascii?Q?XWLReW/xG8DWWYQE4rRg6Zyluwk7Fcu60feeBMyA806/e8+w4r3Nn+mUW3w0?= =?us-ascii?Q?MIi0I26ZlodqJlEGXg0MyvYZy+B4fkCI5mKGVfWRumCJw8PUtSr2nNj8WxqL?= =?us-ascii?Q?lc0Nd8bhIQhkS8z8byleFXnSyrsSTbIHmtnRw46Oy3i6tJDEfPT1Xtg5UWp6?= =?us-ascii?Q?cX/S9zjAZ9KNu6qliDBYe8kPma8hZaR3F0a0/H0mMHZ3F3WR/04bNEqccIel?= =?us-ascii?Q?bkABFYlCZCU4/OrTkceUOp+yNdpOQBlevW1ZpyvANCG1Mx+AS+v5qvvqLhoj?= =?us-ascii?Q?P8Ve5ONWWHqoSvtT/mEILppTJ0CUSC9ckxNLC247V5bKTY/2x0z3NWlEAGcz?= =?us-ascii?Q?ZE6LvDR29IZM33lVl5/hqPf9CqvEFifPO1FjXS0G7RolnzYjfsSJpMImph/S?= =?us-ascii?Q?0UKepDMdrVteL8E7oP3SI0jRqqe59wjQfYFi5K35c9x/Sd0cGw/w4l+/XEcs?= =?us-ascii?Q?5vTbCfHM0RLAUl+V+e6jK08cnPKZgiH6KYYDd+rd26rfaOkqN9yceBbkKbV8?= =?us-ascii?Q?C783v/ss6Zz8y25QtS+wuktAgsSApXL7+sbTmXecCummS+gszgwmY4YnNn9t?= =?us-ascii?Q?KXm+CXv5Ib7rc/+dUWeLhHU343e4t7+u9M0G2Zyp50YQgzvI95Dq2yydZQop?= =?us-ascii?Q?LGYIFDOGbNqMiM0Zv2216ck/TmL6q6FgA3CPJvnD+HD6VQfoNJd3jZoO5w2o?= =?us-ascii?Q?ObgugejNxmVrFgXurzKYzD8AV/TZGn+r/dqmClRzFElSwKqrgRUD7Cs5Cwmx?= =?us-ascii?Q?VX92A9+ul+w+8BREZMgFrF0XI0SkyMXrRr5AoEbuD5obuSqVM684qvqAJ3cM?= =?us-ascii?Q?rQBlJa4Y/JjREX5b3a99KyIZaPOlozIp2lJZkGzJW8M64E9CEc60RPFDQnPE?= =?us-ascii?Q?EtP0GUdTZS0AHrt5zDA/faJODpRTditlp7sWBS2io8ZaTMcUdXpnK0JHmlQ/?= =?us-ascii?Q?XlaHBOo3CJzYRDK6GWWRzv+b72a/qr5495ULAEc4idLYi2Qfm3HUX6C3pi+c?= =?us-ascii?Q?j4+9ZPYtxJYOW2V2mCCSqb5cSA7aN60DoSSGdAHpKyEZCxtZSncJT/aGiMi2?= =?us-ascii?Q?7NyVtVFtfZFHIgaydM2h3FQE7bYOaEaVliEp03VlCG7vwZkJ5WXo/Vv0l5Uv?= =?us-ascii?Q?WoAdUIbYNGFaSUoDedWh6vNm+EPNFqXDZqvc/Yw94II7vmvN+WnHyU//M4Cw?= =?us-ascii?Q?HylLMeiXyBiiE79xfWhwsUJU40NZwB9tzMOp+4fabpkjYAT3V7eZpmHnmcJI?= =?us-ascii?Q?n9NRdSY9fs2dXyaEXx4PKGYl4kwoXz8l2hlcsqsJSdNdXPbE9MRc/KKkQ8Jb?= =?us-ascii?Q?m6CZfvLVW1B+i4K81W47SwQ8NxAThzxSboNdglNwp0sfb8O1HoN3NmnJV9FB?= =?us-ascii?Q?H50cwX0Ijyu1qmp5vTBMT+A5Ca3y24MwfpCSAUVx?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a99e08f-d720-4add-b8db-08db842ea81f X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2023 05:53:32.6949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SDR+2+LWP+ZL9DZKLSEBPDm/2M4sn4o+B+2fLdBfBmEp8LJJJgfGG3stT9QjFdZ/NVLhnFFD6+/43k4fOv+QDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4598 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ranbir Singh > Sent: Friday, July 14, 2023 12:47 AM > To: devel@edk2.groups.io; rsingh@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH v3 2/2] MdeModulePkg/Bus/Ata/AtaAtapiPassThru: Fix > UNUSED_VALUE Coverity issue >=20 > From: Ranbir Singh >=20 > The return value stored in Status after call to SetDriveParameters is not= made > of any use thereafter and hence it remains as UNUSED. >=20 > Add error check as is done after calls to SetDeviceTransferMode. >=20 > Cc: Hao A Wu > Cc: Ray Ni > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4204 > Signed-off-by: Ranbir Singh > Signed-off-by: Ranbir Singh > --- > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > index 75403886e44a..af022139cf02 100644 > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/IdeMode.c > @@ -2549,13 +2549,21 @@ DetectAndConfigIdeDevice ( > // >=20 > if (DeviceType =3D=3D EfiIdeHarddisk) { >=20 > // >=20 > - // Init driver parameters >=20 > + // Init drive parameters >=20 > // >=20 > DriveParameters.Sector =3D (UINT8)((ATA5_IDENTIFY_DATA > *)(&Buffer.AtaData))->sectors_per_track; >=20 > DriveParameters.Heads =3D (UINT8)(((ATA5_IDENTIFY_DATA > *)(&Buffer.AtaData))->heads - 1); >=20 > DriveParameters.MultipleSector =3D (UINT8)((ATA5_IDENTIFY_DATA > *)(&Buffer.AtaData))->multi_sector_cmd_max_sct_cnt; >=20 >=20 >=20 > Status =3D SetDriveParameters (Instance, IdeChannel, IdeDevice, > &DriveParameters, NULL); >=20 > + >=20 > + if (EFI_ERROR (Status)) { >=20 > + DEBUG ((DEBUG_WARN, "Set Drive Parameters Fail, Status =3D %r\n"= , > + Status)); >=20 > + // >=20 > + // Ignore warning and proceed normally >=20 > + // >=20 > + Status =3D EFI_SUCCESS; To please both sides, how about: 1. Remove the 'Status' assignment of the return value from SetDriveParamete= rs() Based on my findings (https://edk2.groups.io/g/devel/message/106844), the successful execution of SetDriveParameters() is not mandatory for initializ= ing IDE mode hard disk device. 2. Add DEBUG_WARN level debug message within SetDriveParameters() function In function SetDriveParameters, for the 2 calls of AtaNonDataCommandIn (one for the INITIALIZE DEVICE PARAMETERS command and the other for SET MULTIPLE MODE command), if the return status is not EFI_SUCCESS, add debug message t= o display the information. Best Regards, Hao Wu >=20 > + } >=20 > } >=20 >=20 >=20 > // >=20 > -- > 2.34.1