From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.119.1686018304482662020 for ; Mon, 05 Jun 2023 19:25:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=C0LQ3cRr; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686018304; x=1717554304; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=kXsOfSbX6MouKPBFzDMY3e9f/+tqeqSWj61Wq+n8mwU=; b=C0LQ3cRrlA2r5Lh4bPaEeezAb1oJaR13PuHs02g2Ho/TNXQrrw8N9qBH 3fRY7d079E8CTkpBL2acKWWm1lQDelAL2yLm/OcEOiM1Tl890qvjlFulk OHgn0piWHvUq/wfyNG2ix56PPc/0sNemD9alzzqUTBf6SKhI6Yo8IoZlI 9dUj0RIZYL6xffxEj9fUEXGhaTvE6wcq+Gv5ZwcCd93H6HnpB5KA9AVDS LolIxv4CzMzsjt3MtTJoWdzwhhVFhlggJvuSc4vA7pS/DJZwdJb2jkz0h my3scZxUB+k9meqQqB6GDV37wwHaAsJucwQ630R2c8q2Vssh7dh+mYBmi A==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="359856840" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208,217";a="359856840" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 19:25:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="1039002704" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208,217";a="1039002704" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 05 Jun 2023 19:25:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 5 Jun 2023 19:25:02 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 5 Jun 2023 19:25:02 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 5 Jun 2023 19:25:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JrkahhO+m2al9nIk9QgiyiG3SETkEDDDoTlZhQLjAqtmGO7ROkl0jKSHKKCuR3WU+sGTuTFx5tqHtQLNXtx8FMlhecRJ0GRxHA8GhxDfdZEF+NsVItIP8pmxzIomUA4af2E8EqZjuV8IoCuTd5KWkYT2iEBk3zWwepVHJrpwOEJvGHaTpjKgLeJ/Kj2091p95xOKAo4AhggYNZI08Uvb+auXVwwv2QGuaOPWlJIitaax8plUevC3GR1BYSei5kFy2hbV/x8icInUSpo3zF6x9blvE86T9sIObHi7opV0rBjl4TKVDssaSlURxl0Zsww3z8+n3pvVC43ycWYYSkoJqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KDKF/Mhpyc4Qc4uP3DTq9OjexXSSTpVWjpGc99ffuAM=; b=VLSf9T2L4+Z/rHXNzX7aiwxWVZb+p+RS5vqSObBFIYPrZ4PkJmxcONQ+9PZdZDEngypUhtgXK6Rp7nAm8MbnJzHmLiVHTqY3FI5D7j9qB1+vQUz0wDrAZE3UmMzIxLhkexGUkbrsrK4VIeIluMeqYaEjFykMNk42khlm2TCPWQEu95ns46CGdiVU3qxkMyVek+5+BiHZRV/H6WYeCFjIPzeFaAFMILSOngP3a6bIjPg4I6vBmTDj/+1d0v9fUNe8tfF8paXC1cT+H48Vvcfpj1/IJBGLpFKnBYzhK8cMTThMKDT+sXFsTihJl+mu2BkuahnAWnFQMWXWW1/00jzoNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CH0PR11MB5233.namprd11.prod.outlook.com (2603:10b6:610:e0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Tue, 6 Jun 2023 02:24:58 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f%4]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 02:24:58 +0000 From: "Wu, Hao A" To: Andrew Fish , Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" , "Hsueh, Hong-Chih (Neo)" , "Chang, Abner" , "He, Jiangang" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjaEROuhuDY7qr02+W0SYB4rkMK9zxJ5QgAC+DQCAAmKz0IAAvsUAgAAf9YCAABwSgIAD0WGggAFuabA= Date: Tue, 6 Jun 2023 02:24:58 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-02T18:11:56.552Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|CH0PR11MB5233:EE_ x-ms-office365-filtering-correlation-id: 2e0fed9d-5ecc-4046-ecd8-08db6635395a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: unvdemTT0rdotRc2K/CjXa6tyJGpiTXTdK7YR0BLqaajVUGV91eKr/lNK09OMTHJSsiRo5RiSV0+1JLVpLZP6GZBDBbxHj0lMsvHwtEGFmd0GcXsQuJYKWpZ7dhXs6/0/SEvkeOzugIIwwnwChbU5RyRppJXTHLpAyUTHkGJtVTORYashXifZ6ckS33Cd68bqx2R/2De2fmZOB1pDocW7DfACWjSdCS6WfbgDr4iPJlREfLLdjEeXMQaDK6IJ4nLuZWPDMu0BMOxJveKdFG0fhqNJskyol/PSrK6XS9msiPlosvsH40mT7Dg4u2bVFF59bGSjLW6PbB7aLNV66P7aidQMYKoutvBoBf6b94ATMCtc/13ATYVFGltnh6oVZQS3rB3BPRECCpcCJWPmhX6guK1ElC0MAj9XUQ1yDE9zNdx9eSbr0kkKKUhWjCEB4FUcAUfzimzav5iE5by03dZB6CUz0HzFajALR5KhotZS3FLOGsvrlX+6e/lrR1JXiPtsOnoTzpCHj1aThQ4M0gviJgLO8n9wicVn8c3MuvohXoX9btiG2hugwdmwph1pe23KW/DXyMqJmNKGTZRsw/W2kM3DLrJsoyLKecRcmQ93ed0avrOnp6BkT+g5uCgqWYOb7y6h+fk17yq9wqt1P5Lr8L3wHkXZGJ7sqyR9CjVUOQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199021)(478600001)(66446008)(71200400001)(921005)(38100700002)(82960400001)(122000001)(66946007)(76116006)(66476007)(64756008)(110136005)(55016003)(8676002)(38070700005)(86362001)(52536014)(33656002)(8936002)(5660300002)(2906002)(41300700001)(166002)(316002)(83380400001)(66556008)(966005)(6506007)(26005)(53546011)(9686003)(186003)(76236004)(66899021)(7696005)(1406899024);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UVgoORMzmQp65SB+5ByV6ig2H3sIX0QSxAYy4wFrg1aAHUGIQ21kAwPkjTUq?= =?us-ascii?Q?Lt+WHRWejXAwnII414jxXim1g21aZBICr/vmHure/RPr+/7B5G+cbkzWlTpN?= =?us-ascii?Q?d799RMqAYVLn89kJw9dnwBkPgjpD7B9JIQzHMrrHxC4vC+nZpxqT4R27fpzq?= =?us-ascii?Q?LB6pzTV0yO9X2bMDiTJMAJp6QOwyt2aFVg8O7Sb4OAPsTejLS64J8Mk8l8ns?= =?us-ascii?Q?8tl/NygZG+A3d7H3eshxi6xIR3bFG8KCm8N6BbJXc0rONa2sKCB/k/VJFc8q?= =?us-ascii?Q?YiE6292tt/2bwAgeZ9Nphlq1leNZ4mnrHwe+vts8nSNNLI1eSN5WsmrLKp1K?= =?us-ascii?Q?VeFeZBQrsGN6iltNYPJkZrZA6/AnDODLJd9i09jbBjhNbyiTDu3VOQyjXbw4?= =?us-ascii?Q?OogSYlNr5F8Mqyo0UntBqxd3iZWEDrMUNzfINgGnln5Xh4c3I70onQ38L+Pf?= =?us-ascii?Q?5RwIyek5798MMe67ljbuNId1s8UCIPu5Hv10QZnNghWCIu7Bv/Elc7MInIWq?= =?us-ascii?Q?ZjFBgIHIsYRg4iXRz2TouF2wQMwBspCMTv/GHnNY1YjS9vhpZDefIPZMFfvS?= =?us-ascii?Q?5vxsaRj0X/QkkOAeZ4S53OhKr0DuwlETmgh/npGosjkPU00jD4xsOWYE6p6d?= =?us-ascii?Q?vI9UhcG28SixAVVC9EiuVLH6nSuE3OTR8Pb6MPlGbJKBhyQB3KKiOM559y1d?= =?us-ascii?Q?nxClGQWgd020A0r18Bt32oXaQh4zgzBAaS+HzizTBIjkdl1fwwefby7ySL7o?= =?us-ascii?Q?JBsSQzZL+YYNPSvNaUfPuzXJYOAI8F/klQh4dm5e/hwu0ACrFGOyP+5CN+Bs?= =?us-ascii?Q?X6mYrjpyxtElVMUKtNwa3h7ga4dHdJ2ADFnq6ao8Bx0Ox8LjcNi+4/ST3ct8?= =?us-ascii?Q?dL6Iq88L71kwCbLQJh3zOLctbhbz8BmfubxIQQfay5UPr7mLN2n9QUITw/Ls?= =?us-ascii?Q?8eDtWeEoZqjoCJhmowNUNE2Ix2BOJoDURYpaOanm78LgOjjVsB2QdAzEjVGj?= =?us-ascii?Q?vpDsum8pcjI6na5DtUH545IZAg19cnsgIsrUvIHwomaunp70lXSbDRJCB9b8?= =?us-ascii?Q?hirCGD2yp2P4/4EEvx4hVVqaMZ1sCcZ4CaZI0J8Cbiu5sMsEU9d6n1dG98KQ?= =?us-ascii?Q?MWPuGbFwP6+fVf8XtTOCG9LfK8Qd04HQfQ+uKApuDyNL98GKDSpKCnS4rj/t?= =?us-ascii?Q?JzySRK4rU2Wh+OTE8NyWVOd5PoYCf6X8FJyQQ9SMaYk+0KEMSx6eWzO2X9KR?= =?us-ascii?Q?27QXI6uocbU4UvrYPuIOGZ84XPgFjRzPfQAONImPRMp8Ep3bh/sdiATQ7SoY?= =?us-ascii?Q?gJU9WmdtRTFKpSBNBxrKknClqD9erlPIQ+9sglInAsgVylvahuLsn11AdsfR?= =?us-ascii?Q?Q7WzBBkBh2PH4ftvj+kbstrB7Hbe75g2SbSAfa94QJ+6N39lpDNv6y6XLRwo?= =?us-ascii?Q?VxA4Hb9P4bznNCjYyMFwOtF+BbBPEbhNIHXNil88MIzybmzpQY9CWGDp+CQt?= =?us-ascii?Q?Gp/dAb2th+a25rc3FLIoZgelNtAiKAw1qo7nlr7dNhkRqtPHSdUOkKNjH+9/?= =?us-ascii?Q?KjTB8sui0Ba8Zb9R5u5enVmHx/5Pj8LddLFIqQVE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e0fed9d-5ecc-4046-ecd8-08db6635395a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2023 02:24:58.4002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vBcU7T/vGaPaYaXeMe0d6KkFl0+li89B5vIZooSmM6uKRmBOTPRXnz6qxS+vgbD8dbQCGH/fMIXhfork5pRh0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5233 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB40258C3D19AC1842612EE6C2CA52ADM6PR11MB4025namp_" --_000_DM6PR11MB40258C3D19AC1842612EE6C2CA52ADM6PR11MB4025namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Add Stewards. I cannot merge PR https://github.com/tianocore/edk2/pull/4478 due to consta= nt cancelled CI tests. Could someone help with the situation or help to merge the change? Thanks i= n advance. Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Wu, Hao A Sent: Monday, June 5, 2023 12:32 PM To: Hsueh, Hong-Chih (Neo) ; Chang, Abner ; He, Jiangang ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM Thanks all, Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/44= 78, but failed 3 times (all due to some canceled CI tests). Will re-try tomorrow. Best Regards, Hao Wu From: Hsueh, Hong-Chih (Neo) > Sent: Saturday, June 3, 2023 2:12 AM To: Chang, Abner >; Wu, Hao= A >; He, Jiangang >; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Abner, Thank you for your feedback. I updated the commit and re-create the PR as b= elow: https://github.com/tianocore/edk2/pull/4471 Regards, Neo ________________________________ From: Chang, Abner > Sent: Friday, June 2, 2023 11:31 AM To: Hsueh, Hong-Chih (Neo) >; Wu, Hao A >; He, J= iangang >; devel@edk2.group= s.io > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Leo, Please add Hao's RB in the commit message below your signed-off-by, thus we= know this patch has been reviewed. I also suggest to update your commit subject to "MdeModulePkg/Bus: Fix port= multiplier port in AhciPei PEIM". Please resend the PR with above updates, then Hao will add "Push" label to = this PR once your change passed CI. Thanks Abner From: Hsueh, Hong-Chih (Neo) > Sent: Friday, June 2, 2023 10:37 PM To: Wu, Hao A >; He, Jiangang= >; devel@edk2.groups.io Cc: Chang, Abner > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Hao, Thank you for your review. I already created a pull request for this commit, may I know how to proceed= to merge it into master? https://github.com/tianocore/edk2/pull/4424 Regards, Neo ________________________________ From: Wu, Hao A > Sent: Thursday, June 1, 2023 10:14 PM To: He, Jiangang >; devel@e= dk2.groups.io >; Hsueh, Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks. Reviewed-by: Hao A Wu > Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A >; devel@edk2= .groups.io; Hsueh, Hong- > Chih (Neo) > > Cc: Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > [AMD Official Use Only - General] > > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. > > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (= Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang >; Chang= , Abner > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.co= m; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > > > > --_000_DM6PR11MB40258C3D19AC1842612EE6C2CA52ADM6PR11MB4025namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Add Stewards.

 

I cannot merge PR https://github.com/tianocore/edk2/pull/4478 due to constant cancelled C= I tests.

Could someone help with the situation or help to mer= ge the change? Thanks in advance.

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Wu, Hao A
Sent: Monday, June 5, 2023 12:32 PM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Chang, A= bner <Abner.Chang@amd.com>; He, Jiangang <Jiangang.He@amd.com>;= devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

Thanks all,

 

Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/4478, but failed 3 times (all du= e to some canceled CI tests).

Will re-try tomorrow.

 

Best Regards,

Hao Wu

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Saturday, June 3, 2023 2:12 AM
To: Chang, Abner <Abner.Ch= ang@amd.com>; Wu, Hao A <ha= o.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Abne= r,

&n= bsp;

Thank y= ou for your feedback. I updated the commit and re-create the PR as below:

&n= bsp;

Regards= ,

Neo

&n= bsp;

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Friday, June 2, 2023 11:31 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Leo,

Please add Hao’s RB in the commit message bel= ow your signed-off-by, thus we know this patch has been reviewed.

I also suggest to update your commit subject to = 220;MdeModulePkg/Bus: Fix port multiplier port in AhciPei PEIM”= ;.

 

Please resend the PR with above updates, then Hao w= ill add “Push” label to this PR once your change passed CI.

 

Thanks

Abner

 

 

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Friday, June 2, 2023 10:37 PM
To: Wu, Hao A <hao.a.wu@int= el.com>; He, Jiangang <Jia= ngang.He@amd.com>; devel@edk2.groups.io
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]

 

Hi Hao= ,

 =

Thank = you for your review.

 =

I alre= ady created a pull request for this commit, may I know how to proceed to me= rge it into master?

 =

 =

 =

Regard= s,

Neo

From: Wu, Hao A <hao.a.wu@intel.com>
Sent: Thursday, June 1, 2023 10:14 PM
To: He, Jiangang <Jiangang= .He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Hsueh, Hong= -Chih (Neo) <Hong-Chih.Hsueh@= amd.com>
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use On= ly - General]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@in= tel.com>

Best Regards,
Hao Wu

> -----Original Message-----
> From: He, Jiangang <Jiangang= .He@amd.com>
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A <hao.a.wu@intel= .com>; devel@edk2.groups.io; Hsueh, Hong-
> Chih (Neo) <Hong-Chih.Hs= ueh@amd.com>
> Cc: Chang, Abner <Abner.Chan= g@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> [AMD Official Use Only - General]
>
> We did crisis recovery and Opal HD password unlock from S3 resume from=
> SATA HD test on two different version of AHCI host controllers.
>
> Thanks,
> Jiangang
> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@int= el.com>
> Sent: Tuesday, May 30, 2023 10:30 PM
> To: devel@edk2.groups.io; = Hsueh, Hong-Chih (Neo) <Hong-
> Chih.Hsueh@amd.com>
> Cc: He, Jiangang <Jiangang.H= e@amd.com>; Chang, Abner
> <Abner.Chang@amd.com>=
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Thanks, the code changes look good to me.
> May I know what tests have been performed for the patch?
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.i= o <devel@edk2.groups.io&= gt; On Behalf Of Neo
> > Hsueh via groups.io
> > Sent: Wednesday, May 24, 2023 1:07 AM
> > To: devel@edk2.groups.io<= /a>
> > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh <Hong-
> > Chih.Hsueh@amd.com><= br> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier p= ort
> > in AhciPei PEIM
> >
> > If there is no port multiplier, PortMultiplierPort should be conv= erted
> > to 0 to follow AHCI spec.
> > The same logic already applied in AtaAtapiPassThruDxe driver.
> >
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 +++++++= +++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > index cd55272c96..7bd04661d0 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > @@ -3,6 +3,7 @@
> >    mode at PEI phase.
> >
> >    Copyright (c) 2019, Intel Corporation. All righ= ts reserved.<BR>
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All right= s
> > + reserved.<BR>
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent > >
> > @@ -92,6 +93,15 @@ AhciPassThruExecute (  {
> >    EFI_STATUS  Status;
> >
> > +  if (PortMultiplierPort =3D=3D 0xFFFF) {
> > +    //
> > +    // If there is no port multiplier, PortMultip= lierPort will be 0xFFFF
> > +    // according to UEFI spec. Here, we convert i= ts value to 0 to follow
> > +    // AHCI spec.
> > +    //
> > +    PortMultiplierPort =3D 0;
> > +  }
> > +
> >    switch (Packet->Protocol) {
> >      case EFI_ATA_PASS_THRU_PROTOCOL_ATA= _NON_DATA:
> >        Status =3D AhciNonDataT= ransfer (
> > --
> > 2.40.0.windows.1
> >
> >
> >
> >
> >

--_000_DM6PR11MB40258C3D19AC1842612EE6C2CA52ADM6PR11MB4025namp_--