From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 35E5DD80A38 for ; Wed, 20 Sep 2023 07:14:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1WQccBpjmlDD/BuZX4Y8oPnQodiCnikv3Yi3y61B3o4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695194058; v=1; b=IWT7abzHgtJ2z9oqw27umT3JkB/FWlOu9WKeCLNqU5kzz2vz0AHdk7iUIXpNJitLwvn/fpYO 8u045ZYTe3L0u1zsPKXM8PfC2FDjewseFPsWk7PKML6XcPoW0gXVJmjuz7I/REHr+EGVUI4HdTE rrginUOPcQQ9lwmc6kAjhsrk= X-Received: by 127.0.0.2 with SMTP id DPNZYY7687511xlgWX0Nrq7C; Wed, 20 Sep 2023 00:14:18 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.31425.1695194057783226529 for ; Wed, 20 Sep 2023 00:14:18 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="380047792" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="380047792" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 00:14:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="920168192" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="920168192" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Sep 2023 00:14:16 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 20 Sep 2023 00:14:16 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 20 Sep 2023 00:14:16 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.42) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 20 Sep 2023 00:14:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhLxMLqEvBJvxExMPBRQ1nOQlmDFsQUZXpQwqU3sc4G3/BV2nObqTlA3uh+dJGjCbzAp2q1q7YD409XMl3YPPVeweQZUn4g4nE0WCvrz6rHL5b2l0BLzed/wYwwCoNi37wFxuWnwZV9pH/uzIdFPVLAOjzj0bda1Nt+DhD1X8+PquL9myY4oM1kWIkdTK/wIx40A/TTsGi2FyD2o7HrtW6Ha8HANh4Y+uAN8tSyfTZShtqVH/56FEs2Nvpwacy7tM15zfAz64GGagIFmbVHxHrSMpOBRW0rwy7L0QJAzAkj2DASgsVDifuQZq9wAo25eWS3OjM7xCA5VoZryuMAjtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sbiq+kN4GKkq11RdNnxqG5H4OP3vP1sp0PZqTYNsF2g=; b=KI7433dQYqG+7mlOJun35FidTJydESPLoILLBy8WZPSyCKUOhZAFNFdPZKo/0FFPeHvNQB0hd54IpI1cvNA8P0sG6BK1/uoRzsvzY9PpynIJXvDbhYKQ+2PaC6HFYmYmW1JQ5rzeQ2eWhBFYh3d90me+aS8N9JMP0CArZoG3d4lHdV8YXQ1TD0/2i8pX7n6h4cuEPP1jsGMRIwx3h3JVR1RQ0D51eyJMBqyJE3js6Q8mCEj797XYzhkEc7zk+x0vjspIGAKHeryNKg6pwm1ziqNZlfcLfvwind/MRe8BmVZv2r4wrdYtXJiw4yL4dul6E6Z9CzqPB5+jJ0pupaJUdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH0PR11MB7471.namprd11.prod.outlook.com (2603:10b6:510:28a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Wed, 20 Sep 2023 07:14:14 +0000 X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::38c3:ed7c:3562:2e18]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::38c3:ed7c:3562:2e18%4]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023 07:14:13 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , Ranbir Singh CC: "Ni, Ray" , Veeresh Sangolli Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue Thread-Topic: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue Thread-Index: AQHZuKN8O7txD/5VlUSLtqKQpsKCaK/i7pgAgEDECjA= Date: Wed, 20 Sep 2023 07:14:13 +0000 Message-ID: References: <20230717114008.2290970-1-rsingh@ventanamicro.com> <20230717114008.2290970-2-rsingh@ventanamicro.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH0PR11MB7471:EE_ x-ms-office365-filtering-correlation-id: 45886fb3-c95a-47e4-1452-08dbb9a9317f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: AoxqjhZOLpfeuNT67ZeaB6QlZg56nD7uloGl9bGqXcH3URNWZruKh1OQMDJCNYIm5yfhjrwQSsCrTUQZHSpEgRbbAStEmgmufHvN7cE3ARiBTh+oguc5D/YELZMqB5reHi9V+1DpFFcrMMmmuFk99yiaFa4i4hEmR42lB/+YDE6eKJeAa6Qt6cUeStvidBdd3h7PdiMVSV4oX7A/C3ztrds1E7nMOqUzCrcDk0g+hZAdNVnwBqm3zXCrBWmgY2avgUlMQCLygp3WdIfawWIXPbb7f+OTqDYJqxoGEio1B4U6RNDKUsefU0ySe6Ezj+vhV2aIIKwrlA/YQyj3tuhir4EJyqUGemxaI4f2HOku5QFkMZOAB8O6dYMqIBRTUCV+Hm/1C7wJpBeZM9FG9t94LrQ2xfexBbZF4M871zWAq7QmKGS3OQzj9gfDrmKwle7yl5tG01x3zCpdHvrmrEHmO9KzeLtlwtrzRoCgDkKrcclKALgsPEJ8u4Zbw+mH3fB+Gqzf/9RYEvr+EHqu48AskTHCkMwvoUa7aFF0cT/lspoBm4w/EjJX+28P1gunHitNLvW8j12aImbjOlKlfyB4J/VNPLLtmlyAjtztTrc3XNzFUzXnatx+Sd80EINDQGdPOT7jYUhMIiERAlvdf9psKA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TUTjX2/p7IBig9skAh2VMm8Z7N0srHdW7kzJp6FUc6hQat6NcSn/OWSNvS50?= =?us-ascii?Q?RmLhO3B/tipaYZZCJ851oEVCIJyUK4OllJZKqfsr5nvh7s2yZyFh7cMS4pRc?= =?us-ascii?Q?OXNYicd6his+SMSLbLHUNCVpQvKobxbX3j+pH71pcs4vpOMolfqniWpY3G8R?= =?us-ascii?Q?3Oe3/5kbSHVZnQccj+4puxLYufSh1eq5oKGtIyerzKCJJqG7k712c8TMHSO5?= =?us-ascii?Q?VzzSSdM8aw1IlI/M9O/3bmLRycFnCDGV4V/vzkN6b+S1nYwx65Unkhq2bM9L?= =?us-ascii?Q?0ZgklVUPq6OwswCv3XfqAJe3Zw0Rpy9BQtMGAR+yJ/wzhOd7VTpLqHlyGxl/?= =?us-ascii?Q?GKCzM0Ve87Jm7eE660bEmwfBpEniVKuASMffjnqLhk+iEkFlGixYFQfardjo?= =?us-ascii?Q?J9t+LpuhSETHgangp1qnvaHTU+zyzTam5w1FARi80VPY+/fOgDTaznSzz8ES?= =?us-ascii?Q?S1B/GAfEDzcEDHK9nyhHIdZ3sBuwnt9vZMou0x5mZDeZKf1oop4UgEV/cuE+?= =?us-ascii?Q?NqvImqTDzMtj0HWcn+eVwXnkL+QOTXvL7yuk213B5pBsKb5oq9Kt68dK5fvt?= =?us-ascii?Q?gkZDIu3a5WDuIhCc28u1zbB8aG+Z8oVkX3chb1BnL1MIOqcs17RNnCxQVbjT?= =?us-ascii?Q?/wvhFxRDijQ0jpXA/3/2WpwoQ3UkQXJNkdU7c+yPTX/GwX9WqSXPK1mxMI8O?= =?us-ascii?Q?BJN06K/UP+geiRH81XalgfBqCKXkS41sqFcIggWQLeBZlIbWaDUsrLGIdnnv?= =?us-ascii?Q?r8I2zB+6rqJ2FxuNLPwiXxaYlEJvgzrjgRoSMW/+VAPTiz/drJbTwweV/cFb?= =?us-ascii?Q?oA14Lql3ZRzE/1YfjMSHXuXha1Ho6Gk+UaZj1aE0/JBezdAxAg9r7ykODQYU?= =?us-ascii?Q?jsKWjA3UCPJrjpUouLdHE5ntWFXC1QWK+6x/OUAfGj1ArgbbCE6KMxKevSeN?= =?us-ascii?Q?/kADWKgKr/QY5z8lJl+zhLHiFmm2VVThguGHrAk9344Z2YEKRjYl3VFttxjY?= =?us-ascii?Q?obHiX27VE3vcjIyt/nGl+xpI6bEMW9Db3g/p/oe1XH4WNUjpuuwdZ8Ao/cU9?= =?us-ascii?Q?KS3JYO8AJs360qZHRN8VbvTndsOWCtxbjttdvLZCRln7T1k+zwhsA/w9pWSx?= =?us-ascii?Q?18U/Pbw+KghhAh2jbYrozWHvgGbZYh2L3bfQ3FVjokRpnsQn8wA1QBIHXfKR?= =?us-ascii?Q?y6X5a9kj0yrh7NID5yQh1O6DRAmLcNyUTFwyC0724SIbdKLUj+s/DCackCXK?= =?us-ascii?Q?Faa4D+Vf8rBU9WWfzWrvrDYSIhZnycpnt+82vHHmErKT8I0DQwEUScUVZmrd?= =?us-ascii?Q?TS5ouJ3ZaYRihCj95tETtRq7f1Py8qfJkU0BPtKADr7ix6U3tcLvIpUOdZLj?= =?us-ascii?Q?YRzctuaqDUPBFxJpfXZ/b1ri7ljFcy0C17iZD4y/qHOFa69UIikUmbhU6yWy?= =?us-ascii?Q?Kl+2xoBCOX0vEhOgCfWZwiIc9ZiB5eXDsXt5aa5dmd3oxZwPJS/Go0seH0nx?= =?us-ascii?Q?+PJQrp7YMJcRLAf1sL6Lt7BGUTxFXtFCbtLJIgvoYwZih3rBSU3NHZ9cEQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45886fb3-c95a-47e4-1452-08dbb9a9317f X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 07:14:13.3873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PxsfxNsbCDAZE1OZSutWmdOZNC8mGVsz4hh2IjtnoKArcXCw+J5i2sTRcWsqfbX6Jdq1ylHHAVx8vIF7s47mCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7471 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nTuUPtjJhhZvdQSlo62FEU1tx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IWT7abzH; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Pushed via: PR - https://github.com/tianocore/edk2/pull/4843 Commit - https://github.com/tianocore/edk2/commit/4317b4824bc881fe6079d04b7= ee5b0f6bddf62ca Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Thursday, August 10, 2023 10:39 AM > To: Ranbir Singh ; devel@edk2.groups.io > Cc: Ni, Ray ; Veeresh Sangolli > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > MdeModulePkg/Bus/Pci/NvmExpressPei: Fix DEADCODE Coverity issue >=20 > Reviewed-by: Hao A Wu >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Ranbir Singh > > Sent: Monday, July 17, 2023 7:40 PM > > To: devel@edk2.groups.io; rsingh@ventanamicro.com > > Cc: Wu, Hao A ; Ni, Ray ; > > Veeresh Sangolli > > Subject: [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix > > DEADCODE Coverity issue > > > > From: Ranbir Singh > > > > The code can reach line 65 only through the else path above at line 53. > > The else path already has the same NULL check at line 55 and hence the > > duplicate code lines are totally redundant which can be deleted. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4220 > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Co-authored-by: Veeresh Sangolli > > Signed-off-by: Ranbir Singh > > Signed-off-by: Ranbir Singh > > --- > > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > index d704c62eaab3..1d03d4964025 100644 > > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > > @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( > > } } - if (S3InitDevices =3D=3D NULL) {- return Skip;- }- = // // Only need to > > initialize the controllers that exist in the device list. //-- > > 2.34.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108898): https://edk2.groups.io/g/devel/message/108898 Mute This Topic: https://groups.io/mt/100212115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-