From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.64028.1669944373087628483 for ; Thu, 01 Dec 2022 17:26:13 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=S2sPV+yY; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669944373; x=1701480373; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=GQq0vGcTsWaGNON8iwtQjmPN9INCSOQRnbVjth9NS58=; b=S2sPV+yY8n6ZUeF2in8anRbCBuKyDsVfrk8INL9Lbr8902vdHL5QFfth p3917Cot8v3w2ue6x3Hm7HzL+TSexWHNBhuBr8pDgNPwmb3SQrC9NkdcX mf+N9NfR0TDMvlCxaAMemtUenPAGAfnM3Q/yGOCt4zEeGGFb3jMiONm4c syjhsk4Ixnd2+vyTou3f3s/w9l/6br3fAndmZQj1Q2BAYy4WsyvXaj7GB +VH0R9yP+WBPrMaqpsKkza9E0MWkvRqw2iey6jI9ZEV04hXkS90KN1d+S 3kEMkSBBXhmdREMPGQEQjN5Oc0g5TVoN5E0QZOESEVDQ608TiSHoynHvy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10548"; a="296197292" X-IronPort-AV: E=Sophos;i="5.96,210,1665471600"; d="scan'208";a="296197292" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2022 17:26:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10548"; a="751055970" X-IronPort-AV: E=Sophos;i="5.96,210,1665471600"; d="scan'208";a="751055970" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 01 Dec 2022 17:26:12 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 1 Dec 2022 17:26:12 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 1 Dec 2022 17:26:12 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 1 Dec 2022 17:26:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bDA+sRmL6XvuehzlzuS/zZNZgmSh3vpgKsk4q7ejnX1RX/d55w+VF4BxVX/QjffrHpWQZUMGCXws2DQ5lrMG4QKZIri9KwP3UXj2yRNtI9hl+BSAsYdsQ0e7j6V1l/LrdW3X5r7dlKi1V04QUgI12KeJSGAU0c26S/4cBR80aneyYRlmW0sY2OyAXFumEYyn6Dvj5SwluK+YMEq6qKjWf317lybT8HcFkWMF6LX3bxMSrgSYE/JpEB9mXgCSQ/uVp7MGKvyqY5Ivw/X8f/SHhk9sfRjrokyd1qL1Hdv1oix55WHunbpFPh182f7KQYhMxK8m5vWqKcUAX3eduwJIRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oNW0qKGOdLVXzjxRAqaA4fXnJTscKY0HGeHdTh8SSLE=; b=C4Rz7XwPgXwdnipyh5ZgDIolgsfu9/yzYB1Q2zBjkv2IkXyl9sgOuZbc/jxazEX32MQLu7nnz4684se6Gqs3Lz/rzdESETzYjz5FiGyJDbYUbdRG/yQHOALQuSGLZnDKyXt8/MUof0GS43NdrOA2YNSrh9LLlkktblshwoYgzT2pqiZg36vzWvQh+nlOHSoXGTQrzscRztMjFi32FwTSeZRGeFTo8EGJEvNojZkpwZXM/y/teKQQnrfQdgBJ5Fihx4dIOmVOqTYiBcmHSe1i3JT3VDhQUfcFD2V7U7CNX1QIIARw2mp8e+UDhuer/t+v6MpLvVRMp8lQJYNLoXBDmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CH3PR11MB7392.namprd11.prod.outlook.com (2603:10b6:610:145::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Fri, 2 Dec 2022 01:26:09 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c%3]) with mapi id 15.20.5857.023; Fri, 2 Dec 2022 01:26:09 +0000 From: "Wu, Hao A" To: Rebecca Cran , "devel@edk2.groups.io" , "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" Subject: Re: [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE Thread-Topic: [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE Thread-Index: AQHZBcgC+9G3Ib16akSpDPz6hBmKXK5Zy7Rg Date: Fri, 2 Dec 2022 01:26:09 +0000 Message-ID: References: <20221201210007.62020-1-rebecca@quicinc.com> In-Reply-To: <20221201210007.62020-1-rebecca@quicinc.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|CH3PR11MB7392:EE_ x-ms-office365-filtering-correlation-id: 8d2faa7a-87c2-4a26-b2a2-08dad4043129 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i8vfLUz/rI1RTP0+wDYOZlwQfHtPbB/cc8yLyy6YeF3fv8w8gMguNW04XtdtJ3Rota/JoNukxoutIzgywIo/5hmL2vHt5Ra7d/hMe9L9od9h8fiyF3Bb7znqs7BNHAXSggiOiBpd0U2A5lvPZE4sa13SwOX+bBHVoKJmU55lCDbrFmaFPmHw6mqoLTQiMgGQuTS68a4mAOm4e5D02gCm9D6kPmRjLnIzpZTs+m0hcTDDiSngpDIoIACqYd4E8G4t7mu5uULouGVs1PlWSaSAwVhpzQz4hZXltejp9dJaj80oB5BIHLS9t3H3Bvk3w9rxZySS1LG8pKqNsPl0lDQGWt71xULGMtNf34CbR9D9xcB23PnAc40Dmlfoji/YYMscix/iySjEASyg2f2/iJcgrECDtV/hZC5x34dRU5mekstbEYAvdYMWWY6WHOAcWnfM0D+bZOO8BWD6/aaPncnpBIahTUZPmtSE3u5JSzS/CHCwYlmQi0z5wfo0up/GOC9+Tfybk8z0fhwA6/GZLYuDIiTlrzdLQ5pRVJ8rc4mZNE/NNFE2DvEHICF3vpsHzin9RkFrZCHly6WhHwvmQess4/w1oHn3BX43oKgeXHl/O+PYacAlx7ABVCgBg8PK3JMRIhRgBffZE9dsBFrk6eexhdOf6Yo9SmkXhOEFPr0worBHulcPerwx56yHMXHY/kZhAAo5g6pwsuzXo1vwirE+IA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(136003)(346002)(366004)(39860400002)(451199015)(33656002)(8936002)(38070700005)(2906002)(41300700001)(38100700002)(66556008)(82960400001)(86362001)(110136005)(66446008)(122000001)(83380400001)(66476007)(6636002)(8676002)(64756008)(76116006)(55016003)(478600001)(71200400001)(316002)(66946007)(5660300002)(53546011)(52536014)(6506007)(186003)(7696005)(26005)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HhNnaathmD6gUxGmJbsl/HEoe7P6teAP8ize38CMTgvcTHeQGZ5iIhLeTjeZ?= =?us-ascii?Q?v5U+eN3cW9U0SJLO4vMW/ajMFnfeYiU0mEEbihupJtrl0I3uysfKanQc62FR?= =?us-ascii?Q?bOlaqi81UfsDiD0pHR3Kfsu3x1TueJIfHUlePdQ7PMcAhYPifBLllxm03zgO?= =?us-ascii?Q?XE7ctqtwJmXZVozz0vBndp9thUyC/PQ01JnNvBIOP/mK5AlkXhkKM6D/AaIl?= =?us-ascii?Q?XbMlzScwCqgSvVlHPjYXqh/XgqCsvAqeFmna3rFaiRQl72Xh8Q2ItkEyJd4w?= =?us-ascii?Q?FHJFUIMS8ib5E7n9HxZRsXH0ICN44JgvoSitoNnG7yRrclP5xhyx8eBD63og?= =?us-ascii?Q?vksmPWVQUdXgvySYEeLVBpc8NNiCaftBk7Bl0Hop4OW0h9unc1yI3Y2yN9Q8?= =?us-ascii?Q?HpTSXDvw1sHFQNdr5MYMEKFMDdQeRpq3i8H+20sR82UPtBj8oxAAeWag7guf?= =?us-ascii?Q?gwOFkaZNu7pN49rJHAKa+MkTbm8Tx/JotuYv6n3AELyY3lkFmrYzjpj/0KQV?= =?us-ascii?Q?ltA7lsxqr5t4FS1dDWVxSj4dET3vKh0dEn3I/HQZEPbMtId3vS+ti7KT+UIP?= =?us-ascii?Q?h2KC6MauKG94LP1WvrEjZP6wcPbmr0QaAOHpRnOjF1EtwUQjwCXRdKP1On4w?= =?us-ascii?Q?syR1vWLyfyx1P7JnDfM2IHHaD3QVBcH45vfVa7gIFEbKR5XjpylDcVDubO28?= =?us-ascii?Q?DUL/qJD3vsvcJqhncgrileLUCdTY29gSt+Jotvbvy0IlUi+vXyd3bYpQod+y?= =?us-ascii?Q?jxK6v2/F8IuRp1lWS754j22PFchTt0c76+F7zcsRIOwYs7mUiP/KjSQQ0SG4?= =?us-ascii?Q?Wpb9KD71z4j2Glx5a9iaIzHCEBF7Y80MRH9GKfAFumos9Y9xPLKy+kISjPYK?= =?us-ascii?Q?5y5Ivz3FXAysb/YGLcdnab/GjJVi3ENmJdobgGOiNBSdTi4Ou2O9TFCnU9D3?= =?us-ascii?Q?IJex9XYJZR5tLst0ENw6MQXOv/w2Uy4TwdMgvZ8IjBbrgUt4Y2kXtr+Fc6UZ?= =?us-ascii?Q?RsDiEp7jr+7bzaaFBcP5a+5HF02CMFq7xSv7up9WjoJpdY55/2xGirpmtdvA?= =?us-ascii?Q?5KSqcXq9nO7qmj+T92POMPU9T1iH3wsf+LKHlII7us5mLK/ic9WkX7jk5ErR?= =?us-ascii?Q?UOyO2az1TJBvcdX8RZNYq3Osl9lhobi7WRPDfiNlrsxZX4p+/RMsZIC9dRqN?= =?us-ascii?Q?rhVtsqd7hnVxWLfHPltT1ExvjU0hhkaSzeUrPlvjCvartx5xxqDBa98Tu4jQ?= =?us-ascii?Q?UgAKWmtlAdP8X5HUbgKQlXeRq3jlkmJS9CSk5UhUvjXwcoBi0T6nFU53mek6?= =?us-ascii?Q?XmnlqgpWn2xyRffJTfIgaASC97HwTpDr6foikl3gSm1pID5BqwyyGYHkPEJ/?= =?us-ascii?Q?gVVDp5jA7Oj4/GZT7yan7qljmj93kPvqOf0I6d4RkA/q5VS7gXaA4EhKTgM3?= =?us-ascii?Q?VkNs4I85QonfjRR2dUIyCtxPlUt3RNUYTajl+Ai5tVTBWC2ZmqXdvVRaWcRM?= =?us-ascii?Q?MZBEIU8a+IBHXA9gqjT5tGLB4U9Rk40fIhjq4XEK5H08okfoY9A/0h3W1jwG?= =?us-ascii?Q?xlFelEIukVunUA8FJ4rWDUJ5pCPV9ZJZspQhw2b5?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d2faa7a-87c2-4a26-b2a2-08dad4043129 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2022 01:26:09.5651 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DknJ31pR+mgqYvGTt6SJ2pVt/tBnNOEAgYm5U2vGfBvrhxrK6DcsGj+sBI0GHB/UVfrBewdUQBu+2J+J7R7RQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7392 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry for a question. For the changes in EhcBulkTransfer() and XhcBulkTransfer(), is it feasible to distinguish timeout cases with other error cases and only adjust timeout related messages to VERBOSE level? Best Regards, Hao Wu > -----Original Message----- > From: Rebecca Cran > Sent: Friday, December 2, 2022 5:00 AM > To: devel@edk2.groups.io; Wang, Jian J ; Gao, Limi= ng > ; Wu, Hao A ; Ni, Ray > > Cc: Rebecca Cran > Subject: [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk > timeouts under VERBOSE >=20 > With the pending commit of UsbNetworkPkg, it will become common for > UsbBulkTransfer calls to timeout, given that the drivers are called from > MnpSystemPoll every MNP_SYS_POLL_INTERVAL milliseconds: the drivers > check for network packets by calling UsbBulkTransfer with a timeout of > 1ms. >=20 > Avoid console spam by moving DEBUG messages that occur each time a bulk > transfer request times out from DEBUG_ERROR to DEBUG_VERBOSE, for both > EHCI and XHCI drivers. >=20 > Signed-off-by: Rebecca Cran > --- > MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 2 +- > MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c | 2 +- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 2 +- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > b/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > index 0b7270f4e930..4f1d990c8bf1 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c > @@ -932,7 +932,7 @@ EhcBulkTransfer ( > gBS->RestoreTPL (OldTpl); >=20 > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "EhcBulkTransfer: error - %r, transfer - %x\n", > Status, *TransferResult)); > + DEBUG ((DEBUG_VERBOSE, "EhcBulkTransfer: error - %r, transfer - %x\n= ", > Status, *TransferResult)); > } >=20 > return Status; > diff --git a/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > b/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > index 5da26afbe120..6967aabceb78 100644 > --- a/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > +++ b/MdeModulePkg/Bus/Pci/EhciDxe/EhciSched.c > @@ -702,7 +702,7 @@ EhcExecTransfer ( > } >=20 > if (!Finished) { > - DEBUG ((DEBUG_ERROR, "EhcExecTransfer: transfer not finished > in %dms\n", (UINT32)TimeOut)); > + DEBUG ((DEBUG_VERBOSE, "EhcExecTransfer: transfer not finished > in %dms\n", (UINT32)TimeOut)); > EhcDumpQh (Urb->Qh, NULL, FALSE); >=20 > Status =3D EFI_TIMEOUT; > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > index c05431ff30ec..e0347970c9ad 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > @@ -1304,7 +1304,7 @@ XhcBulkTransfer ( >=20 > ON_EXIT: > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "XhcBulkTransfer: error - %r, transfer - %x\n", > Status, *TransferResult)); > + DEBUG ((DEBUG_VERBOSE, "XhcBulkTransfer: error - %r, transfer - %x\n= ", > Status, *TransferResult)); > } >=20 > gBS->RestoreTPL (OldTpl); > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > index 13b0400e83d7..13247f7b0dfc 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > @@ -734,7 +734,7 @@ XhcDequeueTrbFromEndpoint ( > Dci =3D XhcEndpointToDci (Urb->Ep.EpAddr, (UINT8)(Urb->Ep.Direction)); > ASSERT (Dci < 32); >=20 > - DEBUG ((DEBUG_INFO, "Stop Slot =3D %x,Dci =3D %x\n", SlotId, Dci)); > + DEBUG ((DEBUG_VERBOSE, "Stop Slot =3D %x,Dci =3D %x\n", SlotId, Dci)); >=20 > // > // 1) Send Stop endpoint command to stop xHC from executing of the TDs= on > the endpoint > @@ -3376,7 +3376,7 @@ XhcStopEndpoint ( > EVT_TRB_COMMAND_COMPLETION *EvtTrb; > CMD_TRB_STOP_ENDPOINT CmdTrbStopED; >=20 > - DEBUG ((DEBUG_INFO, "XhcStopEndpoint: Slot =3D 0x%x, Dci =3D 0x%x\n", = SlotId, > Dci)); > + DEBUG ((DEBUG_VERBOSE, "XhcStopEndpoint: Slot =3D 0x%x, Dci =3D 0x%x\n= ", > SlotId, Dci)); >=20 > // > // When XhcCheckUrbResult waits for the Stop_Endpoint completion, it a= lso > checks > @@ -3497,7 +3497,7 @@ XhcSetTrDequeuePointer ( > CMD_SET_TR_DEQ_POINTER CmdSetTRDeq; > EFI_PHYSICAL_ADDRESS PhyAddr; >=20 > - DEBUG ((DEBUG_INFO, "XhcSetTrDequeuePointer: Slot =3D 0x%x, Dci =3D 0x= %x, > Urb =3D 0x%x\n", SlotId, Dci, Urb)); > + DEBUG ((DEBUG_VERBOSE, "XhcSetTrDequeuePointer: Slot =3D 0x%x, Dci =3D > 0x%x, Urb =3D 0x%x\n", SlotId, Dci, Urb)); >=20 > // > // Send stop endpoint command to transit Endpoint from running to stop= state > -- > 2.30.2