From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E849941130 for ; Mon, 25 Sep 2023 04:10:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UW7I43yFPrU7wo7LBBLQdWVQAp3uivpLTKJb9u5/nu4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695615014; v=1; b=ZAYMXkv0o5Sy/3QGH4QAJZSPljs0Y/Nld+hcVMTNuRlY4fArC1zNNR3g9su6dZcDX6HtOr4N ldy2ONIPLGW2KpOL1Mm8ftmRWK36N+uJvaKR8yDEX6t1dTeYAfdDUJ98ezaUJN6WM9D8dNbqfqT cfwIftUoYzUJxqE4JWZE/VLU= X-Received: by 127.0.0.2 with SMTP id idiTYY7687511xlJULU0ckyS; Sun, 24 Sep 2023 21:10:14 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.54765.1695615012948123637 for ; Sun, 24 Sep 2023 21:10:13 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="378431313" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="378431313" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2023 21:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="751526651" X-IronPort-AV: E=Sophos;i="6.03,174,1694761200"; d="scan'208";a="751526651" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Sep 2023 21:10:08 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 24 Sep 2023 21:10:08 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 24 Sep 2023 21:10:07 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Sun, 24 Sep 2023 21:10:07 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Sun, 24 Sep 2023 21:10:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEVMq1MYaimB2FuEdsyXAKQ/wgXq2RE2uGk0ilUahXv4NGsIgO7fMJSi/ywrszJRsdv68wlk096BHcJPhT5+RFEdhLmm13Dx6oVSZwg/vQi9M3PAs2GhivBIiS+CR/ryuV1XkmADhMRAQmL7hunbL4DQ0mg8gemPGb+GOXGQzQK9lphzwKCMqlK4szSoS+tJFjbv+2p0wxfKrsBz0sNuVZ31AniqdgazL1dcr/lYpxr+XPNCbDky0BGlWyVpCLmzK/a3TWHJF0V/uxKByaJrvlv9Zs9h+qMbdwTKNsK/IeFviwuip2IA5v+GndhuuGj3ME9OFMoyTeh05UZXLTOEBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oo45H+Tci7URUJikTRrMGE0sgHLelT9x6SXjbpEJS8g=; b=GuGQ6+625Klaof6pQEbbZnGZaanbrFY4AUgT/u82PhK40HWDO3oTPBuBPtf2WeS5qNIe+JmyOvGPLc/5NKMy6g7vqCAhu4CMSl4W1pr40hjipWXTNkdMbBW7BHL2NNoyUiPCZDhZfOQGT1zOBo40VRu1XRnAy5uY0lHf2+h96Jn1ulV+B/Of+K0xSOC5b80fjvIut9VqBUB8ASShausmgzUNsSLbpOPYf8h4C7HARE3agGBGG5PpMv9iCGloL0MVrZn7VLXPvXaUpHNgcCkNMnja3k+OHzsf+5Md/DhwRD7XGxiBJBiZh/rq2Vxucv+KsrY/7rjbZ6yeG3Ya0OBsKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by MN2PR11MB4741.namprd11.prod.outlook.com (2603:10b6:208:26a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Mon, 25 Sep 2023 04:09:58 +0000 X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::38c3:ed7c:3562:2e18]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::38c3:ed7c:3562:2e18%4]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 04:09:58 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Cai, Xianglei" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , "Shih, More" , "Huang, Jenny" Subject: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device cmd when time out Thread-Topic: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device cmd when time out Thread-Index: AQHZ7D/SazI69dQ+jkqpajW72xbbmLAkzd2ggAYlzzA= Date: Mon, 25 Sep 2023 04:09:57 +0000 Message-ID: References: <5a1ea986c40109ea9860f0b6bd2be0fa249c9b3a.1695268645.git.xianglei.cai@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|MN2PR11MB4741:EE_ x-ms-office365-filtering-correlation-id: 995cc5ef-8e24-4c5c-c646-08dbbd7d480e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Y1AxnAgUwmmpLR/Ue4hDsUKUiMhBezLvb4Ivs7r1itsB0FYcXTlGeXuxKUyw+4iG4vWasbrMa/v5f/Dma80bjpdEEWBvARoFvTvfsSELT7exKZZXYP4IQsXZeNsbfesSF8RoD73YnSEbk6j+SBULU8RKfj29+pJaBPpKETZtCuHFSND9KqZlbDXCoCpmgDqo7NLoXTL66gEN0VvQ9XQs7rii/GXXBo8zFm741dlbWqBGDiO4noQspJTzYc8PkfPBv/078AxVa8TmHrlEckYI8QqEVyr/jGwxOaYPVoMysQ/o1TNLIannyZ9p1w9D01DpKUg0UV+XlD9mHl1j/RkfQnbXFbIlpgn2db31wxZ0FrtumibsqvAnBnqfz+i50HssHTMaRGlIaDZydUMSMvNZlGLQmlJ1V4XPQiZ97mwBkTU6AH7syNg1MVOooxXRv4DHzOjOnQnQFhi70pJ4YLeqKHsqBbOajyoNNIHzMesTkMyJmWyKCTNovStTFPikBmlj6dH+FJjisOOgmHKLkR2Q1UqeSrq3hV6UjqGOXykecDRT/tYZfhsPlXn9ipW9NEJtw60qeL4r3efBfoEaU7ea0clzPoXqoFVuV21EzewcTh05QpFWdKRkzhlBbX+GkBYkc1hfDDt0a1bWvrULdJwZGw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7FzesWL9vMxvkumYyjEzV4+k4sM8WXvM7PhVEnicUYUnYApjdcIsX7fJyATj?= =?us-ascii?Q?FFSxX8EdOoo5J4VjrzaNVRAYWhb/pfgwKWDynkOiuVWK8PVTJZfPItnxb6l5?= =?us-ascii?Q?yTYvbBDykRIcWa8xDb+aXmnrhUdW+s/DKMDorDe+xvtW3tT2OgxiXIAELHdC?= =?us-ascii?Q?n1FtNC2SUwysUv1iB8WIQCOoqfg3O45YhL8k35fI9wBlNSv5Glv44MKziHc+?= =?us-ascii?Q?CYFQSxf8clPwvBh+NxPO3CG3dw9yDlWnYPtbfgfWrtuxIR8oN76v+v8Wz0UG?= =?us-ascii?Q?WZkAcNZB5crX2mPXzxR8PP/o6kytZbwjPYBYXSfpzC+o1LMehHBTR5R6DCzx?= =?us-ascii?Q?Tvbkv129gFqPtZY6fkvAcNAvnY+VvosM/MnMqEmK52LtupaJcw7cFqkSeu2u?= =?us-ascii?Q?+5zWymoT+kjoG5Kbav16eLZ2l1j98NoQyQHIWDZbCbT/OqaaWGTc0tRz5xZr?= =?us-ascii?Q?vUHHLU5gWPAT2zlG6LfuOUj6VyNYXxN4CP3NS3KkgSbprJBxYDJpPttRrE0J?= =?us-ascii?Q?gKSJMQcqnP0/DSdaXBqJzxlf+o6YXBrXJeEEDiQ7AnzCp0FRNXMqwn0XPC3g?= =?us-ascii?Q?+HXap5gnuO8E0GS8ZssvIZjJh3mhW8kU023Ywmh6jXoHVc93m8TSgPcU2wgE?= =?us-ascii?Q?PwaKB/gpRrVwCuKoweNNVshTgiYY0WIkFqmmZLdnF30CI7vf6+KxDWnSHBHn?= =?us-ascii?Q?syEA69sBsdofH2jNRVIoQeicf+Ra34KNKZr27Yrey2eWTRlTvBxbdYGHZIub?= =?us-ascii?Q?8ce4zE6PmyCHXxfq3kxePg7giyERMdGr38YuGCFOpq/w03x7ek5JSGWJ/bVu?= =?us-ascii?Q?pFFoPRjtcdM317Y5ZGxW4/BRyv8dUvt1EeV1zmfjx6S6nQWHAu+AA6GjKEgO?= =?us-ascii?Q?CPt0KQJxR7hOhhFQAnoTrVGBw+A+JkLa152J/dS1RNF8aTAAfKTirRJd8WPb?= =?us-ascii?Q?RlA7uRQy4Z5NC/rYgaez4qCnfgiFQqcjSUxVj05SYMAihzFg82UbTq9C7e2S?= =?us-ascii?Q?BYWKYm8kvL13GRMNe1T+t1iOrxIWBokwBAfC0kHAjqsajHVrloF/MprLOuWC?= =?us-ascii?Q?uve3JPhuN5THK+T70K6yfS2D+bDty3ylQBJYsGeAG2NgWFIBmf28aUuf+XCM?= =?us-ascii?Q?9hQWxUXeuXOIr8q67DLrPfvG4Z/Sa8mGUUZYsXVKah9gIe4/CkXEqvGcBMXB?= =?us-ascii?Q?Gd3Fgpdj05Z2h+p9/wCpnFQBvulrmYVOpjKlDsHOGseplrp3mBo46MN62ZPE?= =?us-ascii?Q?IVgRteV2nt02JtcOVWNWUwT6+LzW4s98O4ni4sBDOAUTIR/SbHGm78yYCJba?= =?us-ascii?Q?26pPfS3C6f298frP6P6wNh8LZ08K5/z+qmBKImjIPoU3Jx2ce1sts4aGzXVU?= =?us-ascii?Q?7y8Vq+VcTSAs5cFLF2Ijn8HYMk4DMGQgrKRefBt5GeJzUNKcIjlBir/CQxiC?= =?us-ascii?Q?lu+t2JqPdsP2GcEaCrCx7mqlBV+sRqUzalgoVXqcpCmL0xztShm/SmTVzE16?= =?us-ascii?Q?mliqS02eYjBM2SFXMKmvZQRMnuwwu8WxNwaCsUD+pIx3akZr+ZSblGrGx0Za?= =?us-ascii?Q?krBq/k+dUknHGiwcSjthCwuJXbSvszD4FN7wmwg4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 995cc5ef-8e24-4c5c-c646-08dbbd7d480e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2023 04:09:58.0459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ws0dgCbUj+rg1YJ62yBhdqyA8ffT37keHSMM+yDEvZ/O2efuLuQLkwHcCd+aF06Tr9VAn2zLZMn6UK2gIPdUPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4741 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kdAzN3Ccv4ekZJk3bs0dzCANx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZAYMXkv0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Pushed via: PR - https://github.com/tianocore/edk2/pull/4863 Commit - https://github.com/tianocore/edk2/commit/d11f0ea045f598e08b414eeba= 4f8a74ac1b4ca0b Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Thursday, September 21, 2023 2:17 PM > To: Cai, Xianglei ; devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Gao= , > Liming ; Shih, More ; > Huang, Jenny > Subject: Re: [edk2-devel] [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the > Address Device cmd when time out >=20 > Reviewed-by: Hao A Wu >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: Cai, Xianglei > > Sent: Thursday, September 21, 2023 11:58 AM > > To: devel@edk2.groups.io > > Cc: Cai, Xianglei ; Wu, Hao A > ; > > Ni, Ray ; Wang, Jian J ; Gao, > > Liming ; Shih, More ; > > Huang, Jenny > > Subject: [PATCH V2 1/1] MdeModulePkg/XhciDxe: Abort the Address Device > > cmd when time out > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4552 > > > > Following XHCI spec 4.6.1.2, software may abort the > > execution of Address Device Command when command failed > > due to timeout. > > > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: More Shih > > Cc: Jenny Huang > > Signed-off-by: Xianglei Cai > > --- > > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 36 > > ++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > index 53421e64a850..f6efcf80f376 100644 > > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > > @@ -2121,6 +2121,26 @@ RingIntTransferDoorBell ( > > return EFI_SUCCESS; > > } > > > > +/** > > + Set Command abort > > + > > + @param Xhc The XHCI Instance. > > + @param SlotId The slot id to be disabled. > > + > > +**/ > > +VOID > > +XhcCmdRingCmdAbort ( > > + IN USB_XHCI_INSTANCE *Xhc, > > + IN UINT8 SlotId > > + ) > > +{ > > + // > > + // Set XHC_CRCR_CA bit in XHC_CRCR_OFFSET to abort command. > > + // > > + DEBUG ((DEBUG_INFO, "Command Ring Control set Command Abort, > > SlotId: %d\n", SlotId)); > > + XhcSetOpRegBit (Xhc, XHC_CRCR_OFFSET, XHC_CRCR_CA); > > +} > > + > > /** > > Assign and initialize the device slot for a new device. > > > > @@ -2331,6 +2351,14 @@ XhcInitializeDeviceSlot ( > > Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; > > } else { > > DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfull= y. > > Status =3D %r\n", SlotId, Status)); > > + // > > + // Software may abort the execution of Address Device Command when > > command failed > > + // due to timeout by following XHCI spec. 4.6.1.2. > > + // > > + if (Status =3D=3D EFI_TIMEOUT) { > > + XhcCmdRingCmdAbort (Xhc, SlotId); > > + } > > + > > XhcDisableSlotCmd (Xhc, SlotId); > > } > > > > @@ -2547,6 +2575,14 @@ XhcInitializeDeviceSlot64 ( > > Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; > > } else { > > DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfull= y. > > Status =3D %r\n", SlotId, Status)); > > + // > > + // Software may abort the execution of Address Device Command when > > command failed > > + // due to timeout by following XHCI spec. 4.6.1.2. > > + // > > + if (Status =3D=3D EFI_TIMEOUT) { > > + XhcCmdRingCmdAbort (Xhc, SlotId); > > + } > > + > > XhcDisableSlotCmd64 (Xhc, SlotId); > > } > > > > -- > > 2.42.0.windows.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109035): https://edk2.groups.io/g/devel/message/109035 Mute This Topic: https://groups.io/mt/101493909/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-