From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.4366.1670377553453829378 for ; Tue, 06 Dec 2022 17:45:53 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OGiuzd0y; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670377553; x=1701913553; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=u3sE+qZYzjL0kx2vCtszTaAoGKq845qAlp7W52lsv8A=; b=OGiuzd0yV1xPlqu+Rq0dqMBiX4K3wSs4Q3yh8xiY4LMzba3btGyB8iWH XIGJQeDyIjv6mIjGRVQqse8ufh/5Rt8wE7ngMgWyIW63jQz3OGdpOYrhW Aqo2TRs8j2kKx0tMVdYfdmgXaOoTzHQkwYOY6GVwYjMYTH5ZWBQ915uou pSsm4JP8T8zttiM3hwdJ9HxG+tmyxf0uKTo/ok4xJAeVo7yNYAXgTtpW4 3uyGqBoF4h1x1FULXVZ/t6z6gDDcGhZ9eaFBdtWTxa/8VNllagRDP1JV6 BaAp05qN/3X8WlYSjVogjuidejg7ezFQuB+EtgtXXSFHT7oDi0jHTjqJR A==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="343808224" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="343808224" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 17:45:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="820789204" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208";a="820789204" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga005.jf.intel.com with ESMTP; 06 Dec 2022 17:45:52 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 17:45:51 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 17:45:51 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 17:45:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9izXwpOD+Ou/Ijh9H4RUfBziW3Rn3MngSx8R5azODXZdvhQD81fhnv0Ttj335PXArthy7d7o1j/E+JkLo5x05yshKdzq4aMC2O5Zjx1XsF43OaMQ1cWieDwnPX/E7+Lxp+1sVtTyqdDkI6Xyz4JfwZSn58vTCV0l64jNRm19AhEhRZ6/cZqVZNCfEO4mcQ7q6twsEfPOHm0UyOiNGBTEWBCKtZup3226FVeXsLXBHqoPxeU4syonCu+05AVo8EojKxEzAwNSBMf590WzBEZTddyCo+Xagg0MzOorWlq82hxqiSct8yI6M2RkwdYtt9XJq5dCWPn/Se3BUbf2hrw+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+rqLt7RSZu9z8x08dFJqd6QhVynxzIyG8beuTX2zBkA=; b=IX8y9QZZwvK32FdU3GSFfk8p7d0GsuaPCViZG0bDv2XlzLfdDFzn4ihAaIFy3PZ3Lh6gKdLmQysCpPek/DLUHvJl0bDdN80HzwAVDYciCBwjzUI2Bq8UwHZryg35fFnB7IXHkcQ/E0/dWwhAgTYpDrMIpcVvDmfkzcvBRWemkhlP8GmnwFiZAbxwEbIf5YdYIG01T/62pyHI8lR1QnOP7DNeL4rMwO4ZKZcwEe9GQsLznMLDPOuidFu+TIxMK4w27Id0ID5bwK6zTJ3WUgpIdvHr6jVFP3Q1zKtiICXtTtbjOO2C2aKwzzWYzsqxEoKW2gsGk1iegqKgKJVQywsv2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH7PR11MB5888.namprd11.prod.outlook.com (2603:10b6:510:137::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 01:45:49 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c%3]) with mapi id 15.20.5880.013; Wed, 7 Dec 2022 01:45:48 +0000 From: "Wu, Hao A" To: Chevron Li , "devel@edk2.groups.io" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , "shirley.her@bayhubtech.com" , "shaper.liu@bayhubtech.com" , "xiaoguang.yu@bayhubtech.com" Subject: Re: [edk2-platform][PATCH V2 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized Thread-Topic: [edk2-platform][PATCH V2 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized Thread-Index: AQHZCXGzNEFXjJHbb0WlG2THPA7TH65hoQ3Q Date: Wed, 7 Dec 2022 01:45:48 +0000 Message-ID: References: <20221206125246.1024-1-chevron.li@bayhubtech.com> In-Reply-To: <20221206125246.1024-1-chevron.li@bayhubtech.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH7PR11MB5888:EE_ x-ms-office365-filtering-correlation-id: f55cf1c9-fb5d-4bfa-21d3-08dad7f4c413 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nkqrq+VQKQn6lbEKeMAxzDXVdbQdtogMjy/8KsEiwI88W4jQOLEpzxPUCeS/QtXDq4Ki5mM7yFhuHsiIAwCs1lZsk+FlpTXNLqmmQ5ECPgedGkBkDnQW4Ak2obYYWFsrVKsJC5etTS6lehj1lD05KnAJAHpV4uYLqxybUeQBIDfYFppNMapnyqnct/pw5NDJqAQoqI6mQQ8VbcCSUwv1AxnxXZenIYHRAkp3GB/czSBDlFeVmbXlLyQnZRcJeDvp69Gz0akDrq81dMLzaNhVCliNRiCiOoV6F0mygSPMi8EWHD6HrQzu6KUGSu0AJnCNx6yZCAus4uF/NKtgGv/vwmYDviQLha/hU14bDsor0sy5LxpgWqpvtLC8aHvgTZROuJi0atK4vNjo3cPIzctGHJv4HRTriBfOVmRXVAQaJALaL3J8i4Ml6qxiJcS3lndkSOTMm02cUVRutG0CdXHDwS4wbpYVIFm8TLCWB9Q5W6Ifq8ncrN/dewaA6iusr8e1UDMyuVjrm1GdH3Uyo8O7zyu21s+eH6qxAvhyYgTv6vwjrbXu5EuXyCVYoaihsuB0lxxSmnrrdpuW/qcTSMibYE/88DBdYoWHaRQ+uiD39r5TJGlYXQi/VUFOR4XJe6Opo4+4G8hHFXq8YthTJF724TRLFrdAPwlhRUSg5x0Z4vAzX5Oo4LHDH9BGfYcV8TELVl4A60P4POauMJFqS9nxI8RVkpJK+I35oC6Ryyv1I7Yp45F1xEdpfc6HhFo4cdHIyOf/oUtXnOjGFs24CVgVTQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(136003)(396003)(376002)(366004)(346002)(39860400002)(451199015)(5660300002)(66446008)(64756008)(2906002)(8936002)(4326008)(316002)(41300700001)(66476007)(66556008)(52536014)(66946007)(76116006)(8676002)(71200400001)(122000001)(54906003)(478600001)(966005)(6506007)(7696005)(9686003)(53546011)(110136005)(26005)(33656002)(186003)(83380400001)(38100700002)(38070700005)(55016003)(86362001)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HSy9gU+Z4yY6DdQLwWvcY9O5QKCRfHlN2nNeEJsuvHXUzAJZVhHFNaChZ9B7?= =?us-ascii?Q?tPLCbvwOLm2Oe8PFu5fXiSiIfIjrujd4NElY/DlxhzNGS38hVmozNJ6b4wzF?= =?us-ascii?Q?ZoGrzhIgsV6vcJhYhXuqsggrrMHkG5ScNT+hFEyVW7sl2c/TUWwULGAjp2jG?= =?us-ascii?Q?NTZmfIJae4zBeV5QYRkxS01XRrvhB6NiAk1bv9oBEzo6N4LzdY34EnW0IFC6?= =?us-ascii?Q?beDzIrnGWsBD+AHguL3zl5bFb1BxPr3WxUHznk9CtuTQvw0x7oti5rmB3EEc?= =?us-ascii?Q?r+YD+6FuL8ObkCgX3W61Tyr3ZfFEVMytQSuiXMYJBiYyz4VtrM2U/QTfKxRI?= =?us-ascii?Q?O1S1BnJHf0oFxCo4o5ha2Jz3hNr1ZN3QjazM8no67PStHmxrIdrr2y8EhqzC?= =?us-ascii?Q?pzIJSPBND4w9Dhsk2UHoiExqvxcSy23hwxF71lHOkN+sJ9F+cpjerPKaMOQe?= =?us-ascii?Q?wTURtVksqmV6EKSLS2Kj5VA4IyCfpe3K4wtRQv5Thr2kqTez/xKRJFAYLJUb?= =?us-ascii?Q?W+pbrFDJ/3s6801VjgHzGpwd9fpL0T54MjNIe72oee59RF6mXnIPQB+9iWV9?= =?us-ascii?Q?o1qE+JT3RvYqzabkg3dessXPVZG6fo0zTJtM/OZJE5C5VtU2HLqADVDInhc2?= =?us-ascii?Q?L9vYRozlY/ZmQ38o2WgyhsTTljCUZLdzM/G0zr4ZWajAsZJAbHGNKs+KikSl?= =?us-ascii?Q?LZEtKGMjbMpcyCsTqaaTyXUHj/C7+f26G0aGTJX94nXqWEbbVcf3O/MStcGP?= =?us-ascii?Q?SSj816fSZ9Ne8MXOuD/gL52K8wt7GxXphyfcUd4NmIMRti41Er/sI9uXdZ9+?= =?us-ascii?Q?QtEae/6m5fRN5OCGYYhoBkUWvC5LHN+JXMFHr05ONFsSKcDcBe5o0FWaTYOZ?= =?us-ascii?Q?1B34ZYJhX9dmT+FfdDxELUrS3h/KDd04jeYwPQiBSVkqKy25hUGHn3DVhrTC?= =?us-ascii?Q?4I5h2kzYONVvlz6OB/v7wpxJzg1tR2ma1G8liaAfEuQt721q1uwOA5hWkaMo?= =?us-ascii?Q?KwD8UaAHYO1UtXieUJiQVht0JrwxUr76xXOgLmN98hheh7GGEAZZnJbnWD7Q?= =?us-ascii?Q?tM3bmjFxVJVXW6oO5dVv7+lkPZsWaKOiib+lneMXOMlyX6bF3Ft8TC7i9mf9?= =?us-ascii?Q?BXEEy89c7jkULssrzcmNRKD+f5+/5QSqV+5LKdWvSkfd2qbsHOBYGwZJiN7r?= =?us-ascii?Q?xJg5MrhD2Q7fWTrDenTKVPeBfQlqqzNgkx38upkycB5modJ6oXzA/vxXfwn2?= =?us-ascii?Q?fzRKeE8BapuVQcCdrmpT8Lmi0FWOq6FmP/H+E83IcLHdYYgTLo3dWVI9KMa0?= =?us-ascii?Q?Ksb9EwG8Db67Pnf64N/KCRUVkEwC6iugb3OrOrWEPOfiUU93ABUn0gtF8q5B?= =?us-ascii?Q?HVImw/Z4FcikfsRHsBk4oCFdD5w0PknXomxR1xkzw2ZL4V+HNAm03CoMqSf4?= =?us-ascii?Q?iHg0VtFrj+L2iLu3X2W1QF9rUx+Sy+SCsBQXGL8IBPF9gY0BnWT/BPnCuSne?= =?us-ascii?Q?UJ8LlNBq4R2IKrgIs+08IujXeB+cc6sxFhHWG7OYI/MCUTTdNtxNPSOlUIRQ?= =?us-ascii?Q?k29srD4umI/0+LRXwZlVzzmW6s9ZbnRbGJgX6fxq?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f55cf1c9-fb5d-4bfa-21d3-08dad7f4c413 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 01:45:48.7614 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V6WR4kbp345NKIxpJCmIbvBJQFSd3ouJ4MCKS8ECIx6XT2fiTBChfgET8BRuYMn3gH5vrKdpLbnDOMIojO/eWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5888 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry, The proposed patch still causes CI test failure: https://github.com/tianoco= re/edk2/pull/3724. Could you help to follow steps 10 and 11 in the below wiki page: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Pr= ocess#the-developer-process-for-the-edk-ii-project to make sure the patch can pass the CI test? Thanks in advance. Also, for below added code: ZeroMem (SwitchResp, 64 * sizeof (SwitchResp)); My take is that it will zero memories beyond the scope of local variable 'S= witchResp', could you help to double check on this? Best Regards, Hao Wu > -----Original Message----- > From: Chevron Li > Sent: Tuesday, December 6, 2022 8:53 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Wang, > Jian J ; Gao, Liming ; > shirley.her@bayhubtech.com; shaper.liu@bayhubtech.com; > xiaoguang.yu@bayhubtech.com; Chevron Li (WH) > > Subject: [edk2-platform][PATCH V2 1/1] MdeModulePkg: SdMmcPciHcDxe: > Fix issue that SD1.0 cards can't be recognized >=20 > From: "Chevron Li (WH)" >=20 >=20 > SD1.0 cards don't support CMD8 and CMD6 >=20 > CMD8 result can be used to distinguish the card is SD1.0 or not. >=20 > CMD8 result can be used to decide following CMD6 is sent or skip. >=20 >=20 >=20 > Cc: Hao A Wu >=20 > Cc: Ray Ni >=20 > Cc: Jian J Wang >=20 > Cc: Liming Gao >=20 > Signed-off-by: Chevron Li >=20 > --- >=20 > Changes in V2: >=20 > 1.Update description comment for input parameter 'SdVersion1'. >=20 > 2.Add variables initialize operation to avoid unexpected value. >=20 > 3.Use TRUE replace with 1 to assign value for BOOLEAN variable. >=20 > --- >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 34 +++++++++++++-- > ---- >=20 > 1 file changed, 24 insertions(+), 10 deletions(-) >=20 >=20 >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c >=20 > index f5a3607e47..262f675ea2 100644 >=20 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c >=20 > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c >=20 > @@ -1074,6 +1074,7 @@ SdGetTargetBusMode ( >=20 > @param[in] Slot The slot number of the SD card to send the > command to. >=20 > @param[in] Rca The relative device address to be assigned. >=20 > @param[in] S18A The boolean to show if it's a UHS-I SD card. >=20 > + @param[in] SdVersion1 The boolean to show if it's a Version 1 SD c= ard. >=20 >=20 >=20 > @retval EFI_SUCCESS The operation is done correctly. >=20 > @retval Others The operation fails. >=20 > @@ -1085,7 +1086,8 @@ SdCardSetBusMode ( >=20 > IN EFI_SD_MMC_PASS_THRU_PROTOCOL *PassThru, >=20 > IN UINT8 Slot, >=20 > IN UINT16 Rca, >=20 > - IN BOOLEAN S18A >=20 > + IN BOOLEAN S18A, >=20 > + IN BOOLEAN SdVersion1 >=20 > ) >=20 > { >=20 > EFI_STATUS Status; >=20 > @@ -1095,6 +1097,8 @@ SdCardSetBusMode ( >=20 > SD_MMC_HC_PRIVATE_DATA *Private; >=20 > SD_MMC_BUS_SETTINGS BusMode; >=20 >=20 >=20 > + ZeroMem (SwitchResp, 64 * sizeof (SwitchResp)); >=20 > + >=20 > Private =3D SD_MMC_HC_PRIVATE_FROM_THIS (PassThru); >=20 >=20 >=20 > Capability =3D &Private->Capability[Slot]; >=20 > @@ -1117,10 +1121,13 @@ SdCardSetBusMode ( >=20 >=20 >=20 > // >=20 > // Get the supported bus speed from SWITCH cmd return data group #1. >=20 > + // SdVersion1 don't support the SWITCH cmd >=20 > // >=20 > - Status =3D SdCardSwitch (PassThru, Slot, 0xFF, 0xF, SdDriverStrengthIg= nore, > 0xF, FALSE, SwitchResp); >=20 > - if (EFI_ERROR (Status)) { >=20 > - return Status; >=20 > + if(SdVersion1 =3D=3D FALSE) { >=20 > + Status =3D SdCardSwitch (PassThru, Slot, 0xFF, 0xF, SdDriverStrength= Ignore, > 0xF, FALSE, SwitchResp); >=20 > + if (EFI_ERROR (Status)) { >=20 > + return Status; >=20 > + } >=20 > } >=20 >=20 >=20 > SdGetTargetBusMode (Private, Slot, SwitchResp, S18A, &BusMode); >=20 > @@ -1141,9 +1148,14 @@ SdCardSetBusMode ( >=20 > } >=20 > } >=20 >=20 >=20 > - Status =3D SdCardSwitch (PassThru, Slot, BusMode.BusTiming, 0xF, > BusMode.DriverStrength.Sd, 0xF, TRUE, SwitchResp); >=20 > - if (EFI_ERROR (Status)) { >=20 > - return Status; >=20 > + // >=20 > + // SdVersion1 don't support the SWITCH cmd >=20 > + // >=20 > + if(SdVersion1 =3D=3D FALSE){ >=20 > + Status =3D SdCardSwitch (PassThru, Slot, BusMode.BusTiming, 0xF, > BusMode.DriverStrength.Sd, 0xF, TRUE, SwitchResp); >=20 > + if (EFI_ERROR (Status)) { >=20 > + return Status; >=20 > + } >=20 > } >=20 >=20 >=20 > Status =3D SdMmcSetDriverStrength (Private->PciIo, Slot, > BusMode.DriverStrength.Sd); >=20 > @@ -1214,8 +1226,10 @@ SdCardIdentification ( >=20 > UINT8 HostCtrl2; >=20 > UINTN Retry; >=20 > BOOLEAN ForceVoltage33; >=20 > + BOOLEAN SdVersion1; >=20 >=20 >=20 > ForceVoltage33 =3D FALSE; >=20 > + SdVersion1 =3D FALSE; >=20 >=20 >=20 > PciIo =3D Private->PciIo; >=20 > PassThru =3D &Private->PassThru; >=20 > @@ -1231,12 +1245,12 @@ Voltage33Retry: >=20 > } >=20 >=20 >=20 > // >=20 > - // 2. Send Cmd8 to the device >=20 > + // 2. Send Cmd8 to the device, the command will fail for SdVersion1; >=20 > // >=20 > Status =3D SdCardVoltageCheck (PassThru, Slot, 0x1, 0xFF); >=20 > if (EFI_ERROR (Status)) { >=20 > + SdVersion1 =3D TRUE; >=20 > DEBUG ((DEBUG_INFO, "SdCardIdentification: Executing Cmd8 fails > with %r\n", Status)); >=20 > - return Status; >=20 > } >=20 >=20 >=20 > // >=20 > @@ -1426,7 +1440,7 @@ Voltage33Retry: >=20 > DEBUG ((DEBUG_INFO, "SdCardIdentification: Found a SD device at slot > [%d]\n", Slot)); >=20 > Private->Slot[Slot].CardType =3D SdCardType; >=20 >=20 >=20 > - Status =3D SdCardSetBusMode (PciIo, PassThru, Slot, Rca, ((Ocr & BIT24= ) !=3D > 0)); >=20 > + Status =3D SdCardSetBusMode (PciIo, PassThru, Slot, Rca, ((Ocr & BIT24= ) !=3D 0), > SdVersion1); >=20 >=20 >=20 > return Status; >=20 >=20 >=20 >=20 >=20 > base-commit: 7bee2498910a9034faaf90802c49188afb7582dc >=20 > -- >=20 > 2.18.0.windows.1 >=20 >=20