From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.36783.1639546989300485264 for ; Tue, 14 Dec 2021 21:43:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.com header.s=intel header.b=DheVFUAK; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639546989; x=1671082989; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jZRzXz2w2rAl8lDLmUJjPSrUSdudFijc5i3KVK+BYEA=; b=DheVFUAKuHESJVrg+1PtgQqtkCb2RqwlQFYkxnr2LbTN06S2/QBzlUaa Qu8+2RQRhv8JnfZ5+56pFKTWW6cGvhA+fB0wgZZdTih8BFs5awRCXmnbP 7sOATiaGfx24Oq9ofp3MUpJQU08T1ZuwX6bMRrhDKaaRKzT9RXNcPCvA6 y8A+vhhuenM+EEQ1lfxjHhl3T9mDqKxcSE9/djGxv5F5LXKD/GMc2eCGZ 2rz99M88BiUfsrCQIMWjobosH6FEGRU3GV4hrIqhJWivNik52M4sg9pDB fo607mavyPfPa+oh98yqAbc/ZByAr0ut2hCN3HuGh9Gz6/EXBbjB3PZ0O w==; X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="226434777" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="226434777" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 21:43:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="661744560" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2021 21:43:08 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 21:43:07 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 21:43:07 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 14 Dec 2021 21:43:07 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 14 Dec 2021 21:43:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7/sOrsE1bzYek+XpEq77PpOci9KUSZKbPlqRRm/1RhZid/yW79D/1nIffvJTCwH0DvdrMKTtQuI53wfHwLwHSVsRD9L8mvZ3UUj+0XwIhWu/krXgEX7H4hBKxdEBU4FJ7yQU9+TNVbP2P/zEdsWsZsuijyPWpV8AfUBePKRekXeJjfLaldVT7O/T7Ux43qAVI0ZYO5OYbm9ZiNlb20twjVLXxq/Js1QRMxhgSDr2qKu5Rt7zMFKGqWuEAmPbaqT0mK8WFCB4DfxrAG3JV7VVQOD8f4mQHK4leJEitzr0nPMivXTfU28GY2yKnE4BkUvhblxsOzgpc+0WAHENMlrvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DKiBsTuab8RKkvMx0VOodJx3NYS/VotsoF5RBlUenGo=; b=IFICpvi5Aj4if4HXoD7XYICpLuCdsyZD69D6fgtzgm3KX9yCneWY1Sx5kT6FlunJBD3tLS2k2Lzho7WnCO1wc6dIs/ZVDxSfkztgk0uLn6jg+711b6h+SLlyiTnbEm/RrpwCfOv8vM+vtJtKd3yMfbrbqGIjO8VLpZwLbkH2gTROn5z/RNxnTydOdMiVW1Pfl3uGk12RzzzHU563VE740NXX4ujyUJZZRQowm7/d4m+HNFf2Vv9AFZ5VEgdg4z0fwRnr2L4bOoKuqzhFSq+HUs3B0mjopqyWXujBpoIuTFW3PIicnxeI6pRGHAwP6GOKrT0eQtPDNPlVWWXA5zp+6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DKiBsTuab8RKkvMx0VOodJx3NYS/VotsoF5RBlUenGo=; b=j/kgMGIJAS4n3+2/dgbvLq3S8e38IhhnOZiSL1TV8zYO8k0K9i5iOWlATRD7hfoaCmm28Tk9i0AQ3RP03jBWzRd/uY8opfFu4M92H3f50g8aFwX4RblVbo1KluVfY7wbHv9IJrnbZAJYAaDrQgko/9IysEiEJoK7b57CnZs96oI= Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB2875.namprd11.prod.outlook.com (2603:10b6:5:cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Wed, 15 Dec 2021 05:43:05 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%5]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021 05:43:05 +0000 From: "Wu, Hao A" To: Jeff Brasen , "devel@edk2.groups.io" , "Kinney, Michael D" , "Gao, Liming" , "Zeng, Star" CC: "Ni, Ray" Subject: Re: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Thread-Topic: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY Thread-Index: AQHX8RRhP+NC435QqEyMgowdUQbl8Kwy2ghggAAhxYCAAA6JwA== Date: Wed, 15 Dec 2021 05:43:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ace6577d-1adc-44dd-0e26-08d9bf8dc42b x-ms-traffictypediagnostic: DM6PR11MB2875:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: peLgIkEI4mcgV2q8VtiVW3fAFS7hRkjoRbzsY6HJwp1bappfIiBDmFfmoC8HcEDBtlTMy2VtIs1ZzVjfZN5OPfz5CLL4+WCxVZRu5y8GzBKQf09tSvOHNF+aEAG1usOU3sRFPwIh0tSlUUMXB6vR46kju0w7wzpItddmIXVq+2X+oy1RGM34D4b3rBH4RBLxgL9VMFrwHo7TO7lOtd1qgS5bDi8vAIRirW3G6ehhRZ4OicmjOPsxEZjsEiaSyuWADKSYHZ9rJOShxiRXnmpVKtz+ogp4p272+ZjXtYvX6hhzvMQueE/Nd/Xeqk+5TLcCeCqTOCBRahF+zsHQPkiBqUNDTtQ2ilbWUBrFL5y1kjzcde/a1ITtRC9PPGlLOZa8Wlh36NMn9nOlxEEaInNyNHeM4S+7zo0h4OKobRIKIVKB8T9nOFiCPZCr7HmtlbpWZY60ANll4K1b9JQg0rfIr2BDX9iCtRQosmQNYcwachlcIjHtwuxBPgLZqn6U0aDP9PAvyxCmXNAcDHd3L/jkR1EzdDVQkMbvxUS6QBXu/M/XNHCPl2u7sGjyCrQdQLBZ2OMkAqUVch8Ek2gjfNuQA9xiCZ8rEhqZ0kAAZE5Krp7Hb9Kgyh4OEWHRHBepPaxBkprNNo4QMg1185iBXygPMKUS4FvTpE8hbwIb46kMfmxnrL11b+ChZDl2O7athE45Xw0LhejE/VEJiTDyyJ3CSQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(508600001)(26005)(38100700002)(52536014)(122000001)(9686003)(83380400001)(316002)(64756008)(8676002)(86362001)(71200400001)(5660300002)(82960400001)(2906002)(55016003)(7696005)(4326008)(53546011)(6636002)(6506007)(110136005)(33656002)(66476007)(107886003)(38070700005)(66556008)(8936002)(66946007)(76116006)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LqZ0h2tpgKoYo+R3fF4GKtyLcK6NeeVFKm4XZp8ZFYdAxj/L38Zxn3TyioWG?= =?us-ascii?Q?px9sWvkA9EmT/P6pKMM8zCEgCkHem+Trw1KXyjVG1hlwXy3mIfdtORbfPHeC?= =?us-ascii?Q?/9cyGPPnC6cR36UeBXyZFmaAmrnk3PmwSxVzROo+ZuRAzV1hzygIprvndWzI?= =?us-ascii?Q?p1syR6Pj4KORsrHud9I3cd2//49xh8soTJzhq/c/BU0PJnqCPGHvG/JCR0yp?= =?us-ascii?Q?Cp1/pIyzk7hQ3dY13MV+5C4FSJKglqKDT+n0HWWdVaK4itV0Dn77kGuBR7UK?= =?us-ascii?Q?hWKM9GBpx4yOPOhysPRduUJRUqrbnwvu1ovD72cNnX5aQADuhRgFGdB5G1R5?= =?us-ascii?Q?qwlkUmWPy6dk3JAiqB8bowGS4winA5+DCt3fUkvXld5eKKMWhOrzfRf4BTts?= =?us-ascii?Q?fWbjDAvyqc5Zk1l3JrA9qbqxZIaakG6Uxi1aQ4ae2pfZQemWoy+UZViKVCdJ?= =?us-ascii?Q?O0njkMuVmhIqycYbmtcXl0BwSLdf8+TClNbTbfjOn7PoskgGQO/LnNfzebne?= =?us-ascii?Q?DhTNygWVaRyUre6JPUUT9e5C1ihVyt6d9Dp91zlYT1eQGjkoUVnPwsyWdil+?= =?us-ascii?Q?o1gRYvdAbKQ7NvyFW213kJ4wBaKVNqdGbh3wxZRQt1pVYVLxSvtgPMwF1q20?= =?us-ascii?Q?8vfxqTYXUt4k/2mgJBknLWnZ0Uz4lDkOz36fRSCQFWZcb5xT/UnWTNDLBDoe?= =?us-ascii?Q?vs/wRYEKX04CmgT5qgyL0Bhovp5ciqrkBXrOui8gG2iNdaWV6djUtS9M/04X?= =?us-ascii?Q?nwrEHbv3Jny57vaI4JyHbjnu2U+VWZue9l+pFRlAjAujpAE+xsldJ677/nCV?= =?us-ascii?Q?i70x2tzbOIxDLjsQztfDmA3orrG0udztvnr5fx9x/WGWmm+MIl9y1HsQQyFa?= =?us-ascii?Q?MFWW1tQprDJ2BAnirIztnf+4WtlxJnCf/+fKsX0PGZZP5QjOwrh8fOpyrIgn?= =?us-ascii?Q?G/jIRvwYak53zqGJVqrOS4nldoP6DHSpckf0UErf/dAXC+CQflSUrEx3AC+4?= =?us-ascii?Q?FYoCjFzs8CyrtWMRnHDLNt/hyyTLudm6UzYRlVpPCxCFp4RArspx4NBmXyNl?= =?us-ascii?Q?HuhzWcuOxGaqHJ3GKKrKwTISI+FMP2805VFWGhPu23W17ECYVj3XtWdwBhvY?= =?us-ascii?Q?lRFuhAYmTZLXsjk6/vtBqy3IIYaUAWLQnxAoT0V5BhCfPBlqWoKgpVjBUaYJ?= =?us-ascii?Q?hP5UXXRku8V9VcCWvWIzfc/yrywqGd3BZLdHeqKc9gyzVdUlCEkg5fGU37D4?= =?us-ascii?Q?inTjc7XDiyNjFrekeV2Mn8F0aVmEDIGBjFXGRl/0oyFor9tIRUAOmcY1coCH?= =?us-ascii?Q?FUZh2436WLAFhrVQTuCJf2KoYzsi8QXtLecjaqr5R2ZyWbqlzTlmLbQ8XKeZ?= =?us-ascii?Q?lGcT1r/Ahzn80HWENNSm8Ga3Vpi2DtYoWW8i5k7OXBfmb3GW24AD0P1fJpoz?= =?us-ascii?Q?MpHPvONEqKb1noGoFA94XIC1tP7+nJWkImWwDlkVYIIqZsWKS6sh0cJOtqd1?= =?us-ascii?Q?+fHFJ4eY/j27TKAgnt7sxn7+Ju05BtwlqcKW+3GIQjYNhsmylLtMVCTKTcvN?= =?us-ascii?Q?XObdlLBty4OGnwD9nTQfJ2BOIzFN9jyRnRtDfpdjgKjNyAEwUupMPFKFXAce?= =?us-ascii?Q?qKQUQaxeOlLoXDO6q7YXaR8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ace6577d-1adc-44dd-0e26-08d9bf8dc42b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 05:43:05.1304 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: acP9oQpY3GTiAMkCmaoO4+TYKRZ0Zm6Q5WgqPuskYwbZTlSXV5bXnBeliYzEYhvs7/FCfeIq6+L/OjhG2YlzTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2875 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable (Add more people) Hello Mike, Liming and Star, Do you have suggestions for the below question raised from Jeff Brasen: " The core of the issue I am trying to solve it support variable services o= n a UFS device. When the UFS blockIO is invoked from variable services it i= s not allowed (which does align from the UEFI spec perspective but does not= allow me to implement variables services on UFS) The other way that worked was lowering the lock TPL level in the PCD drive= r and Variable down to callback. The PCD one seems like it should be done a= s variable services is supposed to only be called from <=3D TPL_CALLBACK. H= owever, I was worried about that having a larger system impact on that chan= ge." Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: Jeff Brasen > Sent: Wednesday, December 15, 2021 12:48 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Tuesday, December 14, 2021 8:00 PM > > To: Jeff Brasen ; devel@edk2.groups.io > > Cc: Ni, Ray > > Subject: RE: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > > > External email: Use caution opening links or attachments > > > > > > > -----Original Message----- > > > From: Jeff Brasen > > > Sent: Wednesday, December 15, 2021 1:59 AM > > > To: devel@edk2.groups.io > > > Cc: Wu, Hao A ; Ni, Ray ; Jeff > > > Brasen > > > Subject: [PATCH] MdeModulePkg/ScsiDisk: Change TPL to NOTIFY > > > > > > Increase TPL to TPL_NOTIFY to allow for use if caller is > TPL_CALLBA= CK. > > > This allows services like variable services that run at TPL_NOTIFY > > > to be hosted on ScsiDisks (i.e. UFS) > > > > > > Aligns with the eMMC driver that also uses a higher TPL. > > > This change was made in 3b1d8241d0dac25c5e678c364fa2754ac1731060 > > > > > > Sorry, my take is that this change is not equivalent to the one made > > in the SD/MMC stack. > > > > For the SD/MMC change you mentioned (commit > > 3b1d8241d0dac25c5e678c364fa2754ac1731060), the TPL is raised to > > TPL_NOTIFY only when: > > a) Operation to the linked lists that manage the asynchronous IO task= s > > b) Callback functions that process the asynchronous IO tasks The TPL > > remains TPL_CALLBACK during the BlockIO services and the majority of > > the > > BlockIO2 services (operations to asynchronous tasks linked list are > > the exceptions). > > > > But the proposed change in ScsiDisk modifies the TPL level of the > > entire > > BlockIO/BlockIO2 (and other protocols) services to TPL_NOTIFY. > > For me, this is not aligned with the "TPL Restrictions" documented in > > the UEFI specification. > > > > Best Regards, > > Hao Wu > > > > >=20 > I had sent out a query on this before and didn't see any response. The co= re > of the issue I am trying to solve it support variable services on a UFS d= evice. > When the UFS blockIO is invoked from variable services it is not allowed > (which does align from the UEFI spec perspective but does not allow me to > implement variables services on UFS) >=20 > The other way that worked was lowering the lock TPL level in the PCD dri= ver > and Variable down to callback. The PCD one seems like it should be done a= s > variable services is supposed to only be called from <=3D TPL_CALLBACK. > However, I was worried about that having a larger system impact on that > change. >=20 > > > > > > Signed-off-by: Jeff Brasen > > > --- > > > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 22 > > > ++++++++++---------- > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > index 98e84b4ea8..b6e5848e77 100644 > > > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > > > @@ -514,7 +514,7 @@ ScsiDiskReset ( > > > SCSI_DISK_DEV *ScsiDiskDevice; > > > EFI_STATUS Status; > > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > > > > > > @@ -581,7 +581,7 @@ ScsiDiskReadBlocks ( > > > EFI_TPL OldTpl; > > > > > > MediaChange =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -733,7 +733,7 @@ ScsiDiskWriteBlocks ( > > > EFI_TPL OldTpl; > > > > > > MediaChange =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -898,7 +898,7 @@ ScsiDiskResetEx ( > > > SCSI_DISK_DEV *ScsiDiskDevice; > > > EFI_STATUS Status; > > > > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > > > > @@ -975,7 +975,7 @@ ScsiDiskReadBlocksEx ( > > > EFI_TPL OldTpl; > > > > > > MediaChange =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -1154,7 +1154,7 @@ ScsiDiskWriteBlocksEx ( > > > EFI_TPL OldTpl; > > > > > > MediaChange =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -1323,7 +1323,7 @@ ScsiDiskFlushBlocksEx ( > > > EFI_TPL OldTpl; > > > > > > MediaChange =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_BLKIO2 (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -1717,7 +1717,7 @@ ScsiDiskEraseBlocks ( > > > EFI_TPL OldTpl; > > > > > > MediaChange =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_ERASEBLK (This); > > > > > > if (!IS_DEVICE_FIXED (ScsiDiskDevice)) { @@ -1907,7 +1907,7 @@ > > > ScsiDiskReceiveData ( > > > AlignedBuffer =3D NULL; > > > MediaChange =3D FALSE; > > > AlignedBufferAllocated =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -2122,7 +2122,7 @@ ScsiDiskSendData ( > > > AlignedBuffer =3D NULL; > > > MediaChange =3D FALSE; > > > AlignedBufferAllocated =3D FALSE; > > > - OldTpl =3D gBS->RaiseTPL (TPL_CALLBACK); > > > + OldTpl =3D gBS->RaiseTPL (TPL_NOTIFY); > > > ScsiDiskDevice =3D SCSI_DISK_DEV_FROM_STORSEC (This); > > > Media =3D ScsiDiskDevice->BlkIo.Media; > > > > > > @@ -2294,7 +2294,7 @@ ScsiDiskDetectMedia ( > > > > > > Status =3D gBS->CreateEvent ( > > > EVT_TIMER, > > > - TPL_CALLBACK, > > > + TPL_NOTIFY, > > > NULL, > > > NULL, > > > &TimeoutEvt > > > -- > > > 2.17.1