From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "abner.chang@amd.com" <abner.chang@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kuei-Hung.Lin@amd.com" <Kuei-Hung.Lin@amd.com>,
"Ni, Ray" <ray.ni@intel.com>,
Garrett Kirkendall <garrett.kirkendall@amd.com>
Subject: Re: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value
Date: Mon, 12 Dec 2022 03:27:19 +0000 [thread overview]
Message-ID: <DM6PR11MB40259DC433410F04CB8E4B8FCAE29@DM6PR11MB4025.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221210150824.1231-1-abner.chang@amd.com>
For the 3 patches:
[PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block
[PATCH V2] MdeModulePkg/Usb: Read a large number of blocks
[PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value
I found that they will cause CI failures: https://github.com/tianocore/edk2/pull/3749
Could you help to update them and help to ensure they can pass the CI test? Thanks in advance.
Best Regards,
Hao Wu
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Saturday, December 10, 2022 11:08 PM
> To: devel@edk2.groups.io
> Cc: Kuei-Hung.Lin@amd.com; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>;
> Abner Chang <abner.chang@amd.com>
> Subject: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context
> value
>
> From: Abner Chang <abner.chang@amd.com>
>
> In V3: Add AMD copyright.
> In V2: Remove the signed-off-by: Abner Chang.
>
> Initialize XHCI DCI slot's context entries value.
>
> Signed-off-by: Kuei-Hung Lin <Kuei-Hung.Lin@amd.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> ---
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++++++
> MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> index 13b0400e83d..f08722905f3 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> @@ -4,6 +4,7 @@
>
> Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.<BR>
> Copyright (c) Microsoft Corporation.<BR>
> +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -2807,6 +2808,9 @@ XhcInitializeEndpointContext (
> MaxDci = 0;
>
> NumEp = IfDesc->NumEndpoints;
> + if (NumEp == 0) {
> + MaxDci = 1;
> + }
>
> EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> for (EpIndex = 0; EpIndex < NumEp; EpIndex++) {
> @@ -3006,6 +3010,9 @@ XhcInitializeEndpointContext64 (
> MaxDci = 0;
>
> NumEp = IfDesc->NumEndpoints;
> + if (NumEp == 0) {
> + MaxDci = 1;
> + }
>
> EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> for (EpIndex = 0; EpIndex < NumEp; EpIndex++) {
> diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> index cc597a43717..8400c90f7ad 100644
> --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based
> on gPeiUsbControllerPpiGuid
> which is used to enable recovery function from USB Drivers.
>
> Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -1752,6 +1753,9 @@ XhcPeiSetConfigCmd (
> }
>
> NumEp = IfDesc->NumEndpoints;
> + if ((NumEp == 0) && (MaxDci == 0)) {
> + MaxDci = 1;
> + }
>
> EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> for (EpIndex = 0; EpIndex < NumEp; EpIndex++) {
> @@ -1974,6 +1978,9 @@ XhcPeiSetConfigCmd64 (
> }
>
> NumEp = IfDesc->NumEndpoints;
> + if ((NumEp == 0) && (MaxDci == 0)) {
> + MaxDci = 1;
> + }
>
> EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> for (EpIndex = 0; EpIndex < NumEp; EpIndex++) {
> --
> 2.37.1.windows.1
next prev parent reply other threads:[~2022-12-12 3:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 15:08 [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Chang, Abner
2022-12-12 3:27 ` Wu, Hao A [this message]
2022-12-20 2:45 ` Chang, Abner
2022-12-20 3:03 ` Wu, Hao A
2022-12-20 3:05 ` Chang, Abner
2022-12-21 15:44 ` Chang, Abner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB40259DC433410F04CB8E4B8FCAE29@DM6PR11MB4025.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox