From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.34609.1670815647726685244 for ; Sun, 11 Dec 2022 19:27:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=llPaZf6w; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670815647; x=1702351647; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yF4pQZJOdy3xFAc+3hTZudIeZuVDSu/FDiV2/jwMZeA=; b=llPaZf6wxjltDHPfwm+poVrT53VuyxwssWW40b0nnMHWyUfjOvEkSPq+ ttPVRzRaZhflf87RqvPveD3KFeqLveKS9BwwKLti7POm567HOEjJ+ASgR 3A42+se6iOc3KeTFWIcL+ekABnAaXsX33Uv5MYOPZ9HbkJf9gC/ivmKza 0EaXyKzaIfK8coIJCpw+MVm5xwzPNGKOIan1W6ZxoizR+Kdf8AyFq85Ev P9+IwdIYSPN1FgAue4u3cSzSII8DhoV3QHpJnqJADNwBdA84Cod9gayKb PhCshrP81npxJSj6sFw7vnzRHiNUoi4aSaGFj7clj1SdPExL9VfrOcbBY A==; X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="382066381" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="382066381" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2022 19:27:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10558"; a="711520375" X-IronPort-AV: E=Sophos;i="5.96,237,1665471600"; d="scan'208";a="711520375" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 11 Dec 2022 19:27:26 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 11 Dec 2022 19:27:26 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 11 Dec 2022 19:27:26 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 11 Dec 2022 19:27:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1O0Sc8l61esRU8PXRCjJ6Bve0VH+dRGQ2R7UTpq5cBv04JjxzJzzDyYbDW3yxqOyQCugs5W63aE7FqSMc3PWWB/soeKixBgsHrNCHTujJQHjEllvFNxOLaj5UcQrbJNKQI2ODtSPgDjTzdzgaq/WYWcpPmXPspbxmw6qdYCO9UQuUPBGzElLkuR8wrYE/VTxrLWnB719sc6PqKfvnpPpuMqXqUQp3hjwvLc+EqxRneXpTEfrwK/b72Bp2dZPnYn5Pt5idaj+hJMAb5DqqXCdHTWYjd0i1j6621IjbL9XQH0fx04sm+0nGQ6bWldnFZOmX30UoVnz1e+sgfQU/4aug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WJ76SqbQjnbueEfWxQ1Ek84Bmx+2OweDlRQ+Bfgy26E=; b=aI9IB06At33BaLSPL+x5ozAiFXq8qH+9Y9/wYQkMzfRpBcYKRRgWsyJdeR96UuxykRjKzzQ5FzZqYPpD3x9R9snHPKE22l1mA9E42LO4r7hOBuxR/pJniYpI6DFgvw2SzbhViog4A8dWBPGbdPyeCCi8hYSaHAG7vo6gBNlUvzmq930vXfHSWImzQtVkdcHozvu7zyOOs6xETF1ao5S96DUuf+Ql6PABNFTASbJ3xVkPTD92X4XJ663kgPumNwiIx/06sy8NOgYYuoDv3OE2aEi5HwP6KGVlYJaTZlUeBk1+pxM/wRgDia1/dxzSH8gEski9zySeirK3/zttSqdXDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM4PR11MB5312.namprd11.prod.outlook.com (2603:10b6:5:393::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Mon, 12 Dec 2022 03:27:19 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c%3]) with mapi id 15.20.5880.019; Mon, 12 Dec 2022 03:27:19 +0000 From: "Wu, Hao A" To: "abner.chang@amd.com" , "devel@edk2.groups.io" CC: "Kuei-Hung.Lin@amd.com" , "Ni, Ray" , Garrett Kirkendall Subject: Re: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Topic: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value Thread-Index: AQHZDKlVl1w3DfWZvkWyzKr1Rk5Ky65pkOOA Date: Mon, 12 Dec 2022 03:27:19 +0000 Message-ID: References: <20221210150824.1231-1-abner.chang@amd.com> In-Reply-To: <20221210150824.1231-1-abner.chang@amd.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|DM4PR11MB5312:EE_ x-ms-office365-filtering-correlation-id: a5071213-b7ae-4a92-a74d-08dadbf0c655 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GNO1BAQyLF0BWu1JjgbZ6u6QhiFaNFN+6j41Dl5GFJoK9uNbqTwVs9NsRoKEN+ckm5d6lbsd37qvWszyG7uhZD80Z9hbcdBM3bpvSZUoijezZAd4fr3PyQvtse4zuppPj+LqZA7e8OL7ycdPoyASI95ENJ9zKz42Lp/aWC02qQe9p5+bcHqtJ27sybIovXM4YNbCrg1jbd/lAWTXKsS0QkhFT1n7F7ySZxpP9JQW9dmoJo4/AEhn7l0p5OB0B11C5hNi73Y4qO2LVo11iah0ZveLLyhkOjFQ9UGGmZum4S2kHE+uruL65TXFLMQPjNS6NH2FI2TX4VTH4DU2rwkVIHT9oB5Z7Hw99EkRtsI2MeBNpk7FhhdM1jQ0dUS/5YYzzqsWsxbLBWoD021xUHF2FVhGnvX0YGXDjrvvzdYbkahcG6WltXVw/k8nBBiBDlbzgz5NQe5RhkMbLKIodvrEfZSPiKSqFElI9FWj72m3ditKWlCSmtY6LsoUS5eYX6vwgfqGbJ0g+6/0qvF/q3IfCe+ELL8dZkCuVOb+6Ik3fjKwPnNs3U1IcQwkksaVqMAKjbC2OSJM4rNT3cWSO1PTNh7+bYGIMav5dCrRJ1iBv1JU0MjXkZ1G+9AVCeBYu7JCM0A8SZ2mFGmHrNeiHMH19iWUrwAaQU9deGEkbHUu43m6xGU1cgk4ebupgq2Lsdxyine3M/GwydxAXcA2o8ioaUX0W1+WvFOlgODLp9T6Jty4njH77OUJODfFXLmbcaFE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199015)(38070700005)(55016003)(86362001)(7696005)(33656002)(966005)(478600001)(71200400001)(53546011)(45080400002)(6506007)(9686003)(66446008)(5660300002)(52536014)(4326008)(8676002)(66946007)(64756008)(66476007)(66556008)(41300700001)(316002)(110136005)(2906002)(19627235002)(8936002)(76116006)(54906003)(122000001)(26005)(82960400001)(38100700002)(186003)(83380400001)(64893003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/PINa2/TPVq+kXcSY1FzYrWqHNv5JdvpC/QoTtDcsUvblOj4zvyk+JFaoRnR?= =?us-ascii?Q?dtrkAf7g+4aygpj+aumMUnbm+wXq1KHWw5El4SsXU+7M+ToCMpVjur1KuY1S?= =?us-ascii?Q?D89kEfBYRRFCr099Y+eDVUUUU1BkBPZLbFgj0fvGGguI58Vi68YaZF4lang0?= =?us-ascii?Q?ssUW2ChNu5SyOtYYhqA2OWWFHZUSio+OyjWHsdHsi50KcJZI/XMnc5TcdS9S?= =?us-ascii?Q?PtByrMvaVUqfMzzyQ4VzMwmPo0icAstWmo4QFLxUaJ/PMsGLN81FPODeQedU?= =?us-ascii?Q?7tcWLY1DXSIkJkCOORj3wzcw9CDIDwMI6Lc9wmL4CR+W7Enkl71hF8OzQkU7?= =?us-ascii?Q?vdW3U++qklpSSXT2Ha1qSNYSqdVI2WYBBZyy5N9neLtCsHaDRN+5A+LcyXnp?= =?us-ascii?Q?6Lq2txnQLwJOz6OS4k1ujDOoRmFaHrIgp2InqMQdpL00FfEGyXmym8xPHAJt?= =?us-ascii?Q?3r+kstReFgu73lqv+IcB+798eNsyQVv9y2B4o4/EZHvaqrSul/P1RIHYqjOH?= =?us-ascii?Q?ksppiRR5xmVuq6h/8GFmg3Q4sJ65+FmSqKT35x3KS5w+Kkx24CWIbKn+IrHV?= =?us-ascii?Q?RW+EhRCwcH2FiNqvPIe/V6XBI8nTeRrd5R7nYjjXRsvLtpNBRMhznK+QA2Y7?= =?us-ascii?Q?lE+VGIbGNgCMENO1cVzZy8bis0q4ock04iY+Ry/+DvCIvW0XnqRWuQSWWCCL?= =?us-ascii?Q?+ANLpD762So+iOpNT7CyHF/k47Orv8zkE2PwrR12p1c0ZZI859NkOdyttIyn?= =?us-ascii?Q?0igWPFA327NAlAuv7hPXElDup6Z4qPot+xq9TZ1Ck/DhfzE4KvPE6eIevnIq?= =?us-ascii?Q?AUoyN2kPOfYXe8Ojhq//x7GGsq/CDQvFWrle0kS8VrHdgq6aVrl5JY9Maez+?= =?us-ascii?Q?bsz5PGQ6iOf0VzhQyuJhQWcCEtL25+p75qUpeJ81HbSWH+dBDoseoI1i6BE9?= =?us-ascii?Q?rbgwN6hGZ+7y4GdwP0V36bub26p5qhjMRVL4IX2kEeTJFAGd2gk30qvMDF34?= =?us-ascii?Q?NWIDrhlKlkul0NQeXfIZsjwtor56e3hzTTw7y4hpiszHg+mKnSnzvbc+KmC+?= =?us-ascii?Q?4/a3DJowV0BwMzCnUTdpCumuQFiWiXV19LzjqUugdSF/CPI4saOL3ueCLwBR?= =?us-ascii?Q?5IY5fmqTdr4cT9pAgPrk5tb6j9cNiqiFLwKHOCvDQScLAgJIcDG+sa4/M6eo?= =?us-ascii?Q?KPoDddMnF7+CeGjCKGIug4gtluYB0LC59D4s9w869dMwzhK6ZMkcJtwRSUMq?= =?us-ascii?Q?PL5KTqGOEqe37KWbOpF6lCYqct0OdXaD95GKbzsTCdtm08pIM/6mWTlcW0mY?= =?us-ascii?Q?mhkM9kJFaud2kxbOzH8mnsGO90HY4YDqRcglQo6vZRxub5vBcM4/FGB2COvi?= =?us-ascii?Q?zgwMe5nCiOl+zHbcYkmE0/RpemJC9voaDk4pHQAYFAyAUtqhZZiuP1YbKmJp?= =?us-ascii?Q?XXpy7zr31NqMbCdNeizSiK7B3xMFgewR8f+7YSwKOPQlMTPVt/7NM1rv6gFE?= =?us-ascii?Q?Ur2Yaz6P4QV0HWUy6n5UnOn3C5yrOOLNZ4nYIUeTMW5sdcoHSj6Q4Zn28qYA?= =?us-ascii?Q?kaS0kHLLW5X4U+ibiQ7QmaVKQO14sEmKDhnMejAd?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5071213-b7ae-4a92-a74d-08dadbf0c655 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2022 03:27:19.1857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VRUirAl/OrNn2V+V1DrGfxYbq9WNpeM5/c9Zcoun/Q4LPqH5CuciZbDBVPBYZtRjLQTEPpVPtKRWRFVEb4Nfng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5312 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the 3 patches: [PATCH V2] MdeModulePkg/XhciPei: Unlinked XhciPei memory block [PATCH V2] MdeModulePkg/Usb: Read a large number of blocks [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value I found that they will cause CI failures: https://github.com/tianocore/edk2= /pull/3749 Could you help to update them and help to ensure they can pass the CI test?= Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: abner.chang@amd.com > Sent: Saturday, December 10, 2022 11:08 PM > To: devel@edk2.groups.io > Cc: Kuei-Hung.Lin@amd.com; Wu, Hao A ; Ni, Ray > ; Garrett Kirkendall ; > Abner Chang > Subject: [PATCH V3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context > value >=20 > From: Abner Chang >=20 > In V3: Add AMD copyright. > In V2: Remove the signed-off-by: Abner Chang. >=20 > Initialize XHCI DCI slot's context entries value. >=20 > Signed-off-by: Kuei-Hung Lin > Cc: Hao A Wu > Cc: Ray Ni > Cc: Garrett Kirkendall > Cc: Abner Chang > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++++++ > MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++++++ > 2 files changed, 14 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > index 13b0400e83d..f08722905f3 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > @@ -4,6 +4,7 @@ >=20 > Copyright (c) 2011 - 2020, Intel Corporation. All rights reserved.
> Copyright (c) Microsoft Corporation.
> +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -2807,6 +2808,9 @@ XhcInitializeEndpointContext ( > MaxDci =3D 0; >=20 > NumEp =3D IfDesc->NumEndpoints; > + if (NumEp =3D=3D 0) { > + MaxDci =3D 1; > + } >=20 > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { > @@ -3006,6 +3010,9 @@ XhcInitializeEndpointContext64 ( > MaxDci =3D 0; >=20 > NumEp =3D IfDesc->NumEndpoints; > + if (NumEp =3D=3D 0) { > + MaxDci =3D 1; > + } >=20 > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { > diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > index cc597a43717..8400c90f7ad 100644 > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based > on gPeiUsbControllerPpiGuid > which is used to enable recovery function from USB Drivers. >=20 > Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.
> +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -1752,6 +1753,9 @@ XhcPeiSetConfigCmd ( > } >=20 > NumEp =3D IfDesc->NumEndpoints; > + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { > + MaxDci =3D 1; > + } >=20 > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { > @@ -1974,6 +1978,9 @@ XhcPeiSetConfigCmd64 ( > } >=20 > NumEp =3D IfDesc->NumEndpoints; > + if ((NumEp =3D=3D 0) && (MaxDci =3D=3D 0)) { > + MaxDci =3D 1; > + } >=20 > EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1); > for (EpIndex =3D 0; EpIndex < NumEp; EpIndex++) { > -- > 2.37.1.windows.1