Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran
> Sent: Friday, December 2, 2022 11:38 PM
> To: Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io; Wang, Jian J
> <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Put USB DEBUGs that
> occur for bulk timeouts under VERBOSE
> 
> On 12/1/22 18:26, Wu, Hao A wrote:
> > Sorry for a question.
> >
> > For the changes in EhcBulkTransfer() and XhcBulkTransfer(), is it
> > feasible to distinguish timeout cases with other error cases and only
> > adjust timeout related messages to VERBOSE level?
> 
> 
> No problem!
> Something like this?
> 
>    if (EFI_ERROR (Status)) {
>      if (Status == EFI_TIMEOUT) {
>        DebugErrorLevel = DEBUG_VERBOSE;
>      } else {
>        DebugErrorLevel = DEBUG_ERROR;
>      }
> 
>      DEBUG ((DebugErrorLevel, "XhcBulkTransfer: error - %r, transfer - %x\n",
> Status, *TransferResult));
>    }
> 
> I'll send out a v2 patch.


Yes, thanks a lot.

One thing I noticed that on https://github.com/tianocore/edk2/pull/3705, 'DebugErrorLevel' is defined as a UINT32,
I think for macro DEBUG (which eventually uses function DebugPrint) takes UINTN as the input parameter.
Could you help to check on that?

Best Regards,
Hao Wu


> 
> --
> Rebecca Cran
> 
> 
> 
>