From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.3299.1646187051489058179 for ; Tue, 01 Mar 2022 18:10:52 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=ElkAqmUn; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646187051; x=1677723051; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1oEN83Spnmil+kcLoyPE546DN3ZDBO3SfOu+hpQqBzQ=; b=ElkAqmUnDOaHR/Ydfq0aF4hGg7yZAiaBMyN23TyMky9LiGRVB9vCf3vs 7fmLKdOk3ijkADoKZzh/LQSEhTwMPVymig2AX8IOBGr2I+awW14MaLVkG XgDP9RzZICyszvJQyGMSGypnNedCHr3KX5puCFUbAQo8TAxywzjatOB7S oKspqQIsVVOTzgSRwPbc6OaUn4J+00tX4ooaznyLEdaa69trEHe4R39hy QWGkQwnGnwcCU+rEg8g0WfANWqc+0H1qQ1OoBi7m2ZmSHZrSO8bAou6f7 LTgsAcVkYCxbRt3TMlkpOC7uX4UavH2nkiYaluUIxSgPG/egkGcf9H8GZ w==; X-IronPort-AV: E=McAfee;i="6200,9189,10273"; a="233905480" X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="233905480" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 18:10:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,146,1643702400"; d="scan'208";a="806324060" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 01 Mar 2022 18:10:43 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 1 Mar 2022 18:10:42 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 1 Mar 2022 18:10:42 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Mar 2022 18:10:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CG/Ub7CwIwbSzuQ09i4/E81qDDCqxGR4ofda41CWv9pRcYGUFF+hbPznRaTG4z98mD++Tev7OYMTKO8XJuFw8lb3F7VcdQ2y5/Cr3IA0loMMlc4cG9ja8DAsmIrbpv3Y8Gc55RHUIUr+Djvl9nfj3iNNq9FBY9lfGnYR8Fa2ouTVKKWzOI10ypnt2miCIUuVq1kby794G0Kmkiv6cZyUBvx7SfdilijfT4AO9luxvFPWBLQ9xdiJY+PaYFbZHIbPkbtJZLb7FOkHoyLmTDJuzElqWnNhiR/JU5x8sOPgoSiDLcAUPdpQXhZyAI8HtUxcFPGJUFLMNyc8gbYsX+FUwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9AAtIFyB2UbxxCg9N2yOk8S42xypRp5qE1WC+f1F9Yc=; b=ZKdrQzPWvmBDDmBWpFs6KZPFo0AkbBWm+vCrvjAXrHM3v2RU79JdYvJYIV/ep/1Ts7BV/3dfq2Xof+y4USHvH8mn4/KcOVMc1dvWdPDfC6SFkHqvMVYE09V4mKojxzSmlNrpepOKBNHo3jkPF7U71cCYCUrWajq5KQ3KY0mw9hofr/LsZdmAZ4T8i3fOdyqmp2hgH5qgJxFQBCXBdmgRHQtufZAIpBPcoZCBD5Q+72xZ5pboTg0hHSPqQ3rbr9W30a+0GRvLEMVt5DMXK6Q4xVR+ACgmMPWzNsiWdVVyW8dLTdXbDcPM8M2gtisjjClu2nTdjN4TakejQJcZwMX7Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM5PR11MB1753.namprd11.prod.outlook.com (2603:10b6:3:10d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 02:10:33 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::2dd0:9ba8:a8c:fc96]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::2dd0:9ba8:a8c:fc96%3]) with mapi id 15.20.5017.027; Wed, 2 Mar 2022 02:10:33 +0000 From: "Wu, Hao A" To: "Rhodes, Sean" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Rhodes, Sean" , "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , Matt DeVillier Subject: Re: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card configurable Thread-Topic: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card configurable Thread-Index: AQHYKVRvbFn8UyE5k0GsfKqciXi+p6yjgI0g Date: Wed, 2 Mar 2022 02:10:33 +0000 Message-ID: References: <2ae73e745893fd40f73f75390d1f16b5c36296f5.1645689532.git.sean@starlabs.systems> In-Reply-To: <2ae73e745893fd40f73f75390d1f16b5c36296f5.1645689532.git.sean@starlabs.systems> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3ee6834-b864-46da-ebef-08d9fbf1d569 x-ms-traffictypediagnostic: DM5PR11MB1753:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5KTy6ZZW12PU9JCVFoW4nChg48x3/PSimeUmell6hd3AwxPIW2TI0sfls1ARZXRWu9n/i3310XBheka763rBnPkZQ9/LiUgAlo8HW09X5JQjetrQGnCLHSQgDD87KxzMkh1Tqer8yT91XGbuWzygurURIBV3+L7DyXvftUXkpy35Brqz9UVLA1gnALz31/M22OqbIGzoPE0rx8M3pt27BmC2M9ahtjV6r1X4MuNJYoRoYI+m1t1MPFCKCVqNqP9DX5gDPn32kbN/1cOyNZ/JXpyLxp2XiAh7imtZVMxwkXGCNnNDbOZzYbIiGU5+41yTZ5qUHxxGO8wmjkEz+VVfi43qRMvvyX7xb9Uk46PUCiTVOeuj4V2xf8cZVZF28j1KrpKr1emiA08Fv7K0gbapcirRJC6090988dxIdXjkvSubwMWtXWICydwC5mGl7I9wMokyGpUTFCA1RlLrj5auVUT/BpmiGYDnEho9HHRfu+fRGZ7qiXrKjiGGA3VuhGhpypsjAUvkHGCnwX+p/sNtQ6ZDqxH/U6D25g0gFaBO+nPrFka5AUAfj3k2Rhl6GItTUItHbajUA9NFIOQyiLPWjbbOB3csNfc/dRSS8PHX9LCf2zgGo7LPaYZdTUOOIZaXfIIrm9zBnEODJWE9/0A7rQKbpVq4dtTquhVqg8+ZyQuyxhV6N2x3ZA7utaznGocJNW+StPt/I/piIl8pl6iCXSzxp8CqEYEgcIvP23QazgUuR6IJZSWUXT4stirhb/CM x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(53546011)(64756008)(66946007)(66446008)(6506007)(86362001)(7696005)(110136005)(316002)(38070700005)(508600001)(38100700002)(66476007)(82960400001)(66556008)(54906003)(76116006)(26005)(186003)(71200400001)(9686003)(83380400001)(122000001)(55016003)(5660300002)(8936002)(52536014)(2906002)(8676002)(4326008)(33656002)(14943795004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w1WslEuAfseymKHLJ11c7C2u94AueGiT+PSjjUE0O1G5r9a4riNbVFC5dF2Q?= =?us-ascii?Q?XzfDRyTTdyzc8YvZhW9V0IchlzfpNHUXmWX9nZ+wWY6fZuGgcdMOt7jS8AqH?= =?us-ascii?Q?+GF1BMaIMJPiTLbwG6nYZK1eGUSbhk2eWBOuvMDaZcUMdfo1TRl8quFTywfe?= =?us-ascii?Q?TVbIr8+ZxmXBY+5NWt7QfEJEVoHPfOUiKkc5BC3+A1w8m6zZSbPxA7cS/Zl7?= =?us-ascii?Q?MOf8Cu7y11Bx+XDixIz5ivcEulmpcCigPsy0UNCyiEfpwQE46iPi5d6vGzE0?= =?us-ascii?Q?Jmc8RYAWnqvQVHhuI+FQQ3e/0lgZqovGsto6KX6vPnMtKixPrx/uaCVuUEIh?= =?us-ascii?Q?xYwrGpLI/RN/fg3/hlhsRv6yQ0MYn4GTNHbK/lBCMDptavmG5GLRJgPBYerN?= =?us-ascii?Q?OG4RfdKu0LW3zhwaP/MrZiMeHfllF5AxzCgwdYv1aNTTwHE683al6BfVUJ3s?= =?us-ascii?Q?P/divnidETJMZX+REBn7WH+i6FjPlbepcvbTjjhSji8b/ckC6a490mLWW0Xm?= =?us-ascii?Q?jsyK8IhWTy7nl/zJT6t2hNeW2kqKbmX+QJjRKrjozHJvJMfhCNdf8gG17Blw?= =?us-ascii?Q?JaJNZawUmr5suHoIGzVHALFjiDwbT6iv/dqCo+c9Quo1V5lIjFffveKKFvq6?= =?us-ascii?Q?/U/mqaU85IBDi4LYrWovYcQD0y9kN82M1l+WCRgodzaaN/h/mptyVihgTEmB?= =?us-ascii?Q?yyO+5XSoX9t5g6ipNUfGuFetvWzSnrSx8ZxgzJx9bf77K5+3VVUIVnPxjVWJ?= =?us-ascii?Q?qpzkfdsmxnCWoWnZM4eLhBZ8FP/QTG3oWzHKImH7UW/JCZn4GfSDvzapKhIR?= =?us-ascii?Q?oHvyA0jAzhpwsmsj7Fkn0sRAVEr4VLxWhPtjIZG2/F6GYKo7iytP/JCwji33?= =?us-ascii?Q?sY+jpp1bnpFKUVm+f71nWIW9BY3o88K/cIRai+KIOTHTzf85+8nVknwvelq7?= =?us-ascii?Q?Oe/YhsRYTRYgPJKeLNeIveqL7Qv4obULqGwFsbY4asnpfvxsmQLtpmQ3MiWf?= =?us-ascii?Q?+jT6OWze8uKW5fvhrBzWrvu03+tyHvK0jKCSzKHBkunuq3oDTHrEBEcnUPHQ?= =?us-ascii?Q?zJsTrTwu38LKgkygQfZIyTqkUm76NmIhGbhSvfYeeTyDY7vQz/ihYJ/2kvNA?= =?us-ascii?Q?EdVu/mTaBuanp9Q76q8Lph4ijfiutTMuBkrKm9Uvdkp6wBrLIRAVA9ys/EDJ?= =?us-ascii?Q?ZgtuAAArnC0N8yzPOoMm1Bh2u0yEc24ZlbEyJQJhA9xREOVu+uu2MN0UiaG7?= =?us-ascii?Q?0ootB1k3xARTtTgVsXxpFoEpjyGfmW8R1Qzozu6QVyVs+5z9fBea2QZr6hCN?= =?us-ascii?Q?9GFG1vrYe9At1nL6ohl96BbIH2DrQgWa6NUwVm4AFEnClr4cKcsVapr6mvDy?= =?us-ascii?Q?z9Kt/3kw6u6sJw71G+ZW9Wq4Bc+BQDiWN7pKBzTlOeA/UJFYstcg8Jd1oewB?= =?us-ascii?Q?3vnICs7fGfIKdQasbOgHoMp3GKtcf1Y8tpRJRu+hrc9A10MdIFbYpeQVkNtF?= =?us-ascii?Q?PsTkdQTdbzQCqJOLJprHTp92tLOJLYS/tqGrqafJ5EypJ04hYTkeqzpaezvu?= =?us-ascii?Q?Q2ITgfix491Z5wSUIaB1wMcVgkm5jcT8LMFJaepRJjHjUwmHVJEFq3lsEfXO?= =?us-ascii?Q?rGYhfvQhFJERy6d70EyU3AQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3ee6834-b864-46da-ebef-08d9fbf1d569 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 02:10:33.5033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1e8sqjPQPg+Mu9256Z/cVBepZzWR0KBN9SRsYaVUPv8z3/vVOq500M4gXY9KxU6PLrfm/t7AkKbGWYBMHx3nlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1753 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: Sean Rhodes > Sent: Thursday, February 24, 2022 3:59 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Rhodes, Sean > ; Wu, Hao A ; Ni, Ray > ; Wang, Jian J ; Gao, Liming > ; Matt DeVillier > Subject: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for > SD card configurable >=20 > The default 1s timeout can delay boot splash on some hardware with no > benefit. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Signed-off-by: Matt DeVillier > Signed-off-by: Sean Rhodes > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 3 ++- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 4 ++++ > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > MdeModulePkg/MdeModulePkg.uni | 4 ++++ > 4 files changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > index 85e09cf114..b76c7cffa2 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > @@ -24,6 +24,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 > #include >=20 > +#include >=20 >=20 >=20 > #include >=20 > #include >=20 > @@ -49,7 +50,7 @@ extern EDKII_SD_MMC_OVERRIDE *mOverride; > // >=20 > // Generic time out value, 1 microsecond as unit. >=20 > // >=20 > -#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 1000 >=20 > +#define SD_MMC_HC_GENERIC_TIMEOUT (PcdGet32 > (PcdSdMmcGenericTimeoutValue)) >=20 >=20 >=20 > // >=20 > // SD/MMC async transfer timer interval, set by experience. >=20 > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > index 453ecde7fd..e502443ddd 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > @@ -56,6 +56,7 @@ > BaseLib >=20 > UefiDriverEntryPoint >=20 > DebugLib >=20 > + PcdLib >=20 >=20 >=20 > [Protocols] >=20 > gEdkiiSdMmcOverrideProtocolGuid ## SOMETIMES_CONSUMES >=20 > @@ -68,3 +69,6 @@ >=20 >=20 > [UserExtensions.TianoCore."ExtraFiles"] >=20 > SdMmcPciHcDxeExtra.uni >=20 > + >=20 > +[Pcd] >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue ## > CONSUMES >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 463e889e9a..40601c9583 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1559,6 +1559,10 @@ > # @Prompt Maximum permitted FwVol section nesting depth (exclusive). >=20 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdFwVolDxeMaxEncapsulationDepth| > 0x10|UINT32|0x00000030 >=20 >=20 >=20 > + ## Indicates the default timeout value for SD/MMC Host Controller > operations in microseconds. >=20 > + # @Prompt SD/MMC Host Controller Operations Timeout (us). >=20 > + > gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000 > 000|UINT32|0x00000031 >=20 > + >=20 > [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >=20 > ## This PCD defines the Console output row. The default value is 25 > according to UEFI spec. >=20 > # This PCD could be set to 0 then console output would be at max colu= mn > and max row. >=20 > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index 27889a7280..b070f15ff2 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1173,6 +1173,10 @@ > = " TRUE - Capsule In Ram is > supported.
" >=20 > = " FALSE - Capsule In Ram is not > supported." >=20 >=20 >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue > _PROMPT #language en-US "SD/MMC Host Controller Operations Timeout > (us)." >=20 > + >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue > _HELP #language en-US "Indicates the default timeout value for SD/MMC > Host Controller operations in microseconds." >=20 > + >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_PRO > MPT #language en-US "Capsule On Disk relocation device path." >=20 >=20 >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_HELP > #language en-US "Full device path of platform specific device to store > Capsule On Disk temp relocation file.
" >=20 > -- > 2.32.0