Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability debug print is incorrect

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard
> Biesheuvel
> Sent: Wednesday, May 17, 2023 7:46 PM
> To: devel@edk2.groups.io; Wu, Hao A <hao.a.wu@intel.com>
> Cc: Giri Mudusuru <girim@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Andrew Fish <afish@apple.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC
> capability debug print is incorrect
> 
> On Wed, 17 May 2023 at 06:19, Wu, Hao A <hao.a.wu@intel.com> wrote:
> >
> > Thanks for the patch, inline comment below:
> >
> >
> > > -----Original Message-----
> > > From: Giri Mudusuru <girim@apple.com>
> > > Sent: Friday, May 12, 2023 5:55 PM
> > > To: devel@edk2.groups.io
> > > Cc: Giri Mudusuru <girim@apple.com>; Wu, Hao A
> <hao.a.wu@intel.com>;
> > > Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> > > Gao, Liming <gaoliming@byosoft.com.cn>; Andrew Fish
> > > <afish@apple.com>
> > > Subject: [PATCH] MdeModulePkg SdMmcPciHcDxe: SD/MMC capability
> debug
> > > print is incorrect
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4394
> > >
> > > Fix DumpCapabilityReg() debug log to print 64 bit capability instead
> > > of 32 bit pointer
> > >
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Andrew Fish <afish@apple.com>
> > > Signed-off-by: Giri Mudusuru <girim@apple.com>
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 
> > > ---
> > >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > > index aab6815328..2e7497a89d 100644
> > > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > > @@ -30,7 +30,7 @@ DumpCapabilityReg (
> > >    //
> > >
> > >    // Dump Capability Data
> > >
> > >    //
> > >
> > > -  DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%x ==\n",
> > > Slot, Capability));
> > >
> > > +  DEBUG ((DEBUG_INFO, " == Slot [%d] Capability is 0x%llx ==\n",
> > > + Slot,
> > > *(UINT64 *)Capability));
> >
> >
> > Please help to use %p for printing pointers.
> >
> 
> Why? The point of this patch is that we are not interested in the pointer, only
> in the value that it points to.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
> 
> 
>