From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web08.2006.1666923950731712744 for ; Thu, 27 Oct 2022 19:25:50 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=K3HPv8eP; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666923950; x=1698459950; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PUQqKiLxf+duxBTwzcrbRl3CAgzfG2DDqtuDJf6xsqs=; b=K3HPv8ePAdUoqbF0EtwKXjP6bbPBlVaf4LXCsbb+y1B7Hsf+d1Caf9P/ 5RlifKP0DhtDdvRVFoe06zVeW5lh5d2NkBZdYF/LCVGLYKxcTURbsObvJ 98Nz2JZCo0a3YKyo1qTQB8mBzU4U3100ULswKUzvUTDNoSdueCobIXEpD zNMVADYKiGJiD19Gj8sG/xqKwzO0eUyR9To5j8Y3aAXA+JoiMPl6rhTeI pSQ21WVT/5YQB/SxhPY9AGeXXh955jxVEuoN2+Xl1MXRspxseIX7yVXkl yvRijqZCY7GDE7rSn6uisSKs/HSJU6kw7Qd4r9mZmxjnT2PW9Zf1kFSyU g==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="310088727" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="310088727" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2022 19:25:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="583771297" X-IronPort-AV: E=Sophos;i="5.95,219,1661842800"; d="scan'208";a="583771297" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 27 Oct 2022 19:25:49 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 19:25:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 27 Oct 2022 19:25:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 27 Oct 2022 19:25:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRO/Hhun70DuvIAK34ZPAXAM5Lgz2+NG1txIOAwLCTiSydwPnbEUCxgdLMpgqOLfQrTFRHrqK5ccH/i3AAol3L7r7woAJCZRt/bcmUlYWSfF5qsC7Qz4AO42uno9ah+mnqLDtP9dXvg3PlUk5RFQXQnzPfpxyJHLo6DAie2pKnKFDblC1I+GzWLSl2SRIA+ZJyJk8PkITfWmdt5hJC8XKmd5vv340ORQ9XG+kaMoFcpEMT5Cwtv+tfAEsLKCI4YuBYef/htjunKW6oa3/GD0V74BAOhU19tmtOIFb0YrEb4AmfQf0MPo/LPjLFtkbCyEjIKlMXEI1RvrT+xDtZJz0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u4mc8ddCb9ve//vyKpbBSR03+z7R5LolRIoTOyeYEmE=; b=OvYbSLsoLYEHGIcJ1ZLpnQ/JkG1AzEmmwMAmyV9JKY+3oRSw+v79e1Up570LuEdpt1NH4HNtCGwfrA4Xh8ajIpHW0bTOVkwkTBHHJv8UkE+Uaibcs7b9bLkjyi49y3b/W6lRA8HMOI5BgORnFIOhe0r76uA62kac8XG1CoJv8wcXrBfT/SmwXVKQWu6SR+ZlIoVY1POyA4zCrVYrn41B77bZsXHsOFeYp2zuAM6zMJ1c2hvFJMlgJaS7BNt1x2JKBIEdUrB13EPEo37TB/4h9d3WmMqPj76WMprIdAKcRgcA5xHJPBX+gngQJz1d0V75XUKRTPrmmfDp81zlZ8TBSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by SN7PR11MB6897.namprd11.prod.outlook.com (2603:10b6:806:2a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.23; Fri, 28 Oct 2022 02:25:46 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::82ad:97fd:4cd6:b7ae]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::82ad:97fd:4cd6:b7ae%3]) with mapi id 15.20.5769.014; Fri, 28 Oct 2022 02:25:46 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "gopic@ami.com" CC: "Selvaraj, Sundaresan" , "Sambandan, Vasudevan" Subject: Re: [PATCH v2] MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drive Thread-Topic: [PATCH v2] MdeModulePkg/ScsiDiskDxe: Update proper device name for ScsiDisk drive Thread-Index: AQHY6dKt1c9zfKSYBUOqrMMgdLVtQK4jDfzg Date: Fri, 28 Oct 2022 02:25:45 +0000 Message-ID: References: <57ad249a7bf55fc175b6206ec91c597a969a06d5.1666851664.git.gopic@ami.com> In-Reply-To: <57ad249a7bf55fc175b6206ec91c597a969a06d5.1666851664.git.gopic@ami.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|SN7PR11MB6897:EE_ x-ms-office365-filtering-correlation-id: 1acce941-5d02-495e-d108-08dab88bb86a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nOu2CkG6nuzSQWfbLccB+VbBh4Q181Bq3i3E5vLZN+VhZ9oBgh2s9RpMlGGKcvM+Xo4zCjRQkAUsYT0kAB+xgo1YpphGOfu7u4qEFv1y1WkBUXPEdO+bAZU3IXo28Bckm75eqBpfXcfJi8vmn6VtNWMS7W+1oKZ+Rch3GjtG31CC2HKIgC4lAWCyfK8WJTojK7ZATgweTUhaxc9UTTNJW8dHkHxFzAvv0VyPY/asgNpiVuVB61ih4UjHjIt+JaKh8QplQmRY1rge8ENTqN1rXLkdyMddGpVQ4GUjzSm/JecXsGRYu49keSQlKHjrvyDo+8pBoWrGPIromfVWiX3d0cadmqg0bPynHSrSI5d5VJh17JsE5IKm7z2E3zCo1cQTQcI1gL3yL2JtvlIUZEOhoY6pC7zHEpvVjdL4kyaFFixuudSYvUCF6gA048VjleNwk0nTb0gciIypfjKU3unmg14KWjafewBcvNLrS/nrjDTfjSqDHgzUJfGM1o4dP4TG+Z583xknr/YQKVk+TLYwNrs9s0eTktijzUCcL1+KuCXVn1ZImHO+5acz5eDMeGwptMdIB1B+gy4lBoLmL5+IThDieo3W2gXT3FWWmAd/R/Ed7J32K3iIkj9ZFhgdFY7cQemI1UT1p0kS1xN1ERgWnHVq532o5/CAewkaJSclkyct7k3x2ijVZVVm7nBiLhNe24iNO6IqAxI0bB4XlGz+SzdKsQrsffzi/XL2UM85kmsFD0fxMCvEOYkFG/on5fs4RO58erQg9Ar+KeCjpxnIURhOGvA4cUZol5aurYaAoCWv3vAks4wXEMujaM8qCWbVO1xeIJBOhnCwDw1UrBlU7g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199015)(26005)(8936002)(76116006)(66556008)(7696005)(41300700001)(8676002)(66446008)(54906003)(110136005)(53546011)(15650500001)(4326008)(52536014)(66946007)(5660300002)(66476007)(9686003)(38070700005)(316002)(64756008)(6506007)(82960400001)(40140700001)(33656002)(186003)(2906002)(122000001)(38100700002)(55016003)(86362001)(83380400001)(966005)(66899015)(71200400001)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5gFvwKU6LH8B85m2LcP8v9hRx4OjvYar43ZvlYqs3KuXG3xs4DN6okh6rahP?= =?us-ascii?Q?dgmyhWsCwiHB8gJ7Vw429JJqGyEOD6bINroIDpFdPM+buRU8eNYAa40pTqBP?= =?us-ascii?Q?oO5wcqAd5S/eERBY945C1//3urr3ienlNPyusGatLraZL+lBhIgc+/PoLuGN?= =?us-ascii?Q?m8E3i2pJ4GtkKLyfS5dEER2Bc0jB/LjOB/RZxj+B25cq+h3WqDFupRwn4XoT?= =?us-ascii?Q?QI/M7+eyIhcZBYKJu/4esbv70NhpWqNsK3ypli41WtXauhf+KlTIAXn3+6kC?= =?us-ascii?Q?Ui1Y8TmTR7AHa0mXIt7hYFFTagDDhwbHe4mVbjy1++DV6MxDBdtEBVxxV7xY?= =?us-ascii?Q?u5fGRzegV0giuvWJzIjk2+MrH23hjZguR2eKFWMs5O+tvAjKqYS0yb7NZYhi?= =?us-ascii?Q?yWIF8MexxsS1jwdKRBKMNuZlB8EOjvBpkYwDO4aJ0ZtMXY6Kg05QuDadTgfr?= =?us-ascii?Q?oaeCDsPD1wl1x33n+zt8Tl5m8BppU9pDMhPa0l2iO9MFY91qop53ieh5d2Mn?= =?us-ascii?Q?bWVpbQs/XzJm8bLTH/LsxqAzETuqXZHrw1i8NwMiLWYB+Bdm6erh43WHcNdM?= =?us-ascii?Q?iGZCFs3TL17mhroM53MqvgoAo3n0UIBx0QrIR03s4Eju9zaYrHmwg7/fXDN9?= =?us-ascii?Q?SeNJ0ZvUe9GxeDfbD4Gdp86GKv7+dxDSEpJ8Qt6YyYedVdNNqWeayEzpPJGU?= =?us-ascii?Q?GDuVYGsS0xWmN2HSBZSTgrGTydYwFLCOZTA3goaA5gAZOrxFm0WGcfed5WUu?= =?us-ascii?Q?jPFwassL7etEUkJ8F5Zp6/13bIjSTIzdWY42S8mQ0oBj3WZiSG6hB8F9pSEg?= =?us-ascii?Q?9SlQTyMNCWTh/wAMGpCITnmBTRxwi8e3gIlJAmadN+mzXZBXMdQTiRueQ0Hj?= =?us-ascii?Q?SCkL76Pq9Cm3sO4DEAw5jB/hV/0lGr24nj8nMCjVTfTZR7/m7Qsffn7yDhl0?= =?us-ascii?Q?dR4ZvzvgcSik0xiEOg98inmhxbbGlX8L1pLMO+cx8UL37txNZ0wdqLaB5XzD?= =?us-ascii?Q?bubWSih80VCF0RnlOgDdIO7ltIlA4lMP1kr1sc4o1yAE6Q3LfJSR4Yyz2r51?= =?us-ascii?Q?z9BohLRRI094+f3NgSflQr8Wy7+NrJYM3YXhruKRqvHTq0IiYNw359ln6Ro4?= =?us-ascii?Q?Sq/QFhLLkoI2X86s+k0/1uAHziVPs01ImUf+imHsKMj3iDg7jj6oSrgFma3G?= =?us-ascii?Q?oQrtqGs2JjE7rwtVB5rlt6m9DdIDVN1ZMhBhxGFnxLF6i09/nW14e99aKjYl?= =?us-ascii?Q?0BdvdTi7tniwbf7SjoxJ49vhwhH1iDJYq21Ls4cpagQjVC6AKuNIMWsviN4W?= =?us-ascii?Q?x01Hh9qwxY8Li6B6daRy7hDKF6l9N2uTer26jyRnBGcWbQ0YdYfHiFtyBdUN?= =?us-ascii?Q?T54VmhQK7uHbwyu9QO24IEW6tmRT6eIBLQXs58V7O+TwAAaBoC0bhjxCQwFc?= =?us-ascii?Q?hrxsheTsbzlUgfe1e8gsZDWS9B0b+cH7H/7M9+FzZY9Fy/tvA7xe0PCXjuCT?= =?us-ascii?Q?dW1DeEJ+rN/OANHzfLONy8NKST1Anqx/4TmtwtmqG2jv1TDnf+iHqR7VQtjp?= =?us-ascii?Q?Mct7dME769Xqrzp2VXPecR0tGvke0Hh3zRnwt/RH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1acce941-5d02-495e-d108-08dab88bb86a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 02:25:45.9694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QLzmtcG1xBFH5TuxRR9i6zvVRY/1oxlZvr68DO1GXCJcgf0cHuKMBe1y22H/ljXg00FwoRDJoRNmwYeStejP5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6897 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks. Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other rev= iewers. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Cheripally > Gopi via groups.io > Sent: Thursday, October 27, 2022 3:07 PM > To: devel@edk2.groups.io > Cc: Selvaraj, Sundaresan ; Sambandan, Vasudevan > ; Cheripally Gopi > Subject: [edk2-devel] [PATCH v2] MdeModulePkg/ScsiDiskDxe: Update proper > device name for ScsiDisk drive >=20 > ScsiDiskDxe driver updates ControllerNameTable with common string > "SCSI Disk Device" for all SCSI disks. Due to this, when multiple > SCSI disk devices connected, facing difficulty in identifying correct SCS= I > disk device. As per SCSI spec, standard Inquiry Data is having the fields > to know Vendor and Product information. Updated "ControllerNameTable" wit= h > Vendor and Product information. So that, device specific name can be > retrieved using ComponentName protocol. >=20 > Cc: Vasudevan Sambandan > Cc: Sundaresan Selvaraj > Signed-off-by: Cheripally Gopi > --- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 53 ++++++++++++++++++- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 9 ++++ > .../Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 2 + > 3 files changed, 62 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > index 98e84b4ea8..0928605dc4 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > @@ -2,6 +2,7 @@ > SCSI disk driver that layers on every SCSI IO protocol in the system. >=20 >=20 >=20 > Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 1985 - 2022, American Megatrends International LLC.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -67,6 +68,33 @@ FreeAlignedBuffer ( > } >=20 > } >=20 >=20 >=20 > +/** >=20 > + Remove trailing spaces from the string. >=20 > + >=20 > + @param String The ASCII string to remove the trailing spaces. >=20 > + >=20 > + @retval the new length of the string. >=20 > +**/ >=20 > +UINTN >=20 > +RemoveTrailingSpaces ( >=20 > + IN OUT CHAR8 *String >=20 > + ) >=20 > +{ >=20 > + UINTN Length; >=20 > + >=20 > + Length =3D AsciiStrLen (String); >=20 > + if (Length =3D=3D 0) { >=20 > + return 0; >=20 > + } >=20 > + >=20 > + while ((Length > 0) && (String[Length-1] =3D=3D ' ')) { >=20 > + Length--; >=20 > + } >=20 > + >=20 > + String[Length] =3D '\0'; >=20 > + return Length; >=20 > +} >=20 > + >=20 > /** >=20 > The user Entry Point for module ScsiDisk. >=20 >=20 >=20 > @@ -203,6 +231,9 @@ ScsiDiskDriverBindingStart ( > UINT8 MaxRetry; >=20 > BOOLEAN NeedRetry; >=20 > BOOLEAN MustReadCapacity; >=20 > + CHAR8 VendorStr[VENDOR_IDENTIFICATION_LENGTH + 1]; >=20 > + CHAR8 ProductStr[PRODUCT_IDENTIFICATION_LENGTH + 1]; >=20 > + CHAR16 DeviceStr[VENDOR_IDENTIFICATION_LENGTH + > PRODUCT_IDENTIFICATION_LENGTH + 2]; >=20 >=20 >=20 > MustReadCapacity =3D TRUE; >=20 >=20 >=20 > @@ -354,19 +385,37 @@ ScsiDiskDriverBindingStart ( > } >=20 > } >=20 >=20 >=20 > + CopyMem ( >=20 > + VendorStr, >=20 > + &ScsiDiskDevice- > >InquiryData.Reserved_5_95[VENDOR_IDENTIFICATION_OFFSET], >=20 > + VENDOR_IDENTIFICATION_LENGTH >=20 > + ); >=20 > + VendorStr[VENDOR_IDENTIFICATION_LENGTH] =3D 0; >=20 > + RemoveTrailingSpaces (VendorStr); >=20 > + >=20 > + CopyMem ( >=20 > + ProductStr, >=20 > + &ScsiDiskDevice- > >InquiryData.Reserved_5_95[PRODUCT_IDENTIFICATION_OFFSET], >=20 > + PRODUCT_IDENTIFICATION_LENGTH >=20 > + ); >=20 > + ProductStr[PRODUCT_IDENTIFICATION_LENGTH] =3D 0; >=20 > + RemoveTrailingSpaces (ProductStr); >=20 > + >=20 > + UnicodeSPrint (DeviceStr, sizeof (DeviceStr), L"%a %a", VendorSt= r, > ProductStr); >=20 > + >=20 > ScsiDiskDevice->ControllerNameTable =3D NULL; >=20 > AddUnicodeString2 ( >=20 > "eng", >=20 > gScsiDiskComponentName.SupportedLanguages, >=20 > &ScsiDiskDevice->ControllerNameTable, >=20 > - L"SCSI Disk Device", >=20 > + DeviceStr, >=20 > TRUE >=20 > ); >=20 > AddUnicodeString2 ( >=20 > "en", >=20 > gScsiDiskComponentName2.SupportedLanguages, >=20 > &ScsiDiskDevice->ControllerNameTable, >=20 > - L"SCSI Disk Device", >=20 > + DeviceStr, >=20 > FALSE >=20 > ); >=20 > return EFI_SUCCESS; >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > index d54282df5f..5b4047e1db 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > @@ -2,6 +2,7 @@ > Header file for SCSI Disk Driver. >=20 >=20 >=20 > Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 1985 - 2022, American Megatrends International LLC.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 > @@ -30,6 +31,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include >=20 > #include >=20 > #include >=20 > +#include >=20 >=20 >=20 > #include >=20 > #include >=20 > @@ -179,6 +181,13 @@ extern EFI_COMPONENT_NAME2_PROTOCOL > gScsiDiskComponentName2; > #define SCSI_COMMAND_VERSION_2 0x02 >=20 > #define SCSI_COMMAND_VERSION_3 0x03 >=20 >=20 >=20 > +// Per SCSI spec, EFI_SCSI_INQUIRY_DATA.Reserved_5_95[3 - 10] has the > Vendor identification >=20 > +// EFI_SCSI_INQUIRY_DATA.Reserved_5_95[11 - 26] has the product > identification >=20 > +#define VENDOR_IDENTIFICATION_OFFSET 3 >=20 > +#define VENDOR_IDENTIFICATION_LENGTH 8 >=20 > +#define PRODUCT_IDENTIFICATION_OFFSET 11 >=20 > +#define PRODUCT_IDENTIFICATION_LENGTH 16 >=20 > + >=20 > // >=20 > // SCSI Disk Timeout Experience Value >=20 > // >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > index 40818e669b..26227132e8 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > @@ -4,6 +4,7 @@ > # the device handle. >=20 > # >=20 > # Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved. >=20 > +# Copyright (c) 1985 - 2022, American Megatrends International LLC.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -46,6 +47,7 @@ > UefiDriverEntryPoint >=20 > DebugLib >=20 > DevicePathLib >=20 > + PrintLib >=20 >=20 >=20 > [Protocols] >=20 > gEfiDiskInfoProtocolGuid ## BY_START >=20 > -- > 2.33.0.windows.2 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended = to > be read only by the individual or entity to whom it is addressed or by th= eir > designee. If the reader of this message is not the intended recipient, yo= u are on > notice that any distribution of this message, in any form, is strictly pr= ohibited. > Please promptly notify the sender by reply e-mail or by telephone at 770-= 246- > 8600, and then delete or destroy all copies of the transmission. >=20 >=20 >=20 >=20