From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.4273.1685675675611894760 for ; Thu, 01 Jun 2023 20:14:35 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=V8S31bb/; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685675675; x=1717211675; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6hjjqnPtCH05a6njD/HXJj0+DpieVDMqMYJuRI8YxbA=; b=V8S31bb/HnsD5I+cICp94cDAJKkEH9kL/39PM77CnGI8GqpW1GSQExem haoCO8Z4t9UGExegTDJHNW1QVdDhQ32RD3J4E5wHIbVQ82bSDW57UyhO5 GrVVEY3daBbf3Ly+FddKUB8nVnf8oQ5MvjWUZXN7hfHTpan+iYmd+/KN6 cNmkgFz1SV3+eDf6y41WZMVx5eyPfsQfXm0lOAnaYB8CmEbrang/9YdEe FAyJx0b76bEXH3KackTlWvb2MQxrXn1hpfRPQszh/utQAB6IKcZ5mAyc5 nZVzohw5uV2WaTwVZfDftC9LpFNnslwcH4PoM9L/Fgcyzk4TOkxA0RPka Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="419281416" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="419281416" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 20:14:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="737360806" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="737360806" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 01 Jun 2023 20:14:34 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:14:32 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 20:14:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 20:14:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oDRvpsV+a+2l+Q9xMm91esyhKKZpXOUVDru6VbYdJfJU8FV3bMp0Cio1joAH2od250eietICh+QNjGA65FDs0Yhx5B0UkSkF1ddrgWTZZAaAQKy2jsnQQY01n7IYMx23me4nam+PTCWc/vXtULY36w2fokRxe7cdmnOCeixU6ts930YP9KWjLt47I2RnmBVdZXIDWTPfutJcrGU1/X7ewRXVSTYzAGcIOtnEFV2Tc5MeG14lG5budiPasshWzbz5w5TwiXYZTgL4Us17MuslP7ty5qOTmYpDFCxayjabB3n8BTnGPAk9zNql26s14AGrFL8Ndar4PPXXflxXAxibKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/THlhVTBiQLa1P8ohikAH3HE/qyeI1jgQj06SvCwOk=; b=K0JeQDVt/UVxWtbfm8ThHWHSYqE9R6fU0b7adtR+uanF1tdjFkoltGzLcKmEHvAi5VN7t6BG8fZV+jq4RvkSeig4dtmEl+j+5jXxhjrAE4W0vmHnV+s4pTnoe2hb71hNpL1noYPR6JzewcLFyvVJgG1Qk2UiJ0Bp9XyOPziw0K0LKLDkNW8eOnIdpVG8s7DrH8kuHMfeSm4OIBo9/k4YENL4+bWNDlFIFhZ9gMB/Abcb/L0DhjG0Lo8XrQVXFOZBeEdffD7k/ejkUTPz0zDYp67hYLxK9WT3M/FYiEKHDoSP4jENBENFk/9QweWaNqnvyCankvFpo/IMoFLR0v7hig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CY5PR11MB6462.namprd11.prod.outlook.com (2603:10b6:930:32::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.26; Fri, 2 Jun 2023 03:14:30 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::ff1:67ce:7c9a:aa3f%4]) with mapi id 15.20.6455.020; Fri, 2 Jun 2023 03:14:30 +0000 From: "Wu, Hao A" To: "He, Jiangang" , "devel@edk2.groups.io" , "Hsueh, Hong-Chih (Neo)" CC: "Chang, Abner" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjaEROuhuDY7qr02+W0SYB4rkMK9zxJ5QgAC+DQCAAmKz0A== Date: Fri, 2 Jun 2023 03:14:29 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d21dead0-8696-4352-9606-25ca7d77c028; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-31T14:41:31Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|CY5PR11MB6462:EE_ x-ms-office365-filtering-correlation-id: c6106af1-d371-47e4-5928-08db63177ae3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bQ2CGUYGywA8h4AIsxzAs5m+f0HdmDaIIdPY8ZV6vJLhuwSMs0NQiCxMFH1yufKOhpS1HxOctN5ty51eT5JH7TKPw50o3gzrn8wIVWiFz8l+rpB8UGiGpA53oGxx0fuFsP4EEtFIil51mPB6afVGH3IqKVoEU9bm3GtcH6hYexFFMyYrvGu47xnZ3uM3PiNwQ6b/s1O5NLwR52Scugl06Y1oNs27uDDAFKIX4DLWtu9R82J5vtAL51/50EGrrP/3U1vupzYN6jLEdW6uuhUMbxTnXcZxCE60/nB2BMOlSXZWRr83kL1EMndphQGix0+6z14Al8s4B3sFOiuGiR4ivCmjf2NA1p39a+QBhXC1HCYzpDCsMXnVAWIzL8lM0y0Nou/+CDZ5zEUgMJdFwDsUzrokRnutSzRfbZnf5yXUqg9aN+UmuKkPJuFjeSeaAnHCaR2LMZQn9SRsYFr2zHaCXO9DAZ8ts6LBSYHjE0QKsELKyoSDXyc1TqjQXfZcIw9qIXadj/RskdSJiL6edzefEW9DVT6Ju5wOFpGWHLiG27UJYDXGmnKwFPWXPyKl/p/tecnZj699at8kP/OyULfb7hVtfVGYNQ+maEAzEjCLsVvYKdmR55iW2BkBEVcR8dv2dEaJjQndIMxqiACqVzgo/g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(39860400002)(396003)(376002)(366004)(346002)(451199021)(38100700002)(122000001)(966005)(82960400001)(53546011)(6506007)(9686003)(26005)(83380400001)(186003)(2906002)(55016003)(8676002)(33656002)(5660300002)(8936002)(71200400001)(38070700005)(478600001)(316002)(7696005)(4326008)(110136005)(66476007)(41300700001)(64756008)(76116006)(66556008)(66446008)(66946007)(86362001)(52536014)(66899021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FRG6R0ie0HC2EylMLlWF7ibKqaemDx4y4ls7dBFXic/URyk5WZuZWKNqAGEI?= =?us-ascii?Q?4rFV+XPyDJYrqP4z6lYPYofEEnFGpJViGVSd2zbGwmaEoi75YeSTbxF/+X/s?= =?us-ascii?Q?y6OV50US7ETZs2urWyEuA/oY0fJwse36Kr4XAROYnlsoBvym25Fj2T8p5OWR?= =?us-ascii?Q?GnZdUz9JF/kCHYpfO6uj4I2rXVxZzU4vq43xzR4a9/B+GMpbDfzOmgCIufIx?= =?us-ascii?Q?mrgPuPW43XKciM9Se0/5QpGRK0qrFYrrYEZVod757zoa4NMSC8t2VjIyUk4m?= =?us-ascii?Q?8fqm2luT0KsibhVQqWLj+g9Y9F3bpIJ/yxayg6+118DQlcoKaVHOQBYkgjil?= =?us-ascii?Q?0bFDYaIDgImdlc5RGoCFbQhhlbK/8ZrIBHmZUzDCrKMloX9L2F0V2mMLc/Cg?= =?us-ascii?Q?vUKTW6iJZmwCmSJESiClkAQahfw8KGHCzOBM4/56XDNODnTEj+G6I6ZG9Kn0?= =?us-ascii?Q?uIirwJA8wepK4eqQaVwP+V9pqfnJqx/BT7p2df6OZ6+PqHzEEthMzgHlpUI5?= =?us-ascii?Q?c7AQrZazH/jJJUbFuMzkG5QqBdQ2EJCjSxztmRjMT0KzPHUnn9SfY/Oze//i?= =?us-ascii?Q?5b1KkFaOr8n2RKJ4f2d1MjXts2TXU89AglDZAhoJV8tEYnmbLXtwGCrI38Ap?= =?us-ascii?Q?G86l34HcFVybj6re8xegpLioEXXfMEqtP0vPHB3xHz2nITpp++9E/XgA0L4S?= =?us-ascii?Q?zJDaJsgWhReAPJgN9zC9PDAIuq4H197ziBRc1DnEpqV8GsszqPJab4XJvUll?= =?us-ascii?Q?oh/USWvQ4fRL+lb/7KDZ6oJYtzXUec5tcpizH5bb595e242zqGAADkVUnqXm?= =?us-ascii?Q?STIEKp26GQoqOb6ycxkE1WpxxCwjoU9e+8w9DNUXi6A0XsAadb0BvmokaJSo?= =?us-ascii?Q?Mh2ony9NZgNhuuVCs42QG+ts40NjH+TpAlDXbsAU5izoaqYrCPtGktvXBIDp?= =?us-ascii?Q?/68NJqxKsIM09U+++SrrrBIVga0NqN2zjJEvjyZGYwkEJGDXWfhpWsTTR40b?= =?us-ascii?Q?98/+Mn10Fsdr22BJNmkxjqLsDmLWKQfEyCcU25j3KdONci4w+AZMWZVk0wJ2?= =?us-ascii?Q?NzXVatq0ar/DYDkHl3A4XyoEk9V6x4OcgxaaLYE/0fesbe+dYWW5/qsh7Q4l?= =?us-ascii?Q?6GXcQgT9qpWK6wd9sePVN2K/vUuoNUTqbjZrRkNGIMsFM5Ih9HjzURPOMb72?= =?us-ascii?Q?OxMF0H5XNBGuxgcrfDtF/DJeMypdXPuyIRnE3UoN/nIaBnG7gua3SD07W6XU?= =?us-ascii?Q?6Jgm5Ey4qmC5tzmEPQY6BzIz7tTXS4/eJ2HuJ4M9lNXtM25I4r9TmLYygXCc?= =?us-ascii?Q?L3/bgRAuIGt2ReGRyFrbti+ynUg+zOSSOiawgYub2kh0o11rLEh2qcFdsKKb?= =?us-ascii?Q?a6orbwioJuJ0eCvp8crY04eQ/Isi5ixZKfx9RbWYX+Y2n/3V01Je/KAERU/W?= =?us-ascii?Q?HsfpSNb8glqdX5cDyeDsk0nKPPSHzKUGNQGb6fUMliqedqFDMuFE0dsZNbtK?= =?us-ascii?Q?9v75Dkkf+DP9EVmFsMzwzuTtYrfH82F1aRWLmPgvU2kp+/rOZ83Z4MP+E4pq?= =?us-ascii?Q?+xvyGUFuut1/2ct9tMUUrh/+Sa0LEQAHO9JlNJ3/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6106af1-d371-47e4-5928-08db63177ae3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 03:14:30.0105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g/2qznjgcghRq5+VQuobdyozf8k6Dt9HXi3KsziytyLCdA6scdLci59IhOIOfL7mVqasbauEaghKFnaRmY5V1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6462 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks. Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A ; devel@edk2.groups.io; Hsueh, Hong- > Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM >=20 > [AMD Official Use Only - General] >=20 > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. >=20 > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang ; Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > >=20 > >