From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.4552.1635823047359288325 for ; Mon, 01 Nov 2021 20:17:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rYsxBp9F; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="211227482" X-IronPort-AV: E=Sophos;i="5.87,201,1631602800"; d="scan'208";a="211227482" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 20:17:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,201,1631602800"; d="scan'208";a="638057786" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 01 Nov 2021 20:17:26 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 20:17:25 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 20:17:25 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 20:17:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEEtYjxYdfUI2NHtPhNOQGPtYkYiHKiPOyq1f+rYF6vuWgiM7+FAkriLiqo7RmaSIVHUVn35rwgehmRwDvKCoIxFaLmwSdf1/YmT/DI4LRpXMkdjSfQR8ds93xBe6YgoXw3QWE5Cx/KLZ4uHO1hgudxL+rCsfztYhhy3+OOx7rL48taZrsY/1a/JVNvkYG14Mg52Httk5GODv+zMRcALaxfqQJtk/kdcqVYf/d6xjHwhJ/n74xuiuF0O2qaxjCNCeGE3NwTjew8VdTxWyfOQjdxxmPiL8cthciEIWJBE3DhwM/wxHzxt5+0aYOmasqAbjg30PZBGpmbNnfdLh8yDXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U61W0eqtxFjKtg28XZy68swY8a1/U32VElIm+PP4YfI=; b=AboerI5dmvp2cTDbUanQ6K80jr8CnY8WOAOS1Of0OZMQiLI5Jcpk1ILb88HlCgwqXa0GoyxKkJoXgpp3/gJj49sMtDjDgfKbE3sRt9uO64uSRQD1jaHqUOivvYghD1yxwQLTw85q/JlWQNCThY3P4s4i5GtagruMK60kieCFKpHi7di95JG/eelqRJVhKnbfZp0mRzq8Z1EIlOgixihjX+TAGZdw2X5JkKFWA9Ynu2yjrSrjryB/hWBB5Oqqsp3i6Fi95NWGAjDnz0Br0peFKRk+lQLMoyqTvPTUBfRu47SYCXBFIPHKgVydGFQeApbNIYV94lpHOWVpXqQNqPBcPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U61W0eqtxFjKtg28XZy68swY8a1/U32VElIm+PP4YfI=; b=rYsxBp9FmAQoZIdDERgWCOx7aI6YEyJuOPL9pynUrTsYEWEdwsgmN2RYbJtNBeP1nMJQ18NHVu91+J57QKQwgwU2Qi42sn9KzoRA47W/xgRfyAoymQ8rdauUZkSoE8sBWX7RpxrlHshw+ut/S9LfgkeKO1uH3yXW1RozRUvqXHs= Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB4089.namprd11.prod.outlook.com (2603:10b6:5:198::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 03:17:25 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::214c:de33:74b3:bd7b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::214c:de33:74b3:bd7b%6]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 03:17:25 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "gaoliming@byosoft.com.cn" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do S.M.A.R.T. check if device support Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do S.M.A.R.T. check if device support Thread-Index: AQHXzwVVCRAtQNS6kEGLSefETR6oGKvvkcuw Date: Tue, 2 Nov 2021 03:17:24 +0000 Message-ID: References: <20211101094538.489-1-gaoliming@byosoft.com.cn> In-Reply-To: <20211101094538.489-1-gaoliming@byosoft.com.cn> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 785bc947-5a22-4075-504b-08d99daf4adb x-ms-traffictypediagnostic: DM6PR11MB4089: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F+UESAAc/4AuUAohTir4nQbeIWbRwLmuzuosSkbPwGh1uZmwbCkmdWbU47ZJCmmGQQBN1NQPvvR2ynzSYt31LVffGSQHC6NPC94wkkYcU/km0EomcV+XLH1jJ4EFUikOT66N0DWSgM+xWabRwhoLNdRBiFsVQIkPQPOOtGIqaSarr6JK+lZw815mdfUA49U+uH1Ym/yccyQSIS6Q8r0hIYvBcK+u6wW5jGQWm5P1h2cBQbVOygdJ9rOb33KZjsuZtd7Yfh+8aW3pF3IYn/6bWxx15m1vvxuDJAWMGdtLmK1OaKxjXRPKZUN3v8LhxAF/ZjRRgjb9hSeLYIsoEawdcqFCxI9c2XJU/AF1Up2NmqAyRzWjnicmNJBm8qqdc+2/pIjmT0nsTtQaRbI9jeSLz5uQSdbPphp/v9MSr/y+EOxWZsRcRO6DWVKxK/ShHb/V6NLa6KIy7NLP4ZILQ0yz8rMODUk+ArFRyqVu2y7Se6z5niXhvpCHuWkAlfm79Ajll6RAQIM2TEHnUlcWl56IWwbOmoUmy8Lvy0+VRvwn4WRT58WPWRYqd481cjLRyapK8jJUXWpmPmUZyxFqz1/kI2+t04Ut+qtwKRdLF32Px1rqrDhRKXSf033atc509g4oGKDw5tUotp67NJQQSEJssw499aK9bQEe3ooNyxjgZBoGGUzBA9A/kiOxcq5/D4IDj/8V9IXw2OXabMOB+F2Zo/Y+ENjPf9nohscLBp+tAnhsU4H6DlBOCF5oeb8LV2Qp2lTaCjq/+emukhSuquLTIuCiB/nd+puIdECKK3FrCZo1BQCJ8Y9CKj57271Dwq6DhqhzHDYBR+U3KkRjaq5qSg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(9686003)(508600001)(55016002)(7696005)(186003)(2906002)(8676002)(52536014)(316002)(6506007)(53546011)(33656002)(122000001)(38100700002)(4326008)(107886003)(66946007)(26005)(8936002)(966005)(83380400001)(38070700005)(66476007)(66556008)(110136005)(64756008)(86362001)(5660300002)(66446008)(71200400001)(82960400001)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pQiiaM/rGgAdTROS9TpEaAZ9AJqBF+CaoNaFOi6z0q9x4TzpY7vaNBva86DJ?= =?us-ascii?Q?m8xWquZ7vo9v9S2R8nzhbxyjb3bfIAUaJ7N87PeUmVfaC8mUF4Hnlk91OZ7C?= =?us-ascii?Q?iTJESczyNLOPdZcDJ0jVt8aVkSC+yw71J7R6mdgbDRnQy960EE7MmBGBLPBc?= =?us-ascii?Q?T2LouJtF6FU9cjzdkowWDPuI7szkjL+h+JvL2oeC4Y+Srsi8yEJgoa+qnqsM?= =?us-ascii?Q?11cNubxAk/XJKKOBTnOs4VzVRy/Ra6JOZWJBriUh4nRTBihV1moeQKwnT69R?= =?us-ascii?Q?/IfvjxVp5ReawfJHklyKogWv2utdSgQRFSQ8c5q2lrQEUW45rTEpXspASvxz?= =?us-ascii?Q?s4zZivGbSWkl+ZR/tO6FMQ+H72W4wh1C5Im8fotPd2m3/jN/yYcePK4PrcM/?= =?us-ascii?Q?Cp2K+WXIJd49ppz2yp3S6JpF2Yh4yFXtpeI2Bmi1Wj1piBADD2teSXCm6X35?= =?us-ascii?Q?mteB9rdZVVY9dOjGrhvj86f7UC99sb/y4TFClWdUX7EgVd9T2MePJXkAWmBP?= =?us-ascii?Q?EXsAGVUgISBDcsobThN3OC8cBp7W70/b36WpxOa+76KKjRQ0d8htxftP95PP?= =?us-ascii?Q?9ZLBOm++FQGZWR1NJzEwRFZEpniOtd8LOUNCJiETXgIZ3xXbfT9tHDtDlKlN?= =?us-ascii?Q?k0Y3lirJ+8S0/zT143VIGlwgKzZOalg9XUSM5/SPkjqY1XtjEjsF2Lhsp0Xz?= =?us-ascii?Q?kMWaXcODMM9G/UCPm8YgbvO4H+6TUjIU2uql8ilfBwOCyK/ZyPQEuE4cjMLJ?= =?us-ascii?Q?rota0pPBtrmDUxiqY1AdEqhT+CH7zORjSF7+FOu+ZMml91LOJia6TEthIUgB?= =?us-ascii?Q?qL9/ds3cETJoGvv9QRPftDmRPRvxnB4lSmWly3S3rEGiFSOwOf7QiQmOmEQ2?= =?us-ascii?Q?TPeQ7mWNOiR3SIHOjrlYTBmJHYVTzOMJV9pwrryd6oOH/9Dm+jSn47ll5yqq?= =?us-ascii?Q?lZWkLk5Hs0JgM7GP4uuZUgNImMM+wLuR64wBgeOwIohELp/1edfKwaZF2BZq?= =?us-ascii?Q?keu9nQdY6NZygkH1kur7Fz6JMST8BMAbMcQ6w1QVmyK9D3Y03ixS4vCQ/Rfa?= =?us-ascii?Q?KklqmV1Y50eB8yVSdQwVfWrexXufNetHdw2uR1EnvR5TS5zx/ONHQ19vV2l3?= =?us-ascii?Q?yhqF7HU4Pc2gRbHecd1YDgTc3BuCKV1SgUzIJ1rWqB4SX0V98uV7jRdm/U9z?= =?us-ascii?Q?p1/M0OuW9rbHp3zpzvA6LbLrq3sAkpqWqOIyV7u/DFH6RzqdTSlwdYxtO8+V?= =?us-ascii?Q?i2yoVffNYtHr7iRIBzwntS527FzRJcOOSO0gTlcRvqC/HaBDPho3+orgzf6e?= =?us-ascii?Q?hU/KGIfV3nxgJXaFeh7Ij0ripiRWp+hxMqlaSRSjr0xLPcWlsOF84TTVpWyC?= =?us-ascii?Q?4FyJ0M5hQw4sfAEiH8HcwOkAI1cKZSGcW6jtYXRUYi7c6IUm8vISotBPlP5c?= =?us-ascii?Q?tSCLR+sB/JXcNxk6xm8yaJ0xKUmzO21axOrvjNQrLlVty3/BojRXUnYrXaTW?= =?us-ascii?Q?JaOvdzXDuZrwZ8bkec3IUL+NzAW/LuJghsM1j4NVBJDGaZNWrG9Bi1dMgmPm?= =?us-ascii?Q?jhf7ie5EtbuR4GhajkDP6aeMBjsRA6abBooPnlnciX4u6eNdNuyv8fenNH42?= =?us-ascii?Q?tKgapggmwyi0pg3E1pa/NYw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 785bc947-5a22-4075-504b-08d99daf4adb X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 03:17:24.8961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gPIwpzfWbjNAqZk/7iVBw3GZt7ojhdsHTbYP4q3kZCMycGqVUs4quRzzJLOZm89rlYP//l+p3nHahBBKvVhHyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4089 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Monday, November 1, 2021 5:46 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray > Subject: [edk2-devel] [PATCH] MdeModulePkg AtaAtapiPassThru: Always do > S.M.A.R.T. check if device support >=20 > If S.M.A.R.T. has been enabled, it can be checked. A minor comment. I think the log message can be refined a little bit to: If S.M.A.R.T. is supported, it can be checked. The code change looks good to me: Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > Signed-off-by: Liming Gao > Cc: Hao A Wu > Cc: Ray Ni > --- > .../Bus/Ata/AtaAtapiPassThru/AhciMode.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > index 1053695b3b..a2831de65c 100644 > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > @@ -1833,18 +1833,17 @@ AhciAtaSmartSupport ( > ATA_ATAPI_TIMEOUT, > NULL > ); > - > - if (!EFI_ERROR (Status)) { > - Status =3D AhciAtaSmartReturnStatusCheck ( > - PciIo, > - AhciRegisters, > - (UINT8)Port, > - (UINT8)PortMultiplier, > - AtaStatusBlock > - ); > - } > } > } > + > + AhciAtaSmartReturnStatusCheck ( > + PciIo, > + AhciRegisters, > + (UINT8)Port, > + (UINT8)PortMultiplier, > + AtaStatusBlock > + ); > + > DEBUG ((EFI_D_INFO, "Enabled S.M.A.R.T feature at port [%d] > PortMultiplier [%d]!\n", > Port, PortMultiplier)); > } > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20