From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.17902.1642989724465568089 for ; Sun, 23 Jan 2022 18:02:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mBp0BKmv; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642989724; x=1674525724; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=uQOJNQXzXJs2JF3eRuYaTKuoXAbN6nxtPiWEwmom/qc=; b=mBp0BKmvn1gz+u3r+8nDbVK2OcYper/V3hiYFAZb9Z97JkxNTj4U4Lvv sSUikMYCTsdXvOowxABdLvELIA0NZZ5wH4go0QTcMnkwHQfnjAXAUjuO1 j67c3d2Y1hlGHiK8H8r3i0TtLIHFfCbg0yaLgY1czdmuDhG/qVnenzZkE jBgXDhg8Ak+17thxcn9Pcs7YLtziwj+nofysB28l9PuGqztVZteci1IFY iWyPQ239IYtb4gpDSvw18+uMRXyodmmzKSM77uoHoOpkgykBDgdq4X0Mk S19IEKVu2Hg5hUZ6C+se20hLewlZ0Zke7eaMIwVIDgqhMLfowKYV2VKLj g==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="243538120" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="243538120" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2022 18:02:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="617077111" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 23 Jan 2022 18:02:03 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 23 Jan 2022 18:02:02 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 23 Jan 2022 18:02:02 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 23 Jan 2022 18:02:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WEWiMZXEjfZ9o0/ARaE1yx8aYy+9GX36OowJm0NDdoHu+H9eCn4YugSnAiQVmy2lAyvcIUt+1muApChA9zfBxgF+/4nV1X5KNxk5445luMbh4I/YIW/blyGa9n5kJWAz51c+8tSUK++H9DQgBkDKx2+B+jl8P5b7Yfp9gZug+jn1cCiThleDvS3/Zr7RT/ePGm5duezZqy8zDgZQFrx4+K0/HuVkOiXmVp6EyxTIUi/blw7BWwsctjugC+wmQMwuLmPhwTCnAzX14hHtKFzQCQTsAhd4kDuGd/AzwNOShzWjY4Ni2GtU2ux7sY3m8/8+q0gD8Gfd8CZ1ARo/ORMLAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GSjKU8WAO/JZ6j8YH7erG0Icf1pOg2S8FGx3PTPKJK0=; b=E5aDES5dGYF1gOn+Cq5h3JteuKNJq8sGoY1jTHV+lnBYRdD9VMBnkZIv1+Hx+A3ZWXsOAmm26KPI3Z1u8joeSwY2r/QOykSI+XTKY9fbzFscZrrKVcUMVRqtb17kqHXvNY5ZfqrhhVz9LKmbAf7EIRjOzwXRS6MXcQtbUee19+oE7P300gI6EF8X8GT9XF2xd3mwT6cigEx5zuxSCSHzcOVy7PSmkZbphZk/lB67nk2KaAD93aiVXtMzSNuL1iXqL7fz/ORdIM6QMa8rGaOVIyR5SpVnrG/WMNo9lYyDSJWCbr5+afCHLaWaOx4sm8H9zs6CoMpGne3GqXjF2cBhkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by BN9PR11MB5355.namprd11.prod.outlook.com (2603:10b6:408:11c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Mon, 24 Jan 2022 02:02:01 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::80c6:4975:98cf:bcee]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::80c6:4975:98cf:bcee%5]) with mapi id 15.20.4909.017; Mon, 24 Jan 2022 02:02:01 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Rosli, Muhammad Aiman" , "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v3] MdeModulePkg: Enabling OS boot from SD card through UEFI payload Thread-Topic: [edk2-devel] [PATCH v3] MdeModulePkg: Enabling OS boot from SD card through UEFI payload Thread-Index: AQHYDi8VcBfSYhX6ykW3Gjipiw/eQKxspqsAgATDOQA= Date: Mon, 24 Jan 2022 02:02:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2be6d76d-7ef2-4e51-26ad-08d9dedd82a4 x-ms-traffictypediagnostic: BN9PR11MB5355:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:483; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MwAsBGnYgDNxTjv9JxSDk0JstUeFOsBPv9VrPjokFRHo6N3kt+uzQM1PFbW03eDfnhKrgRVOm6RTME3wqgRiGtnoMg2MVmdWS1FJurjHyPIGeqzgAdytvrjcYNWIX7gvyiu9H0k/AwqDUxtKGx+KNhyMbW+hImt9+KxDw14qnOs66Mbj36Z/Qd0U4e3hOyiFVBPU+FPx59SJeEvANXd8dqPMIpAASq+B9ErGnE+zQdTR8kgm6k0+/XRS9axlNlr1IroHvYhUsOYS4rm+PbTw1camSwmbuExegvpufJGt0mh73d3kaMR1R64+Qe9QDp/WiaYgLGCC87z6AaNKmI1AmCezYaTDIplguaq9gM+r0z6Q0Z535GmFpdfI/tKKPtcDgbLAwqhyItucHgPOHLWTlyEhexsgLeNdZL+En0iY9RKMOh021L+AMviFZ/y4u2yvv+AgMgNKO/sTz/3ESSt4khG29qd0F7MGg7lySL4+0qej1AjFrzPBq4O/KxNi9R/qmMEutyyAZ42KnZMWIN47p785aoURlcHTa5lakPMnRvIEQ6WOSQGKRBm//LVLSgnmOfguJArYcCwPf5E7ja+llcQKLwEgZUTuNR2wbjvmqNksEjtZkJtaKAXtIQN0s6j2ibNWYBjBNTBcx1Wi8zNystD/u59WwIp6ueR0Gnfzj2WwDK61Z6UUP+p1uqDo5CfolnAnvSVsoHI/pqOQZ/Sa34BdcswZSYOL87Y0xjyEk/EbYYuQasbr7L91H5XVKLebRrUgHE4vIIMuW5z6BwrTnGwdPRJk3OVGhM2JxjUjyTgqfVE/LkoHap8QO7ZqRdF7OhWkwKHglLJ/CIurerQjQ7W7faNTW4f6Vqg9T7JZtwI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(186003)(8936002)(26005)(38070700005)(55016003)(38100700002)(921005)(2906002)(71200400001)(6636002)(83380400001)(8676002)(7696005)(82960400001)(122000001)(6506007)(53546011)(86362001)(316002)(110136005)(5660300002)(508600001)(66946007)(66446008)(76116006)(64756008)(66556008)(66476007)(52536014)(9686003)(966005)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g1A1wN5zVuDvCIUKZ3kj+xC5Zpk0FEfL2Nfc7PLy70jIbgqclRqztAPbWhln?= =?us-ascii?Q?qQ39hWbRsswqqrJewFWDLby3bdfGdY223EActXAkhqNYgS88W3vXj8auUVp/?= =?us-ascii?Q?VASn4Ax42AdIDzNvxycK0IzhRv40NWFaQxissx6cU/NYI+uvWmIdwIz/JAGV?= =?us-ascii?Q?nith89ZY7RYSxcBQXCLr51YZdMLzTgy7YnMdKk0okQxBjMRJdGo/Lu6nt6q/?= =?us-ascii?Q?2blNkBF+CGPk+DqGl5CyUEukjgW2aZvYWNb9iBa8Dd0/o6prvXlLtp3U1IMB?= =?us-ascii?Q?fNutXHn0R2DcsnvsHm1xO/zfKZaJj7j/Xk5gP2Xvk3bqIT/Srkoe9rIWltmF?= =?us-ascii?Q?m6yXBqk56R0JYGa/1l+BGEpdJmXfN70DOxbD1LHxJlK3ydrwk4nyzpFwlIMh?= =?us-ascii?Q?WaHyG+8fILiLTJsYpIdd1wrHj+JXLwqkk9HIriFTObzw8hr+vVrwbrBgK/xH?= =?us-ascii?Q?QnHyCitP/2rBwyPxuJzriLF8rzH7O9B/73UBgWFO7Z9G6avPJVF6JP9fybDD?= =?us-ascii?Q?2kpEHdD5rNv/12PsXeFPD7HPPzHPgAxpZQPLSxyPs131oCv0aqyTJxb7fDcM?= =?us-ascii?Q?2BrJwIH0vMfwZ3eLRAakpMr4bAhNyyJg6/QvfjaE2xW6+7YeMqaFTDMVrl21?= =?us-ascii?Q?2EeepW704kspfCUBbk4aySMBSqLq7CRPnVnC9Z7MqMJG25+/WVs22+4MCwK6?= =?us-ascii?Q?+g823PJ9TcGs5AYXrBl4wb1k3NemFR7emmOA4dCEc0yryiHVgMpLeAwMQpee?= =?us-ascii?Q?vh3lXH4JSlRWWZhuSGTJA7G6FNTII5Whiiehc1SocgKxGZfW4aR7SLuRdE65?= =?us-ascii?Q?99Zlfu/thgUw33ndMdqctviybIoLgNyy7gNpUNi54WW2uqEKZxwwiWar2JpF?= =?us-ascii?Q?pxkJH4F5Gj/zwAO8AekEopVGGhXn+AjYrIXflF6sbNpis8778eo2jilIkAlx?= =?us-ascii?Q?KBGmj9gYMiRPgy4Lx5/3xZ76mHOEEOIMnkF8+z1BdzeMYWNNWIwGjdS72oCf?= =?us-ascii?Q?b0K+DHvGdHI+DtJ02ECo8+YT5ouwez+uLcUvPj/DnhuCqp78zwvfRChjAiNX?= =?us-ascii?Q?VtSwCHYAp/Espo1Rs74IO1vN2MrvP0pVJdspd9d/EW6fAs3stBPSJYM8GjMr?= =?us-ascii?Q?KvkMnRDsOqG0h4waz30CfO2Tv9myhIBopROTu3Ix8X8stTLE7FH0E72eVi/W?= =?us-ascii?Q?X6f+9GGMKiAPaZrdUgS2x+Qyi6L8YKnVL89FIW5HXoqWZQhex/IKxW1UmuSA?= =?us-ascii?Q?eBLJTVPQ7v9KXow3fLGkwsXXMU/sjjaAVQyfIizA2ReYFVuxthqFwyulQAGT?= =?us-ascii?Q?HjDwr2D9tqYVKFf1QeyVEb+rMqzMgKxAOtQRWnQYxFJu+eoM1qS7kndyWhvG?= =?us-ascii?Q?IiVbLhaAD0c2LuH60lDeyIChJhLpjuCCmgRvzZI3Rfet5A0QwTWTITYbdxPB?= =?us-ascii?Q?QpwscwD1vOZ84QLqM0uzdZ/gk7vlPtduIz07DkRZB4fOzlK29T2UNNl6OOJi?= =?us-ascii?Q?wacAwOyXLwcCxUfAjrneEkPajztyZfJa4/X3TArANK+VIIJK9VvN7iFqe7sq?= =?us-ascii?Q?ncIU6pugkAlcU14m8nKUFJA+oQH6b0xTzdJsedi8/2WVWJkTSYO5cU5t2yud?= =?us-ascii?Q?DDlx4eQF8SHOXHQozSc7xyA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2be6d76d-7ef2-4e51-26ad-08d9dedd82a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 02:02:00.9476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SH0n0VM+TWlO2PkjFgL0evpRafna9zC/Ravm2jU5eHemjkTupUv7cHq+/fR9bQV2UCGkjTozZ5/7zAUPIUi06g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5355 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Change the subject of the commit to "MdeModulePkg/SdMmcPciHcDxe: Robust imp= rovements for SD card 1.8V switch" in order to better reflect the purpose o= f the change. Patch merged via: PR - https://github.com/tianocore/edk2/pull/2438 Commit - https://github.com/tianocore/edk2/commit/7e5c603cba0823fd97456984f= 4cfc21c4c831b52 Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Friday, January 21, 2022 8:57 AM > To: devel@edk2.groups.io; Rosli, Muhammad Aiman > ; Wang, Jian J ; > Gao, Liming ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH v3] MdeModulePkg: Enabling OS boot > from SD card through UEFI payload >=20 > (Add missing maintainers/reviewers) >=20 > Reviewed-by: Hao A Wu Will wait until early next > week for the merging to see if any comment from other reviewers. >=20 > Best Regards, > Hao Wu >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Aiman > > Rosli > > Sent: Friday, January 21, 2022 2:53 AM > > To: devel@edk2.groups.io > > Cc: Rosli, Muhammad Aiman > > Subject: [edk2-devel] [PATCH v3] MdeModulePkg: Enabling OS boot from > > SD card through UEFI payload > > > > This changes is by adding 50ms delay during voltage switching from > > 3.3V to 1.8V, plus adding a goto Voltage33Retry for 3.3V checking and > retrying. > > > > Signed-off-by: Aiman Rosli > > --- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 39 > > +++++++++++++++++-- > > 1 file changed, 36 insertions(+), 3 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > index 662f9f483c..f5a3607e47 100644 > > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > > @@ -1213,9 +1213,14 @@ SdCardIdentification ( > > UINT32 PresentState; > > UINT8 HostCtrl2; > > UINTN Retry; > > + BOOLEAN ForceVoltage33; > > + > > + ForceVoltage33 =3D FALSE; > > > > PciIo =3D Private->PciIo; > > PassThru =3D &Private->PassThru; > > + > > +Voltage33Retry: > > // > > // 1. Send Cmd0 to the device > > // > > @@ -1294,6 +1299,13 @@ SdCardIdentification ( > > return EFI_UNSUPPORTED; > > } > > > > + // > > + // 1.8V had failed in the previous run, forcing a retry with 3.3V > > + instead // if (ForceVoltage33 =3D=3D TRUE) { > > + S18r =3D FALSE; > > + } > > + > > // > > // 5. Repeatly send Acmd41 with supply voltage window to the device. > > // Note here we only support the cards complied with SD physical > > @@ -1366,9 +1378,30 @@ SdCardIdentification ( > > > > SdMmcHcRwMmio (PciIo, Slot, SD_MMC_HC_PRESENT_STATE, TRUE, > > sizeof (PresentState), &PresentState); > > if (((PresentState >> 20) & 0xF) !=3D 0xF) { > > - DEBUG ((DEBUG_ERROR, "SdCardIdentification: SwitchVoltage fail= s > with > > PresentState =3D 0x%x, It should be 0xF\n", PresentState)); > > - Status =3D EFI_DEVICE_ERROR; > > - goto Error; > > + // > > + // Delay 50 milliseconds in order for clock to stabilize, > > + retry reading the > > SD_MMC_HC_PRESENT_STATE > > + // > > + gBS->Stall (50000); > > + SdMmcHcRwMmio (PciIo, Slot, SD_MMC_HC_PRESENT_STATE, TRUE, > > sizeof (PresentState), &PresentState); > > + if (((PresentState >> 20) & 0xF) !=3D 0xF) { > > + DEBUG ((DEBUG_ERROR, "SdCardIdentification: SwitchVoltage > > + fails > > with PresentState =3D 0x%x, It should be 0xF\n", PresentState)); > > + // > > + // Reset and reinitialize the slot before the 3.3V retry. > > + // > > + Status =3D SdMmcHcReset (Private, Slot); > > + if (EFI_ERROR (Status)) { > > + goto Error; > > + } > > + > > + Status =3D SdMmcHcInitHost (Private, Slot); > > + if (EFI_ERROR (Status)) { > > + goto Error; > > + } > > + > > + DEBUG ((DEBUG_ERROR, "SdCardIdentification: Switching to > > + 1.8V > > failed, forcing a retry with 3.3V instead\n")); > > + ForceVoltage33 =3D TRUE; > > + goto Voltage33Retry; > > + } > > } > > } > > > > -- > > 2.34.1.windows.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20