From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0B2B7740035 for ; Wed, 1 Nov 2023 02:26:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5l/kl67+z5Q2Fu1Qr6gtlFdiLEHRW+BEXyv/liQBvOs=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698805566; v=1; b=YKwad4eL5cuv2Avw6yOPhrjAsbHLmhyZm/aRA33QlBNsuK79y8B7mwyB0SV4C1T3Yb1i6JB9 GvOsBx0p5lO0318V1m+h5j+MIyP4EPQ2VzWAkWJZbLwRdr0hEH3z3g9TQBE8EdMjuQUCzE8eSIJ FVWZC3LD5laf9MaWbauvEgQQ= X-Received: by 127.0.0.2 with SMTP id 1GZ2YY7687511xgqTzjv4v1L; Tue, 31 Oct 2023 19:26:06 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.48551.1698805565380915072 for ; Tue, 31 Oct 2023 19:26:05 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="419535705" X-IronPort-AV: E=Sophos;i="6.03,266,1694761200"; d="scan'208";a="419535705" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2023 19:26:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="884400637" X-IronPort-AV: E=Sophos;i="6.03,266,1694761200"; d="scan'208";a="884400637" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Oct 2023 19:26:04 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 31 Oct 2023 19:26:03 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 31 Oct 2023 19:26:03 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 31 Oct 2023 19:26:03 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 31 Oct 2023 19:26:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P3fgSkiEbSbUVoNqdzUtQJMxekhqLJ8zU9dBaCAp7ndo70EyU91w+ViV/7KzWVTd0/qmnfTCqdb9gphJsCn2HOSUJzApWCYUMB2C6wvLO2+KgsC/vNKZddASWcFV4po8dkH1/3y2WtVqkTztfcD9Xo/Rx9E4NGhwlEY41wYfZxfloIjzeawglOC82A/C8D45ZLbGcfHC1ITw+sjMpi3f8dwDlFpBqR5dGWqVDc8Wb9PneXtan+Xv7hxaOCFcy7Oq/7AwdSO92o4AvqnQF4M/yoMWRATViV22dtf8pCyT8guWZFFPDMDL7Tl+q9aUjObD0/9CgtLMEHr4VgmTQ5Ox7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Ru4ghu9aR4vbDC+ADYauYrUkLF4+VEwPclND68XHbY=; b=ItVtAniJ6ZnBZq36HgtqPQ0HcnUvQOCobM2EjHnrNQ3OFIjZptrZG+Wn48bf1Dwx5XPxqRiu4w+dOmd5gu9J7XTDT+17cuaRdiku2zZDOALvKFRi1iVkQeb0EMqWjTEYcZlnB2SqyTgroW4ATE3e9HWq42oSMUvCSrhnvcfXHEu0le2ZhjF89HWwf0vK7uhLUuJF++raGSbaQkAiI8ggOgMNfd3JusFMViYIbWQsZ8NknlT66wrBL+fTNvvZOg8taICc479UjyuFuGUc0nDBly5ZGsAfZjrTWwkFD2PyWqoGhBfQqvZkjNNTAKgMjzRsmD3qdOALCcErm5ciKz8GDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by PH0PR11MB5928.namprd11.prod.outlook.com (2603:10b6:510:144::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Wed, 1 Nov 2023 02:25:55 +0000 X-Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::fd1c:5b02:8fe:2ee2]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::fd1c:5b02:8fe:2ee2%4]) with mapi id 15.20.6933.021; Wed, 1 Nov 2023 02:25:55 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Henz, Patrick" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks Thread-Index: AQHaDBqkBIFo4XUkkUaV5XhTqg7HhLBkvS4Q Date: Wed, 1 Nov 2023 02:25:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|PH0PR11MB5928:EE_ x-ms-office365-filtering-correlation-id: 2c29ca8b-65a5-4200-f0f9-08dbda81e047 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: nhe6I5fiWu8xRi8zifl5YMfN6j6qsXnYiCW1UjKObKI8tixAbr2nz9fq1spHC8xmIKuRkAeAIYfS6xFcyf9LB3ymNGrDt43LRoyy1i4+B3VwWH4tpr3QDk2CuwOFHch0nFHO5gfGdJWP4FUFcsXNX+NZKdLK8nmpD59ITzN+L+xJrXjIMmY84McOAe/aUbN5kTykkGNAfPYwrqtA8DLMOrWfpjp/roxH8wX6zkf0/TbG1AMXozEIPkWFpqNpNi8jpH5jHJGwAumH2X6EUqJ0ywcHr0ly2QhBypcn2s0B2Id/RONh7Z6jLhrovXquJvnhROMDqN8qN2nYyteul4B7WG7HkIcGgw72cePwIbrLUTJ+roaX5zlex21r6vw/r/IuUAQ9FwpnXM4KMSAixY6M+17XqQrRcsK3kl2DOuu3rmqGMHsBgWh8kMNnipmQT3B6kGegRmpkAfeX+RLwnRPBAXJt0ds7uCR3L3o4BITP88Ezzz4rkMatVWQSArXBN9iFzaw/M1ABYZlEvfu9FLeiG5ZukYjsSP0sRNgPFOQ639F7rYaXOGMB/+THXiwlg68u9ckYrzPwd6l7YtSxYTKMggQ/hHb+BeaCro7SZMbOdxZYrJq3iSMheJ8+CnK136QWwRA5UZHk4dD+dw8JO1UbgQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9yujaQ4st2pNlrYTYeP6XS2U07N1NpAIqaQesB0hB0hjwYUvsw3g+kKImIOc?= =?us-ascii?Q?tWzKf12Gk2YxA6b6jNpzY7yi6wTn7q/wFvSWIJ4u5Kuedl36sYwu47M9IU97?= =?us-ascii?Q?fjk+UpPqceOb8+TCp/mlKliP4fhxT86Ga96jcMPo+57sQO88PrqubPOqvxcH?= =?us-ascii?Q?L9iW8/kqqhw9FjF91J/vSdbwRUy8IqnrDkMeOPmCh3l0jAzMOZhseqMnoieS?= =?us-ascii?Q?Xbj+96vjs1pOLesR/7OaRxgUqeKi2aTZ9wg2AwPu5WFUP1feVQCgcYJP9Czl?= =?us-ascii?Q?42vqo6HrNpcFD/+raSO4nBlfFNUnodQ+Y1UBLQh9aITvaOMdApXkimzUlsLf?= =?us-ascii?Q?XiRYSRzZ9pe1S7m32BHHMg5jIZfXDcO3EvnB4k1jP8S9I0rIE/lEYUxejsIz?= =?us-ascii?Q?5aXqoPbYbYJrlmsWjvjBmmCiuPi851kWQTlO6SukQrwhZMUrA2PM6hoZov9W?= =?us-ascii?Q?i0fas/u9Q/RwAkw00wQMeG9CVEeizDArG4ZPwkW/J4fgQVS9e2OdNasb98QE?= =?us-ascii?Q?VLYee39FIvuP3rnh04JXE8Ho7mj9cml/aMDXNaAL/6SaUMVSy4lpB3xJYriZ?= =?us-ascii?Q?yhh5upKhAu6Ejet/+Yo/CMXk5A49zLOceV9HD7+pTSSH0y6aXdjsA4Lt8uvw?= =?us-ascii?Q?joGxDrA/iqnzX5aQorMnr2wgwsJ38F53SRcdk1lb0xVBdrfno642zsFw7ARk?= =?us-ascii?Q?2tZ6cOHvzkAB9RNUZkmQlF3CMp5t6mM7+76W2ku2VID5beHMyvrDI4I7oWPw?= =?us-ascii?Q?y051wIEYN0XcFnKMyAkwxm0/zlN84mAHJlWxOvgtr/Hf7EfkfE3BhwhNP399?= =?us-ascii?Q?v9SCiA6uSHq2NLDlfZSgY0a9FAGge3qv34VhlSSJ0FVIHPjRQXmGPhdB1bI2?= =?us-ascii?Q?6UiJ/suyT5fXAn1RVyxH4jHSIMymmawdM9iBQvxZMapuGh/gerHQHMlFWXjg?= =?us-ascii?Q?+HpCd2P4VYjJeZcgghPNbG5cGl5If/MXDdIOv9oSeTUqFk35ZS+0xWptlHE1?= =?us-ascii?Q?52NN3VE1nRewWc3yzyGZpHSoMQL2ZFBAQpQDiVh0r5lY9D0oa8pyqpGd0nAl?= =?us-ascii?Q?prOEVuY4L2zdwHt4XRRTZSPHJ1ySh08S91a5q0OHBweHT98BFCJpCX2Np3Or?= =?us-ascii?Q?EXj4BLc+UoYs4WmrDpSbIZzm5Sb6y045Nt2uEkz8ydkPgxO+BFfHy0zh+nOm?= =?us-ascii?Q?3iihytlpbx9fEWILaFhUa14qWECKSHNqukiYCU0ZWoChZj+rITc3kEb7PMvw?= =?us-ascii?Q?mYMAzE1HQsog6qGeIzyqcpsG0AxoI1sTAaHNPMM/uUVlHSexG2CAsiiUDI5E?= =?us-ascii?Q?r4ImzwFAa3SRvLEChuYFkvNPrHU7Q6sXP0banBldoXefEJ6auEDbZYsT42fH?= =?us-ascii?Q?KZPxcbnIA9yxUJPiVcNiNo84IJizXH3WDa2uy5OrdjuBVEQAOZVXAfRJpEYC?= =?us-ascii?Q?MKk8Qy4Serah+udEtwy6ikz8pEdW4fafgyzSUKhTxW/5UWRF9cZxO1uiljxN?= =?us-ascii?Q?AYbnRKBhE/Bcr01Gvp/Mm5UizBnhVZ1XhCro1zY2m9KgomsG/ootG/zvxHRl?= =?us-ascii?Q?AthGeAXMua1fFCkcKLwhJV8BScmCE/f98NTz7X42?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c29ca8b-65a5-4200-f0f9-08dbda81e047 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2023 02:25:55.0923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6RyA++KfMVQvJJnERUISSLDQbQ1qofZgioOMhhK1WwO7AYPZaW/0qUOxPJxpTi6im94m7GX7g5B6c0nLJbYtdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5928 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MYvdGtcdcmN2W9h8vaZJm38gx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YKwad4eL; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Acked-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Henz, > Patrick > Sent: Wednesday, November 1, 2023 12:51 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Henz, > Patrick > Subject: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop > values in XhcGetElapsedTicks >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4578 >=20 > The implementation of XhcGetElapsedTicks did not account for > non-zero start and stop values for the performance counter > timer, potentially resulting in an incorrect elapsed tick > count getting returned to the caller. Account for non-zero > start and stop values when calculating the elapsed tick > count. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Patrick Henz > Reviewed-by: > --- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > index 7a2e32a9dd..6cb97b7452 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > @@ -2389,7 +2389,7 @@ XhcGetElapsedTicks ( > // Counter counts upwards, check for an overflow condition >=20 > // >=20 > if (*PreviousTick > CurrentTick) { >=20 > - Delta =3D (mPerformanceCounterEndValue - *PreviousTick) + CurrentT= ick; >=20 > + Delta =3D (CurrentTick - mPerformanceCounterStartValue) + > (mPerformanceCounterEndValue - *PreviousTick); >=20 > } else { >=20 > Delta =3D CurrentTick - *PreviousTick; >=20 > } >=20 > @@ -2398,7 +2398,7 @@ XhcGetElapsedTicks ( > // Counter counts downwards, check for an underflow condition >=20 > // >=20 > if (*PreviousTick < CurrentTick) { >=20 > - Delta =3D (mPerformanceCounterStartValue - CurrentTick) + *Previou= sTick; >=20 > + Delta =3D (mPerformanceCounterStartValue - CurrentTick) + (*Previo= usTick > - mPerformanceCounterEndValue); >=20 > } else { >=20 > Delta =3D *PreviousTick - CurrentTick; >=20 > } >=20 > -- > 2.34.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#110434): > https://edk2.groups.io/g/devel/message/110434 > Mute This Topic: https://groups.io/mt/102301510/1768737 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110463): https://edk2.groups.io/g/devel/message/110463 Mute This Topic: https://groups.io/mt/102301510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-