From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.5431.1635985889196426037 for ; Wed, 03 Nov 2021 17:31:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cnREpk73; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="211677413" X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="211677413" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 17:31:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,207,1631602800"; d="scan'208";a="468298105" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2021 17:31:27 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 17:31:27 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 17:31:27 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 17:31:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gr/ySk5fUBbZc9pGEzbxfnNgpDJMAuRGjmRX+P89SW8YT/ZqN/0hp6oVCTju9+6S8ayq+rd+Ud7pN7fbyw1bmvtQ+2nwZpdsx5/1pVs72kfqiORuMSPb4uRfAD1kfYzYCAGYBIFGO5SDeM4/JFViuYJkKKAdskjdBi/w+nsHBDhhA61EwoJe7cu+gS+xBeHRkQWsypDMDyvBnYueCieTthASDGs0Qdp/n9I//hsKslD5PjoFIs834sO3kc/ZxcorDMnONy8aC/la3OEplrWwfN9x2YGaAC5MNPQIhXq/s5HKFl0aKc6yUbfw5ldchOEiVTKX4UNqwEqfu5ehbeIBXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xWrPzxFqwBGI2rs43nT9LSnBEnvpyjT0hwu4GMTGuuc=; b=PW/GOC2fsmr/HIBkMypx5GF/OwdKOctOnU+gE/vEb/3hjT5IjnazbNnsuqFRF4OVPqJ8JagGRuVQYQ5j4i9Psw0+9cwzaIk1J86CXtygg5k/fPWHkF+wsF/lg9aKdBZds9hZUHLJUHZM8I0h59gThvY4jRpFOgZzz03y3knvY+HZZK6hrOncbru9gkHa1dulXpokI07LlAyy0VXDNPVMZtYTv5RxXawT3Zkxzw1jMVhOnp3TrL0C58J+FAkdNL9AjsGcqwCoJMvcbJHGprQvt9XBRM2uOcLB62Fd+Hcrr4uuChquuQyo1qVGyEI5WYk9m/W0oz6LF4ux8sUhgP5HHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xWrPzxFqwBGI2rs43nT9LSnBEnvpyjT0hwu4GMTGuuc=; b=cnREpk73AYvsqDOpGd3HaeWjy1ZHG2pVG2xiPjGu9DuqaUXNzB3rIP9BMZ64msghbf4O2xcuALGq86feyAn6b1bNK4UhLRV7aTNRikg7t3RzgCp8Qo6QnFDcbsMHLntnnW4UjglbZk4BKxfkEl7myUpzHOc+3nQYSrsMvJ8tgfU= Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB3882.namprd11.prod.outlook.com (2603:10b6:5:4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.18; Thu, 4 Nov 2021 00:31:11 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::214c:de33:74b3:bd7b]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::214c:de33:74b3:bd7b%6]) with mapi id 15.20.4649.020; Thu, 4 Nov 2021 00:31:11 +0000 From: "Wu, Hao A" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Wang, Jian J" , Liming Gao , "Ni, Ray" Subject: Re: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments Thread-Topic: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments Thread-Index: AQHX0MZX1kmZCHtilkin6+Rx8IsTN6vyhNxg Date: Thu, 4 Nov 2021 00:31:11 +0000 Message-ID: References: <20211103151625.2992-1-mikuback@linux.microsoft.com> In-Reply-To: <20211103151625.2992-1-mikuback@linux.microsoft.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f57e7c0c-d283-405b-1324-08d99f2a6730 x-ms-traffictypediagnostic: DM6PR11MB3882: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lQQZ8W9lDmae4UNYQoJRqY7yYPsHJE0pgt8cdayy4Cg1Njhv2P9lq9WVqL2/hlegMVb1eQ6+mOTXKI1Uz/QRi9y0/1eAuZ+DFiUZNG/fURKN6dUjAZiwpFgz/0Qgsyy8AB4L81RxTDQPjmCbQd6ga7VPzH4AtTaSr68akJ8RhjGS3VDGpVjJgLXIu4+HXVvIKD+cjBh/vGjX6zAZ50RXBKHncfysUt8ptPr6WQd23lSDhPrSATH1BWFEUlomhIvTuRjOnMCAIaOdpM1Qs5+uFv2FOdHmnoaFfCOS4vy+cH9aErVFUiCXZ0waMcCmvIZe3nsREu0cmazZHYE7V8mVqsY4xQMgH/lEYM1fZyxicn8QRvnS6oTvIwbeZaKxNyAWtSxyn5gNh5qlo+bBrdXpMu9e23FRnGqlTdTUzsCQYDCT+n1vKX2n+d8tFGZUnvqtfsejd2XtJuIQpCzYUAU6nYSX3j/pP9j396CiC7/K060em6OOUqt3HRWqDHK3KD0XHz213RgQa3g8eisvLsDQ2hrSRbJMvDHj1Xb+Yz8FTAyuJ0wmo+m5ZJ0NWD1ykydshNqfs5Xlz1HKbhTixr1PPGmKKHAbnOnThQmZ64SSjDaKeoHbnYULjHSHrQERN22Z4YqSlqY0f4Z8qJMHuFev88VW5C+gp/o+DIBfQtU5OqIsWAjvQcFJtdni9szQoPTdoJEJ2fuLUqT4FAoHV17txhvqEXcNsug1yh1x2gPGRbx4P/qPoXk3scRsMUzbCpWlN5y4XIFYOYGJv3S1F4YfDuVR3Lc2Of0jVt/THouHcWA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(83380400001)(52536014)(66476007)(8936002)(76116006)(66946007)(8676002)(66446008)(19627235002)(82960400001)(5660300002)(38100700002)(122000001)(38070700005)(9686003)(4326008)(186003)(55016002)(54906003)(53546011)(7696005)(64756008)(66556008)(33656002)(110136005)(26005)(86362001)(107886003)(316002)(6506007)(2906002)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oqQlZpjeNXwIhucPENdkeaUOZIYI7QfyMPjJrQbISP8mo6gJJ1FaOjrGN7z2?= =?us-ascii?Q?eGDSrbNr2DcAh/fFycZhwRTecmJFWHGXg8XkA6Kn7BotOZvVFSyctMSCDudD?= =?us-ascii?Q?6gheIgcMlrzTBRN04R4ayS0jscCx6Gni7wokDdF6Z7cJI04alCz7CHGv9vaQ?= =?us-ascii?Q?4Zw3fx3GfkCNNXScFpsPyd9iihlLC/ceB3HnoqkohnVcDxmvpNYIj+YeFJ13?= =?us-ascii?Q?MUCEkVnudleO6xHf0PJ9hjh++ON+RUhUoS9chBiOPjK8VyxHC7+s4P9bNnDU?= =?us-ascii?Q?3y8J9MidufNP20UKiqa+yr2eniwtA+kv+7MJHjZJIz9G26RarTCjeSuJ5fDx?= =?us-ascii?Q?qQWBqWnvKySqcSUDC3J4Xz45Nxy1eOvSVCUcyF5pTHAayL4BMEgGcHZwsmmM?= =?us-ascii?Q?aSaaTrrN/Aqw3oCPwTTEihT0vk5gV2qf32Jz73BntCjKwEzWdHzeDmTrQU4w?= =?us-ascii?Q?LiKwhr1ImtGviFo9ki4CC+HaAvYmV0nFfpn00JpLjHNhBeWxvlnoZRFVdA/0?= =?us-ascii?Q?+dvne4hPzrE+i7nosuVo5f73DggKYjf6AyeHTWCDQJxe1mpNH++2WMSOP8U0?= =?us-ascii?Q?AnWgnvWTrgoKpt1R7fQsMYe1Jm8s4aFQ0EeBvAHABC7d95SelqJQPXGNA/JE?= =?us-ascii?Q?t52WU7Lp60eysf73sZZlfUlPf8OtUpfGjQlYSjayDrmPofVNwJTmTPs3UtwT?= =?us-ascii?Q?sTSiqDiTKJbB48P3kqkqxP8OhrEHDagc+OTqd4U5kMv4ztWAt/18kiy00j9G?= =?us-ascii?Q?pr7ZPAEzN015YTwm51botdU9mp9JEE3RpXtkkubOEQNDavKS35ovFvHCXjrq?= =?us-ascii?Q?lX2sJGoN5diik4/ADrYxQcLGzMF8ZlInWYZsREepWsWVNTa7xmwfQ07kjkbA?= =?us-ascii?Q?B0nSrszYqHtW7zk9nmCf/ev1qf85hexd0JTOGkZKVFuVl7rPI/WODEJMNZUD?= =?us-ascii?Q?9N1m/AsbEhv7iqtRo4HiN2O9zt/QPxrnAhwrWg/Cqel3uEZYmbQTjNjXNTJK?= =?us-ascii?Q?/E+sOgYILWhM0ZQ2EG48SOVaBTecNCXYsZczDtdRPiy8TtKlGeB7/jEtlOSF?= =?us-ascii?Q?su98/FNHLB1VYyuicM2EicQFDu1PguV7GAF/S2CFn57xuDKY634lStXjKTMF?= =?us-ascii?Q?VXcRzZAaG55UgKv2ZIRUBfH4HiJ9JfItKc3V+c6+wU5fbhlF8mzDA3wx9IRi?= =?us-ascii?Q?b9i/nn1L2CAuxQexGaSUdD5DN0QsCX3tk8TtMi2PWUYTLNDqUioJLOGEQIKg?= =?us-ascii?Q?MiNfrC36AXh+V8m6EK7AHoWgHuTPUXS6JiaYIl+VDbKY7BP2uaIBrVexDMpY?= =?us-ascii?Q?wBqehJWSYv6UPghINPkaaJ3q5yu00p7MnDBfHHS6YmtqgCn3cvPbshRHEhgM?= =?us-ascii?Q?sU/u5kfPVD7Hdbjari6jL6fitK6cWQ6WpFAQaAnoLv3EoLrcz2WaQM1NYNZr?= =?us-ascii?Q?NNIpOlGoTrtYcDPvOzpJnlZNP0X110bGxZ57Dl7NW9ivX+ZgIo3V8e6sCwnj?= =?us-ascii?Q?neG25/V8iIT3erkAyYWyVr9C2qytthw5PKz7a0k5ixrekUmgcEgheOZKmVoA?= =?us-ascii?Q?HXqWvXwV4OE5BqSmO/JH7hM/l6BMnbH2Ij/WALRe9qQI/mEJhfC1Guv6xpTm?= =?us-ascii?Q?DZCqBQGz54VrBH/Ybc2azU0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f57e7c0c-d283-405b-1324-08d99f2a6730 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2021 00:31:11.7722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x0vhWq3bq9TaEAIIHnMyw0r3Eq1eAzFjwWnPF6K8QouoOeWNz70c70iexv26kwg2hgwC9HLsa7iuFd3uv+RRLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3882 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Wednesday, November 3, 2021 11:16 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Liming Gao > ; Wu, Hao A ; Ni, Ray > > Subject: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG > arguments >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3662 >=20 > Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument that > should be passed for the print specifier. >=20 > In addition, this change updates the print level to "DEBUG_ERROR" > and prints the status as well. Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > Cc: Jian J Wang > Cc: Liming Gao > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > index 7cbc9a8502ea..6fcd2be6277c 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot ( > DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", > DeviceAddress)); > Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; > } else { > - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n")); > + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully. > Status =3D %r\n", SlotId, Status)); > XhcDisableSlotCmd (Xhc, SlotId); > } >=20 > @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 ( > DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", > DeviceAddress)); > Xhc->UsbDevContext[SlotId].XhciDevAddr =3D DeviceAddress; > } else { > - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n")); > + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully. > Status =3D %r\n", SlotId, Status)); > XhcDisableSlotCmd64 (Xhc, SlotId); > } >=20 > -- > 2.28.0.windows.1