* [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments
@ 2021-11-03 15:16 Michael Kubacki
2021-11-04 0:31 ` Wu, Hao A
2021-11-04 5:59 ` 回复: " gaoliming
0 siblings, 2 replies; 4+ messages in thread
From: Michael Kubacki @ 2021-11-03 15:16 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Liming Gao, Hao A Wu, Ray Ni
From: Michael Kubacki <michael.kubacki@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3662
Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument
that should be passed for the print specifier.
In addition, this change updates the print level to "DEBUG_ERROR"
and prints the status as well.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
index 7cbc9a8502ea..6fcd2be6277c 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot (
DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", DeviceAddress));
Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
} else {
- DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
+ DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully. Status = %r\n", SlotId, Status));
XhcDisableSlotCmd (Xhc, SlotId);
}
@@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 (
DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n", DeviceAddress));
Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
} else {
- DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
+ DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully. Status = %r\n", SlotId, Status));
XhcDisableSlotCmd64 (Xhc, SlotId);
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments
2021-11-03 15:16 [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments Michael Kubacki
@ 2021-11-04 0:31 ` Wu, Hao A
2021-11-04 5:59 ` 回复: " gaoliming
1 sibling, 0 replies; 4+ messages in thread
From: Wu, Hao A @ 2021-11-04 0:31 UTC (permalink / raw)
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Wang, Jian J, Liming Gao, Ni, Ray
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Wednesday, November 3, 2021 11:16 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG
> arguments
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3662
>
> Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument that
> should be passed for the print specifier.
>
> In addition, this change updates the print level to "DEBUG_ERROR"
> and prints the status as well.
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> index 7cbc9a8502ea..6fcd2be6277c 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot (
> DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n",
> DeviceAddress));
> Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
> } else {
> - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
> + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully.
> Status = %r\n", SlotId, Status));
> XhcDisableSlotCmd (Xhc, SlotId);
> }
>
> @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 (
> DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n",
> DeviceAddress));
> Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
> } else {
> - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
> + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned successfully.
> Status = %r\n", SlotId, Status));
> XhcDisableSlotCmd64 (Xhc, SlotId);
> }
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* 回复: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments
2021-11-03 15:16 [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments Michael Kubacki
2021-11-04 0:31 ` Wu, Hao A
@ 2021-11-04 5:59 ` gaoliming
2021-11-08 4:13 ` [edk2-devel] " Wu, Hao A
1 sibling, 1 reply; 4+ messages in thread
From: gaoliming @ 2021-11-04 5:59 UTC (permalink / raw)
To: mikuback, devel
Cc: 'Jian J Wang', 'Hao A Wu', 'Ray Ni'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> 发送时间: 2021年11月3日 23:16
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Hao A Wu <hao.a.wu@intel.com>; Ray Ni
> <ray.ni@intel.com>
> 主题: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG
> arguments
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3662
>
> Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument
> that should be passed for the print specifier.
>
> In addition, this change updates the print level to "DEBUG_ERROR"
> and prints the status as well.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> index 7cbc9a8502ea..6fcd2be6277c 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot (
> DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n",
> DeviceAddress));
> Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
> } else {
> - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
> + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned
> successfully. Status = %r\n", SlotId, Status));
> XhcDisableSlotCmd (Xhc, SlotId);
> }
>
> @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 (
> DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n",
> DeviceAddress));
> Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
> } else {
> - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
> + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned
> successfully. Status = %r\n", SlotId, Status));
> XhcDisableSlotCmd64 (Xhc, SlotId);
> }
>
> --
> 2.28.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments
2021-11-04 5:59 ` 回复: " gaoliming
@ 2021-11-08 4:13 ` Wu, Hao A
0 siblings, 0 replies; 4+ messages in thread
From: Wu, Hao A @ 2021-11-08 4:13 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
mikuback@linux.microsoft.com
Cc: Wang, Jian J, Ni, Ray
Pushed via:
PR - https://github.com/tianocore/edk2/pull/2181
Commit - https://github.com/tianocore/edk2/commit/b5d4a35d90771ec86ce9cf28727f471ee589fb78
Best Regards,
Hao Wu
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> Sent: Thursday, November 4, 2021 2:00 PM
> To: mikuback@linux.microsoft.com; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix
> missing DEBUG arguments
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> > 发送时间: 2021年11月3日 23:16
> > 收件人: devel@edk2.groups.io
> > 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Hao A Wu <hao.a.wu@intel.com>; Ray Ni
> > <ray.ni@intel.com>
> > 主题: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG
> arguments
> >
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3662
> >
> > Two DEBUG macros in XhciDxe/XhciSched.c are missing the argument that
> > should be passed for the print specifier.
> >
> > In addition, this change updates the print level to "DEBUG_ERROR"
> > and prints the status as well.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > index 7cbc9a8502ea..6fcd2be6277c 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > @@ -2299,7 +2299,7 @@ XhcInitializeDeviceSlot (
> > DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n",
> > DeviceAddress));
> > Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
> > } else {
> > - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
> > + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned
> > successfully. Status = %r\n", SlotId, Status));
> > XhcDisableSlotCmd (Xhc, SlotId);
> > }
> >
> > @@ -2512,7 +2512,7 @@ XhcInitializeDeviceSlot64 (
> > DEBUG ((EFI_D_INFO, " Address %d assigned successfully\n",
> > DeviceAddress));
> > Xhc->UsbDevContext[SlotId].XhciDevAddr = DeviceAddress;
> > } else {
> > - DEBUG ((DEBUG_INFO, " Address %d assigned unsuccessfully\n"));
> > + DEBUG ((DEBUG_ERROR, " Slot %d address not assigned
> > successfully. Status = %r\n", SlotId, Status));
> > XhcDisableSlotCmd64 (Xhc, SlotId);
> > }
> >
> > --
> > 2.28.0.windows.1
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-08 4:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-03 15:16 [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments Michael Kubacki
2021-11-04 0:31 ` Wu, Hao A
2021-11-04 5:59 ` 回复: " gaoliming
2021-11-08 4:13 ` [edk2-devel] " Wu, Hao A
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox