From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.1640.1659406868258364578 for ; Mon, 01 Aug 2022 19:21:08 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=FIpBEGjX; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659406868; x=1690942868; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d6UjYtQQGN+UvLs3clg5nkzJHOjZCOddlHy6Fzv9JPc=; b=FIpBEGjXw5zCCDZtzWSJLbUxs15tffuXqgx7vXajm/66zpex53nnByc3 R64Dp1Njb1WG30wSJ0v201ExTObMSltM4m8ownFNnIuZMSm/JH7APBPXq qfIjsmkMyIHpQ5Y1MZCtMA0yrFRUEyQqtb6RSMZOLLYzyN4tDgE82NxBB 7t0B6+TvscajlWgblBiRjgZ/W++ZJzrfQg6djDVwv/B2CnIhRWa/rUIU9 xGPu54kvGuvXeJkaR6yhILD4/TRT1Ow/mVY2zpBhHLC2d9gsznXneBptm zwYzWaU7GyL2q/bbrKj2Im1N39+zhtVbBcTTD56AwLALU5wN1DE10JoK1 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10426"; a="286861366" X-IronPort-AV: E=Sophos;i="5.93,209,1654585200"; d="scan'208";a="286861366" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2022 19:20:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,209,1654585200"; d="scan'208";a="744499424" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 01 Aug 2022 19:20:48 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 1 Aug 2022 19:20:47 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 1 Aug 2022 19:20:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 1 Aug 2022 19:20:46 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 1 Aug 2022 19:20:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKtiBc2yRC8W4My5b5cjuhggr5OsJMA0iXC3XD78tOiRghsD/e+mY+BXcruKnJ4PYk6mBTa2poUHaxUZeHacVOIkHOqE+PqK0HjojveHkcohCp6KyS1IZuCP4cGezJSg6EtlZGZwYzDoFqdlo4M1BMBp+BWBjVLleH/XjZNri/8JfWhimSsIWdfM5457YpGvkmJLXX8Qd/sVhTcc2RVrL8ay9MIxr0Qv4PFt0rO7KsoiNVepvnHAgex2+Kq5SjP8MT8WWhzneOH6/ojthzEoJqeqEFOmTBxZBhW923WOBkxmjR0IoF+/MCMwZqayZanZ6NhzFqf3Hni6I/0kra5zGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhWVJ3ge97orNsUs1AZM4NMgKSjJOVK4Cy8avXlSEOQ=; b=SVxBPgZ1oeoNPc/u/egR4mUT9EZwKYh0M0GuTqZNsSulPHxLGRfx4LXHB+/K2LLZAeUKLUYZIknBXllcRshsDtPCOxCUttXzn+/+OAtUE2R6VQj+3QBHninF4PPoYx6yW/59y22mnVdFG7kgu5LaU7LdzsTRWhGaM8bLJoQL4K/mThmR/Az3PJJ7BhSNqL/BMGRk3Uk0k3i76P9OyyqwRaXvABJmqNqpSLc8RoGuuRIKRCfP6qRaLVxKfdeYUVNDj7dgTIFkIqaCsrKFlXz3oBmNde/j2HxF9xd5COoPIsBosC6N1ig1g+kBTviunMLmP5KHY78vXNzEw6v1WKdeLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by BYAPR11MB3224.namprd11.prod.outlook.com (2603:10b6:a03:77::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Tue, 2 Aug 2022 02:20:44 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::e9b3:7cad:874e:77f]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::e9b3:7cad:874e:77f%7]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 02:20:44 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Czajkowski, Maciej" CC: "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2 Thread-Topic: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2 Thread-Index: AQHYpchIoaAE+YuFrEmIl70Dfxuoo62a2Xmg Date: Tue, 2 Aug 2022 02:20:43 +0000 Message-ID: References: <20220801170009.2113-1-maciej.czajkowski@intel.com> In-Reply-To: <20220801170009.2113-1-maciej.czajkowski@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb6cb880-4f19-48a8-63b1-08da742d9a7a x-ms-traffictypediagnostic: BYAPR11MB3224:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PBWx9iK78vXmgV5Pz0azd6S/iK8W8zBF59DwFm6cL8N5ymNj6OOF8uG7JEzzxwzP+DZpx2tqU3Gx1ax847xRZqO+RByDwSq1L0b5d5zTAkJxQyjfv8tgYFEF9nWrGNWfJKb7YpI8RCWn1Z8+EDaRMYpc6J41JNXwbTMDoks7zXl41Rbb/oBR1ZOXVVVGREvHWKmsbtr0TkECoF0LqNqIIDm1fb6MKTux4KFPp1IptG4TEYo/m5mn1qlM88XTR0Zlxp7ba7a4ebSTqyjHyv8UlsalXnlCbtg4ZlBkZ5NlSsOFKvSuCxBxeFz3a0AfGC/2dsloDsa/OM6Wjbw5szLePKKWNUueYdOmJ3d1te6a52yXDrEathrbfZHbb4jiPlh9LQzPmK8knwFtWcaLSDHUEs0E4oG0g+xgskAeYxJ+yEWMQj9tOpzv7hbe4nxDWcyANfgRwK5LDojBzYMZXrlqCXqd9d2+TQWwDm1yC2WicpvWqXvCxVBNDA19wYUnW0SEvLB2K/ZuF9EvH7Dcbo7QEP94RBBMEm8yLpJQYlGAdHSbpT2YU/H6npmWFXNTA/oNE4vV1iuzQAOuWYHHlXF7TAoO+PImuybuUAJ0avjbllROBGi9IEXQ+W9GL1pDgMcY2EpQocgLT+JtxZma0V1C0DYM4WI322Tw/yAsfeg8C2DUYNsbBK+rN6DLYRP6qfkK+xdjB5yY8c/AqU/e9eXaCBD1zfybJ1UjgalsaTI2CIWWwVaThj72s2S2x19PD9JUGjLvmoF5/9i8/2XI+qb82l2WyJNKoWe7AX7RBfBArdgfltn4gkWGMsgECVQm4tUspULmhSx+Fcf7EzwtfdmlMlVC0lBoNM8O/IrFBGooX8PbaHR8vMT0vTFzGBEKtE95 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(366004)(376002)(346002)(396003)(41300700001)(6506007)(7696005)(53546011)(9686003)(26005)(316002)(6636002)(55016003)(110136005)(54906003)(478600001)(86362001)(966005)(71200400001)(82960400001)(38070700005)(122000001)(38100700002)(83380400001)(107886003)(186003)(4326008)(33656002)(2906002)(66946007)(76116006)(66556008)(8676002)(66446008)(52536014)(66476007)(64756008)(8936002)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m5Rieh8UKBovPvbdltq2RYWVm9QH0qfXBbtdtmABGzjnP2Le/54u16ErFvJJ?= =?us-ascii?Q?iKPN6VtMZ9zrYbG5w1a+nf/36BoW+AAO3cuwaJHW/sDEJl5WYsvCgtfBTtNO?= =?us-ascii?Q?e9vKRX8ilgrsNM0+L78dMfGTi0bT//3l8c8wXDUaqBxaXlcckHykP+nJk8Ee?= =?us-ascii?Q?1r7mNRKgyeqscYfp1vmWrxtce6y3uvB143YijnGj+OlOnzQNUGTIALMgAPI0?= =?us-ascii?Q?3xwUIl9QP9yVVvSFclQEbh92Fqiw1WZDDXZl90FatgShX4k3rJvRC/qh3HmX?= =?us-ascii?Q?JEWdOCrnTuKHd6fPcfCus6XAarf6VmZxruTc6gL1qNa1R6aUcDjqaOH/PqmE?= =?us-ascii?Q?xj+ys1U/nRlCv1X8wt9HVMO61HstphexxHs29BluufvOzw/YqqENRnzOAtXQ?= =?us-ascii?Q?ZlW6hDJ2vgF2WXuH7KJmWWMng5HRMtm0YYCnxjIYclZ4/1Z36nXtGTpbakD2?= =?us-ascii?Q?rNDrGBiEsJxdSCvVtwDzbgL7vAfDUKmD3JgdEeXFkzaG2/yZfLZHgoisjOF8?= =?us-ascii?Q?KElchi9IF0VE50Elf/xEx6iJzswBLgg2xBiZdyNsRsICNScWVmwdiawbCyKf?= =?us-ascii?Q?+QZ5cqxsNBg3pOSx4wU29XnO/2mhBXzYITP9wHKFPQwwi8Wp/NwpB7N/Aj/j?= =?us-ascii?Q?3HzYCdDRt58ahM5+9jeGqRI8C+UP+RapxSYFgidqPg27sOh3Zj0ha6pXcBEJ?= =?us-ascii?Q?iQPo4w8TmCSPFBhSStjlb3mu98MUKS5bJ2Wzt5GaJlF2KFoEeQxeLFOdZIzu?= =?us-ascii?Q?F8BQw9225FugJkp5Vvcb7VNORLR6NDG/FTUPB6kuiORjcOoz6piXP6B48RpV?= =?us-ascii?Q?bs/a+HU+5eWOJdAz2EDXoC8buHF49jtmVtnM05dUWDQksORKKeH7DnQJCQzY?= =?us-ascii?Q?htfh5Ziz1jxIbm163cGaI3cNhPJrW6t/tIqxF+3AMpfg7cn7FCTlyltAPbHW?= =?us-ascii?Q?8aV1OoeYu/KGqPU8ZSH1ASKtnHJfS5huOWqLdZyeaHcwkn7JHm6UQeFI2LDf?= =?us-ascii?Q?+6AkGeYerDfwwoN6bVbIjLsszQHX1tNqLrmWcfP/PWzmV/ml8j7Y0Bv2UKzR?= =?us-ascii?Q?Om7iKr1ExlLUhj23wAEoMnGFzNLo0Eb5WSPIWHnsEkCpTyGBd2DQxvDU+t85?= =?us-ascii?Q?9fhKFmgFeR8lgeeFMub4bxMDLgbXAPi4TnreMqBEHbbyQpk8XQ783RY7foU5?= =?us-ascii?Q?l7Jj5WYIWr+/2+3dHrPV6c+eH6sdCATZoAEtnwkbUBxDYURy6CZp5Q6cRNna?= =?us-ascii?Q?O31KWMC2Dp7S9CyqlR0j2rBT7bHhF0j+nqmUhADpCzLqkXKfMPHZVEO8b0+9?= =?us-ascii?Q?S5GHNEcytuUjHQ4O2JxOz+hHAcZnhtycfA70wJ3e7qPtiehGl1IFIV4UjeYD?= =?us-ascii?Q?/YU8VpH+rIKAm+mbm+ZFxj806JScCBQw8w3xGUolgn8ElGj1H7ZgUI0/W00o?= =?us-ascii?Q?5lRCY8lBipnyu+yIiOmDkkcz2JbI68nmO5POg/qln9iEc+i9Y2bC0PtLUQYB?= =?us-ascii?Q?DlYlFVHM1fBspudqGrAmWqLzXA+SxhZi1qBWyyqGBVrEepqG2YqSj1GbQ8qm?= =?us-ascii?Q?jaGZKBYtynt3Bjfup9tMVXUuTAHuK3mzcg1ti+v+?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb6cb880-4f19-48a8-63b1-08da742d9a7a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 02:20:44.0096 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U+ez/yhmsQsSv7SLldgrCFWW8+ACHXrFYC9JohSSqUttzVfVZHtnXqskthR0VULZeelFCyArXPEOEN7Hzq7p3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3224 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, the series look good to me. I have given my R-B tag for both of the= patches. Will wait some time to see if there are comments from other reviewers. If n= o further feedback received, I will merge the series before the end of this= week. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Maciej > Czajkowski > Sent: Tuesday, August 2, 2022 1:00 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to > EDK2 >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3907 >=20 > The purpose of those changes is to introduce the way to enumerate and > assign resources in PEI for the systems with more than one PCI root. > Here is a need to have an interface that will support such a mechanizm. > For now, the part that performs the enumeration will be implemented in th= e > silicon code. > Sample code can be seen here: https://github.com/mczaj/edk2- > platforms/commit/d443062e58f9fba228869b54f2546d9735b3b506 >=20 > v1: https://edk2.groups.io/g/devel/topic/91575907 > v2: https://edk2.groups.io/g/devel/message/91893 >=20 > v2 changes: > - collected Acked-by tag for no.1 commit > - followed-up with change suggestions in no.2 commit >=20 > v3 changes: > - no.1 commit: picked up reviewed-by tag > - no.2 commit: a few fixes based on v2 review >=20 > Maciej Czajkowski (2): > MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition > MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device >=20 > MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c | 505 +++++++++++++------- > MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c | 44 -- > MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 57 ++- > MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf | 5 +- > MdeModulePkg/Include/Ppi/PciDevice.h | 32 ++ > MdeModulePkg/MdeModulePkg.dec | 3 + > MdeModulePkg/MdeModulePkg.dsc | 1 + > 7 files changed, 425 insertions(+), 222 deletions(-) create mode 100644 > MdeModulePkg/Include/Ppi/PciDevice.h >=20 > -- > 2.27.0.windows.1 >=20 > --------------------------------------------------------------------- > Intel Technology Poland sp. z o.o. > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957- > 07-52-316 | Kapital zakladowy 200.000 PLN. > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego > adresata i moze zawierac informacje poufne. W razie przypadkowego > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale > jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest > zabronione. > This e-mail and any attachments may contain confidential material for the > sole use of the intended recipient(s). If you are not the intended recipi= ent, > please contact the sender and delete all copies; any review or distributi= on by > others is strictly prohibited. >=20 >=20 >=20 >=20 >=20