From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.36970.1639546488506717740 for ; Tue, 14 Dec 2021 21:34:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.com header.s=intel header.b=Ou9ipHIW; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639546488; x=1671082488; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gZLhBjYDfqMZxJ9Ss0PZWIkWQw9H/yG6c6tVE+PLxUk=; b=Ou9ipHIW9Q6uOiqtob8ZVGy4PI3YSQqvGOlsNlyIbRqukW2Y6N5Hz+GQ qmLQGCM4fnQQqwQW+uZ7vNo6qYs8RfnlANZig2XQwdfsznVjbwwljx8eU KihPSw05zW4/N7/brEsk1ExMHgsLc+zxW9ZcdR3pP2tson2DvdaWWh/ov RQVsTDZ/PQMwILMP91MuFiqyCd9XUMnl5Vn1BhxqIphddpzWWztTsYbOQ GTN+DkadGzkOgamKaQKKt6vbZ6x5RzdrkvSiWh3yEH5rAvHMWUinqKONf e1sI8OXRal7mlRxUgstTFwl81BV2uC/RjWZd6AjVCzJdOmEGXoMvdD1VS g==; X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="238965680" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="238965680" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 21:34:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="661742904" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2021 21:34:45 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 21:34:45 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 21:34:44 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 14 Dec 2021 21:34:44 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 14 Dec 2021 21:34:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QlAvtAix2TKI25fJzPttiCxH3uA/D62mJsIAT+cbgOnqoMmJB5GQpnrXzFiyrK8ppit1Ct0U6M6cJvA2Abm48vm0XRF/aRfDZn3Thdi4ltaMvRKOaK3jXRuygI8P+99af6ldwZl2VBUw2fv1puzD/aT+Yp1Eodr9eV+36ThMaXaEIM7j9NssjwTC5MA4eczExa0R+YIHFlRAMVNdzSNIQ1rj1BMkeTzxK3NMu2Y4GyhJ706CLxk+2Mqcx5vU4V8Rj0LEeMycx05mLZ4UTMQaepx8rrFyr7YhVC5KRk1G+oWZFoykKtZfY8XpLVFa4M9msJguKDQucnEC0TQQ7IMuDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wlpkw2ZvPHRgcY9eFzDaxktPjFhIbbQ2tm67b2DpEUg=; b=alb1Kx9ASrfpL1+6fruuKxasapTyyTts7U9V0ap7ZeaXnk77ImJWhCfPf4yPxqkx2bJLheVG4b50imi078qrfr6E75MKeUFHzQ2HIm1o6A+nCZ13GHklcaFzcbzemzLV3wIhyHLhDVtHoaIMBOkRcJoL6Bw1z8cIUq5YiYRDGAz2suj8RRz9gOOyz2otqyg2ktDrY+LmUvp8HNuymWBja34baiS+UuKLPGGhSJF+t5BFT+8gJwwGt0yPUnppXElMiiZ29qTlWvSX5BHT70+eaWn9NZf9KtOc5x2EdqkzaYt2UXgelc/UU93VlB7R5OSbP0lVZDGWT4VuiC0jzH3b8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wlpkw2ZvPHRgcY9eFzDaxktPjFhIbbQ2tm67b2DpEUg=; b=epHqBEnZfovD6UWIAFbMe8PGC3qUMOsgB0tJC4UOw6jPuoWIhjo0qIiDCMLXje/WBqroHMaqsKqExmJ+aX7SEqTw8nkcEkNxs8gYZUjbEmMbaD+i1KjneHFS9L2TWqsONst+YiIefzzNhQJyfC0V6eq0YjeJFQ12l+2amvNdQLI= Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM4PR11MB5262.namprd11.prod.outlook.com (2603:10b6:5:389::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Wed, 15 Dec 2021 05:34:43 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%5]) with mapi id 15.20.4801.014; Wed, 15 Dec 2021 05:34:43 +0000 From: "Wu, Hao A" To: "Ke, VincentX" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chiu, Ian" , "Chu, Maggie" Subject: Re: [PATCH v3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix response timeout problem. Thread-Topic: [PATCH v3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix response timeout problem. Thread-Index: AQHX8WNAUK5m3KCyM0+WkxpQjjkNU6wy7cfA Date: Wed, 15 Dec 2021 05:34:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 615ca12e-9895-48a8-d75c-08d9bf8c9932 x-ms-traffictypediagnostic: DM4PR11MB5262:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:45; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rHF9O+Vdn4gMNdOmmOO6nL45Vn90s962R+r2CDJbxOdJI6MFtwk/aOND9PbU6sq3SQSi65Z4c3Ojij3DQWoAcog3/YuDNbDHbkFzsNKkwB5T0bnly4DoTqZDDScZX0UOFcKcUfkF3U9rGEBNVOaXthuWKg6vViZkACGorxO8by8ldtvhneLYNrdujP/8b2qGmxUiy8hQq/8F8q0KtMxUPfEU2UXXmWb2WGdIb3R4bRqdcPsXsqSwN99Y8eqyqdINrft4RJtAMc2QVP9HqhTQ2dEPM8okqzdvCytLS9zxyUeSty0210aPHajCT3byi5fIgXFPsO1Eiw43Y9cfH8TATFUm6vRfN0FFLjg3vvPVnry7IO3ZeDDXysbKUSkmlKfQmhkqDxUlmxVTVu5Qj84ycB8W5Ea2UW2gDU5YKvmq+cOwsEsMCYuU6uI2wR4dWtUx7KXm5afBJVAjVhdX50yU36NU7mjVDk2Wsz0UZnEolZqHd05tNWo7ouLMYPRfdCpdOPHEK5lAmzs+3bGXsCfCgT4FqeWOuIxLXipoZ7Ktfw0xGS8P6lVsE32J7LEGha8cjTKytf3zp1lsiNz1Ens7xftEWEIdvNWAXbySpT0C9D+Rwh9j0v0YL6d5OZ+Aa8EHsy6cF87OOsP1NJYal02a+MKMdTx3ehmTnuJvXKzLAdHHTcbjY48nFHNx0FGa2SussLu2kCLW1ZouecWmMH1hkV2XsDMmPaWM8DYW69xvL4ukbSE1XKcmcsctRKEuB04ldiehQRhPNcJVpqiYyU3rQmSzii1lphE9sRIcZgAK8LaHV5KpPG5YAuOKLloLwUbrwF0h7s6ncE6Nl+nCcAShtg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(55016003)(66446008)(5660300002)(64756008)(66556008)(66946007)(76116006)(110136005)(8936002)(38100700002)(83380400001)(107886003)(38070700005)(8676002)(82960400001)(66476007)(122000001)(966005)(71200400001)(9686003)(186003)(508600001)(26005)(53546011)(6506007)(7696005)(52536014)(2906002)(33656002)(86362001)(54906003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?doOwBh069IGRgZDdCVE4W+09bntRPGdVe4ITexHtTmgOgWg0vHiNjs/v8SXv?= =?us-ascii?Q?KZmuPyWWeKEcTn6jOhtrEBr3hHAIt+BL8ZQ2Eh5yFqBOP9jf9yaAHDEkJi+r?= =?us-ascii?Q?lwI28xmbc8oBrnyG96gMA1b1kfm6xcWJ1O8V6Yl9ybuXjUEAE9QwgfRbvSeY?= =?us-ascii?Q?ipwtq+83OCWeRcCwOaMJ8ad1LkzrV0v5ONhkdPdb/KeAlCk1Glqa81zguuw8?= =?us-ascii?Q?eiFgqDpMxOsyg2VFp6tZKV8+6egYN2vYEjC2Y6eehP2eiKotxxL/T0iWTSU2?= =?us-ascii?Q?tPSXhA0/8h+78HwsYhh2s76Qq6VKUIKgJn9RIllJcEvnBFhmcrhKO+x67wTT?= =?us-ascii?Q?mcGX2h+LoXIJTJoC03wYRug+aZ9iSm9jLUWSdtLOGJE5ztMkl4Me1e63DPI1?= =?us-ascii?Q?Duanjkwg77OtAWALRhVeExfqwHxVLoUgHquutrBQZj2K5uzQ1ZMgtAv6LzqC?= =?us-ascii?Q?vnj1MPP20sVeo+t3TjLxNrJkIo3TR63gN2QsbW4T1PA194ZwzHAyhiuX4lsT?= =?us-ascii?Q?SpN+VM3a7EreEXW13mcElq8d929TjxAz19RwIO3C/xTcj0KftDiEfrnUX1Gg?= =?us-ascii?Q?3trL5359HN2ijwgbjGcUGWdIKifGkgQsKO0EGXx57u/KPJZYtSWT+yjLEkT/?= =?us-ascii?Q?26P625tWH6uIegXNulR95v5SdsgcH1kYd5e2tcblf/Ff+B12u5TBCZvo1wh5?= =?us-ascii?Q?CkE7VpSrfZA/3l7MHjGEEBqg2rU/fesB7iYBDfNUHvfLSt0cMBf1sx87y7aj?= =?us-ascii?Q?nl4/K+cbXcwMOIpECR7286XzXo1o9+s4/ub5WuXcsHwsKQpiblo3Ihnq0iFe?= =?us-ascii?Q?Gu7D/nVdUtOGOxx7rDtckQJQZVJWFbpwjUGLdDEW1cDzupXfGgbqoE/vBU8J?= =?us-ascii?Q?RFdtIuQPrWFGlKF31epJcW7JHXHsczX8bR2kAWaMdoojFvYmnA78VRCmrfq1?= =?us-ascii?Q?OLC7iLgpLM+Iw8h8ZR3sp8fwOTcNIVg5PySsQBFAVRsIphJ4I5G9K25/4ano?= =?us-ascii?Q?JjS+Cc119Cp3AIHucoUDosAAfRVokKcBHy+WP5oJ87gxivB5E9aEtq8pdhg7?= =?us-ascii?Q?umFBmxHzvzEs3JElD11tRd+hNFD6bs9tkcMXeqj62/FAcDYfQG1Rg8ncOeK9?= =?us-ascii?Q?mdzA6T+ym4ZSv8v9xWsH+AUFiIp806P4oGdH3h3DzIQFpZAsiyW6bkp3xwIt?= =?us-ascii?Q?RZ4ooTtEZvih3vt6dT0RZQEQaJZpKhqFyZoRPIcuJWGajE12xht3WAa4DkmL?= =?us-ascii?Q?Qlrjxjn9FsWZxZuU98kOyi4qKV4ufMgQqQPDuhq42kL8WNC6Wu3zxUK0R6Ko?= =?us-ascii?Q?foknBZqguLxvhE0B2iIid+4E3DljOHth4kdS8jfW6RLqxJCdCalQzEA5Bxiz?= =?us-ascii?Q?iEZBVGCgU3EMztGN6L8fqrAJRRNVm2I3cltKrofW3yKGi9nPemc6gaVaqBGh?= =?us-ascii?Q?1YUVyUPXpJ/hu8WPMp0kOk9jVjUg0a73iVRhqHIJ7jxlJV3Wbs6fKs2yVm66?= =?us-ascii?Q?YgwY3mH0xV8nvYmA9luGv+Z3rt6x0hrBM75mSW0iVdJa2gpscT5Dstq4Ovlu?= =?us-ascii?Q?2TBGNWkE2C72GTEsg7p4As62mkKMKFZWsk/NTnpciBA8oM62bEK73rWCO6NF?= =?us-ascii?Q?LqBhQ4Uc4ZWzjImEThbT8Dw=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 615ca12e-9895-48a8-d75c-08d9bf8c9932 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 05:34:43.5427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TZqUFnHv6k2K1BYqibxZBUOd++Uk8QpjmHKOQdJdI3pKZjnDFPLeZg/wPFITdkArV9mg+WRsA0SRRYoC8f6B5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5262 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Will hold the merge a couple of days to see if comments from other reviewer= s. Best Regards, Hao Wu > -----Original Message----- > From: Ke, VincentX > Sent: Wednesday, December 15, 2021 11:23 AM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Wu, Hao A > ; Ni, Ray ; Chiu, Ian > ; Chu, Maggie > Subject: [PATCH v3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix > response timeout problem. >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3714 >=20 > Replace with UFS_UNIT_DESC to fix response timeout problem. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ian Chiu > Cc: Maggie Chu > Signed-off-by: VincentX Ke > --- > .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +++++++++---------- > 1 file changed, 9 insertions(+), 11 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > index b331c0f3e3..9ad1e19fe0 100644 > --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > @@ -1037,9 +1037,9 @@ InitializeUfsBlockIoPeim ( > UFS_PEIM_HC_PRIVATE_DATA *Private; > EDKII_UFS_HOST_CONTROLLER_PPI *UfsHcPpi; > UINT32 Index; > - UFS_CONFIG_DESC Config; > UINTN MmioBase; > UINT8 Controller; > + UFS_UNIT_DESC UnitDescriptor; >=20 > // > // Shadow this PEIM to run from memory @@ -1126,19 +1126,17 @@ > InitializeUfsBlockIoPeim ( > } >=20 > // > - // Get Ufs Device's Lun Info by reading Configuration Descriptor. > + // Check if 8 common luns are active and set corresponding bit mask. > // > - Status =3D UfsRwDeviceDesc (Private, TRUE, UfsConfigDesc, 0, 0, &Con= fig, > sizeof (UFS_CONFIG_DESC)); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "Ufs Get Configuration Descriptor Error, Stat= us > =3D %r\n", Status)); > - Controller++; > - continue; > - } > - > for (Index =3D 0; Index < UFS_PEIM_MAX_LUNS; Index++) { > - if (Config.UnitDescConfParams[Index].LunEn !=3D 0) { > - Private->Luns.BitMask |=3D (BIT0 << Index); > + Status =3D UfsRwDeviceDesc (Private, TRUE, UfsUnitDesc, (UINT8) In= dex, 0, > &UnitDescriptor, sizeof (UFS_UNIT_DESC)); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "Fail to read UFS Unit Descriptor, Index = =3D %X, > Status =3D %r\n", Index, Status)); > + continue; > + } > + if (UnitDescriptor.LunEn =3D=3D 0x1) { > DEBUG ((DEBUG_INFO, "Ufs %d Lun %d is enabled\n", Controller, > Index)); > + Private->Luns.BitMask |=3D (BIT0 << Index); > } > } >=20 > -- > 2.18.0.windows.1