From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.29501.1640238276596063741 for ; Wed, 22 Dec 2021 21:44:37 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RFGTGbMI; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640238276; x=1671774276; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VzNJLLeQBNNhTMTrrLeGf3vZUUNjNS4dc5pcX98EgmI=; b=RFGTGbMI1Hb9yCay9Kqp1Rnero8CKG7SiHl3BxyWfu7Gxyt2ZrK6RwRe O0ZwLO8M5FjFBApPOREdJqJ21MlMVqTnX4TEmvYwM8+ziQlqafej0DAtY JCwasiekYjXQ6PkQt+tEffhHyS2jnbgDFDEWlBjpzy3fR0o8VzAt42CMS jOjfA0qgJj98Ko3TtZ6a0YWxu/VG8KXfGUEpAVisES182zZgXUPSI3/n3 wCmO8WgQNU2X55oPZ1OqkVSEntrZTGwZlEf4+mVhKNUPUOY2DWjinXE+j 1M6cNfSYDsnLjJqzRkB4qgfVRk2Kp5+n8rbjQhDeev2tviJwiZTIzVnKp A==; X-IronPort-AV: E=McAfee;i="6200,9189,10206"; a="238297765" X-IronPort-AV: E=Sophos;i="5.88,228,1635231600"; d="scan'208";a="238297765" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2021 21:44:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,228,1635231600"; d="scan'208";a="468420431" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 22 Dec 2021 21:44:35 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 22 Dec 2021 21:44:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 22 Dec 2021 21:44:35 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 22 Dec 2021 21:44:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wu1SBTcu8Toy5/wZdw2LaOPxGfQgXDXGUEjcdSJBDWNumt+ActsUkCdrYZPcT2vkY6LWBIJp62RKrwNI742dxII0KIsUeX7ZkgU+mwqetgAglZI6pmdA+E0hqwWdIgKBFz+0TpDa0Fc5jypGEJKxhgrc22Vy/rz6Sk3NpDdE9Xs2KkdNqhOAh9hpWCrkmvUF7VRu3w1fS0kkRLDscDdKWxp12MK8p555il+3knDD/HZiXH5+bf4jpL7eLUHd3ltnPwek1+FULincI+t9/IFwSFwpk5ukRTu1KXMZ9As9JmHc09xtsb/ef51wZxudsOR+LvoCd5Eb5bZlu1PTFRu3aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZDyb3bpDqLbaZU6BonhdHOIa/m3drmLOgQ5JcKIbXV8=; b=CMcEC8mQ4witoKQHIGLqaPKu5ak1R4z72c7J97KCP8gWWglm2dt47an5Tg23PDEW8i23FNtgMDDn7sc2N4W8I1MoBFCeNkzwsvXuTlqRBcR2P2SHpEpibWWZON+Qiv/c1tgccDWYeefMi3//Lf67mOwyNF7Y5lm8HmQRKz4i1MqhBQVa/7dG3HBYNxaAP5XAJ9ZvRFWlN/J59rbdojmGkQKdfx/QAruwBbmxLJ37m/NXgg6CQG/8fyzNJANgLIeIPaiG0ufunliRv5M9Y8+rAE1irmz+xsAnz8VJ5eIO2wF42TnuizHyvUTCEHhv24jlJkWE/Yekpc8ELkwV/yAVcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by DM6PR11MB3980.namprd11.prod.outlook.com (2603:10b6:5:192::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Thu, 23 Dec 2021 05:44:33 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::b8f1:aa83:cbbf:6964%6]) with mapi id 15.20.4823.019; Thu, 23 Dec 2021 05:44:33 +0000 From: "Wu, Hao A" To: "Ke, VincentX" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Chiu, Ian" , "Chu, Maggie" Subject: Re: [PATCH v6 1/3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem Thread-Topic: [PATCH v6 1/3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem Thread-Index: AQHX97RrhQm8efJFzU+0i3FJR/L0Kqw/iipw Date: Thu, 23 Dec 2021 05:44:33 +0000 Message-ID: References: <20211223041919.1307-1-vincentx.ke@intel.com> <20211223041919.1307-2-vincentx.ke@intel.com> In-Reply-To: <20211223041919.1307-2-vincentx.ke@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f1f6dbd0-7925-4d60-4863-08d9c5d74bf3 x-ms-traffictypediagnostic: DM6PR11MB3980:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:28; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0PleilCwxcy4tpmVxLJBa1OtN2SxdiR9ipOO6L/IAL4s1b35b8B7T/AyITMBjpbrS1g23R/hag6ZWEA4VwwBp1VSKWxgyOJrrNTgndNyjVScpJVsAWoozwjfIuKcnoZS+5yqkk6ZNFwH924wLjII0yCfXSRxrlwVAy6EOLKZ+R9sddZU7do+xuS/LlEm4VBBl0P4PiQCHtUJ2bFGglfvMP5gjZtLuBvWRTgFBd891YmR6bUTgvQfqHK2QC0Zcbwo27jm/WVr/8SEMsCAngqGsTbJ/8e+hCudHvpQOxLd23IIVahO86QoDrTvLJRTcu0+R2BhX0qP1R/wx2fdmg6+BPS7bsH8WZk5I0iHSOMefaHKFihlNlgF5GnRQwSJOAE5KSoFmhaL/LOfxbzoQN5UzZX8fHjD1rRnfk/XAI5qAzLLMZ0R+siqkonAyQ5LCzJGbhehFSACyI3opGL7zI5Xo+NUgSKbTDAlIM5w6lK2DZTgJZlimGbydIKJBhrNds46XcEVFb7X4tTdJyuMcjvefD3KM0U9EDL2RU1sqPHWYkEGG/vy5Xholn2YOqoYE1zz00+b5942j+46kQyUI8oZtoN8YhA4/XQ8lDp/WqO2CaBTwsmkxJ9QyryhtuCXQKrIK3lQUsugTo6SRREgombI51iR/zWOr5AJRo6zHS2rZVI1sFeX5kMHRUiF2BH5mNIJHBvldP9IVEeyBLmRlscvIyAhX1wMwK7k+yiKTksjvs9Ut1ZDWCRbfTYVF8gEF1QdYPr488LGPTlTgJy8PmlFeZnBGVIz0a0xSLxv6Y0Ad6o= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(82960400001)(71200400001)(2906002)(64756008)(38070700005)(122000001)(508600001)(54906003)(4326008)(110136005)(38100700002)(8936002)(5660300002)(107886003)(83380400001)(26005)(316002)(33656002)(7696005)(66446008)(186003)(9686003)(66556008)(55016003)(52536014)(86362001)(76116006)(8676002)(66946007)(53546011)(966005)(66476007)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dAp1yKm5HxXd5g6pPRNMYD14eY22rngqipd0dRZKw54pRxiVCCLSOHQaU6hB?= =?us-ascii?Q?mDAuDoMIMwmgrkOR7YcmbzG4VDcQFKX3ct+FDvM49nJ8iNsjcoYWJiXvpkpz?= =?us-ascii?Q?tHcU5XCfmDsS7eKyEva2KdNEEZZG5/XKiyhSl3zeyLyGH5NrtkFDT1AQ29/z?= =?us-ascii?Q?XwtZQ16Mp2uYkSVzxcLKocDkyuTeMvosVuSvOWDaTDOYtVIdjyW4dMNsiMyG?= =?us-ascii?Q?dhPAQ6nbjU8tqUToO/mCdQlwCp6d78YFTFjqAhxNh5bCYbxCrugjmVjJugEl?= =?us-ascii?Q?Dd2ndKkprjgWqWffpqoq0mQL+2P4zW/8m11t0IzZQJoBSN11eD0go6ECrNlt?= =?us-ascii?Q?e5RNn7v6Vnw6vM2v75HGmSBbi9f64MyJ4NVpoKfAfErzyyguNjtuIV9FOrm2?= =?us-ascii?Q?/hRkL6loBG2htxbVmTTjgIeZ9nFnaUXYmXLFsNac2xyijgbhghRn1hV9Zc1h?= =?us-ascii?Q?8KYjZbWt48dVaOLmjI0rDXt8ZCwQYEDRvkgxlzgeZNT9TQtaKDnvQMHGfPs+?= =?us-ascii?Q?vcm9JMQYsVRyLjvvXukOFpDr+91+l8wEx3prIZc49EJRZVy+fI56uG7Sni6v?= =?us-ascii?Q?MHxfV4NR645UtVgXDDDEz0IGUCTPCj2IrG9We/JNjQQuO0Ec7j6P+hw2bmHU?= =?us-ascii?Q?mcQmzto3vJCrfeXjUB/lHz03TA/ux69KQaAfTp2cRMkm1u0MkYY6mwMxcYwF?= =?us-ascii?Q?X6JwBnEtpZycwfyVugYKyYqsglhWzm4vo5TvQSRrpfT5wMbIoAISF0q72fuB?= =?us-ascii?Q?iv8mKTMYS/Kz+eMsqWqTTiYi/2cneWScx18FZVAkzcH684lvl1u8aJ+eBoyE?= =?us-ascii?Q?xnxlTtx/l0SR1ueX1Or155VGO4jQxlne3tJmExPHq137Y3VmDNG4+4hdNAWq?= =?us-ascii?Q?oPDPWi1leYgOnSfMg7BotMG2V6AbK19qTTytj0vbdPj/OFH8L+xwho7+aEmQ?= =?us-ascii?Q?jAS7D+PKngAUOmOT7nVO+u53wvKUmOrcZHFDiI4lECixNfLXpFwsoU0G1NlU?= =?us-ascii?Q?m7GzdJVDpAVPTx4Hacgh+K2gacX6cbL6815nWDm9+AS6wW+pCKuxaRoIEVEa?= =?us-ascii?Q?nAuWBM531uq/bj+qHcOgh/FG4qOJxWQ67ZkQIiMx1i0nYPgiTU+EZjtGjDH7?= =?us-ascii?Q?Hie5eNls6lLBhuh+0ZtBKhg/Pv7A4L4gSEmuZd48V9JEX4Nv3PhnnKG1c0fb?= =?us-ascii?Q?Zw9PkEDejQxuyxQgq5GbRPIdpLCxbMEbpvMoI7i19F2Oedgajb2sNVOP2I+k?= =?us-ascii?Q?SHRAjQ9ADBfo84ZEFvr9mCxJHIdldE39/CgG1tF/uSYetxslrtlSR8HvY8b+?= =?us-ascii?Q?G7w/HuN382fly0KqUKrLN4DQlcRRP59sBcvOajKH1BVE8ZeAjzXcCuGCEwi+?= =?us-ascii?Q?MILqrIJGI9rZH2LSq/djmRlu+YJMOWcHOJS6Ue8rthuf9xgKETbXe3D7GPsW?= =?us-ascii?Q?ET81BCdl5CgSE3Rg9SGjaGkONlnjE5eGEIkJjIX5P9e6FjHZQbxDFpSn5/3e?= =?us-ascii?Q?TLiRSoA6EEXMz0XxNpXXRElFheXiaTWe5WAQnqx74sJ6aVpJiWTUX3lE5iWR?= =?us-ascii?Q?kXAINXgATe4kG3HzJI5aur8JiCDwz2wAm4HHMWkIiSCchMM/twdep9/N9LdZ?= =?us-ascii?Q?yDW6X5VWjBgoWexc+PZ7hw0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1f6dbd0-7925-4d60-4863-08d9c5d74bf3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2021 05:44:33.1261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w95IQTsTds6bwl2ZGWYytnxPR9XAUrHocRs1X/4OVav4Mv4iHNyLBO3LhrCfaHdtaMXyBpM/FWczUl4M0Ip19Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3980 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao A Wu Best Regards, Hao Wu > -----Original Message----- > From: Ke, VincentX > Sent: Thursday, December 23, 2021 12:19 PM > To: devel@edk2.groups.io > Cc: Ke, VincentX ; Wu, Hao A > ; Ni, Ray ; Chiu, Ian > ; Chu, Maggie > Subject: [PATCH v6 1/3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix > timeout problem >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3714 >=20 > Replace with UFS_UNIT_DESC to fix response timeout problem. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Ian Chiu > Cc: Maggie Chu > Signed-off-by: VincentX Ke > --- > .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +++++++++---------- > 1 file changed, 11 insertions(+), 12 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > index b331c0f3e3..b8651ff998 100644 > --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - Copyright (c) 2014 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2014 - 2021, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -1037,9 +1037,9 @@ InitializeUfsBlockIoPeim ( > UFS_PEIM_HC_PRIVATE_DATA *Private; > EDKII_UFS_HOST_CONTROLLER_PPI *UfsHcPpi; > UINT32 Index; > - UFS_CONFIG_DESC Config; > UINTN MmioBase; > UINT8 Controller; > + UFS_UNIT_DESC UnitDescriptor; >=20 > // > // Shadow this PEIM to run from memory @@ -1126,19 +1126,18 @@ > InitializeUfsBlockIoPeim ( > } >=20 > // > - // Get Ufs Device's Lun Info by reading Configuration Descriptor. > + // Check if 8 common luns are active and set corresponding bit mask. > // > - Status =3D UfsRwDeviceDesc (Private, TRUE, UfsConfigDesc, 0, 0, &Con= fig, > sizeof (UFS_CONFIG_DESC)); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "Ufs Get Configuration Descriptor Error, Stat= us > =3D %r\n", Status)); > - Controller++; > - continue; > - } > - > for (Index =3D 0; Index < UFS_PEIM_MAX_LUNS; Index++) { > - if (Config.UnitDescConfParams[Index].LunEn !=3D 0) { > - Private->Luns.BitMask |=3D (BIT0 << Index); > + Status =3D UfsRwDeviceDesc (Private, TRUE, UfsUnitDesc, (UINT8)Ind= ex, 0, > &UnitDescriptor, sizeof (UFS_UNIT_DESC)); > + if (EFI_ERROR (Status)) { > + DEBUG ((DEBUG_ERROR, "Fail to read UFS Unit Descriptor, Index = =3D %X, > Status =3D %r\n", Index, Status)); > + continue; > + } > + > + if (UnitDescriptor.LunEn =3D=3D 0x1) { > DEBUG ((DEBUG_INFO, "Ufs %d Lun %d is enabled\n", Controller, > Index)); > + Private->Luns.BitMask |=3D (BIT0 << Index); > } > } >=20 > -- > 2.31.1.windows.1