public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: 张家定 <jdzhang@kunluntech.com.cn>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Demeter, Miki" <miki.demeter@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();
Date: Wed, 21 Sep 2022 01:34:36 +0000	[thread overview]
Message-ID: <DM6PR11MB4025E5D0D6CDA2F4192BB29DCA4F9@DM6PR11MB4025.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ACEADwDGIg9Ss3Sbj*sD5qqN.3.1663668046999.Hmail.jdzhang@kunluntech.com.cn>


[-- Attachment #1.1.1: Type: text/plain, Size: 2365 bytes --]

Hello,

I created the a Bugzilla tracker for this issue at: https://bugzilla.tianocore.org/show_bug.cgi?id=4074.
I have attached the tracker mail and please help to check if the issue report looks good to you. If needed I can help to update the tracker before you got the Bugzilla access.

Also, please help to add the below information in the commit log message:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4074

Best Regards,
Hao Wu

From: 张家定 <jdzhang@kunluntech.com.cn>
Sent: Tuesday, September 20, 2022 6:01 PM
To: Wu, Hao A <hao.a.wu@intel.com>
Cc: devel@edk2.groups.io; Demeter, Miki <miki.demeter@intel.com>
Subject: Re:Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

Hi Miki:
    I want to file a Bugzilla to track this issue , but I haven't a Bugzilla account yet,  could you please help to process?

Thanks!

--------------------------------------------------

[Image removed by sender.]


------------------------------------------------
张家定  固件产品部  产品三部
昆仑太科(北京)技术股份有限公司
手机:15810479495
电话:010-89056290-8050
邮箱:jdzhang@kunluntech.com.cn
地址:北京市海淀区北四环中路211号太极大厦10层
邮编:100083

发件人:"Wu, Hao A" <hao.a.wu@intel.com>
发送日期:2022-09-20 14:27:21
收件人:"devel@edk2.groups.io" <devel@edk2.groups.io>,"jdzhang@kunluntech.com.cn" <jdzhang@kunluntech.com.cn>
主题:Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

Thanks.

Could you help to:
1) File a Bugzilla to track this issue at https://bugzilla.tianocore.org/enter_bug.cgi?product=EDK2;
2) Send a new version of the patch for code changes (please update XhcEvaluateContext function accordingly as well).

Best Regards,
Hao Wu

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jiading Zhang
Sent: Tuesday, September 20, 2022 2:00 PM
To: Wu; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64();

I update XhcEvaluateContext64 according your suggesting and test in my platform, the KB and mass storage both can work!



[-- Attachment #1.1.2: Type: text/html, Size: 12972 bytes --]

[-- Attachment #1.2: ~WRD0000.jpg --]
[-- Type: image/jpeg, Size: 823 bytes --]

[-- Attachment #2: Type: message/rfc822, Size: 14810 bytes --]

From: "bugzilla-daemon@bugzilla.tianocore.org" <bugzilla-daemon@bugzilla.tianocore.org>
To: Edk2+Bugs via Email Integration <bugs@edk2.groups.io>
Subject: [edk2-bugs] [Bug 4074] New: [MdeModulePkg][XhciDxe] Current endpoint input context is not fully initialized for evaluate context command
Date: Tue, 20 Sep 2022 21:28:20 +0000
Message-ID: <bug-4074-42@https.bugzilla.tianocore.org/>

https://bugzilla.tianocore.org/show_bug.cgi?id=4074

            Bug ID: 4074
           Summary: [MdeModulePkg][XhciDxe] Current endpoint input context
                    is not fully initialized for evaluate context command
           Product: EDK2
           Version: Current
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Lowest
         Component: Code
          Assignee: unassigned@tianocore.org
          Reporter: hao.a.wu@intel.com
                CC: edk2+bugs+int+994+563148131503455288@groups.io

From community report:
https://edk2.groups.io/g/devel/message/93737
https://edk2.groups.io/g/devel/message/93741
https://edk2.groups.io/g/devel/message/93976

The endpoint input context of Default Control Endpoint (EP[0]) for Evaluate
Context
command is not fully initialized according to the requirements in the xHCI
specification:

6.2.3 Endpoint Context:
* Note: Unless otherwise stated: As Input, all fields of the Endpoint Context
shall be initialized to the appropriate value by software before issuing a
command.
* Endpoint Type (EP Type). This field identifies whether an Endpoint Context is
Valid

According to the above community report
(https://edk2.groups.io/g/devel/message/93741), this will prevent USB devices
from being initialized on Phytium Platform (ARM).

Need to update XhcEvaluateContext/XhcEvaluateContext64 to properly initialize
the input context for Evaluate Context command.

--
You are receiving this mail because:
You are on the CC list for the bug.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#18913): https://edk2.groups.io/g/bugs/message/18913
Mute This Topic: https://groups.io/mt/93818337/1768737
Group Owner: bugs+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/bugs/unsub [hao.a.wu@intel.com]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2022-09-21  1:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  7:14 [PATCH] MdeModulePkg/Bus/Pci/XhciDxe: Fix the Bug of clean InputContext in XhcEvaluateContext64(); Jiading Zhang
2022-09-14  8:31 ` [edk2-devel] " Wu, Hao A
2022-09-14  9:23   ` Jiading Zhang
2022-09-15  3:26     ` Wu, Hao A
2022-09-20  0:46       ` Jiading Zhang
2022-09-20  3:03         ` Wu, Hao A
2022-09-20  3:16           ` Wu, Hao A
2022-09-20  5:59             ` Jiading Zhang
2022-09-20  6:27               ` Wu, Hao A
2022-09-20 10:00                 ` Jiading Zhang
2022-09-21  1:34                   ` Wu, Hao A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4025E5D0D6CDA2F4192BB29DCA4F9@DM6PR11MB4025.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox