From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.40696.1683166790744443763 for ; Wed, 03 May 2023 19:19:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=bu+4FLK2; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683166790; x=1714702790; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3ym//iGzn2aNMNmK7pROxipZBCcczQgXLqYUFLinKyw=; b=bu+4FLK2jSca3JzOsuQt2vaPqNl2FhOvjkGNaVpAWA7mIo3xXzlCKuq7 Kj6aIK+DiDll7bFmjxbxCDw7E3a5HyLfslWPUzfGhga/3gDI52QQHqZVY ETkwXH6qrZyrGbNsNV8N+KO6kv2WuYJ41WneiXocGKxCw9HfySE59010c lDuahWN1XL/WQ2jalyiMZ41KPdkawVLYaHQP2mBdMhQeyoXq3fG57DGe9 9Z5PRTnYwD/ALciLYbIBEa4yzJJkm7EfuiMEZKJ41RQLNpoPDIQpoLyW0 a2r3De4zMF96RtPVed4Nd7VFxVQn4ZCLt5p+4fLa6246rdB99HqhIxbys w==; X-IronPort-AV: E=McAfee;i="6600,9927,10699"; a="337960263" X-IronPort-AV: E=Sophos;i="5.99,248,1677571200"; d="scan'208";a="337960263" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2023 19:19:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10699"; a="943132721" X-IronPort-AV: E=Sophos;i="5.99,248,1677571200"; d="scan'208";a="943132721" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 03 May 2023 19:19:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 3 May 2023 19:19:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 3 May 2023 19:19:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 3 May 2023 19:19:49 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 3 May 2023 19:19:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/1oYxZSTIs3/oQohGqcM048dr0KBBrh93/b45fCT/WQDZlPP6phAUx6uIoLYTIbrWyMWU0tKNqMLP6FH+TwE+L5w1svFHFByALMym7RyXPTjdJgTqM/3iurYmm+in4nnLPrrp+nPC0xpQ44cV2qZRT970D3b+tF/yN5VxwafRDV+jUEiw/F8GhHWEpmcIwAPh2rKwc55VoU2T/2WExPuYW395EQUYwAk43PVUfEbga4Bh49fPqYvzuqScF0bHbNNrPt/uJjLmKUgzn8TmgiMmtGnyGRFf45LSAUe5c3zdyEX+m51IEirHYfvpxWy47ZkuwgWNO1Bh19QPpLbK5HfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A5Ipy8MeWFvzurTpvN7sWmhQG9SI9v5Q6lZUzj/16MU=; b=Mxdu6IBCWHy8Txl+Z2wK3gFb9XeBMYpPFbQDTRJyds0UJXp/k57aGbQ3fwhY0gXnl5gKVGYv53GsONYQfIIwSj3CPaFoJNS0HjRoox52ByZxgHiJFsyzBThmkNWdS1QBKxZUA9NKWGCLsYP7n4nh8Tx9MpeAnFQU+Ergunw6fkFkNfnHXmapM3ZMPK3jIl9VE+AIGEqnFeUFv32zPuyMwCuQTGnNHdUJwuRORHyepqvGUZNa/Lit95fFfAMXwoo1QEnv/deTz7Z+l/XcuxZB9bRqzA4s+c4Hi93MOj6BBjxu+WZtckSoMozgK+/Y2RprZqJ3c3uRFpSDfDxBLFZKQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by MW3PR11MB4601.namprd11.prod.outlook.com (2603:10b6:303:59::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Thu, 4 May 2023 02:19:44 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::1b49:874e:7c04:1e00]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::1b49:874e:7c04:1e00%5]) with mapi id 15.20.6363.020; Thu, 4 May 2023 02:19:43 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "osde@linux.microsoft.com" CC: "Ni, Ray" , "Wang, Jian J" , "Gao, Liming" , Michael Kubacki , Sean Brogan Subject: Re: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpress Passthru CQs Thread-Topic: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpress Passthru CQs Thread-Index: AQHZeS7dP5FEY4wwDUOTI4Soljfcvq9JavtQ Date: Thu, 4 May 2023 02:19:43 +0000 Message-ID: References: <20230427173622.10614-1-osde@linux.microsoft.com> In-Reply-To: <20230427173622.10614-1-osde@linux.microsoft.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|MW3PR11MB4601:EE_ x-ms-office365-filtering-correlation-id: 00076aeb-3f59-49f2-4b57-08db4c4605d4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: stS7UWIpWOGBaCynKVNMHg72nph+QRxeH6nZ5S7mo8i8zf9A99SwzYrGZHrx6ikFboDk929kkiae1orCgnXh7UwP+WrdcLAMmafcJIgdK5JqGiEz+z3ccRyd3juwmVgHQuW0ba46ywbSg8D/Nd9zwohpXP8hQmB4KUr8oXSvxuD+SiPlXEGbK6Lt2n+5hygza0E4mj7RZafpbE4XsLNuScdITgPM8+jzAeJXwGaOn+COqNzw1Pd21p0cqIpY2dMo+k5b0W+tIoHem2oIRyKvTlGkfafa9GFsKUpwLaT2MZQ0maIuzrjbg+MTknh2IaNwwHl1D3qmm+ATXXDqi/vPFad9KgiRebg7xIRzIFRrNVhfBgb553pCyvw9O6ORor1jZ7oRO4OToKPi/2A9GEeKNEEZ4ZaNgex14pAZM0hQSpTNF9yyFA/3WiDYt8bUKncCOV4izEpw1Li40sisPM7Jm6o7YKPJjogwgJH6N/Or1BdbAiamfsrEXjOZNHi+SdpOO7Yigqgxf1AUeEQ/1okWvslI1sX7GKrkbF7rc1YcKuUxgUzxx6aMZDdUkxeNJcWwQLxso5FaoNy0haKj59B8UqUTRmrBzsOh4VREL+tpdWtP8LsbuuspLw7ZpWjLy3wZmFRPzdleWo799t6IhXvqiw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(376002)(366004)(346002)(39860400002)(451199021)(2906002)(82960400001)(52536014)(8676002)(8936002)(122000001)(33656002)(5660300002)(41300700001)(66476007)(66556008)(66946007)(64756008)(66446008)(76116006)(4326008)(38100700002)(316002)(83380400001)(54906003)(55016003)(478600001)(110136005)(966005)(66899021)(86362001)(71200400001)(9686003)(7696005)(26005)(186003)(6506007)(53546011)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jPEv8x1gijh5OAvg9wMjhHvrcKLMjzpzQ7scebpG0SuJg+btUNy9fGRbJMBR?= =?us-ascii?Q?uXy+foS+i4K9hY80ImJfB24zBKzHHH41umVM6NeO55gTgGg3jC900E+LKZ5p?= =?us-ascii?Q?OqucghwoDusZPbH+kKPPmrypi5pKpJSuK60T5R9p6WRzbmeBpgUiOWZp/6oJ?= =?us-ascii?Q?D09Iowm5nNuqd8xINeBv7AVtSsMYgocymu8GFAl9A6sHptf+GvOhA+KRNC2M?= =?us-ascii?Q?yvG0FGAGVjrJhA+XwMRolpkisx/yOsW4NBYzxGxHsuAHP6ZoqEpTZUclEtoB?= =?us-ascii?Q?CBBu+LtDWkpKa633h6avdDmE0uuwXA6jydBR47mEbXV449hdo3hvItLAwenQ?= =?us-ascii?Q?DFfSTkUqCUCKlqFnhlmPvwlFyf3l03rH+RMrt2lMDbP2BV//IkjYAOzda+zJ?= =?us-ascii?Q?rDnvp3sKLRzKflZ4UR1aqNbhAuP1OSR9A4a03Yl0uO42vhIg2p7/zR/kUbav?= =?us-ascii?Q?H+LIoKmuIOmzB9W7RK6zNCQYe9TfU55EcMqKorc7tEoxzhLV2AfBn1uD2itB?= =?us-ascii?Q?J5Mh4TH3vimfMwFpaLhGa/nBKWBQqh7tfZCix3p3AkjLqIKzZj1HzSolsHpc?= =?us-ascii?Q?HbbSPi1Xtk32jFiPzfmaW4vGTzeGk+hNYQl0kfbelsOPCbWdDPayOKU0xDAT?= =?us-ascii?Q?dkT1Smzqen4OM7Kue11v6H+9pWTvtvmB/RPKYFKqPl8sfJe7cPFZzYbX78RN?= =?us-ascii?Q?QPQEASqCEzsbw8QpTZEVXyR89iV3tifQ8+BtKhXkCuaPoDzoAYImbjQuj/3R?= =?us-ascii?Q?5uLI7SLqsuLP5D1HhjhYxN0kF7lQIR1/u+9RQRt3nFJh8GM7To4VECzux6uw?= =?us-ascii?Q?vIlosDup53A8+qpNamEatOzOInyMYtq/kIz+LPlOKeu1KyS4l6s0lrmw3lzv?= =?us-ascii?Q?h5VAr7eECoqCZETNZ9HvfU8fQdnZDJkCm3egj9tW3U8NAsOCodSjSjJ4Fstp?= =?us-ascii?Q?Gg44URGDk8CzYnqWxkjIhPPXZdb0/+pORISpNI3PLU3MKkmVX3StltON+3dc?= =?us-ascii?Q?mxG2Li4JXIDVQWnWep/A4Lgkydy1Je0TIiWzSg3w6jCl5q3GneSfGlefdMBj?= =?us-ascii?Q?fRDggAab8SZqILXUD0IsjhWjve9xtXXlYdaxpcpTzG2f2QMvQbVudoOrGKCu?= =?us-ascii?Q?epNoGdECYZPRYJit/AWQb2WUv+6d+t1XcXTEcygNjaTdslXhXTR5H8OnAcoL?= =?us-ascii?Q?0Xjf06Wpn32EL0wqwYsGvgoVLHWa6VSxmOGVMbx28rx5bM1GIhQj7WHeaxDp?= =?us-ascii?Q?UM3wgWBYvfK8xJSpVCKqTNM6hAmKnzsUkOg4cPUTJ/QzSFQ7wHfWvl1BaoAl?= =?us-ascii?Q?VCV/k/qAzLH7b+EPCCG9/pqL++rG5W67kajMEP8ASWiYUoUWBPsm17Q/fC2t?= =?us-ascii?Q?83iAX0GyOqk6NKzFW+V1fz6V0a4ELQLp+ZgKNW34Djhalth0J3N2Dayz6Eia?= =?us-ascii?Q?+2P1gWcspAcE/d2EAyOsgIQTaaDKnlgbOKTrhYkdHdY0CzclyWUAazaiHGIR?= =?us-ascii?Q?lf1orkRZCXbT8LBpENrvX3Mw0/cDkCm5rEGj642QOzbUBGO2lXykkjrvTwQx?= =?us-ascii?Q?725gnsCMp87QiR1o6BR2XAtkZJiu+oGv9So6+HqZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00076aeb-3f59-49f2-4b57-08db4c4605d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 02:19:43.1874 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KWGpqBP9gnkp6Ld2DwE1RTK8QfaWgH3Hvt3JC5xmfWplvhOTGxzFCIt3mp9gXVYxtAxfNMoRandc2JJsSBvAGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4601 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the series: Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other rev= iewers. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oliver > Smith-Denny > Sent: Friday, April 28, 2023 1:36 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Wang, Jia= n > J ; Gao, Liming ; Michae= l > Kubacki ; Sean Brogan > > Subject: [edk2-devel][PATCH v2 0/2] Add Volatile Keyword to NvmExpress > Passthru CQs >=20 > NVMe CQs are hardware queues mapped to EFI memory. > In the NVMExpress Passthru implementations in PEI and DXE, > it has been observed that NVMe CQs are not marked > volatile, meaning the compiler has significant leeway > to optimize accesses to these structures. >=20 > This led to an issue where the passthru driver waited > for a timeout period for an NVMe CQ to mark that it was > finished with a transaction, but the compiler had > optimized away the read to the actual HW mapped memory, > so the transaction had completed but the timeout continued. >=20 > Marking the CQs as volatile fixes this issue as the reads > happen to the actual HW. >=20 > Personal GitHub PR: https://github.com/tianocore/edk2/pull/4320 > Github branch: https://github.com/os-d/edk2/tree/osde/volatile_cq_v2 >=20 > Changes v1 =3D> v2: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > - Remove volatile keyword from SQ >=20 > Cc: Hao A Wu > Cc: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > Cc: Michael Kubacki > Cc: Sean Brogan >=20 >=20 > Oliver Smith-Denny (2): > Add the volatile keyword to NvmExpressDxe's Passthru CQ > Add volatile keyword to NvmExpressPei's Passthru CQ >=20 > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c | 6 +++--- > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiPassThru.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > -- > 2.40.0 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#103725): https://edk2.groups.io/g/devel/message/10372= 5 > Mute This Topic: https://groups.io/mt/98541927/1768737 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20