From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.3060.1666065963014048683 for ; Mon, 17 Oct 2022 21:06:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=aOKwqbH6; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666065963; x=1697601963; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=sJ0qYhoX1WPcLarBiNA+Mg9GLxLHthVeOt836XLwbik=; b=aOKwqbH6iKmNtgBo5KV5fZYEyaG1plL7zO+Bz94IqN+M6f/5oX4yZdR+ pVc3Qq0smjgFv3XhoDNqQQLtPU0OK+7YLGdD5FlHvKeHIywWRdQAcSJC0 S4sg0UxnQax9yFbssLZ80fbkujt/YZLcTgeQ8Pu8GOaJfq6sVjdvChm4o LESSK8dYaPArOaEgb0skh0jIclWc6qcii464zML8awnG8LMPy8ZoPqF27 jzHqsSJ4xW4OY96GeEUnUNYNQq/cg0mLW54zegAFWuiV+FKCBLbcci9+W qc2aQrJSSJF5Yvw60dL/RkXEPINfgnrzTQ3OpRPW5TBffx9B2srFu5ZKi w==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="307075460" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="307075460" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 21:06:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="661733831" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="661733831" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 17 Oct 2022 21:06:02 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 21:06:01 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 21:06:01 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 21:06:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CJCG+k/PUdu1pRz4Nv62nDjPMYopNPCmmNDv9QAR735h/WpITTKkWtQExBSPRmU3PSfu5ThDDTWQmmOig6xTl5izvyP/c861eONyagp3IxIYtO73kR/yb8ttuHxCdlMslPoGnlqEN0xTxW2xBn1YeS2N4dHHSrjOVLv7AvdEh/Hz/igDfo4l+fpuVRu7S/gpncFJANT3rXDt+fOcKT8nkw4cGkVT40BqIYQCldNGO6J+YnmP6Hd8JGU9o4EBTXQQB/SmgjglFfGZGSy2EjW9mgL0mCezdiJ2DTo2/Xs0Rq4tpKtNCarza2jXiCCVSbPimmEcjU35luLHysjNidff0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOdHeEPw/RSvpAyXIdqFpvU/xzzZw7hGRzBBdwuPBSs=; b=NJm6z/1/B6wCLKo7IdmP6dEo5zYNMGl0ruud0x4lLfKHsgc3ffQVQZIbBa2EnB+KaVCX9HLyCvar1S0gRi1wnGdPCAUcoraxE5AyoiFQm2sMZwP0Ek+HFXCVX9uVcefvPSHtvkcQkSQAZf2dNNc5ZUeQ7I07YO4csbjQqdr0eTXLJ20LljOXLIoR7QVKxjjwZYXiq8ueYACG8YEtfzOpsooiAMiSmB5A+u2toJmYbu/tElUKG235axfCViK9yUg3ikQx+voFPozBCtEklmg0kGU0lyjYShX0SLZlf5SZF4jWKhcQ9X3ChQDMrkJmNUSl6Q33CrH+MYOMg7pzmcd+0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by MW5PR11MB5762.namprd11.prod.outlook.com (2603:10b6:303:196::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct 2022 04:05:59 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::82ad:97fd:4cd6:b7ae]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::82ad:97fd:4cd6:b7ae%3]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 04:05:58 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "gopic@ami.com" CC: "Selvaraj, Sundaresan" , "Sambandan, Vasudevan" , "Gao, Liming" Subject: Re: [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk Thread-Topic: [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Disk Device for all SCSI disk Thread-Index: AQHY4fUPNiDtQtrmLU+pPoy5f4/jT64TiQNQ Date: Tue, 18 Oct 2022 04:05:58 +0000 Message-ID: References: <20221017065233.2152-1-gopic@ami.com> In-Reply-To: <20221017065233.2152-1-gopic@ami.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|MW5PR11MB5762:EE_ x-ms-office365-filtering-correlation-id: 56a1e9fa-bbbe-4adf-1b7e-08dab0be1035 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zah83TA3ugyO/N6cdNH6MybSMAUuHiGpAGiECmV1zoNBx9c2ZnewKPQOTYRR+gFa4UgkBrwhpmdPPx5X+GnXNPmstoiYIzvPjw6A/2eTDCyHJzqwOa0OSNe+V5mai/YME0EHmslkLfh7J1r0Yg8EpRrAMD2br+Ijnr4Fw+tDe7Ho34c2+98ofWB+/Fa0vV+wqgxtqUT4i2Dvqq0h1UDFwd8A9qhydCnviWMSHzBvjOKLuhuGUPTdnIJZGfMgLW6zlNA8u94MXtfGNdDwP0jfIahCG7Gkdukmakb4E6Y1GQXWKIUhIa+mYhRkwIsFu0xZMQke+Q4PK4xA3x2z9OFNe3XIGayXNBmPi/zMEawnKPFB5/NZ7PSdflNaJlG6Z1ORtj+friP6MQcTie342v3S3kKqdQodl9ElspEnHS8IXXEURLts1GW6GIHu3RYHP6GJ8Uq8anvC/ps8HdI7a9Z7RickNxrA84VVnxRN0Pr8A4NUfrr8CMEXew4sdAftKhmEf8wDSL3Mc7dBcmzp8Ld24kjbSjGidYX5X19GFVyio4N8lqB1a4tl24HDfhRjMWPga/fLxBe1BBDzTEWCRX4i8bs7aUrWpR+yqSnsd27qAITLZs9JQ3ocAVe5aVE5GNPykRTMyTPKCJHKRmXtO0z74bEpUknIalOFYIZV1BQOXBGsdDxZ0flzzLtkY6w79pvUfAD/Rvzo/H60XDGPLGIkLItOGxKrPtM0iPx86BQFe65Rk0aOgT2CGA3NLb/TMaGt4kJje+oHmBJWS1sYEBXsX3ZR19hZn8BAmdeFm60fGoFzZ/KlZNIEpICr5YDwKAuHOJ/m18F5bZmCVDyQqIXdWg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(136003)(366004)(39860400002)(346002)(376002)(451199015)(122000001)(53546011)(6506007)(9686003)(7696005)(83380400001)(26005)(186003)(54906003)(2906002)(5660300002)(15650500001)(55016003)(110136005)(316002)(966005)(478600001)(71200400001)(52536014)(76116006)(66446008)(8676002)(41300700001)(8936002)(4326008)(64756008)(66476007)(66556008)(66946007)(66899015)(86362001)(33656002)(40140700001)(38100700002)(38070700005)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AYYAdcNABtM2m8B8DKp35iAaIf4Z2StYKcVyumfj9RfvOZ2zP5e4N8tlpU5P?= =?us-ascii?Q?sKrxAJRCcOWFpIuHNysFyMLs0hddaoZ+CB61bb3/K/aC3Eii8VCQxUtSvUAE?= =?us-ascii?Q?e1j0YoBCKjKmOTF5nyohPQgbejWyNJh9BZLz4GSizO6c1dbV6BminmckKqXr?= =?us-ascii?Q?srNU8X05Fg6TcplTcmJUJytmi+WTV1sPcWZlpLSdiEvqnErjiK+rFblIaIJ3?= =?us-ascii?Q?AymiTPo3wKcTugIJV1UNWES+qAZw3GVPTYmGCHCwbWkwK+4k+k0+SSKASPpP?= =?us-ascii?Q?Fht/dccf1oMNrE045MsztgPqd1X6YN7ouY8mnsT7Abxw/bmeiTvhAMQbXinX?= =?us-ascii?Q?biB6kOh0i4c8TdB0Mox1WKRRznCtIhcOVGRzEH57K6rklP2TvRagGy8e51AK?= =?us-ascii?Q?G8+pihxs5zuksf2PiXz6mwO/X4yn9hQKpED12HbPlaT5ZyESFk5Y4h/B5SI6?= =?us-ascii?Q?wkU1q3m3nDUjD7iZAO/dJJRpOttuF/25foWzafhkPKtmjOUuj3v8WSLmUIyH?= =?us-ascii?Q?y7erdKE/Yvezn/yex0Ep8EECp5crdM67FLlpuWwMW56rqgSUPb26BvM8nlO0?= =?us-ascii?Q?U2et4mEUv9J4YHMBMpJeZljtcZ6MLGhgAEImCJIhIzZ34ySYLm3C+XbZ5giO?= =?us-ascii?Q?5hBtUNIaQ/NCD5taXRlH5LYOz0XtVp27kkwcryjHPWCGVr81r819+ib2XOhE?= =?us-ascii?Q?kbIIgPXsaZpLnqCC+yCld8dzVtUXVwWj7PfGuakGBFCUD9BHdKeIktCUp0JH?= =?us-ascii?Q?KEuF47uC+OtcHJEwH6brnbWkR3h+e8v/B7E1IXlpqrG0jCFrped3I853VQMz?= =?us-ascii?Q?HveOOEPiaFEOrniAeV1f5r2E/LSp9X4KbiVyVP6f8JxWatosXHOPKmjFCHJk?= =?us-ascii?Q?durVpdm7kdKiiAiYfPHmmAYt9IVcnpKey+XD3UYgGMd00nFAL/sCWZr3RggG?= =?us-ascii?Q?4QxZZpQvEnru5HoDcLsOwwcmqgSYO+ip0GQoYf5IsOLtOBsf0VOXVZjcolz/?= =?us-ascii?Q?60pBiHgwj9p1f5V1bpNifdn9dFvmLO1ZuSujJNiSoXoDz986rGF9WIIdF2Xn?= =?us-ascii?Q?tFD7z3GURpHQh0NvqzyiHM73iRuL/ogZ/52piKZ7KoqwufZKtcv+LCG/c1rB?= =?us-ascii?Q?wYPNe13RIrnSBcDfeB1WE08gSrdDtsFs6bTvMgkV0dClwLJkZdLXbOL04BUQ?= =?us-ascii?Q?CnNZ2VZM1SThC4l2MnHpJyVSFzjY6daRGPB9/lR+zexxwoxaWeWWwjSV/8JB?= =?us-ascii?Q?BUXFJsIEC5RAsxmu0ckJ82A6mRCQuJQl0M5DpdiUh7s+RR7iX9ULKAl+PGVn?= =?us-ascii?Q?HajTNFtTi7yxzdhN1CAd9/YBo3h+bDwM7ynYGHy7lnOkhQ2B4Zpdohwxlth/?= =?us-ascii?Q?1/1GtDkS3cwRnAdkAuFcQrL0OY/Z7TXzb88jgalSZA4Q58jgs4R8cQWW+DS7?= =?us-ascii?Q?TELzHxSIABiLeNJRl2hhfNQw6mUkBzfrQIGC5qKWalMgakPvNCbGsidqnnag?= =?us-ascii?Q?abVn9d5FjPtYDTD4gOjsg+8xwlsPaZscJWYyeKePOY/1B55UGa+apQU87+M6?= =?us-ascii?Q?xP6oViMViAC+u5t6VmJhW9ZE7KKfQ++yQ7/tDO4U?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56a1e9fa-bbbe-4adf-1b7e-08dab0be1035 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 04:05:58.8068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OldGCTo5mUC0v1Ak9i9lSCtbyVGkP4OsMy1LmQjhexkCIgD3Mt418aTBgzbrstXwXJSUoaZxfAAOGYrfsryqKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5762 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the patch. Could you help to do a favor and create a pull request for the proposed pat= ch? You can follow the steps 10 & 11 in the below wiki link to do so: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Pr= ocess#the-developer-process-for-the-edk-ii-project Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Cheripally > Gopi via groups.io > Sent: Monday, October 17, 2022 2:53 PM > To: devel@edk2.groups.io > Cc: Selvaraj, Sundaresan ; Sambandan, Vasudevan > ; Sambandan, Vasudevan ; > Gao, Liming > Subject: [edk2-devel] [PATCH] MdeModulePkg: Improved ScsiDiskDxe driver > updates ControllerNameTable with common string SCSI Disk Device for all S= CSI > disk >=20 > ScsiDiskDxe driver updates ControllerNameTable with common string SCSI Di= sk > Device for all SCSI disk.due to this, when multiple SCSI disk devices con= nected, > facing difficulty in identifying correct SCSI disk device. > As per SCSI spec, standard Inquiry Data is having the fields to know Vend= or and > Product information. > Update "ControllerNameTable" with Vendor and Product information. So that= , > device specific name can be retrieved using ComponentName protocol. >=20 > Signed-off-by: > Cheripally Gopi >=20 > CC: Sundaresan S > CC: Vasudevan S > CC: Gaoliming >=20 >=20 > --- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 49 ++++++++++++++++++- > MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 8 +++ > .../Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 1 + > 3 files changed, 56 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > index 98e84b4ea8..3d05b01f8d 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c > @@ -67,6 +67,32 @@ FreeAlignedBuffer ( > } >=20 > } >=20 >=20 >=20 > +/** >=20 > + Remove trailing spaces from the string >=20 > + >=20 > + @param String The ASCII string to remove the trailing spaces >=20 > + >=20 > + @retval the new length of the string >=20 > +**/ >=20 > +UINTN >=20 > +RemoveTrailingSpaces ( >=20 > + IN OUT CHAR8 *String >=20 > +) >=20 > +{ >=20 > + UINTN Length =3D AsciiStrLen (String); >=20 > + >=20 > + if (Length =3D=3D 0) { >=20 > + return 0; >=20 > + } >=20 > + >=20 > + while ((Length > 0) && (String[Length-1] =3D=3D ' ')) { >=20 > + Length--; >=20 > + } >=20 > + >=20 > + String[Length] =3D 0; >=20 > + return Length; >=20 > +} >=20 > + >=20 > /** >=20 > The user Entry Point for module ScsiDisk. >=20 >=20 >=20 > @@ -203,6 +229,9 @@ ScsiDiskDriverBindingStart ( > UINT8 MaxRetry; >=20 > BOOLEAN NeedRetry; >=20 > BOOLEAN MustReadCapacity; >=20 > + CHAR8 VendorStr[VENDOR_IDENTIFICATION_LENGTH + 1]; >=20 > + CHAR8 ProductStr[PRODUCT_IDENTIFICATION_LENGTH + 1]; >=20 > + CHAR16 DeviceStr[VENDOR_IDENTIFICATION_LENGTH + > PRODUCT_IDENTIFICATION_LENGTH + 2]; >=20 >=20 >=20 > MustReadCapacity =3D TRUE; >=20 >=20 >=20 > @@ -354,19 +383,35 @@ ScsiDiskDriverBindingStart ( > } >=20 > } >=20 >=20 >=20 > + CopyMem ( >=20 > + VendorStr, >=20 > + > + &ScsiDiskDevice- > >InquiryData.Reserved_5_95[VENDOR_IDENTIFICATION_OFFSE > + T], >=20 > + VENDOR_IDENTIFICATION_LENGTH); >=20 > + VendorStr[VENDOR_IDENTIFICATION_LENGTH] =3D 0; >=20 > + RemoveTrailingSpaces (VendorStr); >=20 > + >=20 > + CopyMem ( >=20 > + ProductStr, >=20 > + > + &ScsiDiskDevice- > >InquiryData.Reserved_5_95[PRODUCT_IDENTIFICATION_OFFS > + ET], >=20 > + PRODUCT_IDENTIFICATION_LENGTH); >=20 > + ProductStr[PRODUCT_IDENTIFICATION_LENGTH] =3D 0; >=20 > + RemoveTrailingSpaces (ProductStr); >=20 > + >=20 > + UnicodeSPrint (DeviceStr, sizeof (DeviceStr), L"%a %a", > + VendorStr, ProductStr); >=20 > + >=20 > ScsiDiskDevice->ControllerNameTable =3D NULL; >=20 > AddUnicodeString2 ( >=20 > "eng", >=20 > gScsiDiskComponentName.SupportedLanguages, >=20 > &ScsiDiskDevice->ControllerNameTable, >=20 > - L"SCSI Disk Device", >=20 > + DeviceStr, >=20 > TRUE >=20 > ); >=20 > AddUnicodeString2 ( >=20 > "en", >=20 > gScsiDiskComponentName2.SupportedLanguages, >=20 > &ScsiDiskDevice->ControllerNameTable, >=20 > - L"SCSI Disk Device", >=20 > + DeviceStr, >=20 > FALSE >=20 > ); >=20 > return EFI_SUCCESS; >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > index d54282df5f..1a43c5030e 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > >=20 > #include >=20 > #include >=20 > +#include >=20 >=20 >=20 > #include >=20 > #include >=20 > @@ -179,6 +180,13 @@ extern EFI_COMPONENT_NAME2_PROTOCOL > gScsiDiskComponentName2; #define SCSI_COMMAND_VERSION_2 0x02 >=20 > #define SCSI_COMMAND_VERSION_3 0x03 >=20 >=20 >=20 > +// Per SCSI spec, EFI_SCSI_INQUIRY_DATA.Reserved_5_95[3 - 10] has the > +Vendor identification >=20 > +// EFI_SCSI_INQUIRY_DATA.Reserved_5_95[11 - 26] has the product > +identification >=20 > +#define VENDOR_IDENTIFICATION_OFFSET 3 >=20 > +#define VENDOR_IDENTIFICATION_LENGTH 8 >=20 > +#define PRODUCT_IDENTIFICATION_OFFSET 11 >=20 > +#define PRODUCT_IDENTIFICATION_LENGTH 16 >=20 > + >=20 > // >=20 > // SCSI Disk Timeout Experience Value >=20 > // >=20 > diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > index 40818e669b..f03ba1b1ea 100644 > --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf > @@ -46,6 +46,7 @@ > UefiDriverEntryPoint >=20 > DebugLib >=20 > DevicePathLib >=20 > + PrintLib >=20 >=20 >=20 > [Protocols] >=20 > gEfiDiskInfoProtocolGuid ## BY_START >=20 > -- > 2.33.0.windows.2 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended = to > be read only by the individual or entity to whom it is addressed or by th= eir > designee. If the reader of this message is not the intended recipient, yo= u are on > notice that any distribution of this message, in any form, is strictly pr= ohibited. > Please promptly notify the sender by reply e-mail or by telephone at 770-= 246- > 8600, and then delete or destroy all copies of the transmission. >=20 >=20 >=20 >=20