From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.5244.1670379835366019505 for ; Tue, 06 Dec 2022 18:23:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GQViZJ5t; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670379835; x=1701915835; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=ZlzEDg28b7ujfWSLBqqRA6TU0nHmSvpWYHZJBKDbTYc=; b=GQViZJ5tiFfHZ8mMGBlM2NEC1J6Wbgo9P6WwHJFyeTBaPm57ecIdCiaG AmAMOv2cEUSAdgX9pipIJ/YuwqC1fWfODWuLiID/Dw1zeMESzRiA3K2nI grIx46IE63KNXnsOYqKHehBVn7w902PLv9pv/zmAEpTdT7zz3hcqc1i19 PaSTVYnEbtRK3FrqzEJaIh7FlHWhQe8LD7HJt3dr6qzBeF5LtHRIt5kQY 1gHvYcC+ia59YbnF+4CR+N3plaLF0RKm2GqE/YoHEMITvN+puGyly/Pl3 KYtA33qEfYKhxhv/r7biOXi+bc8UaQir4XTcwpmkW6QoREhl7//6g5Mja g==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="296479957" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208,217";a="296479957" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 18:23:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="788718726" X-IronPort-AV: E=Sophos;i="5.96,223,1665471600"; d="scan'208,217";a="788718726" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 06 Dec 2022 18:23:44 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 18:23:43 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 6 Dec 2022 18:23:43 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 6 Dec 2022 18:23:43 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 6 Dec 2022 18:23:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gejf2B66RVW7lizUM8kkRqy+siRiSWSFU9kmEjorLvIyVHgoUo2yNg1fMt+oZ3pA+o+LxYo9eq1FnIk1XkXqW3u/GOhrb81JfYBsZBjLwzyMxITX1P7ULLo3Tjl+txSfDMuwamBrmkZGARrTiSEMM4qBoNHa3QW9p1sNQ7W8YCBFGB+zI8dTo4nO95FZPqf+e7L0sJlGoJnV2bn3pWuiEqsBFmweKHCiTYN9sb80OE/l24d7I/5FntL9AmPOY369i3pBbmzwsTKY6yhs5clTlQLATTrVgz8sURJyk7TpNmstDxoP+YpaSbmExm/yINDAxCEuzcOOtr/PMvDltrTRkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tWBLcuCI2XaWIxSKEL5BB3DqPp/RaW6K390jIhd1Q5U=; b=Wd72TuTKnp3tm9fftRGnRIkg37oXpC6X087F8REdaA+t/6oR2h2hxMWSUJKCHMQ1ifuj1EXzPXf+W9jMrRmDG8TKiTIZSpfkGPAGN24+shgOcC+arc8STeUh+93wRhBrqrybP0p5pKi4FQ7/myakB01Glk5zveiNn4aULYs+YpefiaZCbRf0RLZ3Ym86tcuHZ/ANDNRYDOvfSTHTFMxqoTgMO1SY+0u6n4SHCjSfecWyuP6nO+Uqt3jGmmq1EiYkciw39i187wNp1m4pUO2No/2MsDwRgutCRx64xLGQfPF9Y1p1Jb1U3S/8f85bOeO9Frd1xjv5Z06Y6EUeJA4ovw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4025.namprd11.prod.outlook.com (2603:10b6:5:197::31) by CO1PR11MB5204.namprd11.prod.outlook.com (2603:10b6:303:6e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 02:23:41 +0000 Received: from DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c]) by DM6PR11MB4025.namprd11.prod.outlook.com ([fe80::6129:7158:18dd:761c%3]) with mapi id 15.20.5880.013; Wed, 7 Dec 2022 02:23:41 +0000 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Rhodes, Sean" , "Gao, Liming" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 4/4] MdeModulePkg/UsbBusDxe: Adjust the MaxPacketLength to real world values Thread-Topic: [edk2-devel] [PATCH 4/4] MdeModulePkg/UsbBusDxe: Adjust the MaxPacketLength to real world values Thread-Index: AQHZCIqXMxarFntsRkmbE3qjLLx1565hrjxg Date: Wed, 7 Dec 2022 02:23:41 +0000 Message-ID: References: <04f0fa8e36a7ff57ed6ab14ebe284bce35680262.1670231907.git.sean@starlabs.systems> In-Reply-To: <04f0fa8e36a7ff57ed6ab14ebe284bce35680262.1670231907.git.sean@starlabs.systems> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4025:EE_|CO1PR11MB5204:EE_ x-ms-office365-filtering-correlation-id: cbc369ec-cfa8-4233-cb74-08dad7fa0e92 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dynsE/JsJuxtDstIazsOPX/GgNrzGbQqlnyn7jrM0jccEKjvBrThV+C/Cm/XcqbV3No+dYcWX0C8fy6FksNGG5b8SRe9qooJgMEzqTokNv1VgqVovt+f3xVbWQcz5OEVbnjh0EtLprPQoMZWy9Ztkparj2zABHmdV6c1ksQRVxWrvGm2IDEXQ3QL8/mf7YCkoMi7BybRd/hQJrd+nwStxK+fXFIOpSoSlpgkMS81Xh8FkVd+8QGhxPbZsSh0XjvIFWhuTLzFcEGG1PZdPMY398x9JamI4atHHbkdFONel6bUSQhLVGmZK5fav1X1J/DuDEu0TgsgcHmIyYZRpUGA2TORk2yWzfXTQUv0F/zmWF9np6XqSJbB+/GJ90OKj9yt70WNGXGXFKHxwrkyy2Vdi55TzVjiyKs+2SP035MOIDXskKeBU1E5uavkqrlLT7sGE3OBDKvHS3L1SpjbOv3li2ugYF07XsqhSRF7UmhlWgDAK5HC1nfay4m6LhGgVqhcOYn1boR5/WAF2wn8RfTGBto8DLRhSWborkLAkRJiLjuUQjvqQCscQoDvge0Zm6/FaaRWVyOrsCn21sHYX/fzxpwuhQci+CVHWx5KRQ8+ki1bpmjopNkTFM1xq5Y4CdwgS0Ql7XIU63lh7jgrOF89AMdHqupMr97n3OJCw4mmK9LzcCqAW+evbMy1W8IzWegc8X//ShBXXMHhRMrHMzW0ki/9ZWpEm0VdvPeQ1+CVjKnQp0yPWDeis5Wa8UlJOrOeyZVja6YdbTUSueT15LYyGw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4025.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(346002)(136003)(366004)(396003)(451199015)(66899015)(6506007)(7696005)(33656002)(71200400001)(86362001)(53546011)(478600001)(38070700005)(966005)(55016003)(38100700002)(83380400001)(166002)(82960400001)(122000001)(9686003)(8676002)(41300700001)(186003)(5660300002)(26005)(107886003)(66476007)(66556008)(64756008)(76116006)(66446008)(66946007)(8936002)(2906002)(316002)(4326008)(52536014)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xXaFBlsSFaXBiEZ0uwulQ5/h32v1d3nzge2VzpDGsBd6GspwxuaBOGwpsb25?= =?us-ascii?Q?+JgTigeqzDbTNtZdazt1kYhIRS//p+733B1P2nCktnVxFNxPaOUM+s8mYLIt?= =?us-ascii?Q?eWL/VrbTHBRvy+s+ovW8qfgvT9EWqvfNd8+dy1/tyXZgoBv9UCOK0LYoG4zO?= =?us-ascii?Q?8LaNDrhMB0lTIp2LNmna8GSWRuCqCnOi7KIzWBDAHrlucS5HJJeSpSkXig4x?= =?us-ascii?Q?3M7N+qLH4GOLV+JFsRKVLlsZ/XIHDmhuF9a3E6TKQdIxZd2kbkHWlvJO7hqp?= =?us-ascii?Q?noFOZwA+0mMz5b8Ht3HD4hlVoG1ZFuLNifjzekixNOHqf09/uOzLsc3QLJ33?= =?us-ascii?Q?zKnfd7oJM94XqPU5GA9k6nkGCByjWHgfXKGmtJLABY56GEl+uQMEY9kEh6oC?= =?us-ascii?Q?9ceYhsoNVETJO4uA9IjBajWGtyA5vgahNYA8g5S16ekN24eDbBQtgcPDfkvn?= =?us-ascii?Q?IINacV4EHr2IkjLKt1ae/RbWhE545uRxrHxn8Q45XsAHs4GGIlXUFQyD3VfI?= =?us-ascii?Q?CTTJDWmKXUxTfLG9lH3dpr95qm6+x4l1pzBlq0wWJBoo4MZ/0ADIanYwFCfX?= =?us-ascii?Q?W5rzCG3uaorNe2/MxRFqWWKyY2uLsYn+Fhpc4jxIrzdm9MzdjXxLxRGxqCji?= =?us-ascii?Q?60xKJSrVp+Cr32fJ5KvpKfO8+OfW3Ea/lEyC0Zf9KUpQa0vB429pKWzVjMDF?= =?us-ascii?Q?L3rBVx0uEvsc9OYHr4tKqSghBHRzglJOB//vT6hZuhAquXrTmYM7S/TY/vCY?= =?us-ascii?Q?6PBqjalwkv604nFCKjtYrzEg3MkhF8kSIzeIKohNx8pfoTt2w/vQRKU7dw2d?= =?us-ascii?Q?eJ8iWzPavqxi3Ajl4sDtUQdkn/tOq9U1K5OFNt5Ew/XSnQFrdeJCdErcQFT3?= =?us-ascii?Q?95mMoA3NsLjFNzkJFS1Di+lGnM7rWSP9cfCONMnsSWVnMNIYQ/aqmVW2W9TA?= =?us-ascii?Q?jrUY0S4w/THXsoWrHwxHAvsTIywussnU9p6WtgTivBpM1kG1aHNbD6tvm9Ea?= =?us-ascii?Q?sOY/1/hUvU4O5ErNsgfhbW9vw3psr5nQEeqWnA0acwso7YTbZMMNW2+ElTvs?= =?us-ascii?Q?08TmJzunVhkyzOsoATrF8DaNUCim3XanodeB7CCwqZq2X5bYbsEm9AqRAisn?= =?us-ascii?Q?DSs4l6tU+YQotid7nql/1nYEYDI99XHOtYWx8+EQkBbsu54wtA8uiXBJENFl?= =?us-ascii?Q?cfGffF8u8UgOOpEOVWet4096EGf81riShJ5O5gSN25iEtIaWTdYRfbh0K8xL?= =?us-ascii?Q?E3Ao4vbPPZ7y6kbN7fyGmiLk1qsM0GP1gwww5qnkN+ErRxTeubqiHKb6Uqky?= =?us-ascii?Q?q+aF5oRBv7YKo0JyIjHsDRwE1+gUV8hhQCuFxpIXV6kRlrkRWqE2nLh7/1vE?= =?us-ascii?Q?XqvaKVMqVrUwMfiFfTMlY9URE+LnCSRZBaO8ezjwa4t7sNmce1Xj0DxyQI+9?= =?us-ascii?Q?/IdZ3C/Yhx9kAEtcYmx7fkXEOFxPDQ02QIu60UMacIDUEK3mDXagrjGX71pA?= =?us-ascii?Q?nYs0tp0+zJwJFo4bUSzb5nBNtQRd4KBSBwV7pMdHihuHmnk2rYMLSrObdg/S?= =?us-ascii?Q?3q3+Nu+S7i4frHjuDdklq2Q3Qh5/nyYshWmmhwTL?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4025.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbc369ec-cfa8-4233-cb74-08dad7fa0e92 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 02:23:41.2487 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wsdK3LHANn0J0XK26B2lE6x55MZH6bDWBnsHhFXNwi5D4CSlSJSXmiLEUg8/oKzYU9pwsG3TXYL9dnGorZpRVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5204 Return-Path: hao.a.wu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_DM6PR11MB4025FDA4205FA0FD11086CA7CA1A9DM6PR11MB4025namp_" --_000_DM6PR11MB4025FDA4205FA0FD11086CA7CA1A9DM6PR11MB4025namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have concern for this patch. It will make the implementation of XhcControlTransfer() no longer following= the UEFI specification requirements on the EFI_USB2_HC_PROTOCOL.ControlTra= nsfer() service: Section 17.1.7 of UEFI spec Release 2.10: EFI_INVALID_PARAMETER is returned if one of the following conditions is sat= isfied: ... * MaximumPacketLength is not valid. If DeviceSpeed is EFI_USB_SPEED_LOW, th= en MaximumPacketLength must be 8. If DeviceSpeed is EFI_USB_SPEED_FULL or EFI_USB_SPEED_HIGH, th= en MaximumPac- ketLength must be 8, 16, 32, or 64. If DeviceSpeed is EFI_USB_SPEED_SUPER= , then MaximumPacketLength must be 512. My take is that it will need a UEFI spec update to integrate this proposed = change. Sorry Liming, could you help on the process of raising opens with regard to= the UEFI specification? Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > Sent: Monday, December 5, 2022 5:18 PM > To: devel@edk2.groups.io > Cc: Rhodes, Sean ; Wu, Hao A > ; Ni, Ray > Subject: [edk2-devel] [PATCH 4/4] MdeModulePkg/UsbBusDxe: Adjust the > MaxPacketLength to real world values > > Adjusts the requirements for the MaxPacketLength to match what is seen on > real world devices that do not follow the USB specification. > > This fixes enumeration on the multiple USB 3 devices made by SanDisk, > Integral, Kingston and other generic brands. > > Cc: Hao A Wu > > Cc: Ray Ni > > Signed-off-by: Sean Rhodes > > --- > MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > index 62535cad54..043b7d4cea 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c > @@ -906,19 +906,16 @@ XhcControlTransfer ( > return EFI_INVALID_PARAMETER; > > } > > > > - if ((MaximumPacketLength !=3D 8) && (MaximumPacketLength !=3D 16) && > > - (MaximumPacketLength !=3D 32) && (MaximumPacketLength !=3D 64) && > > - (MaximumPacketLength !=3D 512) > > - ) > > - { > > + // Check for valid maximum packet size > > + if ((DeviceSpeed =3D=3D EFI_USB_SPEED_SUPER) && (MaximumPacketLength > > 1024)) { > > return EFI_INVALID_PARAMETER; > > } > > > > - if ((DeviceSpeed =3D=3D EFI_USB_SPEED_LOW) && (MaximumPacketLength != =3D > 8)) { > > + if ((DeviceSpeed =3D=3D EFI_USB_SPEED_HIGH) && (MaximumPacketLength > > 512)) { > > return EFI_INVALID_PARAMETER; > > } > > > > - if ((DeviceSpeed =3D=3D EFI_USB_SPEED_SUPER) && (MaximumPacketLength != =3D > 512)) { > > + if ((DeviceSpeed =3D=3D EFI_USB_SPEED_FULL) && (MaximumPacketLength > > 64)) { > > return EFI_INVALID_PARAMETER; > > } > > > > -- > 2.37.2 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#96951): https://edk2.groups.io/g/devel/message/96951 > Mute This Topic: https://groups.io/mt/95465401/1768737 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D > --_000_DM6PR11MB4025FDA4205FA0FD11086CA7CA1A9DM6PR11MB4025namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I have concern for this patch.

 

It will make the implementation of XhcControlTran= sfer() no longer following the UEFI specification requirements on the EFI_U= SB2_HC_PROTOCOL.ControlTransfer() service:

 

Section 17.1.7 of UEFI spec Release 2.10:

EFI_INVALID_PARAMETER is returned if one of the f= ollowing conditions is satisfied:

...

• MaximumPacketLength is not valid. If DeviceSpeed is EFI_U= SB_SPEED_LOW, then MaximumPacketLength

  must be 8. If DeviceSpeed is EFI_USB_SPEED= _FULL or EFI_USB_SPEED_HIGH, then MaximumPac-

  ketLength must be 8, 16, 32, or 64. If Dev= iceSpeed is EFI_USB_SPEED_SUPER, then MaximumPacketLength

  must be 512.

 

My take is that it will need a UEFI spec update t= o integrate this proposed change.

Sorry Liming, could you help on the process of ra= ising opens with regard to the UEFI specification? Thanks in advance.<= /o:p>

 

Best Regards,

Hao Wu

 

> -----Original Message-----

> From: devel@edk2.groups.io <devel@edk2.gr= oups.io> On Behalf Of Sean

> Rhodes

> Sent: Monday, December 5, 2022 5:18 PM

> To: devel@edk2.groups.io

> Cc: Rhodes, Sean <sean@starlabs.systems&g= t;; Wu, Hao A

> <hao.a.wu@intel.com>; Ni, Ray <ray.= ni@intel.com>

> Subject: [edk2-devel] [PATCH 4/4] MdeModuleP= kg/UsbBusDxe: Adjust the

> MaxPacketLength to real world values

>

> Adjusts the requirements for the MaxPacketLe= ngth to match what is seen on

> real world devices that do not follow the US= B specification.

>

> This fixes enumeration on the multiple USB 3= devices made by SanDisk,

> Integral, Kingston and other generic brands.=

>

> Cc: Hao A Wu <hao.a.wu@i= ntel.com>

> Cc: Ray Ni <ray.ni@intel.c= om>

> Signed-off-by: Sean Rhodes <sean@starlabs.systems>

> ---

>  MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | = 11 ++++-------

>  1 file changed, 4 insertions(+), 7 del= etions(-)

>

> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xh= ci.c

> b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c

> index 62535cad54..043b7d4cea 100644

> --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c

> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c

> @@ -906,19 +906,16 @@ XhcControlTransfer (

>      return EFI_INV= ALID_PARAMETER;

>

>    }

>

>

>

> -  if ((MaximumPacketLength !=3D 8)&nbs= p; && (MaximumPacketLength !=3D 16) &&

>

> -      (MaximumPack= etLength !=3D 32) && (MaximumPacketLength !=3D 64) &&

>

> -      (MaximumPack= etLength !=3D 512)

>

> -      )

>

> -  {

>

> +  // Check for valid maximum packet si= ze

>

> +  if ((DeviceSpeed =3D=3D EFI_USB_SPEE= D_SUPER) && (MaximumPacketLength >

> 1024)) {

>

>      return EFI_INV= ALID_PARAMETER;

>

>    }

>

>

>

> -  if ((DeviceSpeed =3D=3D EFI_USB_SPEE= D_LOW) && (MaximumPacketLength !=3D

> 8)) {

>

> +  if ((DeviceSpeed =3D=3D EFI_USB_SPEE= D_HIGH) && (MaximumPacketLength >

> 512)) {

>

>      return EFI_INV= ALID_PARAMETER;

>

>    }

>

>

>

> -  if ((DeviceSpeed =3D=3D EFI_USB_SPEE= D_SUPER) && (MaximumPacketLength !=3D

> 512)) {

>

> +  if ((DeviceSpeed =3D=3D EFI_USB_SPEE= D_FULL) && (MaximumPacketLength >

> 64)) {

>

>      return EFI_INV= ALID_PARAMETER;

>

>    }

>

>

>

> --

> 2.37.2

>

>

>

> -=3D-=3D-=3D-=3D-=3D-=3D

> Groups.io Links: You receive all messages se= nt to this group.

> View/Reply Online (#96951): https://edk2.groups.i= o/g/devel/message/96951

> Mute This Topic: https://groups.io/mt/= 95465401/1768737

> Group Owner: devel+owner@edk2.grou= ps.io

> Unsubscribe: https://edk2.groups.i= o/g/devel/unsub [hao.a.wu@intel.com]

> -=3D-=3D-=3D-=3D-=3D-=3D

>

 

--_000_DM6PR11MB4025FDA4205FA0FD11086CA7CA1A9DM6PR11MB4025namp_--