From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.4565.1660130590016610164 for ; Wed, 10 Aug 2022 04:23:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=E9znwAPW; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: kasimx.liu@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660130590; x=1691666590; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Pvq6IOy8/RtP7AA4BLCHOL2Yc95CFV2E6SpcKdOW5i0=; b=E9znwAPW18+f8bj8ROt+VrmexLfe26AJoaW4I3io+ll5Tpq9B8bgvlas OrrJNqRVSKGMcM1U0yrNvWqRqZ/zXWfJUwOqgqNdG+PaaqANPZb9IcmCS uMHZqE7pbvPg69r3RZ3xw1Pwx/miF/00xbrjLUH3gdKFLFnEblBItzWDc JSJbO74VLS2DfGhD207UPrzkEJkSrM0iFVN8QZk2EmGyzV+qlD2aRqK25 bnHXZF/nZVRhzlSeRCHuN7w7wCDwc2CKhB11c9ScIYBxiEXnF7R6LJRFe 7QRZUZ53hm2YfQmcMkfyyiGPaPHXnr7CeGZSzJfMoXlW4m0rgo2xHQ8tF Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="377350242" X-IronPort-AV: E=Sophos;i="5.93,227,1654585200"; d="scan'208";a="377350242" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2022 04:23:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,227,1654585200"; d="scan'208";a="673257047" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 10 Aug 2022 04:22:59 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 10 Aug 2022 04:22:59 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 10 Aug 2022 04:22:58 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 10 Aug 2022 04:22:58 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 10 Aug 2022 04:22:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dj5zA4GNNjFHOvaklMkdt5Spk97VJ9B78/CV5jqgjB1zyhk6J61tKR05jGA7dnKdpQ5eETlHaYWAVNC5nwlkxAcVfcrokPqtcY9AIE76hOm80d32dWKiL9Lp4henPUs4ZyBpKdEVvlAcWpEl9hUs7MJFH9zwPhOlcWl4A8RChr3HX3dQLZgccbQXPF214oaowTZedKpepAutqeiIBik0M1KfS7iy3HJ48VdHbFDkkQfv6UefzOdFGz8Fxwtljp4ld3P1adibgnxNXXfGUb2qxvcQQrUyGu0l/Xvc18qwqMuvUTk0+Ga9IwW2/RA8sKyD+b6nlo9nKEVj0TVvVAgBsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ifKjbt30/b6zxIhplflej++ud5ki2ZQg2YmHhWlJn4o=; b=G7WtnMF7AnBqjCo6QbT/Q2FP14wk3xQ6hOsy+MK/60ZO+EKRAdbff4nCkccdeN7eOmBkDF1WwX24LJ4jMZBCrZ3ddMlTZhdO9XKZWHJ8YVajsLbTMBk7e21xarE/VlS91e64lTgTn8zPkAOgEsVcvvTmAeszka/k0KjXRNHPJGurK50qBtEz2N84gIJ+Fthsq40OMq/V88+6QRb4QUWwHaj5EVWcFtflJfIDIaQz/GPG/aiXEB9IHgaf6jK0+VL2C7FJKQTOcZ2NoK+xkNcUqQeO8k6qWsHun2XEMrlw/WO5s+w6+w+22ZcvCpwqBcglvTP4d7yOF6JuUK5eKSXbwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4027.namprd11.prod.outlook.com (2603:10b6:5:199::11) by DM5PR11MB1354.namprd11.prod.outlook.com (2603:10b6:3:15::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Wed, 10 Aug 2022 11:22:57 +0000 Received: from DM6PR11MB4027.namprd11.prod.outlook.com ([fe80::ec2c:8fa0:e203:546]) by DM6PR11MB4027.namprd11.prod.outlook.com ([fe80::ec2c:8fa0:e203:546%5]) with mapi id 15.20.5525.010; Wed, 10 Aug 2022 11:22:57 +0000 From: "Liu, KasimX" To: "Guo, Gua" , "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Guo" , "Lu, James" Subject: Re: [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL Thread-Topic: [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL Thread-Index: AQHYq7KGn7NqyrKFM0WbnS/CK/VSVq2nnSCAgAACtwCAAF5x4A== Date: Wed, 10 Aug 2022 11:22:56 +0000 Message-ID: References: <20220809054008.1437-1-kasimx.liu@intel.com> In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41a881ca-a20c-403d-7742-08da7ac2acfe x-ms-traffictypediagnostic: DM5PR11MB1354:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xSAcVPxsw7rRjv9UdCpvKgvGvfoOChSlBXBZgkg6XysZNlyzAr+4FdiL+ngxSBzVaWbhUN1PkSBfKK6Vb1b79tuTDRUkCeAb3MgQd5TcEFfvPaTsJj8iqJvQQaieTXv2J+tFesuuFz9j62TSSRkLf4XFoE9nP19U+nIoXNTCOfjqG4fHlfqQHHYwClhkWVTHmnyhtclQRBjdp6BWY/y8zB+bYuchizHqwhJXKsaT9JDFP7C6E2iQjxJ/kaDcA6tx6ejm1umfRuQo6EXh9Fanv6KItT2E5KF+UGvsdTqw13jSGzsGRpT1jjtw5FY721KxfZnh4RX5E9EWvKdVGlQafMUuuBqOtLBl6rVPsFW3Fgy1JApvWaehtCTXGwYZsv+92IqJ5MmvL3jbDVzy5V6HrJpbFQPZYN2uoMv+PB48lEMxvvg3hEZwCMM3lpYK+y79w9733A8OOvTbIv7nTqYK1t7/q/+cOAOuJet4yuwN9OFCVlI6o4QcDKO1sQas9dS3c0XCUYNBuZAqa1c5zhyYdjbppROGCRgAszPt8iLet5AEZMVPdGzEB84/u/nMrmyl40362OX9fDOYpHoOMh8bukK3JkuU9jtKDi76if2PL4uJBqSqNP/rEU1pUyMa9nkI9LsZc3Frm/qWFS1Aa2nmkHT5HNh0pW0uHX0mjiWAL6yv3I0oI3EseNPwDE6NhVdERoyYRWCgOHjzvhHUO1xJTX9K1Jzj6cakVjbwJvyUWSxmEfKHsSmXfrw3MQz8ORtsCfZLaHSSX1YMZ+kYabkmVArayg/QWY+eFoyb9NVqt3WVMbnEWqDvWRqQPdiQ8wXaNp1LKb17I8JXmjxP4BjyEpPot7U8//SA42eQQqX36l++xF8ph4SP3x/+2krySIhN x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB4027.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(376002)(136003)(346002)(84040400005)(64756008)(5660300002)(66556008)(66476007)(66446008)(316002)(76116006)(4326008)(8676002)(54906003)(86362001)(55016003)(110136005)(186003)(478600001)(33656002)(15650500001)(8936002)(122000001)(52536014)(66946007)(2906002)(83380400001)(107886003)(82960400001)(38070700005)(26005)(19627235002)(53546011)(41300700001)(7696005)(71200400001)(9686003)(966005)(6506007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bXhADh4zzwHSSmInb8exUICeKNClUVl5o5Xq7oemQuvzrAKGm0EYS52D4kin?= =?us-ascii?Q?4uRgSnC9xEaBbifNvw53PqjAnAWzn3YrbnEn8V2ihtNeb74LmtHNiVH/VRYY?= =?us-ascii?Q?5WGMoCiv06wzCFWNcKZup40JI7lhf1DIw4SIRMOzGrVqV+JwhIC7zG2f8N+x?= =?us-ascii?Q?ASRsUWt0c6kncRtf+uBJ5RrPL+N7WTTuwcuWP7vFXmibzxmsARuayKT2r3dO?= =?us-ascii?Q?cZhxJNv4jLEMy/aSnpD/3/3SwDkATdBdqA77yj2yOHqiWKFn1Z2owi0+mhvo?= =?us-ascii?Q?931WfFMb7eUKVpFRwTrC8INQhqStqRIeOO0D2dOPNAqKBhA+Oot6Bonm8jQF?= =?us-ascii?Q?UcTwAE0t0g1ciA+MSHT1Le6HIewqh14hZSRHvlB2OJdZ+lmBTymPWhsuBvov?= =?us-ascii?Q?NXHfF6JjvikFbdnTCgatBAJoOjqMPgLyZaoCK6dajYhqdKYzGr8eqbKNAdV7?= =?us-ascii?Q?+OdS1e3jCfoTgPbf3CUciI5hu6rMWmnz0lVl+BzuT1W6mY1d9kE3SwU6+q40?= =?us-ascii?Q?CVFnQJV+cgSyg4bn3iUisOtl15iQxyoMMsnNdPVmL9MsIjBTWL63GGHJvcXu?= =?us-ascii?Q?lNp/yilxJQS36xAXdmcJw7A9lBEYSmdwek3QoGBVwWICkVLSMFvI5epLOJbm?= =?us-ascii?Q?0iHNpVsQ+6vu31aXpa/rc8/7WCXinDsK1Hi5gTyasEqXvgNDdhtA9BLbwaAr?= =?us-ascii?Q?xrDt8JyTe17IiLI3fIIskOk1osl4eO57+aitD8bHDL8inW86HvmX5lBrWVYa?= =?us-ascii?Q?RPO12ZTWmi9DxOoloHeNPTjW8c6DwGxMgjd7vaMe0GM0peKGxGrYHcbEa20s?= =?us-ascii?Q?tDUovsv4OMdEZ7dpi29m8yEJS2XSoilI20DoR6xGSl0IltKqij4+X4YDhLmZ?= =?us-ascii?Q?3QUKV7pJZCBw6ZymcRxUZStjEVr8XkcXhcfAdl+HwgMnw79hmAeiEvk3S+Kc?= =?us-ascii?Q?p93DAwFdN36GxghFVlXbPDOVcx8Y6zcSZ20enw6pHaLpD3UjW5A85X/PurI1?= =?us-ascii?Q?snQA2vfvm0iQlFauh8qgAQjKI1VhuIR6H2RspBaFiPPRR4xswO1gksZingoM?= =?us-ascii?Q?1P3bcZF6t5YxLOuA83ETg3SYQtpomVA+CxyU4XXAlUyuFPk5r+ZlwMKfqJpU?= =?us-ascii?Q?pc07ox+GbRmv/cR9vI1M4pqD1sV7voExcA9TKr822ckRIO0IssBkpaVo6R+T?= =?us-ascii?Q?HcIORp1PSIxONcgj0Hu2gwoXrQmYWdrCvjHxR8XxBLzZIDApKDXn/j4gWQ5z?= =?us-ascii?Q?HHRVxPrjyiA1oBJhYB8VfZD8KOdCEvU7rNTa0WsBz7FrJvj/av46TjWW4RSJ?= =?us-ascii?Q?x5BcXpAhSqniGaO0GBHi86OABI4RNtFS6pJEVf42AdEY3ohfEP9YJh5dAtx1?= =?us-ascii?Q?ztqP/rhpQJZyFJTzWPNRS1cMB2Ceik4jGAMGAYT4u54yHof6avEOUbXBm6kL?= =?us-ascii?Q?FD/HiUH12eK0aY9xqk+GhZ77Z8seQ8PgSkUDgeYN3TEJWjdvD4uf7ouS4QmP?= =?us-ascii?Q?CEl+/3IRHP6VbA7vg4o5zBepec3ApMy2rwiMg8I0jFExorn9TPefEgdM1GVo?= =?us-ascii?Q?i6HbeRLbmyrJtuo+/SmW4VM4FUQPArfuco6/3UCG?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4027.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41a881ca-a20c-403d-7742-08da7ac2acfe X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2022 11:22:57.0323 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MciU1npGRubqfehF7cIxUOWuSpSV5oNKjMPKG6A3qSIqJxtDd6WlMC+W7Dw44YcFFYz7w9p6y3dcGDy+r77JqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1354 Return-Path: kasimx.liu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi @Ni, Ray Thanks for the reply and reviewed-by. I've created the PR, could you help me add push label when you're available= . I think we're better to check in the solution. https://github.com/tianocore/edk2/pull/3188 -----Original Message----- From: Guo, Gua =20 Sent: Wednesday, August 10, 2022 1:40 PM To: Ni, Ray ; Liu, KasimX ; devel@e= dk2.groups.io Cc: Dong, Guo ; Lu, James Subject: RE: [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL Reviewed-by: Gua Guo -----Original Message----- From: Ni, Ray Sent: Wednesday, August 10, 2022 1:30 PM To: Liu, KasimX ; devel@edk2.groups.io Cc: Dong, Guo ; Lu, James ; Guo, Gu= a Subject: RE: [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, KasimX > Sent: Tuesday, August 9, 2022 1:40 PM > To: devel@edk2.groups.io > Cc: Liu, KasimX ; Dong, Guo=20 > ; Ni, Ray ; Lu, James=20 > ; Guo, Gua > Subject: [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL >=20 > From: KasimX Liu >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4013 >=20 > For the SMBIOS version can be update by UPL,we create the=20 > gUniversalPayloadSmbios3TableGuid HOB to store the value then updated=20 > version. >=20 > Cc: Guo Dong > Cc: Ray Ni > Cc: James Lu > Cc: Gua Guo > Signed-off-by: KasimX Liu > --- > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c | 25 > ++++++++++++++++---- > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h | 12 +++++++--- > 2 files changed, 29 insertions(+), 8 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > index 81df59cd0f..7c1e2adc02 100644 > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > @@ -1447,7 +1447,9 @@ BOOLEAN > IsValidSmbios20Table ( >=20 > IN VOID *TableEntry, >=20 > OUT VOID **TableAddress, >=20 > - OUT UINTN *TableMaximumSize >=20 > + OUT UINTN *TableMaximumSize, >=20 > + OUT UINT8 *MajorVersion, >=20 > + OUT UINT8 *MinorVersion >=20 > ) >=20 > { >=20 > UINT8 Checksum; >=20 > @@ -1478,6 +1480,8 @@ IsValidSmbios20Table ( > if (SmbiosTable->MajorVersion < 2) { >=20 > return FALSE; >=20 > } >=20 > + *MajorVersion =3D SmbiosTable->MajorVersion; >=20 > + *MinorVersion =3D SmbiosTable->MinorVersion; >=20 >=20 >=20 > // >=20 > // The whole struct check sum should be zero >=20 > @@ -1522,7 +1526,9 @@ BOOLEAN > IsValidSmbios30Table ( >=20 > IN VOID *TableEntry, >=20 > OUT VOID **TableAddress, >=20 > - OUT UINTN *TableMaximumSize >=20 > + OUT UINTN *TableMaximumSize, >=20 > + OUT UINT8 *MajorVersion, >=20 > + OUT UINT8 *MinorVersion >=20 > ) >=20 > { >=20 > UINT8 Checksum; >=20 > @@ -1541,6 +1547,8 @@ IsValidSmbios30Table ( > if (SmbiosTable->MajorVersion < 3) { >=20 > return FALSE; >=20 > } >=20 > + *MajorVersion =3D SmbiosTable->MajorVersion; >=20 > + *MinorVersion =3D SmbiosTable->MinorVersion; >=20 >=20 >=20 > // >=20 > // The whole struct check sum should be zero >=20 > @@ -1575,7 +1583,9 @@ EFI_STATUS > ParseAndAddExistingSmbiosTable ( >=20 > IN EFI_HANDLE ImageHandle, >=20 > IN SMBIOS_STRUCTURE_POINTER Smbios, >=20 > - IN UINTN Length >=20 > + IN UINTN Length, >=20 > + IN UINT8 MajorVersion, >=20 > + IN UINT8 MinorVersion >=20 > ) >=20 > { >=20 > EFI_STATUS Status; >=20 > @@ -1583,6 +1593,9 @@ ParseAndAddExistingSmbiosTable ( > EFI_SMBIOS_HANDLE SmbiosHandle; >=20 > SMBIOS_STRUCTURE_POINTER SmbiosEnd; >=20 >=20 >=20 > + mPrivateData.Smbios.MajorVersion =3D MajorVersion; >=20 > + mPrivateData.Smbios.MinorVersion =3D MinorVersion; >=20 > + >=20 > SmbiosEnd.Raw =3D Smbios.Raw + Length; >=20 >=20 >=20 > if ((Smbios.Raw >=3D SmbiosEnd.Raw) || (Smbios.Raw =3D=3D NULL)) { >=20 > @@ -1692,6 +1705,8 @@ RetrieveSmbiosFromHob ( > UNIVERSAL_PAYLOAD_GENERIC_HEADER *GenericHeader; >=20 > VOID *TableAddress; >=20 > UINTN TableMaximumSize; >=20 > + UINT8 MajorVersion; >=20 > + UINT8 MinorVersion; >=20 >=20 >=20 > Status =3D EFI_NOT_FOUND; >=20 >=20 >=20 > @@ -1709,9 +1724,9 @@ RetrieveSmbiosFromHob ( > // >=20 > SmBiosTableAdress =3D (UNIVERSAL_PAYLOAD_SMBIOS_TABLE=20 > *)GET_GUID_HOB_DATA (GuidHob); >=20 > if (GenericHeader->Length >=3D > UNIVERSAL_PAYLOAD_SIZEOF_THROUGH_FIELD > (UNIVERSAL_PAYLOAD_SMBIOS_TABLE, SmBiosEntryPoint)) { >=20 > - if (mIsSmbiosTableValid[Index].IsValid ((VOID > *)(UINTN)SmBiosTableAdress->SmBiosEntryPoint, &TableAddress, > &TableMaximumSize)) { >=20 > + if (mIsSmbiosTableValid[Index].IsValid ((VOID > *)(UINTN)SmBiosTableAdress->SmBiosEntryPoint, &TableAddress, > &TableMaximumSize,&MajorVersion,&MinorVersion)) { >=20 > Smbios.Raw =3D TableAddress; >=20 > - Status =3D ParseAndAddExistingSmbiosTable (ImageHandle, = Smbios, > TableMaximumSize); >=20 > + Status =3D ParseAndAddExistingSmbiosTable (ImageHandle, = Smbios, > TableMaximumSize,MajorVersion,MinorVersion); >=20 > if (EFI_ERROR (Status)) { >=20 > DEBUG ((DEBUG_ERROR, "RetrieveSmbiosFromHob: Failed to=20 > parse preinstalled tables from Guid Hob\n")); >=20 > Status =3D EFI_UNSUPPORTED; >=20 > diff --git a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h > b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h > index 019798ea77..f1500beabd 100644 > --- a/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h > +++ b/MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.h > @@ -136,7 +136,9 @@ BOOLEAN > IsValidSmbios30Table ( >=20 > IN VOID *TableEntry, >=20 > OUT VOID **TableAddress, >=20 > - OUT UINTN *TableMaximumSize >=20 > + OUT UINTN *TableMaximumSize, >=20 > + OUT UINT8 *MajorVersion, >=20 > + OUT UINT8 *MinorVersion >=20 > ); >=20 >=20 >=20 > /** >=20 > @@ -155,7 +157,9 @@ BOOLEAN > IsValidSmbios20Table ( >=20 > IN VOID *TableEntry, >=20 > OUT VOID **TableAddress, >=20 > - OUT UINTN *TableMaximumSize >=20 > + OUT UINTN *TableMaximumSize, >=20 > + OUT UINT8 *MajorVersion, >=20 > + OUT UINT8 *MinorVersion >=20 > ); >=20 >=20 >=20 > /** >=20 > @@ -174,7 +178,9 @@ BOOLEAN > (*IS_SMBIOS_TABLE_VALID) ( >=20 > IN VOID *TableEntry, >=20 > OUT VOID **TableAddress, >=20 > - OUT UINTN *TableMaximumSize >=20 > + OUT UINTN *TableMaximumSize, >=20 > + OUT UINT8 *MajorVersion, >=20 > + OUT UINT8 *MinorVersion >=20 > ); >=20 > typedef struct { >=20 > EFI_GUID *Guid; >=20 > -- > 2.32.0.windows.2