public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liu, KasimX" <kasimx.liu@intel.com>
To: "Dong, Guo" <guo.dong@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, "Lu, James" <james.lu@intel.com>,
	"Guo, Gua" <gua.guo@intel.com>
Subject: Re: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase
Date: Tue, 31 Jan 2023 08:33:31 +0000	[thread overview]
Message-ID: <DM6PR11MB4027D82762948921809B8CC494D09@DM6PR11MB4027.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CY5PR11MB62601923A97E45500F1900839EC69@CY5PR11MB6260.namprd11.prod.outlook.com>

Hi @Dong, Guo

I've created the PR, could you help me add push label when you're available. 
https://github.com/tianocore/edk2/pull/3972

Thanks.

-----Original Message-----
From: Dong, Guo <guo.dong@intel.com> 
Sent: Tuesday, January 17, 2023 10:37 PM
To: Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase


Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Liu, KasimX <kasimx.liu@intel.com> 
Sent: Tuesday, January 17, 2023 3:41 AM
To: devel@edk2.groups.io
Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase

From: KasimX Liu <kasimx.liu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193

In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: KasimX Liu <kasimx.liu@intel.com>
---
 UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
index 73f76064a0..06e83dbadc 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
+++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
@@ -37,6 +37,7 @@
 [Packages]   MdePkg/MdePkg.dec   MdeModulePkg/MdeModulePkg.dec+  PcAtChipsetPkg/PcAtChipsetPkg.dec   UefiPayloadPkg/UefiPayloadPkg.dec  [LibraryClasses]@@ -52,6 +53,10 @@
 [Ppis]   gEfiPeiLoadFilePpiGuid                 ## PRODUCES +[Pcd]+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister+ [Guids]   gUniversalPayloadExtraDataGuid         ## PRODUCES -- 
2.32.0.windows.2


      reply	other threads:[~2023-01-31  8:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 10:41 [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase kasimx.liu
2023-01-17 14:36 ` Guo Dong
2023-01-31  8:33   ` Liu, KasimX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4027D82762948921809B8CC494D09@DM6PR11MB4027.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox