public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase
@ 2023-01-17 10:41 kasimx.liu
  2023-01-17 14:36 ` Guo Dong
  0 siblings, 1 reply; 3+ messages in thread
From: kasimx.liu @ 2023-01-17 10:41 UTC (permalink / raw)
  To: devel; +Cc: KasimX Liu, Guo Dong, Ray Ni, James Lu, Gua Guo

From: KasimX Liu <kasimx.liu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193

In order to remove RTC_INDEX/RTC_TARGET from
the UplBuild macro list,change the RTC_INDEX
/RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: KasimX Liu <kasimx.liu@intel.com>
---
 UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
index 73f76064a0..06e83dbadc 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
+++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
@@ -37,6 +37,7 @@
 [Packages]
   MdePkg/MdePkg.dec
   MdeModulePkg/MdeModulePkg.dec
+  PcAtChipsetPkg/PcAtChipsetPkg.dec
   UefiPayloadPkg/UefiPayloadPkg.dec
 
 [LibraryClasses]
@@ -52,6 +53,10 @@
 [Ppis]
   gEfiPeiLoadFilePpiGuid                 ## PRODUCES
 
+[Pcd]
+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister
+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister
+
 [Guids]
   gUniversalPayloadExtraDataGuid         ## PRODUCES
 
-- 
2.32.0.windows.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase
  2023-01-17 10:41 [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase kasimx.liu
@ 2023-01-17 14:36 ` Guo Dong
  2023-01-31  8:33   ` Liu, KasimX
  0 siblings, 1 reply; 3+ messages in thread
From: Guo Dong @ 2023-01-17 14:36 UTC (permalink / raw)
  To: Liu, KasimX, devel@edk2.groups.io; +Cc: Ni, Ray, Lu, James, Guo, Gua


Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Liu, KasimX <kasimx.liu@intel.com> 
Sent: Tuesday, January 17, 2023 3:41 AM
To: devel@edk2.groups.io
Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase

From: KasimX Liu <kasimx.liu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193

In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: KasimX Liu <kasimx.liu@intel.com>
---
 UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
index 73f76064a0..06e83dbadc 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
+++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
@@ -37,6 +37,7 @@
 [Packages]   MdePkg/MdePkg.dec   MdeModulePkg/MdeModulePkg.dec+  PcAtChipsetPkg/PcAtChipsetPkg.dec   UefiPayloadPkg/UefiPayloadPkg.dec  [LibraryClasses]@@ -52,6 +53,10 @@
 [Ppis]   gEfiPeiLoadFilePpiGuid                 ## PRODUCES +[Pcd]+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister+ [Guids]   gUniversalPayloadExtraDataGuid         ## PRODUCES -- 
2.32.0.windows.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase
  2023-01-17 14:36 ` Guo Dong
@ 2023-01-31  8:33   ` Liu, KasimX
  0 siblings, 0 replies; 3+ messages in thread
From: Liu, KasimX @ 2023-01-31  8:33 UTC (permalink / raw)
  To: Dong, Guo, devel@edk2.groups.io; +Cc: Ni, Ray, Lu, James, Guo, Gua

Hi @Dong, Guo

I've created the PR, could you help me add push label when you're available. 
https://github.com/tianocore/edk2/pull/3972

Thanks.

-----Original Message-----
From: Dong, Guo <guo.dong@intel.com> 
Sent: Tuesday, January 17, 2023 10:37 PM
To: Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase


Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Liu, KasimX <kasimx.liu@intel.com> 
Sent: Tuesday, January 17, 2023 3:41 AM
To: devel@edk2.groups.io
Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase

From: KasimX Liu <kasimx.liu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193

In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: KasimX Liu <kasimx.liu@intel.com>
---
 UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
index 73f76064a0..06e83dbadc 100644
--- a/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
+++ b/UefiPayloadPkg/PayloadLoaderPeim/PayloadLoaderPeim.inf
@@ -37,6 +37,7 @@
 [Packages]   MdePkg/MdePkg.dec   MdeModulePkg/MdeModulePkg.dec+  PcAtChipsetPkg/PcAtChipsetPkg.dec   UefiPayloadPkg/UefiPayloadPkg.dec  [LibraryClasses]@@ -52,6 +53,10 @@
 [Ppis]   gEfiPeiLoadFilePpiGuid                 ## PRODUCES +[Pcd]+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister+ [Guids]   gUniversalPayloadExtraDataGuid         ## PRODUCES -- 
2.32.0.windows.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-31  8:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-17 10:41 [PATCH] UefiPayloadPkg: Set RTC dynamic PCD to PeiPCDdatabase kasimx.liu
2023-01-17 14:36 ` Guo Dong
2023-01-31  8:33   ` Liu, KasimX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox