public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liu, KasimX" <kasimx.liu@intel.com>
To: "Dong, Guo" <guo.dong@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>, "Lu, James" <james.lu@intel.com>,
	"Guo, Gua" <gua.guo@intel.com>
Subject: 回覆: [PATCH] UefiPayloadPkg: Move RTC PCD to dynamic PCD
Date: Fri, 6 Jan 2023 08:14:20 +0000	[thread overview]
Message-ID: <DM6PR11MB4027FDFA7E2648BBCF8168E494FB9@DM6PR11MB4027.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CY5PR11MB626079979B3DE97177BCC2DD9EF59@CY5PR11MB6260.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2531 bytes --]

Hi @Dong, Guo<mailto:guo.dong@intel.com>

I've created the PR, could you help me add push label when you're available.

https://github.com/tianocore/edk2/pull/3856

Thanks.

________________________________
寄件者: Dong, Guo <guo.dong@intel.com>
寄件日期: 2023年1月5日 上午 07:16
收件者: Liu, KasimX <kasimx.liu@intel.com>; devel@edk2.groups.io <devel@edk2.groups.io>
副本: Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
主旨: RE: [PATCH] UefiPayloadPkg: Move RTC PCD to dynamic PCD


Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Liu, KasimX <kasimx.liu@intel.com>
Sent: Wednesday, December 28, 2022 1:13 AM
To: devel@edk2.groups.io
Cc: Liu, KasimX <kasimx.liu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Move RTC PCD to dynamic PCD

From: KasimX Liu <kasimx.liu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4193

In order to remove RTC_INDEX/RTC_TARGET from the UplBuild macro list,change the RTC_INDEX /RTC_TARGET type from PcdsFixedAtBuild to PcdsDynamicEx

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: KasimX Liu <kasimx.liu@intel.com>
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 12e80a9e74..a1a3c74290 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -472,8 +472,6 @@
 !endif  [PcdsPatchableInModule.X64]-  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)-  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER) !if $(NETWORK_DRIVER_ENABLE) == TRUE   gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE !endif@@ -580,6 +578,9 @@
   gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|0   gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|TRUE +  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)+  gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)+ ################################################################################ # # Components Section - list of all EDK II Modules needed by this Platform.--
2.32.0.windows.2


[-- Attachment #2: Type: text/html, Size: 4946 bytes --]

      reply	other threads:[~2023-01-06  8:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28  8:13 [PATCH] UefiPayloadPkg: Move RTC PCD to dynamic PCD kasimx.liu
2022-12-28  8:16 ` Guo, Gua
2023-01-04 23:11 ` Guo Dong
2023-01-04 23:16 ` Guo Dong
2023-01-06  8:14   ` Liu, KasimX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4027FDFA7E2648BBCF8168E494FB9@DM6PR11MB4027.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox