From: "Kathappan Esakkithevar" <kathappan.esakkithevar@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
"Kethi Reddy, Deepika" <deepika.kethi.reddy@intel.com>
Subject: Re: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg
Date: Wed, 2 Sep 2020 09:37:39 +0000 [thread overview]
Message-ID: <DM6PR11MB4043DEF6B831AFDBF36610C09B2F0@DM6PR11MB4043.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB2814F41DE7E9C0764252A035E62F0@SN6PR11MB2814.namprd11.prod.outlook.com>
Reviewed-by: Kathappan Esakkithevar <Kathappan.Esakkithevar@intel.com>
> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Wednesday, September 2, 2020 1:29 PM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>;
> devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Kethi Reddy,
> Deepika <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> <kathappan.esakkithevar@intel.com>
> Subject: RE: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add
> usage of CometlakeSiliconBinPkg
>
>
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
>
> > -----Original Message-----
> > From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> > Sent: Wednesday, September 2, 2020 3:15 PM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Kethi Reddy, Deepika
> > <deepika.kethi.reddy@intel.com>; Esakkithevar, Kathappan
> > <kathappan.esakkithevar@intel.com>
> > Subject: [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage
> > of CometlakeSiliconBinPkg
> >
> > Updates CometlakeOpenBoardPkg to use CometlakeSiliconBinPkg instead
> of
> > CoffeelakeSiliconBinPkg.
> >
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > ---
> > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 5
> > +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > index 2d9dcb139f..6de834565a 100644
> > ---
> >
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > sc
> > +++
> >
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> d
> > s
> > +++ c
> > @@ -10,7 +10,7 @@
> > [Defines]
> > DEFINE PLATFORM_PACKAGE = MinPlatformPkg
> > DEFINE PLATFORM_SI_PACKAGE = CoffeelakeSiliconPkg
> > - DEFINE PLATFORM_SI_BIN_PACKAGE = CoffeelakeSiliconBinPkg
> > + DEFINE PLATFORM_SI_BIN_PACKAGE = CometlakeSiliconBinPkg
> > DEFINE PLATFORM_FSP_BIN_PACKAGE =
> > CometLakeFspBinPkg/CometLake1
> > DEFINE PLATFORM_BOARD_PACKAGE =
> > CometlakeOpenBoardPkg
> > DEFINE BOARD = CometlakeURvp
> > @@ -39,7 +39,8 @@
> > #
> > # Include PCD configuration for this board.
> > #
> > - !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> >
> > + !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
> > +
> > !include OpenBoardPkgPcd.dsc
> > !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
> >
> > --
> > 2.27.0.windows.1
next prev parent reply other threads:[~2020-09-02 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 7:15 [edk2-platforms] [PATCH V1] CometlakeOpenBoardPkg: Add usage of CometlakeSiliconBinPkg Nate DeSimone
2020-09-02 7:58 ` Chiu, Chasel
2020-09-02 9:37 ` Kathappan Esakkithevar [this message]
2020-09-02 17:05 ` Chaganty, Rangasai V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4043DEF6B831AFDBF36610C09B2F0@DM6PR11MB4043.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox